snapshot of https://github.com/cortezaproject/corteza.git (2024.9.x, 2026-09-18; blobs > 131072B omitted)
Some checks failed
SonarQube / SonarQube (push) Failing after 5m28s
E2e test on main branch push / server and client test (map[name:admin port:8080]) (push) Failing after 3m33s
Server and lib tests / Library test (js) (push) Failing after 1m36s
Server and lib tests / Library test (vue) (push) Successful in 2m24s
Server and lib tests / Web client test (admin) (push) Successful in 2m52s
Server and lib tests / Web client test (compose) (push) Successful in 3m23s
Server and lib tests / Web client test (discovery) (push) Successful in 2m49s
Server and lib tests / Web client test (one) (push) Successful in 2m52s
Server and lib tests / Web client test (privacy) (push) Successful in 2m44s
Server and lib tests / Web client test (reporter) (push) Successful in 2m56s
Server and lib tests / Web client test (workflow) (push) Successful in 3m0s
Server and lib tests / Server tests (push) Failing after 4m55s
E2e test on main branch push / notify-failure (push) Failing after 9s
Server and lib tests / Send matrix testing notification (push) Successful in 2s
Mark stale issues and pull requests / stale (push) Successful in 40s
Some checks failed
SonarQube / SonarQube (push) Failing after 5m28s
E2e test on main branch push / server and client test (map[name:admin port:8080]) (push) Failing after 3m33s
Server and lib tests / Library test (js) (push) Failing after 1m36s
Server and lib tests / Library test (vue) (push) Successful in 2m24s
Server and lib tests / Web client test (admin) (push) Successful in 2m52s
Server and lib tests / Web client test (compose) (push) Successful in 3m23s
Server and lib tests / Web client test (discovery) (push) Successful in 2m49s
Server and lib tests / Web client test (one) (push) Successful in 2m52s
Server and lib tests / Web client test (privacy) (push) Successful in 2m44s
Server and lib tests / Web client test (reporter) (push) Successful in 2m56s
Server and lib tests / Web client test (workflow) (push) Successful in 3m0s
Server and lib tests / Server tests (push) Failing after 4m55s
E2e test on main branch push / notify-failure (push) Failing after 9s
Server and lib tests / Send matrix testing notification (push) Successful in 2s
Mark stale issues and pull requests / stale (push) Successful in 40s
This commit is contained in:
285
server/compose/service/values/sanitizer.go
Normal file
285
server/compose/service/values/sanitizer.go
Normal file
@@ -0,0 +1,285 @@
|
||||
package values
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"strconv"
|
||||
"strings"
|
||||
"time"
|
||||
|
||||
"github.com/cortezaproject/corteza/server/pkg/expr"
|
||||
"github.com/cortezaproject/corteza/server/pkg/logger"
|
||||
"github.com/cortezaproject/corteza/server/pkg/xss"
|
||||
"github.com/spf13/cast"
|
||||
"go.uber.org/zap"
|
||||
|
||||
"github.com/cortezaproject/corteza/server/compose/types"
|
||||
)
|
||||
|
||||
type (
|
||||
sanitizer struct{}
|
||||
)
|
||||
|
||||
// Sanitizer initializes sanitizer
|
||||
//
|
||||
// Not really needed, following pattern in the package
|
||||
func Sanitizer() *sanitizer {
|
||||
return &sanitizer{}
|
||||
}
|
||||
|
||||
// Run cleans up input data
|
||||
// - fix multi-value order/place index
|
||||
// - trim all the strings!
|
||||
// - parse & format input values to match field specific -- nullify/falsify invalid
|
||||
// - field kind specific, no errors raised, data is modified
|
||||
//
|
||||
// Existing data (when updating record) is not yet loaded at this point
|
||||
func (s sanitizer) Run(m *types.Module, vv types.RecordValueSet) (out types.RecordValueSet) {
|
||||
var (
|
||||
exprParser = expr.Parser()
|
||||
)
|
||||
|
||||
out = make([]*types.RecordValue, 0, len(vv))
|
||||
|
||||
for _, f := range m.Fields {
|
||||
// Reorder and sanitize place value (no gaps)
|
||||
//
|
||||
// Values are ordered when received so we treat them like it
|
||||
// and assign the appropriate place no.
|
||||
var i = 0
|
||||
for _, v := range vv.FilterByName(f.Name) {
|
||||
if v.IsDeleted() {
|
||||
continue
|
||||
}
|
||||
|
||||
c := v.Clone()
|
||||
c.Place = uint(i)
|
||||
out = append(out, c)
|
||||
i++
|
||||
}
|
||||
}
|
||||
|
||||
var (
|
||||
f *types.ModuleField
|
||||
kind string
|
||||
|
||||
log = logger.Default().
|
||||
With(logger.Uint64("module", m.ID))
|
||||
)
|
||||
|
||||
for _, v := range out {
|
||||
f = m.Fields.FindByName(v.Name)
|
||||
if f == nil {
|
||||
// Unknown field,
|
||||
// if it is not handled before,
|
||||
// sanitizer does not care about it
|
||||
continue
|
||||
}
|
||||
|
||||
if f.Expressions.ValueExpr != "" {
|
||||
// do not do any sanitization if field has value expression!
|
||||
continue
|
||||
}
|
||||
|
||||
if v.IsDeleted() || !v.Updated {
|
||||
// Ignore unchanged and deleted
|
||||
continue
|
||||
}
|
||||
|
||||
kind = strings.ToLower(f.Kind)
|
||||
|
||||
if len(f.Expressions.Sanitizers) > 0 {
|
||||
for _, expr := range f.Expressions.Sanitizers {
|
||||
rval, err := exprParser.Evaluate(expr, map[string]interface{}{"value": v.Value})
|
||||
if err != nil {
|
||||
log.Error(
|
||||
"failed to evaluate sanitizer expression",
|
||||
zap.String("field", f.Name),
|
||||
zap.String("expr", expr),
|
||||
zap.Error(err),
|
||||
)
|
||||
continue
|
||||
}
|
||||
v.Value = sanitize(f, rval)
|
||||
}
|
||||
}
|
||||
|
||||
if kind != "string" {
|
||||
// Trim all but string
|
||||
v.Value = strings.TrimSpace(v.Value)
|
||||
}
|
||||
|
||||
if f.IsRef() {
|
||||
if refy.MatchString(v.Value) {
|
||||
v.Ref, _ = strconv.ParseUint(v.Value, 10, 64)
|
||||
}
|
||||
|
||||
if v.Ref == 0 {
|
||||
v.Value = ""
|
||||
}
|
||||
}
|
||||
|
||||
v.Value = sanitize(f, v.Value)
|
||||
}
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
func (s sanitizer) RunXSS(m *types.Module, vv types.RecordValueSet) types.RecordValueSet {
|
||||
var (
|
||||
f *types.ModuleField
|
||||
)
|
||||
|
||||
for _, v := range vv {
|
||||
f = m.Fields.FindByName(v.Name)
|
||||
if f == nil {
|
||||
// Unknown field,
|
||||
// if it is not handled before,
|
||||
// sanitizer does not care about it
|
||||
continue
|
||||
}
|
||||
|
||||
switch strings.ToLower(f.Kind) {
|
||||
case "string":
|
||||
v.Value = sString(v.Value)
|
||||
}
|
||||
}
|
||||
|
||||
return vv
|
||||
}
|
||||
|
||||
func sBool(v interface{}) string {
|
||||
switch c := v.(type) {
|
||||
case bool:
|
||||
if c {
|
||||
return strBoolTrue
|
||||
}
|
||||
|
||||
case string:
|
||||
if truthy.MatchString(strings.ToLower(c)) {
|
||||
return strBoolTrue
|
||||
}
|
||||
}
|
||||
|
||||
// Returning empty string here to align false value with everything else
|
||||
return strBoolFalseAlt
|
||||
}
|
||||
|
||||
func sDatetime(v interface{}, onlyDate, onlyTime bool) string {
|
||||
var (
|
||||
// input format set
|
||||
inputFormats []string
|
||||
|
||||
// output format
|
||||
internalFormat string
|
||||
|
||||
datetime = fmt.Sprintf("%v", v)
|
||||
)
|
||||
|
||||
if onlyTime {
|
||||
internalFormat = datetimeIntenralFormatTime
|
||||
inputFormats = []string{
|
||||
datetimeIntenralFormatTime,
|
||||
"15:04",
|
||||
"15:04:05Z07:00",
|
||||
"15:04:05 MST",
|
||||
"15:04:05 -0700",
|
||||
"15:04 MST",
|
||||
"15:04Z07:00",
|
||||
"15:04 -0700",
|
||||
time.Kitchen,
|
||||
}
|
||||
} else {
|
||||
if onlyDate {
|
||||
// In case only date is used, make sure we format it properly
|
||||
internalFormat = datetimeInternalFormatDate
|
||||
} else {
|
||||
internalFormat = datetimeInternalFormatFull
|
||||
}
|
||||
|
||||
// date & time
|
||||
inputFormats = []string{
|
||||
datetimeInternalFormatFull,
|
||||
"2006-01-02T15:04:05", // iso8601 without timezone
|
||||
time.RFC1123Z,
|
||||
time.RFC1123,
|
||||
time.RFC822Z,
|
||||
time.RFC822,
|
||||
time.RFC850,
|
||||
time.ANSIC,
|
||||
time.UnixDate,
|
||||
time.RubyDate,
|
||||
"2006-01-02 15:04:05.999999999 -0700 MST", // Time.String()
|
||||
"2006-01-02",
|
||||
"02 Jan 2006",
|
||||
"2006-01-02T15:04:05-0700", // RFC3339 without timezone hh:mm colon
|
||||
"2006-01-02 15:04:05 -07:00",
|
||||
"2006-01-02 15:04:05 -0700",
|
||||
"2006-01-02 15:04:05Z07:00", // RFC3339 without T
|
||||
"2006-01-02 15:04:05Z0700", // RFC3339 without T or timezone hh:mm colon
|
||||
"2006-01-02 15:04:05",
|
||||
time.Kitchen,
|
||||
time.Stamp,
|
||||
time.StampMilli,
|
||||
time.StampMicro,
|
||||
time.StampNano,
|
||||
datetimeInternalFormatDate,
|
||||
"02 Jan 06",
|
||||
"Monday, 02-Jan-06",
|
||||
"Mon, 02 Jan 2006",
|
||||
"2006/_1/_2",
|
||||
}
|
||||
}
|
||||
|
||||
for _, format := range inputFormats {
|
||||
parsed, err := time.Parse(format, datetime)
|
||||
if err == nil {
|
||||
return parsed.UTC().Format(internalFormat)
|
||||
}
|
||||
}
|
||||
|
||||
return ""
|
||||
}
|
||||
|
||||
func sNumber(num interface{}, p uint, s uint) string {
|
||||
base, err := strconv.ParseFloat(fmt.Sprintf("%v", num), 64)
|
||||
if err != nil {
|
||||
return "0"
|
||||
}
|
||||
|
||||
// Format the value to the desired precision
|
||||
str := strconv.FormatFloat(base, 'f', int(s), 64)
|
||||
|
||||
// In case of fractures, remove trailing 0's
|
||||
if strings.Contains(str, ".") {
|
||||
str = strings.TrimRight(str, "0")
|
||||
str = strings.TrimRight(str, ".")
|
||||
}
|
||||
|
||||
return str
|
||||
}
|
||||
|
||||
func sString(str interface{}) string {
|
||||
base, err := cast.ToStringE(str)
|
||||
if err != nil {
|
||||
return ""
|
||||
}
|
||||
|
||||
return xss.RichText(base)
|
||||
}
|
||||
|
||||
// sanitize casts value to field kind format
|
||||
func sanitize(f *types.ModuleField, v interface{}) string {
|
||||
switch strings.ToLower(f.Kind) {
|
||||
case "bool":
|
||||
return sBool(v)
|
||||
case "datetime":
|
||||
v = sDatetime(v, f.Options.Bool("onlyDate"), f.Options.Bool("onlyTime"))
|
||||
case "number":
|
||||
// @todo !! This is temporary; precision and scale require a rework
|
||||
v = sNumber(v, maxPrecision, f.Options.Precision())
|
||||
case "string":
|
||||
v = sString(v)
|
||||
}
|
||||
|
||||
return fmt.Sprintf("%v", v)
|
||||
}
|
||||
Reference in New Issue
Block a user