snapshot of https://github.com/cortezaproject/corteza.git (2024.9.x, 2026-09-18; blobs > 131072B omitted)
Some checks failed
SonarQube / SonarQube (push) Failing after 5m28s
E2e test on main branch push / server and client test (map[name:admin port:8080]) (push) Failing after 3m33s
Server and lib tests / Library test (js) (push) Failing after 1m36s
Server and lib tests / Library test (vue) (push) Successful in 2m24s
Server and lib tests / Web client test (admin) (push) Successful in 2m52s
Server and lib tests / Web client test (compose) (push) Successful in 3m23s
Server and lib tests / Web client test (discovery) (push) Successful in 2m49s
Server and lib tests / Web client test (one) (push) Successful in 2m52s
Server and lib tests / Web client test (privacy) (push) Successful in 2m44s
Server and lib tests / Web client test (reporter) (push) Successful in 2m56s
Server and lib tests / Web client test (workflow) (push) Successful in 3m0s
Server and lib tests / Server tests (push) Failing after 4m55s
E2e test on main branch push / notify-failure (push) Failing after 9s
Server and lib tests / Send matrix testing notification (push) Successful in 2s
Mark stale issues and pull requests / stale (push) Successful in 40s
Some checks failed
SonarQube / SonarQube (push) Failing after 5m28s
E2e test on main branch push / server and client test (map[name:admin port:8080]) (push) Failing after 3m33s
Server and lib tests / Library test (js) (push) Failing after 1m36s
Server and lib tests / Library test (vue) (push) Successful in 2m24s
Server and lib tests / Web client test (admin) (push) Successful in 2m52s
Server and lib tests / Web client test (compose) (push) Successful in 3m23s
Server and lib tests / Web client test (discovery) (push) Successful in 2m49s
Server and lib tests / Web client test (one) (push) Successful in 2m52s
Server and lib tests / Web client test (privacy) (push) Successful in 2m44s
Server and lib tests / Web client test (reporter) (push) Successful in 2m56s
Server and lib tests / Web client test (workflow) (push) Successful in 3m0s
Server and lib tests / Server tests (push) Failing after 4m55s
E2e test on main branch push / notify-failure (push) Failing after 9s
Server and lib tests / Send matrix testing notification (push) Successful in 2s
Mark stale issues and pull requests / stale (push) Successful in 40s
This commit is contained in:
395
server/pkg/websocket/session.go
Normal file
395
server/pkg/websocket/session.go
Normal file
@@ -0,0 +1,395 @@
|
||||
package websocket
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net"
|
||||
"sync"
|
||||
"sync/atomic"
|
||||
"time"
|
||||
|
||||
"github.com/cortezaproject/corteza/server/pkg/auth"
|
||||
"github.com/cortezaproject/corteza/server/pkg/errors"
|
||||
"github.com/cortezaproject/corteza/server/pkg/id"
|
||||
"github.com/cortezaproject/corteza/server/pkg/logger"
|
||||
"github.com/cortezaproject/corteza/server/pkg/options"
|
||||
"github.com/gorilla/websocket"
|
||||
"go.uber.org/zap"
|
||||
)
|
||||
|
||||
// active sessions of users
|
||||
var (
|
||||
// wrapper around nextID that will aid service testing
|
||||
nextID = func() uint64 {
|
||||
return id.Next()
|
||||
}
|
||||
)
|
||||
|
||||
type (
|
||||
conection interface {
|
||||
Close() error
|
||||
RemoteAddr() net.Addr
|
||||
WriteMessage(messageType int, data []byte) error
|
||||
SetWriteDeadline(t time.Time) error
|
||||
ReadMessage() (messageType int, p []byte, err error)
|
||||
SetReadDeadline(t time.Time) error
|
||||
SetPongHandler(h func(appData string) error)
|
||||
}
|
||||
|
||||
session struct {
|
||||
l sync.RWMutex
|
||||
|
||||
id uint64
|
||||
once sync.Once
|
||||
conn conection
|
||||
closed atomic.Bool
|
||||
|
||||
ctx context.Context
|
||||
ctxCancel context.CancelFunc
|
||||
|
||||
logger *zap.Logger
|
||||
|
||||
send chan []byte
|
||||
stop chan []byte
|
||||
|
||||
remoteAddr string
|
||||
|
||||
config options.WebsocketOpt
|
||||
|
||||
identity auth.Identifiable
|
||||
|
||||
server *server
|
||||
}
|
||||
)
|
||||
|
||||
func Session(ctx context.Context, ws *server, conn *websocket.Conn) *session {
|
||||
s := &session{
|
||||
id: nextID(),
|
||||
conn: conn,
|
||||
config: ws.config,
|
||||
send: make(chan []byte, 512),
|
||||
stop: make(chan []byte, 1),
|
||||
server: ws,
|
||||
}
|
||||
|
||||
s.ctx, s.ctxCancel = context.WithCancel(ctx)
|
||||
|
||||
s.logger = ws.logger.
|
||||
Named("session").
|
||||
With(
|
||||
logger.Uint64("id", s.id),
|
||||
)
|
||||
|
||||
return s
|
||||
}
|
||||
|
||||
func (s *session) Identity() auth.Identifiable {
|
||||
s.l.RLock()
|
||||
defer s.l.RUnlock()
|
||||
return s.identity
|
||||
}
|
||||
|
||||
func (s *session) disconnect() {
|
||||
s.l.Lock()
|
||||
defer s.l.Unlock()
|
||||
|
||||
// Mark session as closed before tearing it down
|
||||
s.closed.Store(true)
|
||||
|
||||
// Cancel context; this is what stops the write loop and unblocks
|
||||
// anyone waiting to queue a message
|
||||
s.ctxCancel()
|
||||
|
||||
s.logger.Info("disconnected")
|
||||
|
||||
// Close connection
|
||||
_ = s.conn.Close()
|
||||
|
||||
// send & stop are deliberately left open. Closing them races with
|
||||
// Write() and panics on "send on closed channel"; they are garbage
|
||||
// collected with the session instead.
|
||||
s.conn = nil
|
||||
}
|
||||
|
||||
func (s *session) Handle() error {
|
||||
go func() {
|
||||
// Close unidentified connections in 5sec
|
||||
<-time.NewTimer(time.Second * 5).C
|
||||
if s.Identity() == nil {
|
||||
_, _ = s.Write(closingUnidentifiedConn)
|
||||
s.logger.Info("closing unidentified connection")
|
||||
s.Close()
|
||||
}
|
||||
}()
|
||||
|
||||
go func() {
|
||||
if err := s.readLoop(); err != nil {
|
||||
if errors.Is(err, net.ErrClosed) {
|
||||
// read will return net.ErrClosed when
|
||||
// recovering from panic
|
||||
return
|
||||
}
|
||||
|
||||
s.logger.Error("read failure", zap.Error(err))
|
||||
}
|
||||
s.Close()
|
||||
}()
|
||||
|
||||
if err := s.writeLoop(); err != nil {
|
||||
if errors.Is(err, net.ErrClosed) {
|
||||
// write will return net.ErrClosed when
|
||||
// recovering from panic
|
||||
return nil
|
||||
}
|
||||
|
||||
s.logger.Error("write failure", zap.Error(err))
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
func (s *session) Close() {
|
||||
s.once.Do(func() {
|
||||
s.disconnect()
|
||||
s.server.RemoveSession(s)
|
||||
})
|
||||
}
|
||||
|
||||
func (s *session) readLoop() (err error) {
|
||||
if err = s.conn.SetReadDeadline(time.Now().Add(s.config.PingTimeout)); err != nil {
|
||||
return
|
||||
}
|
||||
|
||||
s.conn.SetPongHandler(func(string) error {
|
||||
return s.conn.SetReadDeadline(time.Now().Add(s.config.PingTimeout))
|
||||
})
|
||||
|
||||
s.remoteAddr = s.conn.RemoteAddr().String()
|
||||
|
||||
var (
|
||||
raw []byte
|
||||
)
|
||||
|
||||
for {
|
||||
if raw, err = s.read(); err != nil {
|
||||
return
|
||||
}
|
||||
|
||||
if raw == nil {
|
||||
continue
|
||||
}
|
||||
|
||||
if err = s.procRawMessage(raw); err != nil {
|
||||
return
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
func (s *session) read() (raw []byte, err error) {
|
||||
defer func() {
|
||||
if recovered := recover(); recovered != nil {
|
||||
s.logger.Debug("recovering from websocket read panic", zap.Any("recovered-error", recovered))
|
||||
err = net.ErrClosed
|
||||
}
|
||||
}()
|
||||
|
||||
s.l.RLock()
|
||||
defer s.l.RUnlock()
|
||||
|
||||
// Check if connection was closed by disconnect()
|
||||
if s.conn == nil {
|
||||
return nil, net.ErrClosed
|
||||
}
|
||||
|
||||
if _, raw, err = s.conn.ReadMessage(); err != nil {
|
||||
return nil, errHandler("websocket read failed", err)
|
||||
}
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
func (s *session) procRawMessage(raw []byte) (err error) {
|
||||
pw := payloadWrap{}
|
||||
if err = json.Unmarshal(raw, &pw); err != nil {
|
||||
return fmt.Errorf("could not unmarshal session message: %w", err)
|
||||
}
|
||||
|
||||
if pw.Type == payloadTypeCredentials {
|
||||
authPayload := &payloadAuth{}
|
||||
if err = pw.UnmarshalValue(authPayload); err != nil {
|
||||
return fmt.Errorf("could not unmarshal session payload: %w", err)
|
||||
}
|
||||
|
||||
if err = s.authenticate(authPayload); err != nil {
|
||||
return fmt.Errorf("unauthorized: %w", err)
|
||||
}
|
||||
|
||||
i := s.Identity()
|
||||
s.logger.Debug(
|
||||
"authenticated",
|
||||
logger.Uint64("userID", i.Identity()),
|
||||
logger.Uint64s("roles", i.Roles()),
|
||||
)
|
||||
|
||||
s.server.StoreSession(s)
|
||||
|
||||
// not expecting anything else
|
||||
return
|
||||
}
|
||||
|
||||
if s.Identity() == nil {
|
||||
return fmt.Errorf("unauthenticated session")
|
||||
}
|
||||
|
||||
// at the moment we do not support any other kinds of message types
|
||||
return fmt.Errorf("unknown message type '%s'", pw.Type)
|
||||
}
|
||||
|
||||
// reads send & stop channels and sends received messages to websocket connection via write fn()
|
||||
func (s *session) writeLoop() error {
|
||||
ticker := time.NewTicker(s.config.PingPeriod)
|
||||
|
||||
defer ticker.Stop()
|
||||
defer s.Close() // break readLoop
|
||||
|
||||
for {
|
||||
select {
|
||||
case <-s.ctx.Done():
|
||||
// session disconnected
|
||||
return nil
|
||||
|
||||
case msg, ok := <-s.send:
|
||||
if !ok {
|
||||
// channel closed
|
||||
return nil
|
||||
}
|
||||
|
||||
if err := s.write(websocket.TextMessage, msg); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// continue with wait & write/ping loop
|
||||
|
||||
case msg, ok := <-s.stop:
|
||||
if !ok {
|
||||
// channel closed
|
||||
return nil
|
||||
}
|
||||
|
||||
// Shutdown requested, don't care if the message is delivered
|
||||
if err := s.write(websocket.TextMessage, msg); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// stopping, break the loop.
|
||||
return nil
|
||||
|
||||
case <-ticker.C:
|
||||
if err := s.write(websocket.PingMessage, nil); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// continue with wait & write/ping loop
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// writes messages to websocket connection
|
||||
func (s *session) write(t int, msg []byte) (err error) {
|
||||
s.l.RLock()
|
||||
defer s.l.RUnlock()
|
||||
|
||||
defer func() {
|
||||
if recovered := recover(); recovered != nil {
|
||||
s.logger.Debug("recovering from websocket write panic", zap.Any("recovered-error", recovered))
|
||||
err = net.ErrClosed
|
||||
}
|
||||
}()
|
||||
|
||||
// Check if connection was closed by disconnect()
|
||||
if s.conn == nil {
|
||||
return net.ErrClosed
|
||||
}
|
||||
|
||||
if err = s.conn.SetWriteDeadline(time.Now().Add(s.config.Timeout)); err != nil {
|
||||
return fmt.Errorf("deadline error: %w", err)
|
||||
}
|
||||
|
||||
return errHandler("websocket write failed", s.conn.WriteMessage(t, msg))
|
||||
}
|
||||
|
||||
func (s *session) authenticate(p *payloadAuth) error {
|
||||
identity, err := s.server.tokenValidator(s.ctx, p.AccessToken)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
if i := s.Identity(); i != nil {
|
||||
if i.Identity() != identity.Identity() {
|
||||
return fmt.Errorf("identity does not match")
|
||||
}
|
||||
}
|
||||
|
||||
if !identity.Valid() {
|
||||
return fmt.Errorf("invalid identity")
|
||||
}
|
||||
|
||||
s.l.Lock()
|
||||
defer s.l.Unlock()
|
||||
|
||||
s.identity = identity
|
||||
_, _ = s.Write(ok)
|
||||
return nil
|
||||
}
|
||||
|
||||
// sendBytes sends byte to channel or timeout
|
||||
func (s *session) Write(p []byte) (int, error) {
|
||||
// Check if session is closed before attempting to send
|
||||
if s.closed.Load() {
|
||||
return 0, net.ErrClosed
|
||||
}
|
||||
|
||||
defer func() {
|
||||
if recovered := recover(); recovered != nil {
|
||||
s.logger.Debug("recovering from websocket write panic", zap.Any("recovered-error", recovered))
|
||||
}
|
||||
}()
|
||||
|
||||
select {
|
||||
case <-s.ctx.Done():
|
||||
// Session is disconnecting, channel may be closed
|
||||
return 0, net.ErrClosed
|
||||
case s.send <- p:
|
||||
return len(p), nil
|
||||
case <-time.After(2 * time.Millisecond):
|
||||
return 0, fmt.Errorf("write timedout")
|
||||
}
|
||||
}
|
||||
|
||||
func errHandler(prefix string, err error) error {
|
||||
if err == nil {
|
||||
return nil
|
||||
}
|
||||
|
||||
// Handle websocket close errors - these are expected during disconnection
|
||||
if websocket.IsCloseError(err,
|
||||
websocket.CloseNormalClosure,
|
||||
websocket.CloseGoingAway,
|
||||
websocket.CloseAbnormalClosure,
|
||||
websocket.CloseNoStatusReceived,
|
||||
) {
|
||||
return net.ErrClosed
|
||||
}
|
||||
|
||||
if errors.Is(err, net.ErrClosed) {
|
||||
return net.ErrClosed
|
||||
}
|
||||
|
||||
// close sent occurs when writing to a connection that's closing
|
||||
if errors.Is(err, websocket.ErrCloseSent) {
|
||||
return net.ErrClosed
|
||||
}
|
||||
|
||||
return fmt.Errorf(prefix+": %w", err)
|
||||
}
|
||||
Reference in New Issue
Block a user