snapshot of https://github.com/espocrm/espocrm.git (master, 2026-09-18; blobs > 131072B omitted)
Some checks failed
Test / Test on PHP 8.3 (push) Failing after 5s
Test / Test on PHP 8.4 (push) Failing after 4s
Test / Test on PHP 8.5 (push) Failing after 3s
TypeScript static analysis / TypeScript check (push) Failing after 14s
Test Integration on PostgreSQL / Test on PHP 8.4 fix (push) Failing after 1s
Test Integration on PostgreSQL / Test on PHP 8.4 master (push) Failing after 1s
Test Integration on MySQL / Test on PHP 8.3 (push) Failing after 2s
Test Integration on MySQL / Test on PHP 8.5 (push) Failing after 0s
Some checks failed
Test / Test on PHP 8.3 (push) Failing after 5s
Test / Test on PHP 8.4 (push) Failing after 4s
Test / Test on PHP 8.5 (push) Failing after 3s
TypeScript static analysis / TypeScript check (push) Failing after 14s
Test Integration on PostgreSQL / Test on PHP 8.4 fix (push) Failing after 1s
Test Integration on PostgreSQL / Test on PHP 8.4 master (push) Failing after 1s
Test Integration on MySQL / Test on PHP 8.3 (push) Failing after 2s
Test Integration on MySQL / Test on PHP 8.5 (push) Failing after 0s
This commit is contained in:
237
tests/integration/Espo/Webhook/AclTest.php
Normal file
237
tests/integration/Espo/Webhook/AclTest.php
Normal file
@@ -0,0 +1,237 @@
|
||||
<?php
|
||||
/************************************************************************
|
||||
* This file is part of EspoCRM.
|
||||
*
|
||||
* EspoCRM – Open Source CRM application.
|
||||
* Copyright (C) 2014-2026 EspoCRM, Inc.
|
||||
* Website: https://www.espocrm.com
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||
*
|
||||
* The interactive user interfaces in modified source and object code versions
|
||||
* of this program must display Appropriate Legal Notices, as required under
|
||||
* Section 5 of the GNU Affero General Public License version 3.
|
||||
*
|
||||
* In accordance with Section 7(b) of the GNU Affero General Public License version 3,
|
||||
* these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
|
||||
************************************************************************/
|
||||
|
||||
namespace tests\integration\Espo\Webhook;
|
||||
|
||||
use Espo\Core\Api\ControllerActionProcessor;
|
||||
use Espo\Core\Api\ResponseWrapper;
|
||||
use Espo\Core\Utils\Config\ConfigWriter;
|
||||
use Espo\Core\Exceptions\Forbidden;
|
||||
use tests\integration\Core\BaseTestCase;
|
||||
|
||||
class AclTest extends BaseTestCase
|
||||
{
|
||||
public function testRegularUserNoAccess(): void
|
||||
{
|
||||
$this->createUser(
|
||||
[
|
||||
'userName' => 'test',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => ['create'=> 'yes', 'read' => 'own'],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$this->authenticate('test');
|
||||
|
||||
$processor = $this->getInjectableFactory()->create(ControllerActionProcessor::class);
|
||||
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$request = $this
|
||||
->createRequest('POST', [], ['Content-Type' => 'application/json'], '{"event":"Account.create"}');
|
||||
|
||||
$processor->process('Webhook', 'create', $request, $this->createResponse());
|
||||
}
|
||||
|
||||
public function testApiUserNoAccess1()
|
||||
{
|
||||
$this->createUser(
|
||||
[
|
||||
'userName' => 'api',
|
||||
'type' => 'api',
|
||||
'authMethod' => 'ApiKey',
|
||||
'apiKey' => 'test-key',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => false,
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$request = $this->createRequest(
|
||||
'POST',
|
||||
[],
|
||||
[
|
||||
'Content-Type' => 'application/json',
|
||||
'X-Api-Key' => 'test-key',
|
||||
],
|
||||
'{"event":"Account.create", "url": "https://test.com"}'
|
||||
);
|
||||
|
||||
$this->authenticate(method: 'ApiKey', request: $request);
|
||||
|
||||
$processor = $this->getInjectableFactory()->create(ControllerActionProcessor::class);
|
||||
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$processor->process('Webhook', 'create', $request, $this->createResponse());
|
||||
}
|
||||
|
||||
public function testApiUserNoAccess2()
|
||||
{
|
||||
$this->createUser(
|
||||
[
|
||||
'userName' => 'api',
|
||||
'type' => 'api',
|
||||
'authMethod' => 'ApiKey',
|
||||
'apiKey' => 'test-key',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => false,
|
||||
'Account' => false,
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$request = $this->createRequest(
|
||||
'POST',
|
||||
[],
|
||||
[
|
||||
'Content-Type' => 'application/json',
|
||||
'X-Api-Key' => 'test-key',
|
||||
],
|
||||
'{"event":"Account.create", "url": "https://test.com"}'
|
||||
);
|
||||
|
||||
$this->authenticate(method: 'ApiKey', request: $request);
|
||||
|
||||
$processor = $this->getInjectableFactory()->create(ControllerActionProcessor::class);
|
||||
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$processor->process('Webhook', 'create', $request, $this->createResponse());
|
||||
}
|
||||
|
||||
public function testApiUserHasAccess1()
|
||||
{
|
||||
$configWriter = $this->getInjectableFactory()->create(ConfigWriter::class);
|
||||
$configWriter->set('webhookAllowedAddressList', ['test.com:443']);
|
||||
$configWriter->save();
|
||||
|
||||
$this->createUser(
|
||||
[
|
||||
'userName' => 'api',
|
||||
'type' => 'api',
|
||||
'authMethod' => 'ApiKey',
|
||||
'apiKey' => 'test-key',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => ['create' => 'yes', 'read' => 'own'],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$request = $this->createRequest(
|
||||
'POST',
|
||||
[],
|
||||
[
|
||||
'Content-Type' => 'application/json',
|
||||
'X-Api-Key' => 'test-key',
|
||||
],
|
||||
'{"event":"Account.create", "url": "https://test.com"}'
|
||||
);
|
||||
|
||||
$this->authenticate(method: 'ApiKey', request: $request);
|
||||
|
||||
$processor = $this->getInjectableFactory()->create(ControllerActionProcessor::class);
|
||||
|
||||
$response = $this->createMock(ResponseWrapper::class);
|
||||
|
||||
$response
|
||||
->expects($this->once())
|
||||
->method('writeBody');
|
||||
|
||||
$processor->process('Webhook', 'create', $request, $response);
|
||||
}
|
||||
|
||||
public function testApiUserHasAccessDelete(): void
|
||||
{
|
||||
$user = $this->createUser(
|
||||
[
|
||||
'userName' => 'api',
|
||||
'type' => 'api',
|
||||
'authMethod' => 'ApiKey',
|
||||
'apiKey' => 'test-key',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => ['create' => 'yes', 'read' => 'own'],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$webhook = $em->createEntity('Webhook', [
|
||||
'event' => 'Account.create',
|
||||
'url' => 'https://test.com',
|
||||
'userId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$request = $this->createRequest(
|
||||
'DELETE',
|
||||
[],
|
||||
[
|
||||
'Content-Type' => 'application/json',
|
||||
'X-Api-Key' => 'test-key',
|
||||
],
|
||||
null,
|
||||
[
|
||||
'id' => $webhook->getId(),
|
||||
]
|
||||
);
|
||||
|
||||
$this->authenticate(method: 'ApiKey', request: $request);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$response = $this->createMock(ResponseWrapper::class);
|
||||
|
||||
$processor = $this->getInjectableFactory()->create(ControllerActionProcessor::class);
|
||||
|
||||
$processor->process('Webhook', 'delete', $request, $response);
|
||||
|
||||
$fetchedWebhook = $em->getEntityById('Webhook', $webhook->getId());
|
||||
|
||||
$this->assertNull($fetchedWebhook);
|
||||
}
|
||||
}
|
||||
347
tests/integration/Espo/Webhook/ProcessingTest.php
Normal file
347
tests/integration/Espo/Webhook/ProcessingTest.php
Normal file
@@ -0,0 +1,347 @@
|
||||
<?php
|
||||
/************************************************************************
|
||||
* This file is part of EspoCRM.
|
||||
*
|
||||
* EspoCRM – Open Source CRM application.
|
||||
* Copyright (C) 2014-2026 EspoCRM, Inc.
|
||||
* Website: https://www.espocrm.com
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as published by
|
||||
* the Free Software Foundation, either version 3 of the License, or
|
||||
* (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||
*
|
||||
* The interactive user interfaces in modified source and object code versions
|
||||
* of this program must display Appropriate Legal Notices, as required under
|
||||
* Section 5 of the GNU Affero General Public License version 3.
|
||||
*
|
||||
* In accordance with Section 7(b) of the GNU Affero General Public License version 3,
|
||||
* these Appropriate Legal Notices must retain the display of the "EspoCRM" word.
|
||||
************************************************************************/
|
||||
|
||||
namespace tests\integration\Espo\Webhook;
|
||||
|
||||
use Espo\Core\InjectableFactory;
|
||||
use Espo\Core\ORM\Repository\Option\SaveOption;
|
||||
use Espo\Core\Webhook\Queue;
|
||||
use Espo\Core\Webhook\Sender;
|
||||
use Espo\ORM\EntityManager;
|
||||
use Espo\Entities\Webhook;
|
||||
use Espo\Modules\Crm\Entities\Account;
|
||||
use tests\integration\Core\BaseTestCase;
|
||||
|
||||
class ProcessingTest extends BaseTestCase
|
||||
{
|
||||
public function testProcessing1(): void
|
||||
{
|
||||
$user = $this->createUser(
|
||||
[
|
||||
'userName' => 'test',
|
||||
'password' => '1',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => [
|
||||
'create' => 'yes',
|
||||
'read' => 'own',
|
||||
],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$em = $this->getContainer()->getByClass(EntityManager::class);
|
||||
|
||||
$em->createEntity(Webhook::ENTITY_TYPE, [
|
||||
'event' => 'Account.create',
|
||||
'userId' => $user->getId(),
|
||||
'url' => 'https://test.com',
|
||||
'skipOwn' => true,
|
||||
]);
|
||||
|
||||
$em->createEntity(Webhook::ENTITY_TYPE, [
|
||||
'event' => 'Account.update',
|
||||
'userId' => $user->getId(),
|
||||
'url' => 'https://test.com',
|
||||
'skipOwn' => true,
|
||||
]);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$this->authenticate(null);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$account1 = $em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test1',
|
||||
'assignedUserId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$account2 = $em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test2',
|
||||
'assignedUserId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test3',
|
||||
]);
|
||||
|
||||
$em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test_skip',
|
||||
'assignedUserId' => $user->getId(),
|
||||
], [SaveOption::CREATED_BY_ID => $user->getId()]);
|
||||
|
||||
$dataList1 = [
|
||||
$account1->getValueMap(),
|
||||
$account2->getValueMap(),
|
||||
];
|
||||
|
||||
$account1->set('name', 'test-1-changed');
|
||||
$em->saveEntity($account1);
|
||||
|
||||
$account1->set('description', 'test-skip');
|
||||
$em->saveEntity($account1, [SaveOption::MODIFIED_BY_ID => $user->getId()]);
|
||||
|
||||
$dataList2 = [
|
||||
(object) [
|
||||
'name' => $account1->get('name'),
|
||||
'modifiedById' => 'system',
|
||||
'modifiedByName' => 'System',
|
||||
'id' => $account1->getId(),
|
||||
],
|
||||
];
|
||||
|
||||
$sender = $this->createMock(Sender::class);
|
||||
|
||||
$queue = $this->getContainer()
|
||||
->getByClass(InjectableFactory::class)
|
||||
->createWith(Queue::class, [
|
||||
'sender' => $sender,
|
||||
]);
|
||||
|
||||
$invokedCount = $this->exactly(2);
|
||||
|
||||
$notSame = false;
|
||||
|
||||
$sender
|
||||
->expects($invokedCount)
|
||||
->method('send')
|
||||
->willReturnCallback(function (Webhook $webhook, $dataList) use ($invokedCount, $dataList1, $dataList2, &$notSame) {
|
||||
if ($invokedCount->numberOfInvocations() === 1) {
|
||||
if (count($dataList) !== count($dataList1)) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
if ('Account.create' !== $webhook->getEvent()) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
return 200;
|
||||
}
|
||||
|
||||
if ($invokedCount->numberOfInvocations() === 2) {
|
||||
if (count($dataList) !== count($dataList2)) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
if ('Account.update' !== $webhook->getEvent()) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
return 200;
|
||||
}
|
||||
|
||||
return 0;
|
||||
});
|
||||
|
||||
$queue->process();
|
||||
$queue->process();
|
||||
|
||||
$this->assertFalse($notSame);
|
||||
}
|
||||
|
||||
public function testProcessing2(): void
|
||||
{
|
||||
$user = $this->createUser(
|
||||
[
|
||||
'userName' => 'test',
|
||||
'password' => '1',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => [
|
||||
'create' => 'yes',
|
||||
'read' => 'own',
|
||||
],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$this->authenticate(null);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$account1 = $em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test1',
|
||||
'assignedUserId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$account2 = $em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test2',
|
||||
'assignedUserId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$em->createEntity(Webhook::ENTITY_TYPE, [
|
||||
'event' => 'Account.delete',
|
||||
'userId' => $user->getId(),
|
||||
'url' => 'https://test.com',
|
||||
'skipOwn' => true,
|
||||
]);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$this->authenticate(null);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$em->removeEntity($account1);
|
||||
$em->removeEntity($account2, [SaveOption::MODIFIED_BY_ID => $user->getId()]);
|
||||
|
||||
$sender = $this->createMock(Sender::class);
|
||||
|
||||
$queue = $this->getInjectableFactory()
|
||||
->createWith(Queue::class, [
|
||||
'sender' => $sender,
|
||||
]);
|
||||
|
||||
$dataList1 = [
|
||||
(object) [
|
||||
'id' => $account1->getId(),
|
||||
]
|
||||
];
|
||||
|
||||
$invokedCount = $this->exactly(1);
|
||||
|
||||
$notSame = false;
|
||||
|
||||
$sender
|
||||
->expects($invokedCount)
|
||||
->method('send')
|
||||
->willReturnCallback(function (Webhook $webhook, $dataList) use ($invokedCount, $dataList1, &$notSame) {
|
||||
if ($invokedCount->numberOfInvocations() === 1) {
|
||||
if ('Account.delete' !== $webhook->getEvent()) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
if (json_encode($dataList) !== json_encode($dataList1)) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
return 200;
|
||||
}
|
||||
|
||||
return 0;
|
||||
});
|
||||
|
||||
$queue->process();
|
||||
$queue->process();
|
||||
|
||||
$this->assertFalse($notSame);
|
||||
}
|
||||
|
||||
public function testProcessing3(): void
|
||||
{
|
||||
$user = $this->createUser(
|
||||
[
|
||||
'userName' => 'test',
|
||||
'password' => '1',
|
||||
],
|
||||
[
|
||||
'data' => [
|
||||
'Webhook' => true,
|
||||
'Account' => [
|
||||
'create' => 'yes',
|
||||
'read' => 'own',
|
||||
],
|
||||
],
|
||||
]
|
||||
);
|
||||
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$account1 = $em->createEntity(Account::ENTITY_TYPE, [
|
||||
'name' => 'test1',
|
||||
'assignedUserId' => $user->getId(),
|
||||
]);
|
||||
|
||||
$em->createEntity(Webhook::ENTITY_TYPE, [
|
||||
'event' => 'Account.fieldUpdate.name',
|
||||
'userId' => $user->getId(),
|
||||
'url' => 'https://test.com',
|
||||
]);
|
||||
|
||||
$this->getDataManager()->clearCache();
|
||||
|
||||
$this->authenticate(null);
|
||||
|
||||
$em = $this->getEntityManager();
|
||||
|
||||
$account1->set('name', 'test-1-changed');
|
||||
|
||||
$em->saveEntity($account1);
|
||||
|
||||
$dataList1 = [
|
||||
(object) [
|
||||
'id' => $account1->getId(),
|
||||
'name' => 'test-1-changed',
|
||||
]
|
||||
];
|
||||
|
||||
$sender = $this->createMock(Sender::class);
|
||||
|
||||
$queue = $this->getInjectableFactory()
|
||||
->createWith(Queue::class, [
|
||||
'sender' => $sender,
|
||||
]);
|
||||
|
||||
$invokedCount = $this->exactly(1);
|
||||
|
||||
$notSame = false;
|
||||
|
||||
$sender
|
||||
->expects($invokedCount)
|
||||
->method('send')
|
||||
->willReturnCallback(function (Webhook $webhook, $dataList) use ($invokedCount, $dataList1, &$notSame) {
|
||||
if ($invokedCount->numberOfInvocations() === 1) {
|
||||
if (json_encode($dataList) !== json_encode($dataList1)) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
if ('Account.fieldUpdate.name' !== $webhook->getEvent()) {
|
||||
$notSame = true;
|
||||
}
|
||||
|
||||
return 200;
|
||||
}
|
||||
|
||||
return 0;
|
||||
});
|
||||
|
||||
$queue->process();
|
||||
$queue->process();
|
||||
|
||||
$this->assertFalse($notSame);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user