snapshot of https://github.com/excalidraw/excalidraw.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Tests / test (push) Failing after 15s
Some checks failed
Tests / test (push) Failing after 15s
This commit is contained in:
90
packages/excalidraw/renderer/helpers.test.ts
Normal file
90
packages/excalidraw/renderer/helpers.test.ts
Normal file
@@ -0,0 +1,90 @@
|
||||
import { COLOR_WHITE } from "@excalidraw/common";
|
||||
|
||||
import { bootstrapCanvas } from "./helpers";
|
||||
|
||||
const setup = () => {
|
||||
const canvas = document.createElement("canvas");
|
||||
canvas.width = 200;
|
||||
canvas.height = 100;
|
||||
const context = canvas.getContext("2d")!;
|
||||
const clearRect = vi.spyOn(context, "clearRect");
|
||||
const fillRect = vi.spyOn(context, "fillRect");
|
||||
return { canvas, context, clearRect, fillRect };
|
||||
};
|
||||
|
||||
const run = (viewBackgroundColor: unknown) => {
|
||||
const { canvas, context, clearRect, fillRect } = setup();
|
||||
bootstrapCanvas({
|
||||
canvas,
|
||||
scale: 1,
|
||||
normalizedWidth: 200,
|
||||
normalizedHeight: 100,
|
||||
viewBackgroundColor: viewBackgroundColor as string,
|
||||
});
|
||||
return { context, clearRect, fillRect };
|
||||
};
|
||||
|
||||
describe("bootstrapCanvas background painting", () => {
|
||||
it("skips clearRect for an opaque hex color (fill fully repaints)", () => {
|
||||
const { clearRect, fillRect } = run("#ffffff");
|
||||
expect(clearRect).not.toHaveBeenCalled();
|
||||
expect(fillRect).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("skips clearRect for a 3-digit opaque hex color", () => {
|
||||
const { clearRect, fillRect } = run("#fff");
|
||||
expect(clearRect).not.toHaveBeenCalled();
|
||||
expect(fillRect).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("clears for a hex color with alpha (#RGBA / #RRGGBBAA)", () => {
|
||||
expect(run("#ffff").clearRect).toHaveBeenCalledTimes(1);
|
||||
expect(run("#ffffff80").clearRect).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("clears and skips fill for the transparent keyword", () => {
|
||||
const { clearRect, fillRect } = run("transparent");
|
||||
expect(clearRect).toHaveBeenCalledTimes(1);
|
||||
expect(fillRect).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("clears for rgba()/hsla() colors and still fills", () => {
|
||||
const rgba = run("rgba(255, 0, 0, 0.5)");
|
||||
expect(rgba.clearRect).toHaveBeenCalledTimes(1);
|
||||
expect(rgba.fillRect).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
// the ghosting bug (#10931): a corrupted value must never leave the prior
|
||||
// frame on screen — we always clear when we can't prove the color is opaque
|
||||
it("clears for a corrupted color value to prevent ghosting", () => {
|
||||
expect(run("0000").clearRect).toHaveBeenCalledTimes(1);
|
||||
expect(run("asdfgh").clearRect).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("falls back to white when the color is rejected by the canvas", () => {
|
||||
const { canvas, context } = setup();
|
||||
// simulate a stale fillStyle left over from a previous frame's drawing
|
||||
context.fillStyle = "#ff0000";
|
||||
let fillStyleAtFillTime = "";
|
||||
vi.spyOn(context, "fillRect").mockImplementation(() => {
|
||||
fillStyleAtFillTime = context.fillStyle as string;
|
||||
});
|
||||
|
||||
bootstrapCanvas({
|
||||
canvas,
|
||||
scale: 1,
|
||||
normalizedWidth: 200,
|
||||
normalizedHeight: 100,
|
||||
viewBackgroundColor: "not-a-color",
|
||||
});
|
||||
|
||||
// not the stale red — the seeded default
|
||||
expect(fillStyleAtFillTime).toBe(COLOR_WHITE);
|
||||
});
|
||||
|
||||
it("clears for a non-string background", () => {
|
||||
const { clearRect, fillRect } = run(undefined);
|
||||
expect(clearRect).toHaveBeenCalledTimes(1);
|
||||
expect(fillRect).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user