snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)

server/channels/app/post_file_change_test.go

@@ -0,0 +1,274 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package app
+
+import (
+	"testing"
+
+	"github.com/mattermost/mattermost/server/public/model"
+	"github.com/stretchr/testify/require"
+)
+
+func TestProcessPostFileChanges(t *testing.T) {
+	mainHelper.Parallel(t)
+	th := Setup(t).InitBasic(t)
+
+	t.Run("no files", func(t *testing.T) {
+		oldPost := &model.Post{FileIds: []string{}}
+		newPost := &model.Post{FileIds: []string{}}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 0, len(fileIds))
+	})
+
+	t.Run("have files but nothing changed", func(t *testing.T) {
+		oldPost := &model.Post{FileIds: []string{"file_id_1", "file_id_2"}}
+		newPost := &model.Post{FileIds: []string{"file_id_1", "file_id_2"}}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 2, len(fileIds))
+	})
+
+	t.Run("one file deleted", func(t *testing.T) {
+		postId := model.NewId()
+		fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id},
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id},
+		}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 1, len(fileIds))
+		require.Equal(t, fileInfo1.Id, fileIds[0])
+
+		// verify file2 was soft deleted
+		updatedFileInfos, err := th.App.Srv().Store().FileInfo().GetForPost(postId, true, true, false)
+		require.NoError(t, err)
+		require.Equal(t, 2, len(updatedFileInfos))
+
+		for _, fileInfo := range updatedFileInfos {
+			if fileInfo.Id == fileInfo1.Id {
+				require.Equal(t, int64(0), fileInfo.DeleteAt)
+			} else if fileInfo.Id == fileInfo2.Id {
+				require.Greater(t, fileInfo.DeleteAt, int64(0))
+			} else {
+				require.Fail(t, "unexpected file info")
+			}
+		}
+	})
+
+	t.Run("one file added", func(t *testing.T) {
+		postId := model.NewId()
+		fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
+
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id},
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id},
+		}
+
+		th.Context.Session().UserId = th.BasicUser.Id
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 2, len(fileIds))
+		require.Contains(t, fileIds, fileInfo1.Id)
+		require.Contains(t, fileIds, fileInfo2.Id)
+
+		// verify file2 is attached to the post
+		updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
+		require.NoError(t, err)
+		require.Equal(t, postId, updatedFileInfo2.PostId)
+	})
+
+	t.Run("all files removed", func(t *testing.T) {
+		postId := model.NewId()
+		fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id},
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{},
+		}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 0, len(fileIds))
+
+		// verify file2 was soft deleted
+		updatedFileInfos, err := th.App.Srv().Store().FileInfo().GetForPost(postId, true, true, false)
+		require.NoError(t, err)
+		require.Equal(t, 2, len(updatedFileInfos))
+
+		for _, fileInfo := range updatedFileInfos {
+			if fileInfo.Id == fileInfo1.Id || fileInfo.Id == fileInfo2.Id {
+				require.Greater(t, fileInfo.DeleteAt, int64(0))
+			} else {
+				require.Fail(t, "unexpected file info")
+			}
+		}
+	})
+
+	t.Run("files added when no files existed", func(t *testing.T) {
+		fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
+
+		postId := model.NewId()
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{},
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id},
+		}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 2, len(fileIds))
+		require.Contains(t, fileIds, fileInfo1.Id)
+		require.Contains(t, fileIds, fileInfo2.Id)
+
+		updatedFileInfo1, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
+		require.NoError(t, err)
+		require.Equal(t, postId, updatedFileInfo1.PostId)
+
+		updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
+		require.NoError(t, err)
+		require.Equal(t, postId, updatedFileInfo2.PostId)
+	})
+
+	t.Run("other post's attached file added", func(t *testing.T) {
+		postId := model.NewId()
+		fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, model.NewId(), th.BasicChannel.Id)
+
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id},
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id},
+		}
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 1, len(fileIds))
+		require.Equal(t, fileInfo1.Id, fileIds[0])
+
+		// verify file2 is attached to the post
+		updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
+		require.NoError(t, err)
+		require.NotEqual(t, postId, updatedFileInfo2.PostId)
+	})
+
+	t.Run("when admin adds a file to other user's post", func(t *testing.T) {
+		postId := model.NewId()
+
+		// admin uploads the files
+		fileInfo1 := th.CreateFileInfo(t, th.SystemAdminUser.Id, "", th.BasicChannel.Id)
+		fileInfo2 := th.CreateFileInfo(t, th.SystemAdminUser.Id, "", th.BasicChannel.Id)
+
+		// basic user's post
+		oldPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+		}
+
+		newPost := &model.Post{
+			Id:        postId,
+			UserId:    th.BasicUser.Id,
+			ChannelId: th.BasicChannel.Id,
+			Message:   "Message",
+			CreateAt:  model.GetMillis() - 10000,
+			FileIds:   []string{fileInfo1.Id, fileInfo2.Id}, // admin attaching two files
+		}
+
+		// admin's session
+		th.Context.Session().UserId = th.SystemAdminUser.Id
+
+		fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
+		require.Nil(t, appErr)
+		require.Equal(t, 2, len(fileIds))
+		require.Contains(t, fileIds, fileInfo1.Id)
+		require.Contains(t, fileIds, fileInfo2.Id)
+
+		// verify files are attached to the post and still belong tyo the admin
+		updatedFileInfo1, err := th.App.Srv().Store().FileInfo().Get(fileInfo1.Id)
+		require.NoError(t, err)
+		require.Equal(t, postId, updatedFileInfo1.PostId)
+		require.Equal(t, th.SystemAdminUser.Id, updatedFileInfo1.CreatorId)
+
+		updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
+		require.NoError(t, err)
+		require.Equal(t, postId, updatedFileInfo2.PostId)
+		require.Equal(t, th.SystemAdminUser.Id, updatedFileInfo2.CreatorId)
+	})
+}