snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 1s
This commit is contained in:
140
server/channels/app/properties/license_check_test.go
Normal file
140
server/channels/app/properties/license_check_test.go
Normal file
@@ -0,0 +1,140 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package properties
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"testing"
|
||||
|
||||
"github.com/mattermost/mattermost/server/public/model"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestLicenseCheckHook(t *testing.T) {
|
||||
th := Setup(t)
|
||||
|
||||
group, err := th.service.RegisterPropertyGroup(&model.PropertyGroup{Name: "test_license_check", Version: model.PropertyGroupVersionV2})
|
||||
require.NoError(t, err)
|
||||
|
||||
var currentLicense *model.License
|
||||
hook := NewLicenseCheckHook(func() *model.License {
|
||||
return currentLicense
|
||||
}, group.ID)
|
||||
th.service.AddHook(hook)
|
||||
|
||||
enterpriseLicense := model.NewTestLicenseSKU(model.LicenseShortSkuEnterprise)
|
||||
|
||||
makeField := func() *model.PropertyField {
|
||||
return &model.PropertyField{
|
||||
GroupID: group.ID,
|
||||
Name: "field_" + model.NewId(),
|
||||
Type: model.PropertyFieldTypeText,
|
||||
TargetType: "system",
|
||||
ObjectType: "user",
|
||||
}
|
||||
}
|
||||
|
||||
t.Run("blocks field create without license", func(t *testing.T) {
|
||||
currentLicense = nil
|
||||
_, createErr := th.service.CreatePropertyField(th.Context, makeField())
|
||||
require.Error(t, createErr)
|
||||
assert.Contains(t, createErr.Error(), "license_error")
|
||||
})
|
||||
|
||||
t.Run("allows field create with license, blocks read after license loss", func(t *testing.T) {
|
||||
currentLicense = enterpriseLicense
|
||||
created, createErr := th.service.CreatePropertyField(th.Context, makeField())
|
||||
require.NoError(t, createErr)
|
||||
assert.NotEmpty(t, created.ID)
|
||||
|
||||
currentLicense = nil
|
||||
_, getErr := th.service.GetPropertyField(th.Context, group.ID, created.ID)
|
||||
require.Error(t, getErr)
|
||||
assert.Contains(t, getErr.Error(), "license_error")
|
||||
})
|
||||
|
||||
t.Run("blocks value upsert without license", func(t *testing.T) {
|
||||
currentLicense = enterpriseLicense
|
||||
field := th.CreatePropertyFieldDirect(t, makeField())
|
||||
|
||||
currentLicense = nil
|
||||
value := &model.PropertyValue{
|
||||
GroupID: group.ID,
|
||||
FieldID: field.ID,
|
||||
TargetID: model.NewId(),
|
||||
TargetType: "user",
|
||||
Value: json.RawMessage(`"hello"`),
|
||||
}
|
||||
_, upsertErr := th.service.UpsertPropertyValue(th.Context, value)
|
||||
require.Error(t, upsertErr)
|
||||
assert.Contains(t, upsertErr.Error(), "license_error")
|
||||
})
|
||||
|
||||
t.Run("allows operations on unmanaged groups without license", func(t *testing.T) {
|
||||
currentLicense = nil
|
||||
otherGroup, groupErr := th.service.RegisterPropertyGroup(&model.PropertyGroup{Name: "test_no_license_needed", Version: model.PropertyGroupVersionV2})
|
||||
require.NoError(t, groupErr)
|
||||
|
||||
field := &model.PropertyField{
|
||||
GroupID: otherGroup.ID,
|
||||
Name: "field_" + model.NewId(),
|
||||
Type: model.PropertyFieldTypeText,
|
||||
TargetType: "system",
|
||||
ObjectType: "user",
|
||||
}
|
||||
created, createErr := th.service.CreatePropertyField(th.Context, field)
|
||||
require.NoError(t, createErr)
|
||||
assert.NotEmpty(t, created.ID)
|
||||
})
|
||||
|
||||
countCalls := []struct {
|
||||
name string
|
||||
call func(groupID string) error
|
||||
}{
|
||||
{"CountActivePropertyFieldsForGroup", func(id string) error {
|
||||
_, err := th.service.CountActivePropertyFieldsForGroup(th.Context, id)
|
||||
return err
|
||||
}},
|
||||
{"CountAllPropertyFieldsForGroup", func(id string) error {
|
||||
_, err := th.service.CountAllPropertyFieldsForGroup(th.Context, id)
|
||||
return err
|
||||
}},
|
||||
{"CountActivePropertyFieldsForTarget", func(id string) error {
|
||||
_, err := th.service.CountActivePropertyFieldsForTarget(th.Context, id, "user", model.NewId())
|
||||
return err
|
||||
}},
|
||||
{"CountAllPropertyFieldsForTarget", func(id string) error {
|
||||
_, err := th.service.CountAllPropertyFieldsForTarget(th.Context, id, "user", model.NewId())
|
||||
return err
|
||||
}},
|
||||
}
|
||||
|
||||
t.Run("blocks field counts without license on managed group", func(t *testing.T) {
|
||||
currentLicense = enterpriseLicense
|
||||
th.CreatePropertyFieldDirect(t, makeField())
|
||||
currentLicense = nil
|
||||
for _, c := range countCalls {
|
||||
err := c.call(group.ID)
|
||||
require.Error(t, err, c.name)
|
||||
assert.Contains(t, err.Error(), "license_error", c.name)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("allows field counts with license on managed group", func(t *testing.T) {
|
||||
currentLicense = enterpriseLicense
|
||||
for _, c := range countCalls {
|
||||
require.NoError(t, c.call(group.ID), c.name)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("allows field counts without license on unmanaged group", func(t *testing.T) {
|
||||
currentLicense = nil
|
||||
otherGroup, groupErr := th.service.RegisterPropertyGroup(&model.PropertyGroup{Name: "count_no_license_needed", Version: model.PropertyGroupVersionV2})
|
||||
require.NoError(t, groupErr)
|
||||
for _, c := range countCalls {
|
||||
require.NoError(t, c.call(otherGroup.ID), c.name)
|
||||
}
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user