snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
This commit is contained in:
139
server/channels/app/properties/session_attributes.go
Normal file
139
server/channels/app/properties/session_attributes.go
Normal file
@@ -0,0 +1,139 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package properties
|
||||
|
||||
import (
|
||||
"context"
|
||||
"net/http"
|
||||
"reflect"
|
||||
|
||||
"github.com/mattermost/mattermost/server/public/model"
|
||||
"github.com/mattermost/mattermost/server/public/shared/request"
|
||||
)
|
||||
|
||||
// SessionAttributesHook keeps the seeded session_attributes schema fixed: fields
|
||||
// can't be created or deleted through the public API, and updates are limited to
|
||||
// the tunable Attrs (enabled, ttl_seconds, grace_period_seconds). The fields are
|
||||
// not Protected (that is reserved for plugin-owned fields), so this hook is the
|
||||
// enforcement instead.
|
||||
type SessionAttributesHook struct {
|
||||
BasePropertyHook
|
||||
propertyService *PropertyService
|
||||
groupID string
|
||||
}
|
||||
|
||||
var _ PropertyHook = (*SessionAttributesHook)(nil)
|
||||
|
||||
func NewSessionAttributesHook(ps *PropertyService, groupID string) *SessionAttributesHook {
|
||||
return &SessionAttributesHook{propertyService: ps, groupID: groupID}
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) manages(groupID string) bool {
|
||||
return groupID == h.groupID
|
||||
}
|
||||
|
||||
type systemCallerKey struct{}
|
||||
|
||||
func SystemCallerContext(rctx request.CTX) request.CTX {
|
||||
return rctx.WithContext(context.WithValue(rctx.Context(), systemCallerKey{}, true))
|
||||
}
|
||||
|
||||
func isSystemCaller(rctx request.CTX) bool {
|
||||
if rctx == nil {
|
||||
return false
|
||||
}
|
||||
isSystemCaller, _ := rctx.Context().Value(systemCallerKey{}).(bool)
|
||||
return isSystemCaller
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) PreCreatePropertyField(rctx request.CTX, field *model.PropertyField) (*model.PropertyField, error) {
|
||||
if field.GroupID != h.groupID || isSystemCaller(rctx) {
|
||||
return field, nil
|
||||
}
|
||||
return nil, h.immutableErr("created")
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) PreDeletePropertyField(rctx request.CTX, groupID string, _ string) error {
|
||||
if !h.manages(groupID) || isSystemCaller(rctx) {
|
||||
return nil
|
||||
}
|
||||
return h.immutableErr("deleted")
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) PreUpdatePropertyField(rctx request.CTX, groupID string, field *model.PropertyField) (*model.PropertyField, error) {
|
||||
if !h.manages(groupID) || isSystemCaller(rctx) {
|
||||
return field, nil
|
||||
}
|
||||
if err := h.validateUpdate(rctx, field); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
return field, nil
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) PreUpdatePropertyFields(rctx request.CTX, groupID string, fields []*model.PropertyField) ([]*model.PropertyField, error) {
|
||||
if !h.manages(groupID) || isSystemCaller(rctx) {
|
||||
return fields, nil
|
||||
}
|
||||
for _, field := range fields {
|
||||
if err := h.validateUpdate(rctx, field); err != nil {
|
||||
return nil, err
|
||||
}
|
||||
}
|
||||
return fields, nil
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) validateUpdate(rctx request.CTX, incoming *model.PropertyField) error {
|
||||
existing, err := h.propertyService.getPropertyFieldFromMaster(rctx, h.groupID, incoming.ID)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
if sessionAttributeIdentityChanged(existing, incoming) || !sessionAttributeAttrsEditAllowed(existing.Attrs, incoming.Attrs) {
|
||||
return h.immutableErr("changed")
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func (h *SessionAttributesHook) immutableErr(verb string) *model.AppError {
|
||||
return model.NewAppError("SessionAttributesHook", "app.session_attributes.field_immutable.app_error",
|
||||
nil, "session attribute field "+verb, http.StatusForbidden)
|
||||
}
|
||||
|
||||
func sessionAttributeIdentityChanged(existing, incoming *model.PropertyField) bool {
|
||||
if existing.Name != incoming.Name ||
|
||||
existing.Type != incoming.Type ||
|
||||
existing.TargetID != incoming.TargetID ||
|
||||
existing.TargetType != incoming.TargetType ||
|
||||
existing.ObjectType != incoming.ObjectType {
|
||||
return true
|
||||
}
|
||||
if (existing.LinkedFieldID == nil) != (incoming.LinkedFieldID == nil) {
|
||||
return true
|
||||
}
|
||||
return existing.LinkedFieldID != nil && *existing.LinkedFieldID != *incoming.LinkedFieldID
|
||||
}
|
||||
|
||||
func sessionAttributeAttrsEditAllowed(existing, incoming model.StringInterface) bool {
|
||||
tunable := map[string]bool{
|
||||
model.SAAttrEnabled: true,
|
||||
model.SAAttrTTLSeconds: true,
|
||||
model.SAAttrGracePeriodSeconds: true,
|
||||
}
|
||||
for key, existingValue := range existing {
|
||||
if tunable[key] {
|
||||
continue
|
||||
}
|
||||
incomingValue, ok := incoming[key]
|
||||
if !ok || !reflect.DeepEqual(existingValue, incomingValue) {
|
||||
return false
|
||||
}
|
||||
}
|
||||
for key := range incoming {
|
||||
if !tunable[key] {
|
||||
if _, ok := existing[key]; !ok {
|
||||
return false
|
||||
}
|
||||
}
|
||||
}
|
||||
return true
|
||||
}
|
||||
Reference in New Issue
Block a user