snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
This commit is contained in:
231
server/public/model/incoming_webhook_test.go
Normal file
231
server/public/model/incoming_webhook_test.go
Normal file
@@ -0,0 +1,231 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package model
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestIncomingWebhookIsValid(t *testing.T) {
|
||||
o := IncomingWebhook{}
|
||||
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.Id = NewId()
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.CreateAt = GetMillis()
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.UpdateAt = GetMillis()
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.UserId = "123"
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.UserId = NewId()
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.ChannelId = "123"
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.ChannelId = NewId()
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.TeamId = "123"
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.TeamId = NewId()
|
||||
require.Nil(t, o.IsValid())
|
||||
|
||||
o.DisplayName = strings.Repeat("1", 65)
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.DisplayName = strings.Repeat("1", 64)
|
||||
require.Nil(t, o.IsValid())
|
||||
|
||||
o.Description = strings.Repeat("1", 501)
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.Description = strings.Repeat("1", 500)
|
||||
require.Nil(t, o.IsValid())
|
||||
|
||||
o.Username = strings.Repeat("1", 65)
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.Username = strings.Repeat("1", 64)
|
||||
require.Nil(t, o.IsValid())
|
||||
|
||||
o.IconURL = strings.Repeat("1", 1025)
|
||||
require.NotNil(t, o.IsValid())
|
||||
|
||||
o.IconURL = strings.Repeat("1", 1024)
|
||||
require.Nil(t, o.IsValid())
|
||||
}
|
||||
|
||||
func TestIncomingWebhookPreSave(t *testing.T) {
|
||||
o := IncomingWebhook{}
|
||||
o.PreSave()
|
||||
}
|
||||
|
||||
func TestIncomingWebhookPreUpdate(t *testing.T) {
|
||||
o := IncomingWebhook{}
|
||||
o.PreUpdate()
|
||||
}
|
||||
|
||||
func TestIncomingWebhookRequestHasInteractiveMessageProps(t *testing.T) {
|
||||
t.Run("nil request", func(t *testing.T) {
|
||||
var req *IncomingWebhookRequest
|
||||
require.False(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("empty props", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{}
|
||||
require.False(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("empty interactive arrays", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsMmBlocks: []any{},
|
||||
PostPropsBlockKitBlocks: []any{},
|
||||
PostPropsAdaptiveCards: []any{},
|
||||
PostPropsAttachments: []any{},
|
||||
},
|
||||
}
|
||||
require.False(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("mm_blocks when feature flag enabled", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsMmBlocks: []any{map[string]any{"type": "text", "text": "hello"}},
|
||||
},
|
||||
}
|
||||
require.True(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("mm_blocks ignored when feature flag disabled", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsMmBlocks: []any{map[string]any{"type": "text", "text": "hello"}},
|
||||
},
|
||||
}
|
||||
require.False(t, req.HasInteractiveMessageProps(false))
|
||||
})
|
||||
|
||||
t.Run("blocks when feature flag enabled", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsBlockKitBlocks: []any{map[string]any{"type": "section"}},
|
||||
},
|
||||
}
|
||||
require.True(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("cards when feature flag enabled", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsAdaptiveCards: []any{map[string]any{"type": "AdaptiveCard"}},
|
||||
},
|
||||
}
|
||||
require.True(t, req.HasInteractiveMessageProps(true))
|
||||
})
|
||||
|
||||
t.Run("attachments in props regardless of feature flag", func(t *testing.T) {
|
||||
req := &IncomingWebhookRequest{
|
||||
Props: StringInterface{
|
||||
PostPropsAttachments: []any{map[string]any{"text": "attachment"}},
|
||||
},
|
||||
}
|
||||
require.True(t, req.HasInteractiveMessageProps(true))
|
||||
require.True(t, req.HasInteractiveMessageProps(false))
|
||||
})
|
||||
}
|
||||
|
||||
func TestIncomingWebhookRequestFromJSON(t *testing.T) {
|
||||
texts := []string{
|
||||
`this is a test`,
|
||||
`this is a test
|
||||
that contains a newline and tabs`,
|
||||
`this is a test \"foo
|
||||
that contains a newline and tabs`,
|
||||
`this is a test \"foo\"
|
||||
that contains a newline and tabs`,
|
||||
`this is a test \"foo\"
|
||||
\" that contains a newline and tabs`,
|
||||
`this is a test \"foo\"
|
||||
|
||||
\" that contains a newline and tabs
|
||||
`,
|
||||
}
|
||||
|
||||
for _, text := range texts {
|
||||
// build a sample payload with the text
|
||||
payload := `{
|
||||
"text": "` + text + `",
|
||||
"attachments": [
|
||||
{
|
||||
"fallback": "` + text + `",
|
||||
|
||||
"color": "#36a64f",
|
||||
|
||||
"pretext": "` + text + `",
|
||||
|
||||
"author_name": "` + text + `",
|
||||
"author_link": "http://flickr.com/bobby/",
|
||||
"author_icon": "http://flickr.com/icons/bobby.jpg",
|
||||
|
||||
"title": "` + text + `",
|
||||
"title_link": "https://api.slack.com/",
|
||||
|
||||
"text": "` + text + `",
|
||||
|
||||
"fields": [
|
||||
{
|
||||
"title": "` + text + `",
|
||||
"value": "` + text + `",
|
||||
"short": false
|
||||
}
|
||||
],
|
||||
|
||||
"image_url": "http://my-website.com/path/to/image.jpg",
|
||||
"thumb_url": "http://example.com/path/to/thumb.png"
|
||||
}
|
||||
]
|
||||
}`
|
||||
|
||||
// try to create an IncomingWebhookRequest from the payload
|
||||
data := strings.NewReader(payload)
|
||||
iwr, _ := IncomingWebhookRequestFromJSON(data)
|
||||
|
||||
// After it has been decoded, the JSON string won't contain the escape char anymore
|
||||
expected := strings.Replace(text, `\"`, `"`, -1)
|
||||
require.NotNil(t, iwr)
|
||||
require.Equal(t, expected, iwr.Text)
|
||||
|
||||
attachment := iwr.Attachments[0]
|
||||
require.Equal(t, expected, attachment.Text)
|
||||
}
|
||||
}
|
||||
|
||||
func TestIncomingWebhookNullArrayItems(t *testing.T) {
|
||||
payload := `{"attachments":[{"fields":[{"title":"foo","value":"bar","short":true}, null]}, null]}`
|
||||
iwr, _ := IncomingWebhookRequestFromJSON(strings.NewReader(payload))
|
||||
require.NotNil(t, iwr)
|
||||
require.Len(t, iwr.Attachments, 1)
|
||||
require.Len(t, iwr.Attachments[0].Fields, 1)
|
||||
}
|
||||
|
||||
func TestIncomingWebhookRequestFromJSONRootId(t *testing.T) {
|
||||
id := NewId()
|
||||
payload := `{"text":"hello","root_id":"` + id + `"}`
|
||||
iwr, err := IncomingWebhookRequestFromJSON(strings.NewReader(payload))
|
||||
require.Nil(t, err)
|
||||
require.NotNil(t, iwr)
|
||||
require.Equal(t, id, iwr.RootId)
|
||||
}
|
||||
Reference in New Issue
Block a user