snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
This commit is contained in:
247
server/public/model/message_attachment_test.go
Normal file
247
server/public/model/message_attachment_test.go
Normal file
@@ -0,0 +1,247 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package model
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestMessageAttachment_IsValid(t *testing.T) {
|
||||
tests := map[string]struct {
|
||||
attachment *MessageAttachment
|
||||
wantErr string
|
||||
}{
|
||||
"valid attachment": {
|
||||
attachment: &MessageAttachment{
|
||||
Text: "This is a test",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"invalid color": {
|
||||
attachment: &MessageAttachment{
|
||||
Color: "invalid",
|
||||
},
|
||||
wantErr: "invalid style 'invalid' - must be one of [good, warning, danger] or a hex color",
|
||||
},
|
||||
"valid predefined color": {
|
||||
attachment: &MessageAttachment{
|
||||
Color: "good",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"valid warning color": {
|
||||
attachment: &MessageAttachment{
|
||||
Color: "warning",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"valid danger color": {
|
||||
attachment: &MessageAttachment{
|
||||
Color: "danger",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"valid hex color": {
|
||||
attachment: &MessageAttachment{
|
||||
Color: "#FF0000",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"author link without name": {
|
||||
attachment: &MessageAttachment{
|
||||
AuthorLink: "http://example.com",
|
||||
},
|
||||
wantErr: "author link cannot be set without author name",
|
||||
},
|
||||
"invalid author link": {
|
||||
attachment: &MessageAttachment{
|
||||
AuthorName: "Author",
|
||||
AuthorLink: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid author link URL",
|
||||
},
|
||||
"invalid author icon": {
|
||||
attachment: &MessageAttachment{
|
||||
AuthorIcon: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid author icon URL",
|
||||
},
|
||||
"title link without title": {
|
||||
attachment: &MessageAttachment{
|
||||
TitleLink: "http://example.com",
|
||||
},
|
||||
wantErr: "title link cannot be set without title",
|
||||
},
|
||||
"invalid title link": {
|
||||
attachment: &MessageAttachment{
|
||||
Title: "Title",
|
||||
TitleLink: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid title link URL",
|
||||
},
|
||||
"invalid image URL": {
|
||||
attachment: &MessageAttachment{
|
||||
ImageURL: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid image URL",
|
||||
},
|
||||
"invalid thumb URL": {
|
||||
attachment: &MessageAttachment{
|
||||
ThumbURL: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid thumb URL",
|
||||
},
|
||||
"invalid footer icon": {
|
||||
attachment: &MessageAttachment{
|
||||
FooterIcon: "invalid-url",
|
||||
},
|
||||
wantErr: "invalid footer icon URL",
|
||||
},
|
||||
"invalid timestamp type": {
|
||||
attachment: &MessageAttachment{
|
||||
Timestamp: []string{"invalid"},
|
||||
},
|
||||
wantErr: "timestamp must be either a string or int64",
|
||||
},
|
||||
"valid timestamp string": {
|
||||
attachment: &MessageAttachment{
|
||||
Timestamp: "1234567890",
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"valid timestamp int64": {
|
||||
attachment: &MessageAttachment{
|
||||
Timestamp: int64(1234567890),
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
"invalid action": {
|
||||
attachment: &MessageAttachment{
|
||||
Actions: []*PostAction{
|
||||
{
|
||||
Name: "", // Invalid - missing name
|
||||
},
|
||||
},
|
||||
},
|
||||
wantErr: "action must have a name",
|
||||
},
|
||||
"invalid field value type": {
|
||||
attachment: &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Title",
|
||||
Value: []string{"invalid"},
|
||||
},
|
||||
},
|
||||
},
|
||||
wantErr: "value must be either a string or int",
|
||||
},
|
||||
"valid fields": {
|
||||
attachment: &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Title",
|
||||
Value: "string value",
|
||||
},
|
||||
{
|
||||
Title: "Number",
|
||||
Value: 42,
|
||||
},
|
||||
},
|
||||
},
|
||||
wantErr: "",
|
||||
},
|
||||
}
|
||||
|
||||
for name, tc := range tests {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
err := tc.attachment.IsValid()
|
||||
if tc.wantErr == "" {
|
||||
assert.NoError(t, err, name)
|
||||
} else {
|
||||
assert.ErrorContains(t, err, tc.wantErr, name)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestParseMessageAttachment(t *testing.T) {
|
||||
t.Run("empty list", func(t *testing.T) {
|
||||
post := &Post{}
|
||||
attachments := []*MessageAttachment{}
|
||||
|
||||
ParseMessageAttachment(post, attachments)
|
||||
|
||||
expectedPost := &Post{
|
||||
Type: PostTypeMessageAttachment,
|
||||
Props: map[string]any{
|
||||
PostPropsAttachments: []*MessageAttachment{},
|
||||
},
|
||||
}
|
||||
assert.Equal(t, expectedPost, post)
|
||||
})
|
||||
|
||||
t.Run("list with nil", func(t *testing.T) {
|
||||
post := &Post{}
|
||||
attachments := []*MessageAttachment{
|
||||
nil,
|
||||
}
|
||||
|
||||
ParseMessageAttachment(post, attachments)
|
||||
|
||||
expectedPost := &Post{
|
||||
Type: PostTypeMessageAttachment,
|
||||
Props: map[string]any{
|
||||
PostPropsAttachments: []*MessageAttachment{},
|
||||
},
|
||||
}
|
||||
assert.Equal(t, expectedPost, post)
|
||||
})
|
||||
}
|
||||
|
||||
func TestMessageAttachment_Equals_PrimitiveAndNonPrimitiveField(t *testing.T) {
|
||||
// Field with primitive type (string)
|
||||
attachment1 := &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Field1",
|
||||
Value: "value",
|
||||
Short: true,
|
||||
},
|
||||
},
|
||||
}
|
||||
attachment2 := &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Field1",
|
||||
Value: "value",
|
||||
Short: true,
|
||||
},
|
||||
},
|
||||
}
|
||||
assert.True(t, attachment1.Equals(attachment2), "Attachments with identical primitive field values should be equal")
|
||||
|
||||
// Field with non-primitive type ([]interface{})
|
||||
attachment3 := &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Field1",
|
||||
Value: []any{"value", 2},
|
||||
Short: true,
|
||||
},
|
||||
},
|
||||
}
|
||||
attachment4 := &MessageAttachment{
|
||||
Fields: []*MessageAttachmentField{
|
||||
{
|
||||
Title: "Field1",
|
||||
Value: []any{"value", 2},
|
||||
Short: true,
|
||||
},
|
||||
},
|
||||
}
|
||||
assert.True(t, attachment3.Equals(attachment4), "Attachments with identical non-primitive ([]interface{}) field values should be equal")
|
||||
}
|
||||
Reference in New Issue
Block a user