snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
This commit is contained in:
223
server/public/plugin/context_rpc.go
Normal file
223
server/public/plugin/context_rpc.go
Normal file
@@ -0,0 +1,223 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package plugin
|
||||
|
||||
import (
|
||||
"context"
|
||||
"io"
|
||||
"sync"
|
||||
"time"
|
||||
)
|
||||
|
||||
// rpcRequestContext carries only deadline metadata. Explicit cancellation is signaled
|
||||
// separately over the context stream. Values are not propagated because contexts cannot
|
||||
// enumerate them, and their keys and values may rely on process-local identity.
|
||||
type rpcRequestContext struct {
|
||||
DeadlineUnixNano int64
|
||||
}
|
||||
|
||||
type closeReason byte
|
||||
|
||||
// Cancellation writes one closeReason byte before closing the stream.
|
||||
// Normal closure is represented by EOF; unknown reasons cancel the context.
|
||||
const (
|
||||
rpcStreamClosed closeReason = iota
|
||||
rpcStreamCanceled
|
||||
rpcStreamDeadlineExceeded
|
||||
)
|
||||
|
||||
func openRPCRequestContext(muxBroker rpcMuxBroker, streamID uint32, requestContext rpcRequestContext) (context.Context, func(), error) {
|
||||
if streamID == 0 {
|
||||
return context.Background(), func() {}, nil
|
||||
}
|
||||
|
||||
connection, err := muxBroker.Dial(streamID)
|
||||
if err != nil {
|
||||
return nil, nil, err
|
||||
}
|
||||
|
||||
ctx, cancel := requestContext.Context()
|
||||
go watchRPCContext(ctx, connection, cancel)
|
||||
cleanup := func() {
|
||||
cancel()
|
||||
_ = connection.Close()
|
||||
}
|
||||
|
||||
return ctx, cleanup, nil
|
||||
}
|
||||
|
||||
func newRPCRequestContext(ctx context.Context) rpcRequestContext {
|
||||
deadline, ok := ctx.Deadline()
|
||||
if !ok {
|
||||
return rpcRequestContext{}
|
||||
}
|
||||
|
||||
return rpcRequestContext{DeadlineUnixNano: deadline.UnixNano()}
|
||||
}
|
||||
|
||||
func (c rpcRequestContext) Context() (context.Context, context.CancelFunc) {
|
||||
if c.DeadlineUnixNano != 0 {
|
||||
return context.WithDeadline(context.Background(), time.Unix(0, c.DeadlineUnixNano))
|
||||
}
|
||||
|
||||
return context.WithCancel(context.Background())
|
||||
}
|
||||
|
||||
// rpcStreamCloser owns a per-request mux stream whose MuxBroker.Accept runs concurrently
|
||||
// with request cancellation. Close or Cancel may therefore run before Set receives the
|
||||
// accepted connection. In that case, Set signals the saved cancellation reason when needed
|
||||
// and immediately closes the late connection so it cannot outlive the request. Set returns
|
||||
// false when it closes a connection this way.
|
||||
type rpcStreamCloser struct {
|
||||
mutex sync.Mutex
|
||||
stream io.Closer
|
||||
closed bool
|
||||
reason closeReason
|
||||
}
|
||||
|
||||
func (c *rpcStreamCloser) Set(stream io.Closer) bool {
|
||||
c.mutex.Lock()
|
||||
defer c.mutex.Unlock()
|
||||
|
||||
if c.closed {
|
||||
if c.reason != rpcStreamClosed {
|
||||
if writer, ok := stream.(io.Writer); ok {
|
||||
_, _ = writer.Write([]byte{byte(c.reason)})
|
||||
}
|
||||
}
|
||||
_ = stream.Close()
|
||||
return false
|
||||
}
|
||||
|
||||
c.stream = stream
|
||||
return true
|
||||
}
|
||||
|
||||
func (c *rpcStreamCloser) Close() error {
|
||||
return c.close(rpcStreamClosed)
|
||||
}
|
||||
|
||||
func (c *rpcStreamCloser) Cancel(err error) error {
|
||||
reason := rpcStreamCanceled
|
||||
if err == context.DeadlineExceeded {
|
||||
reason = rpcStreamDeadlineExceeded
|
||||
}
|
||||
return c.close(reason)
|
||||
}
|
||||
|
||||
func (c *rpcStreamCloser) close(reason closeReason) error {
|
||||
c.mutex.Lock()
|
||||
if c.closed {
|
||||
c.mutex.Unlock()
|
||||
return nil
|
||||
}
|
||||
c.closed = true
|
||||
c.reason = reason
|
||||
stream := c.stream
|
||||
c.mutex.Unlock()
|
||||
|
||||
if stream != nil {
|
||||
if reason != rpcStreamClosed {
|
||||
if writer, ok := stream.(io.Writer); ok {
|
||||
_, _ = writer.Write([]byte{byte(reason)})
|
||||
}
|
||||
}
|
||||
return stream.Close()
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
// contextReadCloser closes the underlying stream when the context ends, unblocking an
|
||||
// active Read and ensuring it reports ctx.Err instead of a transport error.
|
||||
type contextReadCloser struct {
|
||||
ctx context.Context
|
||||
reader io.ReadCloser
|
||||
closeOnce sync.Once
|
||||
closeErr error
|
||||
stopContextCallback func() bool
|
||||
onClose func()
|
||||
}
|
||||
|
||||
func newContextReadCloser(ctx context.Context, reader io.ReadCloser, onClose func()) io.ReadCloser {
|
||||
r := &contextReadCloser{
|
||||
ctx: ctx,
|
||||
reader: reader,
|
||||
onClose: onClose,
|
||||
}
|
||||
|
||||
if ctx.Done() != nil {
|
||||
r.stopContextCallback = context.AfterFunc(ctx, func() {
|
||||
_ = r.closeFromContext()
|
||||
})
|
||||
}
|
||||
|
||||
return r
|
||||
}
|
||||
|
||||
func (r *contextReadCloser) Read(p []byte) (int, error) {
|
||||
if err := r.ctx.Err(); err != nil {
|
||||
_ = r.Close()
|
||||
return 0, err
|
||||
}
|
||||
|
||||
n, err := r.reader.Read(p)
|
||||
if ctxErr := r.ctx.Err(); ctxErr != nil {
|
||||
_ = r.Close()
|
||||
return 0, ctxErr
|
||||
}
|
||||
if err != nil {
|
||||
_ = r.Close()
|
||||
}
|
||||
return n, err
|
||||
}
|
||||
|
||||
func (r *contextReadCloser) Close() error {
|
||||
if r.stopContextCallback != nil {
|
||||
r.stopContextCallback()
|
||||
}
|
||||
return r.close()
|
||||
}
|
||||
|
||||
func (r *contextReadCloser) closeFromContext() error {
|
||||
return r.close()
|
||||
}
|
||||
|
||||
func (r *contextReadCloser) close() error {
|
||||
r.closeOnce.Do(func() {
|
||||
r.closeErr = r.reader.Close()
|
||||
if r.onClose != nil {
|
||||
r.onClose()
|
||||
}
|
||||
})
|
||||
return r.closeErr
|
||||
}
|
||||
|
||||
// watchRPCContext cancels immediately on EOF or explicit cancellation. For deadline
|
||||
// expiry, it lets the reconstructed deadline fire locally so ctx.Err is DeadlineExceeded.
|
||||
func watchRPCContext(ctx context.Context, stream io.ReadCloser, cancel context.CancelFunc) {
|
||||
defer func() { _ = stream.Close() }()
|
||||
|
||||
var buffer [1]byte
|
||||
if _, err := io.ReadFull(stream, buffer[:]); err != nil {
|
||||
cancel()
|
||||
return
|
||||
}
|
||||
|
||||
switch closeReason(buffer[0]) {
|
||||
case rpcStreamDeadlineExceeded:
|
||||
// The sender reports DeadlineExceeded for the deadline copied into ctx.
|
||||
// Wait for that deadline to expire so ctx.Err() returns DeadlineExceeded
|
||||
// instead of Canceled.
|
||||
if _, ok := ctx.Deadline(); ok {
|
||||
<-ctx.Done()
|
||||
} else {
|
||||
cancel()
|
||||
}
|
||||
case rpcStreamCanceled, rpcStreamClosed:
|
||||
cancel()
|
||||
default:
|
||||
// Unknown reasons cancel the context.
|
||||
cancel()
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user