snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)

tools/mattermost-govet/appErrorWhere/appErrorWhere.go

@@ -0,0 +1,63 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package appErrorWhere
+
+import (
+	"fmt"
+	"go/ast"
+
+	"golang.org/x/tools/go/analysis"
+)
+
+var Analyzer = &analysis.Analyzer{
+	Name: "appErrorWhere",
+	Doc:  "check for invalid where value in the appError",
+	Run:  run,
+}
+
+func run(pass *analysis.Pass) (interface{}, error) {
+	for _, file := range pass.Files {
+		ast.Inspect(file, func(node ast.Node) bool {
+			switch funDecl := node.(type) {
+			case *ast.FuncDecl:
+				ast.Inspect(funDecl, func(node ast.Node) bool {
+					switch x := node.(type) {
+					case *ast.CallExpr:
+						fun, ok := x.Fun.(*ast.SelectorExpr)
+						if !ok {
+							return true
+						}
+
+						module, ok := fun.X.(*ast.Ident)
+						if !ok {
+							return true
+						}
+
+						if fun.Sel.Name != "NewAppError" || module.Name != "model" {
+							return true
+						}
+
+						if len(x.Args) == 0 {
+							return true
+						}
+
+						firstArg, ok := x.Args[0].(*ast.BasicLit)
+						if !ok {
+							return true
+						}
+
+						if firstArg.Value == fmt.Sprintf("\"%s\"", funDecl.Name.Name) {
+							return true
+						}
+
+						pass.Reportf(node.Pos(), "The first NewAppError parameter must be the name of the function, seen: %s, expected: %s", firstArg.Value, fmt.Sprintf("\"%s\"", funDecl.Name.Name))
+					}
+					return true
+				})
+			}
+			return true
+		})
+	}
+	return nil, nil
+}

tools/mattermost-govet/appErrorWhere/appErrorWhere_test.go

@@ -0,0 +1,15 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package appErrorWhere
+
+import (
+	"testing"
+
+	"golang.org/x/tools/go/analysis/analysistest"
+)
+
+func TestAll(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, Analyzer, "a")
+}

tools/mattermost-govet/appErrorWhere/testdata/src/a/a.go

@@ -0,0 +1,48 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package a
+
+import "a/model"
+
+// Valid: First argument matches function name
+func CreateUser() error {
+	return model.NewAppError("CreateUser", "error.message", nil, "", 500)
+}
+
+func UpdateProfile() error {
+	err := model.NewAppError("UpdateProfile", "error.message", nil, "", 500)
+	return err
+}
+
+func DeleteAccount() error {
+	// Multiple calls with correct names
+	if err := model.NewAppError("DeleteAccount", "error1", nil, "", 500); err != nil {
+		return err
+	}
+	return model.NewAppError("DeleteAccount", "error2", nil, "", 400)
+}
+
+// Invalid: First argument doesn't match function name
+func SaveData() error {
+	return model.NewAppError("WrongName", "error.message", nil, "", 500) // want "The first NewAppError parameter must be the name of the function"
+}
+
+func ProcessRequest() error {
+	err := model.NewAppError("DifferentFunction", "error.message", nil, "", 500) // want "The first NewAppError parameter must be the name of the function"
+	return err
+}
+
+func HandleSubmit() error {
+	// One correct, one wrong
+	if true {
+		model.NewAppError("HandleSubmit", "error1", nil, "", 500)
+	}
+	return model.NewAppError("handleSubmit", "error2", nil, "", 400) // want "The first NewAppError parameter must be the name of the function"
+}
+
+// Edge cases
+func EmptyFunction() error {
+	// Empty function name would be caught but we test with wrong name
+	return model.NewAppError("", "error.message", nil, "", 500) // want "The first NewAppError parameter must be the name of the function"
+}

tools/mattermost-govet/appErrorWhere/testdata/src/a/model/model.go

@@ -0,0 +1,26 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package model
+
+// AppError is a mock of Mattermost's AppError type for testing
+type AppError struct {
+	Where         string
+	Message       string
+	DetailedError string
+	StatusCode    int
+}
+
+func (e *AppError) Error() string {
+	return e.Message
+}
+
+// NewAppError creates a new AppError
+func NewAppError(where string, message string, params map[string]any, details string, status int) *AppError {
+	return &AppError{
+		Where:         where,
+		Message:       message,
+		DetailedError: details,
+		StatusCode:    status,
+	}
+}