snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)

tools/mattermost-govet/emptyInterface/emptyInterface.go

@@ -0,0 +1,55 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package emptyInterface
+
+import (
+	"go/ast"
+	"strings"
+
+	"golang.org/x/tools/go/analysis"
+)
+
+var Analyzer = &analysis.Analyzer{
+	Name: "emptyInterface",
+	Doc:  "check for usage of interface{} instead of any",
+	Run:  run,
+}
+
+func run(pass *analysis.Pass) (interface{}, error) {
+	checkList := []string{
+		"Regenerate this file using `make plugin-mocks`.",
+		"Regenerate this file using `make store-mocks`.",
+		"Regenerate this file using `make sharedchannel-mocks`.",
+	}
+
+	for _, file := range pass.Files {
+		comments := ""
+		for _, commentGroup := range file.Comments {
+			for _, comment := range commentGroup.List {
+				comments = comments + comment.Text
+			}
+		}
+		skip := false
+		for _, check := range checkList {
+			if strings.Contains(comments, check) {
+				skip = true
+			}
+		}
+		if skip {
+			continue
+		}
+
+		ast.Inspect(file, func(node ast.Node) bool {
+			switch x := node.(type) {
+			case *ast.InterfaceType:
+				if len(x.Methods.List) == 0 {
+					pass.Reportf(x.Pos(), "using 'interface{}', please replace it with 'any'.")
+				}
+				return true
+			}
+			return true
+		})
+	}
+	return nil, nil
+}

tools/mattermost-govet/emptyInterface/emptyInterface_test.go

@@ -0,0 +1,15 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package emptyInterface
+
+import (
+	"testing"
+
+	"golang.org/x/tools/go/analysis/analysistest"
+)
+
+func TestAll(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, Analyzer, "a")
+}

tools/mattermost-govet/emptyInterface/testdata/src/a/a.go

@@ -0,0 +1,77 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+package a
+
+// Valid: using any instead of interface{}
+func validUsingAny() {
+	var x any
+	x = 42
+	x = "hello"
+	_ = x
+}
+
+func acceptAny(val any) {}
+
+func returnAny() any {
+	return 42
+}
+
+type ValidStruct struct {
+	Field any
+}
+
+// Invalid: using interface{}
+func invalidUsingInterface() {
+	var x interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+	x = 42
+	_ = x
+}
+
+func acceptInterface(val interface{}) {} // want "using 'interface\\{\\}', please replace it with 'any'."
+
+func returnInterface() interface{} { // want "using 'interface\\{\\}', please replace it with 'any'."
+	return 42
+}
+
+type InvalidStruct struct {
+	Field interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+}
+
+// Invalid: multiple empty interfaces
+type MultipleEmptyInterfaces struct {
+	Field1 interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+	Field2 interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+	Field3 any         // Valid
+}
+
+func multipleParams(a interface{}, b interface{}, c any) {} // want "using 'interface\\{\\}', please replace it with 'any'." "using 'interface\\{\\}', please replace it with 'any'."
+
+// Valid: non-empty interfaces
+type Reader interface {
+	Read(p []byte) (n int, err error)
+}
+
+type Writer interface {
+	Write(p []byte) (n int, err error)
+}
+
+func acceptReader(r Reader) {}
+
+// Invalid: map with interface{} values
+var invalidMap = map[string]interface{}{} // want "using 'interface\\{\\}', please replace it with 'any'."
+
+// Valid: map with any values
+var validMap = map[string]any{}
+
+// Invalid: slice of interface{}
+var invalidSlice []interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+
+// Valid: slice of any
+var validSlice []any
+
+// Invalid: channel of interface{}
+var invalidChan chan interface{} // want "using 'interface\\{\\}', please replace it with 'any'."
+
+// Valid: channel of any
+var validChan chan any