snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s

This commit is contained in:
upstream-mirror
2026-09-16 00:29:55 +05:00
commit 240db4e2a7
15309 changed files with 2173406 additions and 0 deletions

View File

@@ -0,0 +1,96 @@
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
package a
// Valid: idiomatic empty string comparisons
func validEmptyStringChecks() {
var s string
// Valid: direct comparison with empty string
if s == "" {
// This is idiomatic
}
if s != "" {
// This is idiomatic
}
str := "hello"
if str == "" {
// This is idiomatic
}
if str != "" {
// This is idiomatic
}
}
// Invalid: using len for empty string checks
func invalidEmptyStringChecks() {
var s string
// Invalid: len(s) == 0
if len(s) == 0 { // want "calling len\\(s\\) == 0 where s is string, please use s == \\\"\\\" instead"
// Should use s == "" instead
}
// Invalid: len(s) != 0
if len(s) != 0 { // want "calling len\\(s\\) != 0 where s is string, please use s != \\\"\\\" instead"
// Should use s != "" instead
}
str := "hello"
// Invalid: len(str) == 0
if len(str) == 0 { // want "calling len\\(s\\) == 0 where s is string, please use s == \\\"\\\" instead"
// Should use str == "" instead
}
// Invalid: len(str) != 0
if len(str) != 0 { // want "calling len\\(s\\) != 0 where s is string, please use s != \\\"\\\" instead"
// Should use str != "" instead
}
// Invalid: len(s) > 0
if len(s) > 0 { // want "calling len\\(s\\) > 0 where s is string, please use s != \\\"\\\" instead"
// Should use s != "" instead
}
// Invalid: len(s) <= 0
if len(s) <= 0 { // want "calling len\\(s\\) <= 0 where s is string, please use s == \\\"\\\" instead"
// Should use s == "" instead
}
}
// Valid: len for non-zero comparisons
func validLenComparisons() {
s := "hello"
// Valid: comparing length to non-zero values
if len(s) == 5 {
// This is fine
}
if len(s) > 5 {
// This is fine
}
if len(s) < 10 {
// This is fine
}
}
// Valid: len for slices
func validSliceLenComparisons() {
slice := []int{1, 2, 3}
// Valid: len on slices (not strings)
if len(slice) == 0 {
// This is acceptable for slices
}
if len(slice) != 0 {
// This is acceptable for slices
}
}