snapshot of https://github.com/mattermost/mattermost.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 1s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 1s
Server CI Nightly Race / Build Environment (push) Failing after 1s
This commit is contained in:
148
tools/mattermost-govet/openApiSync/openApiSync_test.go
Normal file
148
tools/mattermost-govet/openApiSync/openApiSync_test.go
Normal file
@@ -0,0 +1,148 @@
|
||||
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
||||
// See LICENSE.txt for license information.
|
||||
|
||||
package openApiSync
|
||||
|
||||
import (
|
||||
"net/http"
|
||||
"testing"
|
||||
|
||||
v3high "github.com/pb33f/libopenapi/datamodel/high/v3"
|
||||
"golang.org/x/tools/go/analysis/analysistest"
|
||||
)
|
||||
|
||||
func Test(t *testing.T) {
|
||||
testdata := analysistest.TestData()
|
||||
specFile = analysistest.TestData() + "/spec.yaml"
|
||||
analysistest.Run(t, testdata, Analyzer, "api")
|
||||
}
|
||||
|
||||
func TestCleanRegexp(t *testing.T) {
|
||||
tests := []struct {
|
||||
input string
|
||||
want string
|
||||
}{
|
||||
{"/api/v4/users/{user_id:[0-9]+}", "/api/v4/users/{user_id}"},
|
||||
{"/api/v4/users/{username:[A-Za-z0-9\\_\\-\\.]+}", "/api/v4/users/{username}"},
|
||||
{"/api/v4/jobs/type/{job_type:[A-Za-z0-9_-]+}", "/api/v4/jobs/type/{job_type}"},
|
||||
// Literal-value constraints (e.g., {websocket:websocket}) are stripped like any other.
|
||||
{"/api/v4/{websocket:websocket}", "/api/v4/{websocket}"},
|
||||
// Group-alternation patterns must be left intact for splitHandlerByGroup.
|
||||
{"/api/v4/groups/{group_id}/{syncable_type:teams|channels}/{syncable_id}/link", "/api/v4/groups/{group_id}/{syncable_type:teams|channels}/{syncable_id}/link"},
|
||||
// No constraint — unchanged.
|
||||
{"/api/v4/users/{user_id}/posts", "/api/v4/users/{user_id}/posts"},
|
||||
// Multiple constrained params in one path.
|
||||
{"/api/v4/users/{user_id:[0-9]+}/posts/{post_id:[0-9]+}", "/api/v4/users/{user_id}/posts/{post_id}"},
|
||||
}
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.input, func(t *testing.T) {
|
||||
if got := cleanRegexp(tc.input); got != tc.want {
|
||||
t.Errorf("cleanRegexp(%q) = %q, want %q", tc.input, got, tc.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestMatchesTemplate(t *testing.T) {
|
||||
tests := []struct {
|
||||
specPath string
|
||||
handlerPath string
|
||||
want bool
|
||||
}{
|
||||
// Exact match.
|
||||
{
|
||||
"/api/v4/groups/{group_id}/teams/{syncable_id}/link",
|
||||
"/api/v4/groups/{group_id}/teams/{syncable_id}/link",
|
||||
true,
|
||||
},
|
||||
// Spec param matches handler literal segment.
|
||||
{
|
||||
"/api/v4/groups/{group_id}/{syncable_type}/{syncable_id}/link",
|
||||
"/api/v4/groups/{group_id}/channels/{syncable_id}/link",
|
||||
true,
|
||||
},
|
||||
// Spec literal does not match a different handler literal.
|
||||
{
|
||||
"/api/v4/groups/{group_id}/teams/{syncable_id}/link",
|
||||
"/api/v4/groups/{group_id}/channels/{syncable_id}/link",
|
||||
false,
|
||||
},
|
||||
// Spec param matches handler param name.
|
||||
{
|
||||
"/api/v4/users/{user_id}",
|
||||
"/api/v4/users/{user_id}",
|
||||
true,
|
||||
},
|
||||
// Spec param matches handler literal "me".
|
||||
{
|
||||
"/api/v4/users/{user_id}",
|
||||
"/api/v4/users/me",
|
||||
true,
|
||||
},
|
||||
// Different path lengths.
|
||||
{
|
||||
"/api/v4/users/{user_id}/posts",
|
||||
"/api/v4/users/{user_id}",
|
||||
false,
|
||||
},
|
||||
// Completely different paths.
|
||||
{
|
||||
"/api/v4/teams/{team_id}",
|
||||
"/api/v4/users/{user_id}",
|
||||
false,
|
||||
},
|
||||
}
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.specPath+"~"+tc.handlerPath, func(t *testing.T) {
|
||||
if got := matchesTemplate(tc.specPath, tc.handlerPath); got != tc.want {
|
||||
t.Errorf("matchesTemplate(%q, %q) = %v, want %v", tc.specPath, tc.handlerPath, got, tc.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetOperation(t *testing.T) {
|
||||
get := &v3high.Operation{}
|
||||
post := &v3high.Operation{}
|
||||
put := &v3high.Operation{}
|
||||
patch := &v3high.Operation{}
|
||||
del := &v3high.Operation{}
|
||||
head := &v3high.Operation{}
|
||||
opts := &v3high.Operation{}
|
||||
trace := &v3high.Operation{}
|
||||
|
||||
pathItem := &v3high.PathItem{
|
||||
Get: get,
|
||||
Post: post,
|
||||
Put: put,
|
||||
Patch: patch,
|
||||
Delete: del,
|
||||
Head: head,
|
||||
Options: opts,
|
||||
Trace: trace,
|
||||
}
|
||||
|
||||
tests := []struct {
|
||||
method string
|
||||
want *v3high.Operation
|
||||
}{
|
||||
{http.MethodGet, get},
|
||||
{http.MethodPost, post},
|
||||
{http.MethodPut, put},
|
||||
{http.MethodPatch, patch},
|
||||
{http.MethodDelete, del},
|
||||
{http.MethodHead, head},
|
||||
{http.MethodOptions, opts},
|
||||
{http.MethodTrace, trace},
|
||||
{"get", get}, // case-insensitive
|
||||
{"post", post}, // case-insensitive
|
||||
{"UNKNOWN", nil},
|
||||
}
|
||||
for _, tc := range tests {
|
||||
t.Run(tc.method, func(t *testing.T) {
|
||||
if got := getOperation(pathItem, tc.method); got != tc.want {
|
||||
t.Errorf("getOperation(pathItem, %q) = %v, want %v", tc.method, got, tc.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user