Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
131 lines
4.1 KiB
Go
131 lines
4.1 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
)
|
|
|
|
// dmPostsFromSystemBot returns the posts in the DM channel between the system
|
|
// bot and userID, or nil if no such channel exists yet. NotifyExpiredAccessTokensDeleted
|
|
// posts synchronously, so no polling is required.
|
|
func dmPostsFromSystemBot(t *testing.T, th *TestHelper, botUserID, userID string) []*model.Post {
|
|
t.Helper()
|
|
|
|
channel, err := th.App.Srv().Store().Channel().GetByName("", model.GetDMNameFromIds(botUserID, userID), false)
|
|
if err != nil {
|
|
// No DM channel means no notification was ever sent.
|
|
return nil
|
|
}
|
|
|
|
postList, err := th.App.Srv().Store().Post().GetPosts(th.Context, model.GetPostsOptions{ChannelId: channel.Id, Page: 0, PerPage: 10}, false, map[string]bool{})
|
|
require.NoError(t, err)
|
|
|
|
posts := make([]*model.Post, 0, len(postList.Order))
|
|
for _, id := range postList.Order {
|
|
posts = append(posts, postList.Posts[id])
|
|
}
|
|
return posts
|
|
}
|
|
|
|
// notificationPostsFor returns the DM posts authored by the system bot that
|
|
// mention the given token description.
|
|
func notificationPostsFor(t *testing.T, th *TestHelper, botUserID, userID, description string) []*model.Post {
|
|
t.Helper()
|
|
|
|
var matching []*model.Post
|
|
for _, post := range dmPostsFromSystemBot(t, th, botUserID, userID) {
|
|
if post.UserId == botUserID && strings.Contains(post.Message, description) {
|
|
matching = append(matching, post)
|
|
}
|
|
}
|
|
return matching
|
|
}
|
|
|
|
func TestNotifyExpiredAccessTokensDeleted(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
|
|
t.Run("empty token list is a no-op", func(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
require.NotPanics(t, func() {
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, nil)
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, []*model.UserAccessToken{})
|
|
})
|
|
})
|
|
|
|
t.Run("happy path DMs the token owner", func(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
bot, appErr := th.App.GetSystemBot(th.Context)
|
|
require.Nil(t, appErr)
|
|
|
|
user := th.CreateUser(t)
|
|
const description = "ci-integration-token"
|
|
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, []*model.UserAccessToken{
|
|
{Id: model.NewId(), UserId: user.Id, Description: description},
|
|
})
|
|
|
|
posts := notificationPostsFor(t, th, bot.UserId, user.Id, description)
|
|
require.Len(t, posts, 1, "the owner should receive exactly one expiry notification")
|
|
require.Equal(t, bot.UserId, posts[0].UserId)
|
|
})
|
|
|
|
t.Run("bot-owned token is skipped", func(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
systemBot, appErr := th.App.GetSystemBot(th.Context)
|
|
require.Nil(t, appErr)
|
|
|
|
bot := th.CreateBot(t)
|
|
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, []*model.UserAccessToken{
|
|
{Id: model.NewId(), UserId: bot.UserId, Description: "bot-token"},
|
|
})
|
|
|
|
require.Empty(t, dmPostsFromSystemBot(t, th, systemBot.UserId, bot.UserId))
|
|
})
|
|
|
|
t.Run("deactivated user token is skipped", func(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
bot, appErr := th.App.GetSystemBot(th.Context)
|
|
require.Nil(t, appErr)
|
|
|
|
user := th.CreateUser(t)
|
|
_, appErr = th.App.UpdateActive(th.Context, user, false)
|
|
require.Nil(t, appErr)
|
|
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, []*model.UserAccessToken{
|
|
{Id: model.NewId(), UserId: user.Id, Description: "deactivated-token"},
|
|
})
|
|
|
|
require.Empty(t, dmPostsFromSystemBot(t, th, bot.UserId, user.Id))
|
|
})
|
|
|
|
t.Run("unknown owner is skipped but processing continues", func(t *testing.T) {
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
bot, appErr := th.App.GetSystemBot(th.Context)
|
|
require.Nil(t, appErr)
|
|
|
|
user := th.CreateUser(t)
|
|
|
|
// First token references a user that does not exist (GetUser fails);
|
|
// the second is a valid active user that must still be notified.
|
|
th.App.NotifyExpiredAccessTokensDeleted(th.Context, []*model.UserAccessToken{
|
|
{Id: model.NewId(), UserId: model.NewId(), Description: "orphan-token"},
|
|
{Id: model.NewId(), UserId: user.Id, Description: "valid-token"},
|
|
})
|
|
|
|
require.Len(t, notificationPostsFor(t, th, bot.UserId, user.Id, "valid-token"), 1)
|
|
})
|
|
}
|