240db4e2a7
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
275 lines
8.6 KiB
Go
275 lines
8.6 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package app
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestProcessPostFileChanges(t *testing.T) {
|
|
mainHelper.Parallel(t)
|
|
th := Setup(t).InitBasic(t)
|
|
|
|
t.Run("no files", func(t *testing.T) {
|
|
oldPost := &model.Post{FileIds: []string{}}
|
|
newPost := &model.Post{FileIds: []string{}}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 0, len(fileIds))
|
|
})
|
|
|
|
t.Run("have files but nothing changed", func(t *testing.T) {
|
|
oldPost := &model.Post{FileIds: []string{"file_id_1", "file_id_2"}}
|
|
newPost := &model.Post{FileIds: []string{"file_id_1", "file_id_2"}}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(fileIds))
|
|
})
|
|
|
|
t.Run("one file deleted", func(t *testing.T) {
|
|
postId := model.NewId()
|
|
fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id},
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id},
|
|
}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 1, len(fileIds))
|
|
require.Equal(t, fileInfo1.Id, fileIds[0])
|
|
|
|
// verify file2 was soft deleted
|
|
updatedFileInfos, err := th.App.Srv().Store().FileInfo().GetForPost(postId, true, true, false)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 2, len(updatedFileInfos))
|
|
|
|
for _, fileInfo := range updatedFileInfos {
|
|
if fileInfo.Id == fileInfo1.Id {
|
|
require.Equal(t, int64(0), fileInfo.DeleteAt)
|
|
} else if fileInfo.Id == fileInfo2.Id {
|
|
require.Greater(t, fileInfo.DeleteAt, int64(0))
|
|
} else {
|
|
require.Fail(t, "unexpected file info")
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("one file added", func(t *testing.T) {
|
|
postId := model.NewId()
|
|
fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
|
|
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id},
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id},
|
|
}
|
|
|
|
th.Context.Session().UserId = th.BasicUser.Id
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(fileIds))
|
|
require.Contains(t, fileIds, fileInfo1.Id)
|
|
require.Contains(t, fileIds, fileInfo2.Id)
|
|
|
|
// verify file2 is attached to the post
|
|
updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, postId, updatedFileInfo2.PostId)
|
|
})
|
|
|
|
t.Run("all files removed", func(t *testing.T) {
|
|
postId := model.NewId()
|
|
fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id},
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{},
|
|
}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 0, len(fileIds))
|
|
|
|
// verify file2 was soft deleted
|
|
updatedFileInfos, err := th.App.Srv().Store().FileInfo().GetForPost(postId, true, true, false)
|
|
require.NoError(t, err)
|
|
require.Equal(t, 2, len(updatedFileInfos))
|
|
|
|
for _, fileInfo := range updatedFileInfos {
|
|
if fileInfo.Id == fileInfo1.Id || fileInfo.Id == fileInfo2.Id {
|
|
require.Greater(t, fileInfo.DeleteAt, int64(0))
|
|
} else {
|
|
require.Fail(t, "unexpected file info")
|
|
}
|
|
}
|
|
})
|
|
|
|
t.Run("files added when no files existed", func(t *testing.T) {
|
|
fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, "", th.BasicChannel.Id)
|
|
|
|
postId := model.NewId()
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{},
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id},
|
|
}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(fileIds))
|
|
require.Contains(t, fileIds, fileInfo1.Id)
|
|
require.Contains(t, fileIds, fileInfo2.Id)
|
|
|
|
updatedFileInfo1, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, postId, updatedFileInfo1.PostId)
|
|
|
|
updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, postId, updatedFileInfo2.PostId)
|
|
})
|
|
|
|
t.Run("other post's attached file added", func(t *testing.T) {
|
|
postId := model.NewId()
|
|
fileInfo1 := th.CreateFileInfo(t, th.BasicUser.Id, postId, th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.BasicUser.Id, model.NewId(), th.BasicChannel.Id)
|
|
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id},
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id},
|
|
}
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 1, len(fileIds))
|
|
require.Equal(t, fileInfo1.Id, fileIds[0])
|
|
|
|
// verify file2 is attached to the post
|
|
updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
|
|
require.NoError(t, err)
|
|
require.NotEqual(t, postId, updatedFileInfo2.PostId)
|
|
})
|
|
|
|
t.Run("when admin adds a file to other user's post", func(t *testing.T) {
|
|
postId := model.NewId()
|
|
|
|
// admin uploads the files
|
|
fileInfo1 := th.CreateFileInfo(t, th.SystemAdminUser.Id, "", th.BasicChannel.Id)
|
|
fileInfo2 := th.CreateFileInfo(t, th.SystemAdminUser.Id, "", th.BasicChannel.Id)
|
|
|
|
// basic user's post
|
|
oldPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
}
|
|
|
|
newPost := &model.Post{
|
|
Id: postId,
|
|
UserId: th.BasicUser.Id,
|
|
ChannelId: th.BasicChannel.Id,
|
|
Message: "Message",
|
|
CreateAt: model.GetMillis() - 10000,
|
|
FileIds: []string{fileInfo1.Id, fileInfo2.Id}, // admin attaching two files
|
|
}
|
|
|
|
// admin's session
|
|
th.Context.Session().UserId = th.SystemAdminUser.Id
|
|
|
|
fileIds, appErr := th.App.processPostFileChanges(th.Context, newPost, oldPost, nil)
|
|
require.Nil(t, appErr)
|
|
require.Equal(t, 2, len(fileIds))
|
|
require.Contains(t, fileIds, fileInfo1.Id)
|
|
require.Contains(t, fileIds, fileInfo2.Id)
|
|
|
|
// verify files are attached to the post and still belong tyo the admin
|
|
updatedFileInfo1, err := th.App.Srv().Store().FileInfo().Get(fileInfo1.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, postId, updatedFileInfo1.PostId)
|
|
require.Equal(t, th.SystemAdminUser.Id, updatedFileInfo1.CreatorId)
|
|
|
|
updatedFileInfo2, err := th.App.Srv().Store().FileInfo().Get(fileInfo2.Id)
|
|
require.NoError(t, err)
|
|
require.Equal(t, postId, updatedFileInfo2.PostId)
|
|
require.Equal(t, th.SystemAdminUser.Id, updatedFileInfo2.CreatorId)
|
|
})
|
|
}
|