240db4e2a7
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
257 lines
11 KiB
Go
257 lines
11 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package localcachelayer
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest/mocks"
|
|
)
|
|
|
|
func TestPostStore(t *testing.T) {
|
|
StoreTestWithSqlStore(t, storetest.TestPostStore)
|
|
}
|
|
|
|
func TestPostStoreLastPostTimeCache(t *testing.T) {
|
|
rctx := request.TestContext(t)
|
|
|
|
var fakeLastTime int64 = 1
|
|
channelId := "channelId"
|
|
fakeOptions := model.GetPostsSinceOptions{
|
|
ChannelId: channelId,
|
|
Time: fakeLastTime,
|
|
SkipFetchThreads: false,
|
|
}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
t.Run("GetEtag: first call not cached, second cached and returning same data", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
expectedResult := fmt.Sprintf("%v.%v", model.CurrentVersion, fakeLastTime)
|
|
|
|
etag := cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
assert.Equal(t, etag, expectedResult)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
|
|
etag = cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
assert.Equal(t, etag, expectedResult)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
})
|
|
|
|
t.Run("GetEtag: first call not cached, second force no cached", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
cachedStore.Post().GetEtag(channelId, false, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 2)
|
|
})
|
|
|
|
t.Run("GetEtag: first call not cached, invalidate, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
cachedStore.Post().InvalidateLastPostTimeCache(channelId)
|
|
cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 2)
|
|
})
|
|
|
|
t.Run("GetEtag: first call not cached, clear caches, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
cachedStore.Post().ClearCaches()
|
|
cachedStore.Post().GetEtag(channelId, true, false, false)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 2)
|
|
})
|
|
|
|
t.Run("GetPostsSince: first call not cached, second cached and returning same data", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
expectedResult := model.NewPostList()
|
|
|
|
list, err := cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, list, expectedResult)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 1)
|
|
|
|
list, err = cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, list, expectedResult)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 1)
|
|
})
|
|
|
|
t.Run("GetPostsSince: first call not cached, second force no cached", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 1)
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, false, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 2)
|
|
})
|
|
|
|
t.Run("GetPostsSince: first call not cached, invalidate, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 1)
|
|
cachedStore.Post().InvalidateLastPostTimeCache(channelId)
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 2)
|
|
})
|
|
|
|
t.Run("GetPostsSince: first call not cached, clear caches, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 1)
|
|
cachedStore.Post().ClearCaches()
|
|
cachedStore.Post().GetPostsSince(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPostsSince", 2)
|
|
})
|
|
|
|
t.Run("GetEtag: with includeTranslations appends translation time", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
// Expected: "{version}.{lastTime}.{translationTime}"
|
|
expectedResult := fmt.Sprintf("%v.%v_%v", model.CurrentVersion, fakeLastTime, 5000)
|
|
|
|
etag := cachedStore.Post().GetEtag(channelId, true, false, true)
|
|
assert.Equal(t, expectedResult, etag)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetEtag", 1)
|
|
mockStore.AutoTranslation().(*mocks.AutoTranslationStore).AssertNumberOfCalls(t, "GetLatestPostUpdateAtForChannel", 1)
|
|
})
|
|
|
|
t.Run("GetEtag: translation etag is cached per-channel", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
// First call with includeTranslations=true - should call GetLatestPostUpdateAtForChannel
|
|
expected := fmt.Sprintf("%v.%v_%v", model.CurrentVersion, fakeLastTime, 5000)
|
|
etag := cachedStore.Post().GetEtag(channelId, true, false, true)
|
|
assert.Equal(t, expected, etag)
|
|
mockStore.AutoTranslation().(*mocks.AutoTranslationStore).AssertNumberOfCalls(t, "GetLatestPostUpdateAtForChannel", 1)
|
|
|
|
// Second call - should use cached translation time
|
|
etag = cachedStore.Post().GetEtag(channelId, true, false, true)
|
|
assert.Equal(t, expected, etag)
|
|
mockStore.AutoTranslation().(*mocks.AutoTranslationStore).AssertNumberOfCalls(t, "GetLatestPostUpdateAtForChannel", 1)
|
|
})
|
|
|
|
t.Run("GetEtag: invalidate translation etag clears the channel cache", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
// Call GetEtag with includeTranslations=true
|
|
expected := fmt.Sprintf("%v.%v_%v", model.CurrentVersion, fakeLastTime, 5000)
|
|
etag := cachedStore.Post().GetEtag(channelId, true, false, true)
|
|
assert.Equal(t, expected, etag)
|
|
mockStore.AutoTranslation().(*mocks.AutoTranslationStore).AssertNumberOfCalls(t, "GetLatestPostUpdateAtForChannel", 1)
|
|
|
|
// Invalidate the channel's post translation etag
|
|
cachedStore.AutoTranslation().InvalidatePostTranslationEtag(channelId)
|
|
|
|
// Call GetEtag again - should re-fetch
|
|
etag = cachedStore.Post().GetEtag(channelId, true, false, true)
|
|
assert.Equal(t, expected, etag)
|
|
mockStore.AutoTranslation().(*mocks.AutoTranslationStore).AssertNumberOfCalls(t, "GetLatestPostUpdateAtForChannel", 2)
|
|
})
|
|
}
|
|
|
|
func TestPostStoreCache(t *testing.T) {
|
|
rctx := request.TestContext(t)
|
|
|
|
fakePosts := &model.PostList{}
|
|
fakeOptions := model.GetPostsOptions{ChannelId: "123", PerPage: 30}
|
|
logger := mlog.CreateConsoleTestLogger(t)
|
|
|
|
t.Run("first call not cached, second cached and returning same data", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
gotPosts, err := cachedStore.Post().GetPosts(rctx, fakeOptions, true, map[string]bool{})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, fakePosts, gotPosts)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 1)
|
|
|
|
_, _ = cachedStore.Post().GetPosts(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 1)
|
|
})
|
|
|
|
t.Run("first call not cached, second force not cached", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
gotPosts, err := cachedStore.Post().GetPosts(rctx, fakeOptions, true, map[string]bool{})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, fakePosts, gotPosts)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 1)
|
|
|
|
_, _ = cachedStore.Post().GetPosts(rctx, fakeOptions, false, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 2)
|
|
})
|
|
|
|
t.Run("first call not cached, invalidate, and then not cached again", func(t *testing.T) {
|
|
mockStore := getMockStore(t)
|
|
mockCacheProvider := getMockCacheProvider()
|
|
cachedStore, err := NewLocalCacheLayer(mockStore, nil, nil, mockCacheProvider, logger)
|
|
require.NoError(t, err)
|
|
|
|
gotPosts, err := cachedStore.Post().GetPosts(rctx, fakeOptions, true, map[string]bool{})
|
|
require.NoError(t, err)
|
|
assert.Equal(t, fakePosts, gotPosts)
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 1)
|
|
|
|
cachedStore.Post().InvalidateLastPostTimeCache("12360")
|
|
|
|
_, _ = cachedStore.Post().GetPosts(rctx, fakeOptions, true, map[string]bool{})
|
|
mockStore.Post().(*mocks.PostStore).AssertNumberOfCalls(t, "GetPosts", 1)
|
|
})
|
|
}
|