Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
344 lines
9.8 KiB
Go
344 lines
9.8 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestNeutralizeNonWordHyphens(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
input string
|
|
expected string
|
|
}{
|
|
{"compound word kept", "t-shirt", "t-shirt"},
|
|
{"multiple hyphens kept", "a-b-c", "a-b-c"},
|
|
{"digits kept", "covid-19", "covid-19"},
|
|
{"unicode letters kept", "café-au-lait", "café-au-lait"},
|
|
{"NFD combining mark before hyphen kept", "café-au-lait", "café-au-lait"},
|
|
{"leading hyphen neutralized", "-5", " 5"},
|
|
{"trailing hyphen neutralized", "foo-", "foo "},
|
|
{"standalone hyphen neutralized", "-", " "},
|
|
{"hyphen between spaces neutralized", "a - b", "a b"},
|
|
{"repeated bare hyphens neutralized", "--", " "},
|
|
{"empty string", "", ""},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
require.Equal(t, tc.expected, neutralizeNonWordHyphens(tc.input))
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestChunkSlice(t *testing.T) {
|
|
if enableFullyParallelTests {
|
|
t.Parallel()
|
|
}
|
|
|
|
t.Run("empty slice returns nil", func(t *testing.T) {
|
|
result := chunkSlice([]int{}, 5, defaultMaxInsertParams)
|
|
require.Nil(t, result)
|
|
})
|
|
|
|
t.Run("under limit returns single chunk", func(t *testing.T) {
|
|
items := []int{1, 2, 3}
|
|
result := chunkSlice(items, 15, defaultMaxInsertParams) // 3*15=45 params, well under 50k
|
|
require.Len(t, result, 1)
|
|
require.Equal(t, items, result[0])
|
|
})
|
|
|
|
t.Run("exact boundary returns single chunk", func(t *testing.T) {
|
|
n := defaultMaxInsertParams / 10 // exactly at limit with 10 cols
|
|
items := make([]int, n)
|
|
result := chunkSlice(items, 10, defaultMaxInsertParams)
|
|
require.Len(t, result, 1)
|
|
require.Len(t, result[0], n)
|
|
})
|
|
|
|
t.Run("over limit splits into chunks", func(t *testing.T) {
|
|
n := defaultMaxInsertParams/10 + 1 // one over
|
|
items := make([]int, n)
|
|
result := chunkSlice(items, 10, defaultMaxInsertParams)
|
|
require.Len(t, result, 2)
|
|
require.Len(t, result[0], defaultMaxInsertParams/10)
|
|
require.Len(t, result[1], 1)
|
|
})
|
|
|
|
t.Run("remainder is handled correctly", func(t *testing.T) {
|
|
chunkSize := defaultMaxInsertParams / 15 // 3333
|
|
n := chunkSize*2 + 100 // two full chunks + 100 remainder
|
|
items := make([]int, n)
|
|
result := chunkSlice(items, 15, defaultMaxInsertParams)
|
|
require.Len(t, result, 3)
|
|
require.Len(t, result[0], chunkSize)
|
|
require.Len(t, result[1], chunkSize)
|
|
require.Len(t, result[2], 100)
|
|
})
|
|
|
|
t.Run("columnsPerRow > maxParams panics", func(t *testing.T) {
|
|
require.Panics(t, func() {
|
|
chunkSlice([]int{1}, defaultMaxInsertParams+1, defaultMaxInsertParams)
|
|
})
|
|
})
|
|
|
|
t.Run("columnsPerRow <= 0 panics", func(t *testing.T) {
|
|
require.Panics(t, func() {
|
|
chunkSlice([]int{1}, 0, defaultMaxInsertParams)
|
|
})
|
|
require.Panics(t, func() {
|
|
chunkSlice([]int{1}, -1, defaultMaxInsertParams)
|
|
})
|
|
})
|
|
|
|
t.Run("maxParams <= 0 panics", func(t *testing.T) {
|
|
require.Panics(t, func() {
|
|
chunkSlice([]int{1}, 1, 0)
|
|
})
|
|
})
|
|
}
|
|
|
|
func TestMapStringsToQueryParams(t *testing.T) {
|
|
if enableFullyParallelTests {
|
|
t.Parallel()
|
|
}
|
|
|
|
t.Run("one item", func(t *testing.T) {
|
|
input := []string{"apple"}
|
|
|
|
keys, params := MapStringsToQueryParams(input, "Fruit")
|
|
|
|
require.Len(t, params, 1, "returned incorrect params", params)
|
|
require.Equal(t, "apple", params["Fruit0"], "returned incorrect params", params)
|
|
require.Equal(t, "(:Fruit0)", keys, "returned incorrect query", keys)
|
|
})
|
|
|
|
t.Run("multiple items", func(t *testing.T) {
|
|
input := []string{"carrot", "tomato", "potato"}
|
|
|
|
keys, params := MapStringsToQueryParams(input, "Vegetable")
|
|
|
|
require.Len(t, params, 3, "returned incorrect params", params)
|
|
require.Equal(t, "carrot", params["Vegetable0"], "returned incorrect params", params)
|
|
require.Equal(t, "tomato", params["Vegetable1"], "returned incorrect params", params)
|
|
require.Equal(t, "potato", params["Vegetable2"], "returned incorrect params", params)
|
|
require.Equal(t, "(:Vegetable0,:Vegetable1,:Vegetable2)", keys, "returned incorrect query", keys)
|
|
})
|
|
}
|
|
|
|
var (
|
|
keys string
|
|
params map[string]any
|
|
)
|
|
|
|
func BenchmarkMapStringsToQueryParams(b *testing.B) {
|
|
b.Run("one item", func(b *testing.B) {
|
|
input := []string{"apple"}
|
|
for b.Loop() {
|
|
keys, params = MapStringsToQueryParams(input, "Fruit")
|
|
}
|
|
})
|
|
b.Run("multiple items", func(b *testing.B) {
|
|
input := []string{"carrot", "tomato", "potato"}
|
|
for b.Loop() {
|
|
keys, params = MapStringsToQueryParams(input, "Vegetable")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestSanitizeSearchTerm(t *testing.T) {
|
|
if enableFullyParallelTests {
|
|
t.Parallel()
|
|
}
|
|
|
|
term := "test"
|
|
result := sanitizeSearchTerm(term, "\\")
|
|
require.Equal(t, result, term)
|
|
|
|
term = "%%%"
|
|
expected := "\\%\\%\\%"
|
|
result = sanitizeSearchTerm(term, "\\")
|
|
require.Equal(t, result, expected)
|
|
|
|
term = "%\\%\\%"
|
|
expected = "\\%\\%\\%"
|
|
result = sanitizeSearchTerm(term, "\\")
|
|
require.Equal(t, result, expected)
|
|
|
|
term = "%_test_%"
|
|
expected = "\\%\\_test\\_\\%"
|
|
result = sanitizeSearchTerm(term, "\\")
|
|
require.Equal(t, result, expected)
|
|
|
|
term = "**test_%"
|
|
expected = "test*_*%"
|
|
result = sanitizeSearchTerm(term, "*")
|
|
require.Equal(t, result, expected)
|
|
}
|
|
|
|
func TestRemoveNonAlphaNumericUnquotedTerms(t *testing.T) {
|
|
if enableFullyParallelTests {
|
|
t.Parallel()
|
|
}
|
|
|
|
const (
|
|
sep = " "
|
|
chineseHello = "你好"
|
|
japaneseHello = "こんにちは"
|
|
)
|
|
tests := []struct {
|
|
term string
|
|
want string
|
|
name string
|
|
}{
|
|
{term: "", want: "", name: "empty"},
|
|
{term: "h", want: "h", name: "singleChar"},
|
|
{term: "hello", want: "hello", name: "multiChar"},
|
|
{term: `hel*lo "**" **& hello`, want: `hel*lo "**" hello`, name: "quoted_unquoted_english"},
|
|
{term: japaneseHello + chineseHello, want: japaneseHello + chineseHello, name: "japanese_chinese"},
|
|
{term: japaneseHello + ` "*" ` + chineseHello, want: japaneseHello + ` "*" ` + chineseHello, name: `quoted_japanese_and_chinese`},
|
|
{term: japaneseHello + ` "*" &&* ` + chineseHello, want: japaneseHello + ` "*" ` + chineseHello, name: "quoted_unquoted_japanese_and_chinese"},
|
|
}
|
|
for _, test := range tests {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
got := removeNonAlphaNumericUnquotedTerms(test.term, sep)
|
|
require.Equal(t, test.want, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestScanRowsIntoMap(t *testing.T) {
|
|
StoreTest(t, func(t *testing.T, rctx request.CTX, ss store.Store) {
|
|
sqlStore := ss.(*SqlStore)
|
|
|
|
t.Run("basic mapping", func(t *testing.T) {
|
|
// Create a test table
|
|
_, err := sqlStore.GetMaster().Exec(`
|
|
CREATE TEMPORARY TABLE IF NOT EXISTS MapTest (
|
|
id VARCHAR(50) PRIMARY KEY,
|
|
value INT
|
|
)
|
|
`)
|
|
require.NoError(t, err)
|
|
|
|
// Insert test data
|
|
_, err = sqlStore.GetMaster().Exec(`
|
|
INSERT INTO MapTest VALUES ('key1', 10), ('key2', 20), ('key3', 30)
|
|
`)
|
|
require.NoError(t, err)
|
|
|
|
// Query the data
|
|
rows, err := sqlStore.GetMaster().Query(`SELECT id, value FROM MapTest ORDER BY id`)
|
|
require.NoError(t, err)
|
|
defer rows.Close()
|
|
|
|
// Create scanner function
|
|
scanner := func(rows rowScanner) (string, int, error) {
|
|
var key string
|
|
var value int
|
|
return key, value, rows.Scan(&key, &value)
|
|
}
|
|
|
|
// Call the function under test
|
|
result, err := scanRowsIntoMap(rows, scanner, nil)
|
|
|
|
// Assert results
|
|
require.NoError(t, err)
|
|
require.Len(t, result, 3)
|
|
require.Equal(t, 10, result["key1"])
|
|
require.Equal(t, 20, result["key2"])
|
|
require.Equal(t, 30, result["key3"])
|
|
})
|
|
|
|
t.Run("with default values", func(t *testing.T) {
|
|
// Create a test table
|
|
_, err := sqlStore.GetMaster().Exec(`
|
|
CREATE TEMPORARY TABLE IF NOT EXISTS MapTestDefaults (
|
|
id VARCHAR(50) PRIMARY KEY,
|
|
value INT
|
|
)
|
|
`)
|
|
require.NoError(t, err)
|
|
|
|
// Insert test data - only insert one key to test defaults
|
|
_, err = sqlStore.GetMaster().Exec(`
|
|
INSERT INTO MapTestDefaults VALUES ('key1', 10)
|
|
`)
|
|
require.NoError(t, err)
|
|
|
|
// Query the data
|
|
rows, err := sqlStore.GetMaster().Query(`SELECT id, value FROM MapTestDefaults`)
|
|
require.NoError(t, err)
|
|
defer rows.Close()
|
|
|
|
// Create scanner function
|
|
scanner := func(rows rowScanner) (string, int, error) {
|
|
var key string
|
|
var value int
|
|
return key, value, rows.Scan(&key, &value)
|
|
}
|
|
|
|
// Define defaults
|
|
defaults := map[string]int{
|
|
"key1": 100, // Should be overwritten
|
|
"key2": 200, // Should remain
|
|
"key3": 300, // Should remain
|
|
}
|
|
|
|
// Call the function under test
|
|
result, err := scanRowsIntoMap(rows, scanner, defaults)
|
|
|
|
// Assert results
|
|
require.NoError(t, err)
|
|
require.Len(t, result, 3)
|
|
require.Equal(t, 10, result["key1"]) // Should be from DB, not default
|
|
require.Equal(t, 200, result["key2"]) // Should be from defaults
|
|
require.Equal(t, 300, result["key3"]) // Should be from defaults
|
|
})
|
|
|
|
t.Run("with empty result set", func(t *testing.T) {
|
|
// Create a test table
|
|
_, err := sqlStore.GetMaster().Exec(`
|
|
CREATE TEMPORARY TABLE IF NOT EXISTS MapTestEmpty (
|
|
id VARCHAR(50) PRIMARY KEY,
|
|
value INT
|
|
)
|
|
`)
|
|
require.NoError(t, err)
|
|
|
|
// Query the empty table
|
|
rows, err := sqlStore.GetMaster().Query(`SELECT id, value FROM MapTestEmpty`)
|
|
require.NoError(t, err)
|
|
defer rows.Close()
|
|
|
|
// Create scanner function
|
|
scanner := func(rows rowScanner) (string, int, error) {
|
|
var key string
|
|
var value int
|
|
return key, value, rows.Scan(&key, &value)
|
|
}
|
|
|
|
// Define defaults
|
|
defaults := map[string]int{
|
|
"key1": 100,
|
|
"key2": 200,
|
|
}
|
|
|
|
// Call the function under test
|
|
result, err := scanRowsIntoMap(rows, scanner, defaults)
|
|
|
|
// Assert results
|
|
require.NoError(t, err)
|
|
require.Len(t, result, 2)
|
|
require.Equal(t, 100, result["key1"]) // Should be from defaults
|
|
require.Equal(t, 200, result["key2"]) // Should be from defaults
|
|
})
|
|
})
|
|
}
|