Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
182 lines
5.4 KiB
Go
182 lines
5.4 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package web
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/plugin/plugintest/mock"
|
|
"github.com/mattermost/mattermost/server/v8/channels/store/storetest/mocks"
|
|
)
|
|
|
|
func TestMakeAuditRecord(t *testing.T) {
|
|
t.Run("PAT session includes token ID in meta", func(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
tokenID := model.NewId()
|
|
th.Context = th.Context.WithSession(&model.Session{
|
|
Id: model.NewId(),
|
|
UserId: model.NewId(),
|
|
Props: model.StringMap{
|
|
model.SessionPropType: model.SessionTypeUserAccessToken,
|
|
model.SessionPropUserAccessTokenId: tokenID,
|
|
},
|
|
})
|
|
|
|
c := &Context{App: th.App, AppContext: th.Context}
|
|
rec := c.MakeAuditRecord("test_event", model.AuditStatusAttempt)
|
|
|
|
require.NotNil(t, rec)
|
|
assert.Equal(t, tokenID, rec.Meta[model.SessionPropUserAccessTokenId])
|
|
})
|
|
|
|
t.Run("non-PAT session omits token ID from meta", func(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
th.Context = th.Context.WithSession(&model.Session{
|
|
Id: model.NewId(),
|
|
UserId: model.NewId(),
|
|
})
|
|
|
|
c := &Context{App: th.App, AppContext: th.Context}
|
|
rec := c.MakeAuditRecord("test_event", model.AuditStatusAttempt)
|
|
|
|
require.NotNil(t, rec)
|
|
_, exists := rec.Meta[model.SessionPropUserAccessTokenId]
|
|
assert.False(t, exists, "token ID key should be absent from Meta for non-PAT sessions")
|
|
})
|
|
}
|
|
|
|
func TestLogAuditRec(t *testing.T) {
|
|
t.Run("late-fills token ID for PAT session", func(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
tokenID := model.NewId()
|
|
th.Context = th.Context.WithSession(&model.Session{
|
|
Id: model.NewId(),
|
|
UserId: model.NewId(),
|
|
Props: model.StringMap{
|
|
model.SessionPropType: model.SessionTypeUserAccessToken,
|
|
model.SessionPropUserAccessTokenId: tokenID,
|
|
},
|
|
})
|
|
|
|
c := &Context{App: th.App, AppContext: th.Context}
|
|
|
|
// Simulate a record created before the session was established (e.g., login flow)
|
|
rec := &model.AuditRecord{
|
|
EventName: "test_event",
|
|
Status: model.AuditStatusAttempt,
|
|
Actor: model.AuditEventActor{},
|
|
Meta: map[string]any{},
|
|
EventData: model.AuditEventData{},
|
|
}
|
|
|
|
c.LogAuditRec(rec)
|
|
|
|
assert.Equal(t, tokenID, rec.Meta[model.SessionPropUserAccessTokenId])
|
|
})
|
|
|
|
t.Run("does not add token ID for non-PAT session", func(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
th.Context = th.Context.WithSession(&model.Session{
|
|
Id: model.NewId(),
|
|
UserId: model.NewId(),
|
|
})
|
|
|
|
c := &Context{App: th.App, AppContext: th.Context}
|
|
|
|
rec := &model.AuditRecord{
|
|
EventName: "test_event",
|
|
Status: model.AuditStatusAttempt,
|
|
Actor: model.AuditEventActor{},
|
|
Meta: map[string]any{},
|
|
EventData: model.AuditEventData{},
|
|
}
|
|
|
|
c.LogAuditRec(rec)
|
|
|
|
_, exists := rec.Meta[model.SessionPropUserAccessTokenId]
|
|
assert.False(t, exists, "token ID key should be absent from Meta for non-PAT sessions")
|
|
})
|
|
}
|
|
|
|
func TestRequireHookId(t *testing.T) {
|
|
c := &Context{}
|
|
t.Run("WhenHookIdIsValid", func(t *testing.T) {
|
|
c.Params = &Params{HookId: "abcdefghijklmnopqrstuvwxyz"}
|
|
c.RequireHookId()
|
|
|
|
require.Nil(t, c.Err, "Hook Id is Valid. Should not have set error in context")
|
|
})
|
|
|
|
t.Run("WhenHookIdIsInvalid", func(t *testing.T) {
|
|
c.Params = &Params{HookId: "abc"}
|
|
c.RequireHookId()
|
|
|
|
require.NotNil(t, c.Err, "Should have set Error in context")
|
|
require.Equal(t, http.StatusBadRequest, c.Err.StatusCode, "Should have set status as 400")
|
|
})
|
|
}
|
|
|
|
func TestCloudKeyRequired(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicense("cloud"))
|
|
|
|
c := &Context{
|
|
App: th.App,
|
|
AppContext: th.Context,
|
|
}
|
|
|
|
c.CloudKeyRequired()
|
|
|
|
assert.Equal(t, c.Err.Id, "api.context.session_expired.app_error")
|
|
}
|
|
|
|
func TestMfaRequired(t *testing.T) {
|
|
th := SetupWithStoreMock(t)
|
|
|
|
mockStore := th.App.Srv().Store().(*mocks.Store)
|
|
mockUserStore := mocks.UserStore{}
|
|
mockUserStore.On("Count", mock.Anything).Return(int64(10), nil)
|
|
mockUserStore.On("Get", mock.Anything, "userid").Return(nil, model.NewAppError("Userstore.Get", "storeerror", nil, "store error", http.StatusInternalServerError))
|
|
mockPostStore := mocks.PostStore{}
|
|
mockPostStore.On("GetMaxPostSize").Return(model.PostMessageMaxBytesV2, nil)
|
|
mockSystemStore := mocks.SystemStore{}
|
|
mockSystemStore.On("GetByName", "UpgradedFromTE").Return(&model.System{Name: "UpgradedFromTE", Value: "false"}, nil)
|
|
mockSystemStore.On("GetByName", "InstallationDate").Return(&model.System{Name: "InstallationDate", Value: "10"}, nil)
|
|
|
|
mockStore.On("User").Return(&mockUserStore)
|
|
mockStore.On("Post").Return(&mockPostStore)
|
|
mockStore.On("System").Return(&mockSystemStore)
|
|
mockStore.On("GetDBSchemaVersion").Return(1, nil)
|
|
|
|
th.App.Srv().SetLicense(model.NewTestLicense("mfa"))
|
|
|
|
th.Context = th.Context.WithSession(&model.Session{Id: "abc", UserId: "userid"})
|
|
|
|
th.App.UpdateConfig(func(cfg *model.Config) {
|
|
*cfg.AnnouncementSettings.UserNoticesEnabled = false
|
|
*cfg.AnnouncementSettings.AdminNoticesEnabled = false
|
|
*cfg.ServiceSettings.EnableMultifactorAuthentication = true
|
|
*cfg.ServiceSettings.EnforceMultifactorAuthentication = true
|
|
})
|
|
|
|
c := &Context{
|
|
App: th.App,
|
|
AppContext: th.Context,
|
|
}
|
|
|
|
c.MfaRequired(http.MethodGet)
|
|
|
|
assert.Equal(t, c.Err.Id, "api.context.get_user.app_error")
|
|
}
|