Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
237 lines
6.7 KiB
Go
237 lines
6.7 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package model
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestAIRecapSettingsSetDefaults(t *testing.T) {
|
|
t.Run("sets all defaults on empty struct", func(t *testing.T) {
|
|
s := &AIRecapSettings{}
|
|
s.SetDefaults()
|
|
|
|
// Master toggle
|
|
require.NotNil(t, s.Enable)
|
|
assert.True(t, *s.Enable)
|
|
|
|
// Enforcement toggles - all should be true
|
|
require.NotNil(t, s.EnforceRecapsPerDay)
|
|
assert.True(t, *s.EnforceRecapsPerDay)
|
|
require.NotNil(t, s.EnforceScheduledRecaps)
|
|
assert.True(t, *s.EnforceScheduledRecaps)
|
|
require.NotNil(t, s.EnforceChannelsPerRecap)
|
|
assert.True(t, *s.EnforceChannelsPerRecap)
|
|
require.NotNil(t, s.EnforcePostsPerRecap)
|
|
assert.True(t, *s.EnforcePostsPerRecap)
|
|
require.NotNil(t, s.EnforceTokensPerRecap)
|
|
assert.True(t, *s.EnforceTokensPerRecap)
|
|
require.NotNil(t, s.EnforcePostsPerDay)
|
|
assert.True(t, *s.EnforcePostsPerDay)
|
|
require.NotNil(t, s.EnforceCooldown)
|
|
assert.True(t, *s.EnforceCooldown)
|
|
|
|
// Default limits
|
|
require.NotNil(t, s.DefaultLimits)
|
|
require.NotNil(t, s.DefaultLimits.MaxRecapsPerDay)
|
|
assert.Equal(t, 10, *s.DefaultLimits.MaxRecapsPerDay)
|
|
require.NotNil(t, s.DefaultLimits.MaxScheduledRecaps)
|
|
assert.Equal(t, 5, *s.DefaultLimits.MaxScheduledRecaps)
|
|
require.NotNil(t, s.DefaultLimits.MaxChannelsPerRecap)
|
|
assert.Equal(t, -1, *s.DefaultLimits.MaxChannelsPerRecap) // unlimited
|
|
require.NotNil(t, s.DefaultLimits.MaxPostsPerRecap)
|
|
assert.Equal(t, 500, *s.DefaultLimits.MaxPostsPerRecap)
|
|
require.NotNil(t, s.DefaultLimits.MaxTokensPerRecap)
|
|
assert.Equal(t, 100000, *s.DefaultLimits.MaxTokensPerRecap)
|
|
require.NotNil(t, s.DefaultLimits.MaxPostsPerDay)
|
|
assert.Equal(t, 5000, *s.DefaultLimits.MaxPostsPerDay)
|
|
require.NotNil(t, s.DefaultLimits.CooldownMinutes)
|
|
assert.Equal(t, 60, *s.DefaultLimits.CooldownMinutes)
|
|
})
|
|
}
|
|
|
|
func TestRecapLimitSettingsValidation(t *testing.T) {
|
|
t.Run("valid positive limits", func(t *testing.T) {
|
|
s := &RecapLimitSettings{
|
|
MaxRecapsPerDay: NewPointer(10),
|
|
MaxScheduledRecaps: NewPointer(5),
|
|
MaxChannelsPerRecap: NewPointer(3),
|
|
MaxPostsPerRecap: NewPointer(500),
|
|
MaxTokensPerRecap: NewPointer(100000),
|
|
MaxPostsPerDay: NewPointer(5000),
|
|
CooldownMinutes: NewPointer(60),
|
|
}
|
|
|
|
assert.Nil(t, s.isValid())
|
|
})
|
|
|
|
t.Run("valid unlimited (-1) values", func(t *testing.T) {
|
|
s := &RecapLimitSettings{
|
|
MaxRecapsPerDay: NewPointer(-1),
|
|
MaxScheduledRecaps: NewPointer(-1),
|
|
MaxChannelsPerRecap: NewPointer(-1),
|
|
MaxPostsPerRecap: NewPointer(-1),
|
|
MaxTokensPerRecap: NewPointer(-1),
|
|
MaxPostsPerDay: NewPointer(-1),
|
|
CooldownMinutes: NewPointer(0), // 0 = no cooldown
|
|
}
|
|
|
|
assert.Nil(t, s.isValid())
|
|
})
|
|
|
|
t.Run("valid cooldown of 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.CooldownMinutes = NewPointer(0)
|
|
|
|
assert.Nil(t, s.isValid())
|
|
})
|
|
|
|
t.Run("invalid MaxRecapsPerDay = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxRecapsPerDay = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_recaps_per_day.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxRecapsPerDay = -2 (only -1 allowed for unlimited)", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxRecapsPerDay = NewPointer(-2)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_recaps_per_day.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxScheduledRecaps = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxScheduledRecaps = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_scheduled_recaps.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxChannelsPerRecap = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxChannelsPerRecap = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_channels_per_recap.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxPostsPerRecap = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxPostsPerRecap = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_posts_per_recap.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxTokensPerRecap = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxTokensPerRecap = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_tokens_per_recap.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid MaxPostsPerDay = 0", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.MaxPostsPerDay = NewPointer(0)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_posts_per_day.app_error", err.Id)
|
|
})
|
|
|
|
t.Run("invalid CooldownMinutes negative", func(t *testing.T) {
|
|
s := &RecapLimitSettings{}
|
|
s.SetDefaults()
|
|
s.CooldownMinutes = NewPointer(-1)
|
|
|
|
err := s.isValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.cooldown_minutes.app_error", err.Id)
|
|
})
|
|
}
|
|
|
|
func TestAIRecapSettingsPreservesExistingValues(t *testing.T) {
|
|
t.Run("preserves existing MaxRecapsPerDay", func(t *testing.T) {
|
|
s := &AIRecapSettings{
|
|
DefaultLimits: &RecapLimitSettings{
|
|
MaxRecapsPerDay: NewPointer(20),
|
|
},
|
|
}
|
|
s.SetDefaults()
|
|
|
|
assert.Equal(t, 20, *s.DefaultLimits.MaxRecapsPerDay)
|
|
})
|
|
|
|
t.Run("preserves existing Enable value", func(t *testing.T) {
|
|
s := &AIRecapSettings{
|
|
Enable: NewPointer(false),
|
|
}
|
|
s.SetDefaults()
|
|
|
|
assert.False(t, *s.Enable)
|
|
})
|
|
|
|
t.Run("preserves existing enforcement toggle", func(t *testing.T) {
|
|
s := &AIRecapSettings{
|
|
EnforceRecapsPerDay: NewPointer(false),
|
|
}
|
|
s.SetDefaults()
|
|
|
|
assert.False(t, *s.EnforceRecapsPerDay)
|
|
// Other toggles should be set to true (default)
|
|
assert.True(t, *s.EnforceScheduledRecaps)
|
|
})
|
|
}
|
|
|
|
func TestAIRecapSettingsIsValid(t *testing.T) {
|
|
t.Run("valid with defaults", func(t *testing.T) {
|
|
s := &AIRecapSettings{}
|
|
s.SetDefaults()
|
|
|
|
assert.Nil(t, s.IsValid())
|
|
})
|
|
|
|
t.Run("valid with nil DefaultLimits", func(t *testing.T) {
|
|
s := &AIRecapSettings{
|
|
Enable: NewPointer(true),
|
|
}
|
|
|
|
assert.Nil(t, s.IsValid())
|
|
})
|
|
|
|
t.Run("invalid if DefaultLimits are invalid", func(t *testing.T) {
|
|
s := &AIRecapSettings{
|
|
Enable: NewPointer(true),
|
|
DefaultLimits: &RecapLimitSettings{
|
|
MaxRecapsPerDay: NewPointer(0), // invalid
|
|
},
|
|
}
|
|
|
|
err := s.IsValid()
|
|
require.NotNil(t, err)
|
|
assert.Equal(t, "model.config.is_valid.ai_recap.max_recaps_per_day.app_error", err.Id)
|
|
})
|
|
}
|