Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
82 lines
2.5 KiB
Go
82 lines
2.5 KiB
Go
package configtelemetry
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/go/analysis/analysistest"
|
|
)
|
|
|
|
// stubT is a minimal testing.T implementation that doesn't fail
|
|
// Used to capture analysistest results without test failures
|
|
type stubT struct {
|
|
testing.TB
|
|
}
|
|
|
|
func (s *stubT) Errorf(format string, args ...any) {
|
|
// Ignore errors from analysistest about unexpected diagnostics
|
|
// We validate diagnostics manually below
|
|
}
|
|
|
|
func Test(t *testing.T) {
|
|
telemetryPkgPath = "telemetry"
|
|
modelPkgPath = "model"
|
|
testdata := analysistest.TestData()
|
|
|
|
// Run analyzer using a stub to prevent analysistest from failing on cross-package diagnostics
|
|
// (diagnostics are reported on model package from telemetry package analysis)
|
|
stub := &stubT{TB: t}
|
|
results := analysistest.Run(stub, testdata, Analyzer, "telemetry")
|
|
|
|
// Manually verify expected diagnostics
|
|
if len(results) != 1 {
|
|
t.Fatalf("expected 1 result, got %d", len(results))
|
|
}
|
|
|
|
result := results[0]
|
|
if len(result.Diagnostics) == 0 {
|
|
t.Fatal("expected diagnostics but got none")
|
|
}
|
|
|
|
// Expected diagnostics: fields in model/config.go that are NOT used in telemetry
|
|
expectedDiagnostics := map[string]bool{
|
|
"ServiceSettings.WebsocketURL is not used in telemetry": false,
|
|
"ServiceSettings.LicenseFileLocation is not used in telemetry": false,
|
|
"MessageExportSettings.GlobalRelaySettings.SMTPServerTimeout is not used in telemetry": false,
|
|
"CloudSettings.CWSUrl is not used in telemetry": false,
|
|
}
|
|
|
|
// Check that we got all expected diagnostics
|
|
for _, diag := range result.Diagnostics {
|
|
msg := diag.Message
|
|
if _, ok := expectedDiagnostics[msg]; ok {
|
|
expectedDiagnostics[msg] = true
|
|
// Verify diagnostic is in model/config.go
|
|
pos := result.Pass.Fset.Position(diag.Pos)
|
|
if !strings.Contains(pos.Filename, "model/config.go") {
|
|
t.Errorf("diagnostic %q should be in model/config.go, got %s", msg, pos.Filename)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Verify all expected diagnostics were found
|
|
for msg, found := range expectedDiagnostics {
|
|
if !found {
|
|
t.Errorf("expected diagnostic not found: %s", msg)
|
|
}
|
|
}
|
|
|
|
// Verify we don't have unexpected diagnostics
|
|
if len(result.Diagnostics) != len(expectedDiagnostics) {
|
|
var unexpectedMsgs []string
|
|
for _, diag := range result.Diagnostics {
|
|
if _, ok := expectedDiagnostics[diag.Message]; !ok {
|
|
unexpectedMsgs = append(unexpectedMsgs, diag.Message)
|
|
}
|
|
}
|
|
if len(unexpectedMsgs) > 0 {
|
|
t.Errorf("got %d unexpected diagnostics: %v", len(unexpectedMsgs), unexpectedMsgs)
|
|
}
|
|
}
|
|
}
|