Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
89 lines
2.5 KiB
Go
89 lines
2.5 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package mlogFieldNaming
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"golang.org/x/tools/go/analysis/analysistest"
|
|
)
|
|
|
|
func TestAll(t *testing.T) {
|
|
analysistest.RunWithSuggestedFixes(t, analysistest.TestData(), Analyzer, "a")
|
|
}
|
|
|
|
// TestFixtureCoversEveryConstructor keeps the fixture in step with
|
|
// keyedFieldConstructors, so that dropping a constructor cannot silently go
|
|
// unnoticed just because nothing exercises it.
|
|
func TestFixtureCoversEveryConstructor(t *testing.T) {
|
|
src, err := os.ReadFile(filepath.Join("testdata", "src", "a", "a.go"))
|
|
if err != nil {
|
|
t.Fatalf("reading fixture: %v", err)
|
|
}
|
|
|
|
lines := strings.Split(string(src), "\n")
|
|
for name := range keyedFieldConstructors {
|
|
covered := false
|
|
for _, line := range lines {
|
|
if strings.Contains(line, "mlog."+name+`("`) && strings.Contains(line, "// want") {
|
|
covered = true
|
|
break
|
|
}
|
|
}
|
|
|
|
if !covered {
|
|
t.Errorf("no diagnostic case for mlog.%s in testdata/src/a/a.go; add one so removing %q from keyedFieldConstructors fails a test", name, name)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestToSnakeCase(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
key string
|
|
want string
|
|
wantOK bool
|
|
}{
|
|
{"user_id", "user_id", true},
|
|
{"userId", "user_id", true},
|
|
{"UserId", "user_id", true},
|
|
{"userID", "user_id", true},
|
|
{"ClusterDiscoveryID", "cluster_discovery_id", true},
|
|
{"requestURL", "request_url", true},
|
|
{"requestURLPath", "request_url_path", true},
|
|
{"userIDs", "user_ids", true},
|
|
{"channelIDs", "channel_ids", true},
|
|
{"IDs", "ids", true},
|
|
{"userIDsFoo", "user_ids_foo", true},
|
|
{"userIDs.foo", "user_ids_foo", true},
|
|
{"Diff", "diff", true},
|
|
{"RecvAt", "recv_at", true},
|
|
{"sharedChannelRemoteId", "shared_channel_remote_id", true},
|
|
{"channel name", "channel_name", true},
|
|
{"Possibilities searched", "possibilities_searched", true},
|
|
{"features.users", "features_users", true},
|
|
{"sm.Post.ChannelId", "sm_post_channel_id", true},
|
|
{"user-id", "user_id", true},
|
|
{"_user_id", "user_id", true},
|
|
{"user__id", "user_id", true},
|
|
{"sha256", "sha256", true},
|
|
{"channelId2", "channel_id2", true},
|
|
{"2fa", "", false},
|
|
{"", "", false},
|
|
{"___", "", false},
|
|
} {
|
|
t.Run(tc.key, func(t *testing.T) {
|
|
got, ok := toSnakeCase(tc.key)
|
|
if ok != tc.wantOK {
|
|
t.Fatalf("toSnakeCase(%q) ok = %v, want %v", tc.key, ok, tc.wantOK)
|
|
}
|
|
if ok && got != tc.want {
|
|
t.Fatalf("toSnakeCase(%q) = %q, want %q", tc.key, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|