240db4e2a7
Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Nightly Race / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
41 lines
3.0 KiB
Diff
41 lines
3.0 KiB
Diff
diff --git a/node_modules/dom-accessibility-api/dist/accessible-name-and-description.js b/node_modules/dom-accessibility-api/dist/accessible-name-and-description.js
|
|
index 94a27b7..3337e2a 100644
|
|
--- a/node_modules/dom-accessibility-api/dist/accessible-name-and-description.js
|
|
+++ b/node_modules/dom-accessibility-api/dist/accessible-name-and-description.js
|
|
@@ -442,7 +442,14 @@ function computeTextAlternative(root) {
|
|
var skipToStep2E = context.recursion && isControl(current) && compute === "name";
|
|
if (!skipToStep2E) {
|
|
var ariaLabel = ((0, _util.isElement)(current) && current.getAttribute("aria-label") || "").trim();
|
|
- if (ariaLabel !== "" && compute === "name") {
|
|
+
|
|
+ // @hmhealey I commented out the check below for `compute === "name"` because the current version of this library
|
|
+ // doesn't allow for one element's description to use another element's aria-label when that other element is in
|
|
+ // the first element's aria-describedby. Chrome and Firefox both support that, and based on my reading of
|
|
+ // https://www.w3.org/TR/accname-1.2/#computation-steps, step "2.4 AriaLabel" states that that should it should
|
|
+ // be supported. This is likely also why the current version of this library fails the
|
|
+ // accname/description_from_content_of_describedby_element-manual test from https://github.com/web-platform-tests/wpt.
|
|
+ if (ariaLabel !== ""/* && compute === "name"*/) {
|
|
consultedNodes.add(current);
|
|
return ariaLabel;
|
|
}
|
|
diff --git a/node_modules/dom-accessibility-api/dist/accessible-name-and-description.mjs b/node_modules/dom-accessibility-api/dist/accessible-name-and-description.mjs
|
|
index 05f9ca6..8d37d55 100644
|
|
--- a/node_modules/dom-accessibility-api/dist/accessible-name-and-description.mjs
|
|
+++ b/node_modules/dom-accessibility-api/dist/accessible-name-and-description.mjs
|
|
@@ -437,7 +437,14 @@ export function computeTextAlternative(root) {
|
|
var skipToStep2E = context.recursion && isControl(current) && compute === "name";
|
|
if (!skipToStep2E) {
|
|
var ariaLabel = (isElement(current) && current.getAttribute("aria-label") || "").trim();
|
|
- if (ariaLabel !== "" && compute === "name") {
|
|
+
|
|
+ // @hmhealey I commented out the check below for `compute === "name"` because the current version of this library
|
|
+ // doesn't allow for one element's description to use another element's aria-label when that other element is in
|
|
+ // the first element's aria-describedby. Chrome and Firefox both support that, and based on my reading of
|
|
+ // https://www.w3.org/TR/accname-1.2/#computation-steps, step "2.4 AriaLabel" states that that should it should
|
|
+ // be supported. This is likely also why the current version of this library fails the
|
|
+ // accname/description_from_content_of_describedby_element-manual test from https://github.com/web-platform-tests/wpt.
|
|
+ if (ariaLabel !== ""/* && compute === "name"*/) {
|
|
consultedNodes.add(current);
|
|
return ariaLabel;
|
|
}
|