Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
88 lines
2.9 KiB
Go
88 lines
2.9 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package properties
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/request"
|
|
)
|
|
|
|
var (
|
|
ErrFieldLimitReached = errors.New("per-object-type field limit reached")
|
|
ErrGroupFieldLimitReached = errors.New("group field limit reached")
|
|
)
|
|
|
|
// FieldLimitConfig defines limits for a specific property group.
|
|
type FieldLimitConfig struct {
|
|
// PerObjectType maps ObjectType values to their maximum field count.
|
|
// For example: {"user": 20} means at most 20 fields with ObjectType="user".
|
|
PerObjectType map[string]int64
|
|
|
|
// GlobalLimit is the maximum total number of fields across the entire group,
|
|
// regardless of ObjectType. Zero means no global limit.
|
|
GlobalLimit int64
|
|
}
|
|
|
|
// FieldLimitHook enforces per-group field creation limits. It checks both
|
|
// per-object-type limits and global group limits before allowing a field
|
|
// to be created. The hook only applies to groups that have been configured
|
|
// with limits.
|
|
type FieldLimitHook struct {
|
|
BasePropertyHook
|
|
propertyService *PropertyService
|
|
limits map[string]*FieldLimitConfig // groupID -> config
|
|
}
|
|
|
|
var _ PropertyHook = (*FieldLimitHook)(nil)
|
|
|
|
// NewFieldLimitHook creates a hook that enforces field limits. Call
|
|
// AddGroupLimit to configure limits for specific groups.
|
|
func NewFieldLimitHook(ps *PropertyService) *FieldLimitHook {
|
|
return &FieldLimitHook{
|
|
propertyService: ps,
|
|
limits: make(map[string]*FieldLimitConfig),
|
|
}
|
|
}
|
|
|
|
// AddGroupLimit registers a limit configuration for the given group ID.
|
|
func (h *FieldLimitHook) AddGroupLimit(groupID string, config *FieldLimitConfig) {
|
|
h.limits[groupID] = config
|
|
}
|
|
|
|
func (h *FieldLimitHook) PreCreatePropertyField(_ request.CTX, field *model.PropertyField) (*model.PropertyField, error) {
|
|
config, ok := h.limits[field.GroupID]
|
|
if !ok {
|
|
return field, nil
|
|
}
|
|
|
|
// Check per-object-type limit
|
|
if field.ObjectType != "" {
|
|
if limit, hasLimit := config.PerObjectType[field.ObjectType]; hasLimit {
|
|
count, err := h.propertyService.countActivePropertyFieldsForGroupObjectType(field.GroupID, field.ObjectType)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to count fields: %w", err)
|
|
}
|
|
if count >= limit {
|
|
return nil, fmt.Errorf("limit_reached: field limit of %d reached for object type %q: %w", limit, field.ObjectType, ErrFieldLimitReached)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Check global group limit
|
|
if config.GlobalLimit > 0 {
|
|
count, err := h.propertyService.countActivePropertyFieldsForGroup(field.GroupID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to count group fields: %w", err)
|
|
}
|
|
if count >= config.GlobalLimit {
|
|
return nil, fmt.Errorf("group_limit_reached: global field limit of %d reached for group: %w", config.GlobalLimit, ErrGroupFieldLimitReached)
|
|
}
|
|
}
|
|
|
|
return field, nil
|
|
}
|