Some checks failed
Server CI / Postgres (shard 0) (push) Has been skipped
Server CI / Postgres (shard 3) (push) Has been skipped
BuildEnv Docker Image / build-image (push) Failing after 4s
BuildEnv Docker Image / build-image-fips (push) Failing after 4s
Migration Review & Release Notes / Generate migration review & release notes (push) Failing after 3s
Server CI / Build Environment (push) Failing after 3s
Server CI / Postgres (shard 1) (push) Has been skipped
Tools CI / check-style (mattermost-govet) (push) Failing after 4s
Server CI / Postgres (shard 2) (push) Has been skipped
Tools CI / check-style (mmgotool) (push) Failing after 3s
Server CI / Elasticsearch v8 Compatibility (push) Has been skipped
Server CI / OpenSearch v2 Compatibility (push) Has been skipped
Server CI / Postgres FIPS (shard 0) (push) Has been skipped
Tools CI / Test (mattermost-govet) (push) Failing after 3s
Server CI / Postgres FIPS (shard 1) (push) Has been skipped
Server CI / Postgres FIPS (shard 2) (push) Has been skipped
Tools CI / Test (mmgotool) (push) Failing after 3s
Server CI / Postgres FIPS (shard 3) (push) Has been skipped
Server CI / Run mmctl tests (push) Has been skipped
Server CI / Run mmctl tests (FIPS) (push) Has been skipped
Server CI / Merge Postgres Test Results (push) Has been skipped
Server CI / Merge Postgres FIPS Test Results (push) Has been skipped
Server CI / Check backport migrations (push) Has been skipped
Server CI / Check generated files (push) Has been skipped
Server CI / check-style (push) Has been skipped
Server CI / Vet API (push) Has been skipped
Server CI / Build mattermost server app (push) Has been skipped
Server CI / Server CI Complete (push) Failing after 2s
Server CI / Server CI Artifacts (push) Has been skipped
Server CI / Sentry Upload (push) Has been skipped
Server CI / Server CI Report (push) Failing after 5m1s
Server CI Nightly Race / Race Detector (push) Has been skipped
CodeQL / Analyze (go) (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Webapp CI Cache Warm / Warm Webapp node_modules Cache (push) Has been cancelled
E2E CI Cache Warm / Warm E2E npm Registry Cache (push) Has been cancelled
API / build (push) Has been cancelled
Web App CI / check-types (push) Has been cancelled
Web App CI / check-lint (push) Has been cancelled
Web App CI / check-i18n (push) Has been cancelled
Web App CI / check-external-links (push) Has been cancelled
Web App CI / test (platform) (push) Has been cancelled
Web App CI / test (mattermost-redux) (push) Has been cancelled
Web App CI / test (channels shard 1/4) (push) Has been cancelled
Web App CI / test (channels shard 2/4) (push) Has been cancelled
Web App CI / test (channels shard 3/4) (push) Has been cancelled
Web App CI / test (channels shard 4/4) (push) Has been cancelled
Web App CI / upload-coverage (push) Has been cancelled
Web App CI / build (push) Has been cancelled
YAML Lint / yamllint (push) Has been cancelled
Push mirrored docker images / cd/Push mirrored docker images (push) Has been cancelled
docs-cd / Build and deploy docs (push) Has been cancelled
Docs CI / build (push) Has been cancelled
E2E Cache Warm: Cypress deps / Warm Cypress deps cache (push) Has been cancelled
Scorecards supply-chain security / Scorecard analysis (push) Has been cancelled
Server CI Weekly / Postgres FIPS (push) Has been skipped
Server CI Weekly / Run mmctl tests (FIPS) (push) Has been skipped
Server CI Weekly / Postgres with binary parameters (push) Has been skipped
Server CI Weekly / Build Environment (push) Failing after 1s
Server CI Cache Warm / Warm Go Module and Build Cache (push) Failing after 2s
Server CI Nightly Race / Build Environment (push) Failing after 1s
119 lines
3.2 KiB
Go
119 lines
3.2 KiB
Go
package model
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestFlagContentRequest_IsValid(t *testing.T) {
|
|
validReasons := []string{"spam", "harassment", "inappropriate"}
|
|
|
|
t.Run("valid request without comment", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "spam",
|
|
Comment: "",
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("valid request with comment", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "harassment",
|
|
Comment: "This is inappropriate content",
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("valid request with comment when required", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "inappropriate",
|
|
Comment: "This violates community guidelines",
|
|
}
|
|
err := req.IsValid(true, validReasons)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("missing comment when required", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "spam",
|
|
Comment: "",
|
|
}
|
|
err := req.IsValid(true, validReasons)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.comment_required", err.Id)
|
|
assert.Equal(t, http.StatusBadRequest, err.StatusCode)
|
|
})
|
|
|
|
t.Run("missing reason", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "",
|
|
Comment: "Some comment",
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.reason_required", err.Id)
|
|
assert.Equal(t, http.StatusBadRequest, err.StatusCode)
|
|
})
|
|
|
|
t.Run("invalid reason", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "invalid_reason",
|
|
Comment: "Some comment",
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.reason_invalid", err.Id)
|
|
assert.Equal(t, http.StatusBadRequest, err.StatusCode)
|
|
})
|
|
|
|
t.Run("comment too long", func(t *testing.T) {
|
|
longComment := strings.Repeat("a", commentMaxRunes+1)
|
|
req := &FlagContentRequest{
|
|
Reason: "spam",
|
|
Comment: longComment,
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.comment_too_long", err.Id)
|
|
assert.Equal(t, http.StatusBadRequest, err.StatusCode)
|
|
assert.Equal(t, commentMaxRunes, err.params["MaxLength"])
|
|
})
|
|
|
|
t.Run("comment at max length", func(t *testing.T) {
|
|
maxLengthComment := strings.Repeat("a", commentMaxRunes)
|
|
req := &FlagContentRequest{
|
|
Reason: "harassment",
|
|
Comment: maxLengthComment,
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("unicode comment length validation", func(t *testing.T) {
|
|
// Test with unicode characters that take multiple bytes
|
|
unicodeComment := strings.Repeat("🚀", commentMaxRunes+1)
|
|
req := &FlagContentRequest{
|
|
Reason: "spam",
|
|
Comment: unicodeComment,
|
|
}
|
|
err := req.IsValid(false, validReasons)
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.comment_too_long", err.Id)
|
|
})
|
|
|
|
t.Run("empty valid reasons list", func(t *testing.T) {
|
|
req := &FlagContentRequest{
|
|
Reason: "spam",
|
|
Comment: "Some comment",
|
|
}
|
|
err := req.IsValid(false, []string{})
|
|
assert.NotNil(t, err)
|
|
assert.Equal(t, "api.data_spillage.error.reason_invalid", err.Id)
|
|
})
|
|
}
|