snapshot of https://github.com/ory/kratos.git (master, 2026-09-15; blobs > 131072B omitted)
Some checks failed
CI / Run tests and lints (push) Failing after 29s
CI / Build CLI docs (push) Has been skipped
CI / Run Playwright end-to-end tests (mysql) (push) Failing after 3s
CI / Run Playwright end-to-end tests (postgres) (push) Failing after 2s
CI / Run Playwright end-to-end tests (sqlite) (push) Failing after 3s
CodeQL / Analyze (go) (push) Failing after 4s
CodeQL / Analyze (javascript) (push) Failing after 3s
Docker Image Scanners / scanners (push) Failing after 4s
Synchronize Issue Labels / Synchronize Issue Labels (push) Has been skipped
CI / Run end-to-end tests (postgres) (push) Failing after 19s
CI / Run end-to-end tests (sqlite) (push) Failing after 2s
CI / Run Playwright end-to-end tests (cockroach) (push) Failing after 2s
CI / Draft newsletter (push) Has been skipped
CI / Generate release (push) Has been skipped
CI / Pending approval Slack notification (push) Has been skipped
CI / Send newsletter (push) Has been skipped
Some checks failed
CI / Run tests and lints (push) Failing after 29s
CI / Build CLI docs (push) Has been skipped
CI / Run Playwright end-to-end tests (mysql) (push) Failing after 3s
CI / Run Playwright end-to-end tests (postgres) (push) Failing after 2s
CI / Run Playwright end-to-end tests (sqlite) (push) Failing after 3s
CodeQL / Analyze (go) (push) Failing after 4s
CodeQL / Analyze (javascript) (push) Failing after 3s
Docker Image Scanners / scanners (push) Failing after 4s
Synchronize Issue Labels / Synchronize Issue Labels (push) Has been skipped
CI / Run end-to-end tests (postgres) (push) Failing after 19s
CI / Run end-to-end tests (sqlite) (push) Failing after 2s
CI / Run Playwright end-to-end tests (cockroach) (push) Failing after 2s
CI / Draft newsletter (push) Has been skipped
CI / Generate release (push) Has been skipped
CI / Pending approval Slack notification (push) Has been skipped
CI / Send newsletter (push) Has been skipped
This commit is contained in:
136
cipher/cipher_test.go
Normal file
136
cipher/cipher_test.go
Normal file
@@ -0,0 +1,136 @@
|
||||
// Copyright © 2023 Ory Corp
|
||||
// SPDX-License-Identifier: Apache-2.0
|
||||
|
||||
package cipher_test
|
||||
|
||||
import (
|
||||
"context"
|
||||
"encoding/hex"
|
||||
"fmt"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
|
||||
"github.com/ory/herodot"
|
||||
"github.com/ory/kratos/cipher"
|
||||
"github.com/ory/kratos/driver/config"
|
||||
"github.com/ory/kratos/pkg"
|
||||
"github.com/ory/x/configx"
|
||||
"github.com/ory/x/contextx"
|
||||
)
|
||||
|
||||
var goodSecret = []string{"secret-thirty-two-character-long"}
|
||||
|
||||
func TestCipher(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
_, reg := pkg.NewFastRegistryWithMocks(t, configx.WithValue(config.ViperKeySecretsDefault, goodSecret))
|
||||
|
||||
ciphers := []cipher.Cipher{
|
||||
cipher.NewCryptAES(reg.Config()),
|
||||
cipher.NewCryptChaCha20(reg.Config()),
|
||||
}
|
||||
|
||||
for _, c := range ciphers {
|
||||
t.Run(fmt.Sprintf("cipher=%T", c), func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
t.Run("case=all_work", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
testAllWork(ctx, t, c)
|
||||
})
|
||||
|
||||
t.Run("case=encryption_failed", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
ctx := contextx.WithConfigValue(ctx, config.ViperKeySecretsCipher, []string{""})
|
||||
|
||||
// secret have to be set
|
||||
_, err := c.Encrypt(ctx, []byte("not-empty"))
|
||||
require.Error(t, err)
|
||||
var hErr *herodot.DefaultError
|
||||
require.ErrorAs(t, err, &hErr)
|
||||
assert.Equal(t, "Unable to encrypt message because no cipher secrets were configured.", hErr.Reason())
|
||||
|
||||
ctx = contextx.WithConfigValue(ctx, config.ViperKeySecretsCipher, []string{"bad-length"})
|
||||
|
||||
// bad secret length
|
||||
_, err = c.Encrypt(ctx, []byte("not-empty"))
|
||||
require.ErrorAs(t, err, &hErr)
|
||||
assert.Equal(t, "Unable to encrypt message because no cipher secrets were configured.", hErr.Reason())
|
||||
})
|
||||
|
||||
t.Run("case=decryption_failed", func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
_, err := c.Decrypt(ctx, hex.EncodeToString([]byte("bad-data")))
|
||||
require.Error(t, err)
|
||||
|
||||
_, err = c.Decrypt(ctx, "not-empty")
|
||||
require.Error(t, err)
|
||||
|
||||
_, err = c.Decrypt(contextx.WithConfigValue(ctx, config.ViperKeySecretsCipher, []string{""}), "not-empty")
|
||||
require.Error(t, err)
|
||||
|
||||
// Valid hex that decodes to fewer bytes than the AEAD nonce must be
|
||||
// a clean error, not a panic: a corrupt or truncated stored
|
||||
// ciphertext must never crash the caller. 16 bytes (32 hex chars)
|
||||
// clears the hex-length check but is shorter than XChaCha20's
|
||||
// 24-byte nonce.
|
||||
_, err = c.Decrypt(ctx, hex.EncodeToString([]byte("sixteen-bytes!!!")))
|
||||
require.Error(t, err)
|
||||
})
|
||||
})
|
||||
}
|
||||
|
||||
c := cipher.NewNoop()
|
||||
t.Run(fmt.Sprintf("cipher=%T", c), func(t *testing.T) {
|
||||
t.Parallel()
|
||||
testAllWork(ctx, t, c)
|
||||
})
|
||||
}
|
||||
|
||||
func TestAESBackwardsCompatibility(t *testing.T) {
|
||||
t.Parallel()
|
||||
// Ciphertext produced by the previous implementation
|
||||
// (github.com/gtank/cryptopasta: caller-generated GCM nonce). The new
|
||||
// stdlib NewGCMWithRandomNonce implementation must keep decrypting it.
|
||||
// Key (32 bytes): the literal config secret below.
|
||||
// Plaintext: "fixture: encrypted with caller-supplied nonce".
|
||||
const legacyCiphertext = "74756223e46170ef0579f207af41b7ed435d649ae94f22bd57934398e9861870e58feba1e949d28f18dfdda6395eabf4d2d31fdeb2b07c4c428e9829509470f6d8e23c17708f1368b6"
|
||||
|
||||
ctx := t.Context()
|
||||
_, reg := pkg.NewFastRegistryWithMocks(t, configx.WithValue(config.ViperKeySecretsCipher, []string{"change this password to a secret"}))
|
||||
c := cipher.NewCryptAES(reg.Config())
|
||||
|
||||
plain, err := c.Decrypt(ctx, legacyCiphertext)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "fixture: encrypted with caller-supplied nonce", string(plain))
|
||||
|
||||
// Round-trip with the current implementation.
|
||||
out, err := c.Encrypt(ctx, []byte("fixture: encrypted with caller-supplied nonce"))
|
||||
require.NoError(t, err)
|
||||
plain2, err := c.Decrypt(ctx, out)
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, "fixture: encrypted with caller-supplied nonce", string(plain2))
|
||||
}
|
||||
|
||||
func testAllWork(ctx context.Context, t *testing.T, c cipher.Cipher) {
|
||||
message := "my secret message!"
|
||||
|
||||
encryptedSecret, err := c.Encrypt(ctx, []byte(message))
|
||||
require.NoError(t, err)
|
||||
|
||||
decryptedSecret, err := c.Decrypt(ctx, encryptedSecret)
|
||||
require.NoError(t, err, "encrypted", encryptedSecret)
|
||||
assert.Equal(t, message, string(decryptedSecret))
|
||||
|
||||
// data to encrypt return blank result
|
||||
_, err = c.Encrypt(ctx, []byte(""))
|
||||
require.NoError(t, err)
|
||||
|
||||
// empty encrypted data return blank
|
||||
_, err = c.Decrypt(ctx, "")
|
||||
require.NoError(t, err)
|
||||
}
|
||||
Reference in New Issue
Block a user