snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
124
apps/meteor/server/lib/auth-providers/apple/loginHandler.spec.ts
Normal file
124
apps/meteor/server/lib/auth-providers/apple/loginHandler.spec.ts
Normal file
@@ -0,0 +1,124 @@
|
||||
import { Accounts } from 'meteor/accounts-base';
|
||||
|
||||
import { handleIdentityToken } from './handleIdentityToken';
|
||||
import { settings } from '../../../settings';
|
||||
|
||||
jest.mock(
|
||||
'meteor/accounts-base',
|
||||
() => ({
|
||||
Accounts: {
|
||||
registerLoginHandler: jest.fn(),
|
||||
updateOrCreateUserFromExternalService: jest.fn(),
|
||||
LoginCancelledError: { numericError: 400 },
|
||||
},
|
||||
}),
|
||||
{ virtual: true },
|
||||
);
|
||||
|
||||
jest.mock(
|
||||
'meteor/meteor',
|
||||
() => ({
|
||||
Meteor: {
|
||||
Error: class extends Error {
|
||||
constructor(
|
||||
public error: number,
|
||||
public reason: string,
|
||||
) {
|
||||
super(reason);
|
||||
}
|
||||
},
|
||||
},
|
||||
}),
|
||||
{ virtual: true },
|
||||
);
|
||||
|
||||
jest.mock('../../../settings', () => ({
|
||||
settings: {
|
||||
get: jest.fn(),
|
||||
},
|
||||
}));
|
||||
|
||||
jest.mock('./handleIdentityToken', () => ({
|
||||
handleIdentityToken: jest.fn(),
|
||||
}));
|
||||
|
||||
describe('Apple OAuth loginHandler', () => {
|
||||
let loginHandlerCallback: Parameters<typeof Accounts.registerLoginHandler>[1];
|
||||
|
||||
beforeAll(() => {
|
||||
// eslint-disable-next-line @typescript-eslint/no-require-imports
|
||||
require('./loginHandler');
|
||||
loginHandlerCallback = jest.mocked(Accounts.registerLoginHandler).mock.calls[0][1];
|
||||
});
|
||||
|
||||
beforeEach(() => {
|
||||
jest.clearAllMocks();
|
||||
jest.mocked(settings.get).mockImplementation((key) => {
|
||||
if (key === 'Accounts_OAuth_Apple') return true;
|
||||
if (key === 'Accounts_OAuth_Apple_id') return 'com.yourcompany.app';
|
||||
return null;
|
||||
});
|
||||
});
|
||||
|
||||
it('should not use the client-provided email if Apple does not provide one', async () => {
|
||||
jest.mocked(handleIdentityToken).mockResolvedValue({
|
||||
id: 'apple-sub-123',
|
||||
});
|
||||
|
||||
const maliciousLoginRequest = {
|
||||
identityToken: 'valid.token.without_email',
|
||||
email: 'alice@email.tld',
|
||||
fullName: { givenName: 'Alice', familyName: 'Sender' },
|
||||
};
|
||||
|
||||
jest.mocked(Accounts.updateOrCreateUserFromExternalService).mockResolvedValue({ userId: 'new-user-id' });
|
||||
|
||||
await loginHandlerCallback(maliciousLoginRequest);
|
||||
|
||||
expect(Accounts.updateOrCreateUserFromExternalService).toHaveBeenCalledWith(
|
||||
'apple',
|
||||
{ id: 'apple-sub-123' },
|
||||
{ profile: { name: 'Alice Sender' } },
|
||||
);
|
||||
});
|
||||
|
||||
it('should successfully pass the email if Apple natively provides it in the signed JWT', async () => {
|
||||
jest.mocked(handleIdentityToken).mockResolvedValue({
|
||||
id: 'apple-sub-123',
|
||||
email: 'legit@email.tld',
|
||||
});
|
||||
|
||||
const legitLoginRequest = {
|
||||
identityToken: 'valid.token.with_email',
|
||||
fullName: { givenName: 'John', familyName: 'Doe' },
|
||||
};
|
||||
|
||||
jest.mocked(Accounts.updateOrCreateUserFromExternalService).mockResolvedValue({ userId: 'user-id' });
|
||||
|
||||
await loginHandlerCallback(legitLoginRequest);
|
||||
|
||||
expect(Accounts.updateOrCreateUserFromExternalService).toHaveBeenCalledWith(
|
||||
'apple',
|
||||
{ id: 'apple-sub-123', email: 'legit@email.tld' },
|
||||
{ profile: { name: 'John Doe' } },
|
||||
);
|
||||
});
|
||||
|
||||
it('should pass empty client id to token validation when setting is not configured', async () => {
|
||||
jest.mocked(settings.get).mockImplementation((key) => {
|
||||
if (key === 'Accounts_OAuth_Apple') return true;
|
||||
if (key === 'Accounts_OAuth_Apple_id') return '';
|
||||
return null;
|
||||
});
|
||||
|
||||
jest.mocked(handleIdentityToken).mockResolvedValue({ id: 'apple-sub-123' });
|
||||
jest.mocked(Accounts.updateOrCreateUserFromExternalService).mockResolvedValue({ userId: 'user-id' });
|
||||
|
||||
await loginHandlerCallback({
|
||||
identityToken: 'valid.token.with_mobile_default_audience',
|
||||
fullName: { givenName: 'Mobile', familyName: 'User' },
|
||||
});
|
||||
|
||||
expect(handleIdentityToken).toHaveBeenCalledWith('valid.token.with_mobile_default_audience', '');
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user