snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
@@ -0,0 +1,123 @@
|
||||
import { buildVersionUpdateMessage } from './buildVersionUpdateMessage';
|
||||
import { sendMessagesToAdmins } from '../../../sendMessagesToAdmins';
|
||||
|
||||
const originalTestMode = process.env.TEST_MODE;
|
||||
|
||||
const mockInfoVersion = jest.fn(() => '7.5.0');
|
||||
|
||||
jest.mock('../../../../../app/utils/rocketchat.info', () => ({
|
||||
Info: {
|
||||
get version() {
|
||||
return mockInfoVersion();
|
||||
},
|
||||
},
|
||||
}));
|
||||
|
||||
const mockSetBannersInBulk = jest.fn();
|
||||
const mockFindUsersInRolesWithQuery = jest.fn();
|
||||
|
||||
jest.mock('@rocket.chat/models', () => ({
|
||||
Settings: {
|
||||
updateValueById: jest.fn().mockResolvedValue({ modifiedCount: 0 }),
|
||||
},
|
||||
Users: {
|
||||
findUsersInRolesWithQuery: () => mockFindUsersInRolesWithQuery(),
|
||||
setBannersInBulk: (updates: unknown) => mockSetBannersInBulk(updates),
|
||||
},
|
||||
}));
|
||||
|
||||
const mockSettingsGet = jest.fn();
|
||||
|
||||
jest.mock('../../../../settings', () => ({
|
||||
settings: {
|
||||
get: (key: string) => mockSettingsGet(key),
|
||||
},
|
||||
}));
|
||||
|
||||
jest.mock('../../../i18n', () => ({
|
||||
i18n: {
|
||||
t: jest.fn((key) => key),
|
||||
},
|
||||
}));
|
||||
|
||||
jest.mock('../../../sendMessagesToAdmins', () => ({
|
||||
sendMessagesToAdmins: jest.fn(),
|
||||
}));
|
||||
|
||||
jest.mock('../../../../settings/lib/auditedSettingUpdates', () => ({
|
||||
updateAuditedBySystem: jest.fn(() => () => Promise.resolve({ modifiedCount: 0 })),
|
||||
}));
|
||||
|
||||
jest.mock('../../../notifyListener', () => ({
|
||||
notifyOnSettingChangedById: jest.fn(),
|
||||
}));
|
||||
|
||||
describe('buildVersionUpdateMessage', () => {
|
||||
// Delete the TEST_MODE environment variable so buildVersionUpdateMessage()
|
||||
// doesn't return early (see line 40 in buildVersionUpdateMessage.ts)
|
||||
beforeAll(() => {
|
||||
delete process.env.TEST_MODE;
|
||||
});
|
||||
|
||||
afterAll(() => {
|
||||
process.env.TEST_MODE = originalTestMode;
|
||||
});
|
||||
|
||||
beforeEach(() => {
|
||||
jest.clearAllMocks();
|
||||
mockInfoVersion.mockReturnValue('7.5.0');
|
||||
mockSettingsGet.mockReturnValue('7.0.0');
|
||||
});
|
||||
|
||||
describe('cleanupOutdatedVersionUpdateBanners', () => {
|
||||
it('should remove outdated version banners (<= current installed)', async () => {
|
||||
const admin = { _id: 'admin1', banners: { 'versionUpdate-6_2_0': { id: 'versionUpdate-6_2_0' } } };
|
||||
mockFindUsersInRolesWithQuery.mockReturnValue([admin]);
|
||||
|
||||
await buildVersionUpdateMessage([]);
|
||||
|
||||
expect(mockSetBannersInBulk).toHaveBeenCalledWith([{ userId: 'admin1', banners: {} }]);
|
||||
});
|
||||
|
||||
it('should keep version banners > current installed', async () => {
|
||||
const admin = { _id: 'admin1', banners: { 'versionUpdate-8_0_0': { id: 'versionUpdate-8_0_0' } } };
|
||||
mockFindUsersInRolesWithQuery.mockReturnValue([admin]);
|
||||
|
||||
await buildVersionUpdateMessage([]);
|
||||
|
||||
expect(mockSetBannersInBulk).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should remove banners with invalid semver version IDs', async () => {
|
||||
const admin = { _id: 'admin1', banners: { 'versionUpdate-invalid_version': { id: 'versionUpdate-invalid_version' } } };
|
||||
mockFindUsersInRolesWithQuery.mockReturnValue([admin]);
|
||||
|
||||
await buildVersionUpdateMessage([]);
|
||||
|
||||
expect(mockSetBannersInBulk).toHaveBeenCalledWith([{ userId: 'admin1', banners: {} }]);
|
||||
});
|
||||
});
|
||||
|
||||
describe('version sorting', () => {
|
||||
it('should process versions in descending order (highest first)', async () => {
|
||||
mockFindUsersInRolesWithQuery.mockReturnValue([]);
|
||||
|
||||
await buildVersionUpdateMessage([
|
||||
{ version: '7.6.0', security: false, infoUrl: 'https://example.com/7.6.0' },
|
||||
{ version: '8.0.0', security: false, infoUrl: 'https://example.com/8.0.0' },
|
||||
{ version: '7.8.0', security: false, infoUrl: 'https://example.com/7.8.0' },
|
||||
]);
|
||||
|
||||
expect(sendMessagesToAdmins).toHaveBeenCalledTimes(1);
|
||||
expect(sendMessagesToAdmins).toHaveBeenCalledWith(
|
||||
expect.objectContaining({
|
||||
banners: expect.arrayContaining([
|
||||
expect.objectContaining({
|
||||
id: 'versionUpdate-8_0_0',
|
||||
}),
|
||||
]),
|
||||
}),
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user