snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
227
apps/meteor/server/lib/media/file/file.server.ts
Normal file
227
apps/meteor/server/lib/media/file/file.server.ts
Normal file
@@ -0,0 +1,227 @@
|
||||
import type { ReadStream } from 'node:fs';
|
||||
import fs from 'node:fs';
|
||||
import fsp from 'node:fs/promises';
|
||||
import path from 'node:path';
|
||||
import { Readable } from 'node:stream';
|
||||
|
||||
import type { ObjectId } from 'bson';
|
||||
import { MongoInternals } from 'meteor/mongo';
|
||||
import { NpmModuleMongodb } from 'meteor/npm-mongo';
|
||||
import mime from 'mime-type/with-db';
|
||||
import mkdirp from 'mkdirp';
|
||||
|
||||
import { sanitizeFileName } from './functions/sanitizeFileName';
|
||||
|
||||
const { db } = MongoInternals.defaultRemoteCollectionDriver().mongo;
|
||||
|
||||
type IFile = {
|
||||
buffer: Buffer;
|
||||
contentType?: string;
|
||||
length: number;
|
||||
uploadDate?: Date;
|
||||
};
|
||||
|
||||
interface IRocketChatFileStore {
|
||||
remove(fileId: string): Promise<void>;
|
||||
|
||||
createWriteStream(fileName: string, contentType: string): void;
|
||||
|
||||
createReadStream(fileName: string): void;
|
||||
|
||||
getFileWithReadStream(fileName: string): Promise<
|
||||
| {
|
||||
readStream: NpmModuleMongodb.GridFSBucketReadStream | ReadStream;
|
||||
contentType?: string;
|
||||
length: number;
|
||||
uploadDate?: Date;
|
||||
}
|
||||
| undefined
|
||||
>;
|
||||
|
||||
getFile(fileName: string): Promise<IFile | undefined>;
|
||||
|
||||
deleteFile(fileName: string): Promise<void>;
|
||||
}
|
||||
|
||||
class GridFS implements IRocketChatFileStore {
|
||||
private name: string;
|
||||
|
||||
private bucket: NpmModuleMongodb.GridFSBucket;
|
||||
|
||||
constructor({ name = 'file' } = {}) {
|
||||
this.name = name;
|
||||
|
||||
this.bucket = new NpmModuleMongodb.GridFSBucket(db as any, { bucketName: this.name });
|
||||
}
|
||||
|
||||
private async findOne(filename: string) {
|
||||
const file = await this.bucket.find({ filename }).limit(1).toArray();
|
||||
if (!file) {
|
||||
return;
|
||||
}
|
||||
return file[0];
|
||||
}
|
||||
|
||||
async remove(fileId: string) {
|
||||
await this.bucket.delete(fileId as unknown as ObjectId);
|
||||
}
|
||||
|
||||
createWriteStream(fileName: string, contentType: string) {
|
||||
const ws = this.bucket.openUploadStream(fileName, {
|
||||
contentType,
|
||||
});
|
||||
|
||||
ws.on('close', () => {
|
||||
return ws.emit('end');
|
||||
});
|
||||
return ws;
|
||||
}
|
||||
|
||||
createReadStream(fileName: string) {
|
||||
return this.bucket.openDownloadStreamByName(fileName);
|
||||
}
|
||||
|
||||
async getFileWithReadStream(fileName: string) {
|
||||
const file = await this.findOne(fileName);
|
||||
if (!file) {
|
||||
return;
|
||||
}
|
||||
const rs = this.createReadStream(fileName);
|
||||
return {
|
||||
readStream: rs,
|
||||
contentType: file.contentType,
|
||||
length: file.length,
|
||||
uploadDate: file.uploadDate,
|
||||
};
|
||||
}
|
||||
|
||||
async getFile(fileName: string) {
|
||||
const file = await this.getFileWithReadStream(fileName);
|
||||
if (!file) {
|
||||
return;
|
||||
}
|
||||
return new Promise<IFile>((resolve) => {
|
||||
const data: Buffer[] = [];
|
||||
file.readStream.on('data', (chunk) => {
|
||||
return data.push(chunk);
|
||||
});
|
||||
|
||||
file.readStream.on('end', () => {
|
||||
resolve({
|
||||
buffer: Buffer.concat(data),
|
||||
contentType: file.contentType,
|
||||
length: file.length,
|
||||
uploadDate: file.uploadDate,
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
async deleteFile(fileName: string) {
|
||||
const file = await this.findOne(fileName);
|
||||
if (file == null) {
|
||||
return undefined;
|
||||
}
|
||||
return this.remove(file._id as unknown as string);
|
||||
}
|
||||
}
|
||||
|
||||
class FileSystem implements IRocketChatFileStore {
|
||||
private absolutePath: string;
|
||||
|
||||
constructor({ absolutePath = '~/uploads' } = {}) {
|
||||
if (absolutePath.split(path.sep)[0] === '~') {
|
||||
const homepath = process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE;
|
||||
if (homepath != null) {
|
||||
absolutePath = absolutePath.replace('~', homepath);
|
||||
} else {
|
||||
throw new Error('Unable to resolve "~" in path');
|
||||
}
|
||||
}
|
||||
this.absolutePath = path.resolve(absolutePath);
|
||||
mkdirp.sync(this.absolutePath);
|
||||
}
|
||||
|
||||
createWriteStream(fileName: string) {
|
||||
const ws = fs.createWriteStream(path.join(this.absolutePath, sanitizeFileName(fileName)));
|
||||
ws.on('close', () => {
|
||||
return ws.emit('end');
|
||||
});
|
||||
return ws;
|
||||
}
|
||||
|
||||
createReadStream(fileName: string) {
|
||||
return fs.createReadStream(path.join(this.absolutePath, sanitizeFileName(fileName)));
|
||||
}
|
||||
|
||||
stat(fileName: string) {
|
||||
return fsp.stat(path.join(this.absolutePath, sanitizeFileName(fileName)));
|
||||
}
|
||||
|
||||
async remove(fileName: string) {
|
||||
return fsp.unlink(path.join(this.absolutePath, sanitizeFileName(fileName)));
|
||||
}
|
||||
|
||||
async getFileWithReadStream(fileName: string) {
|
||||
try {
|
||||
const stat = await this.stat(fileName);
|
||||
const rs = this.createReadStream(fileName);
|
||||
return {
|
||||
readStream: rs,
|
||||
// We currently don't store the content type of uploaded custom sounds when using
|
||||
// The filesystem storage. We will use mime to infer its type from the extension.
|
||||
contentType: (mime.lookup(fileName) as string) || 'application/octet-stream',
|
||||
length: stat.size,
|
||||
};
|
||||
} catch (error1) {
|
||||
console.error(error1);
|
||||
}
|
||||
}
|
||||
|
||||
async getFile(fileName: string) {
|
||||
const file = await this.getFileWithReadStream(fileName);
|
||||
if (!file) {
|
||||
return;
|
||||
}
|
||||
return new Promise<IFile>((resolve) => {
|
||||
const data: Buffer[] = [];
|
||||
file.readStream.on('data', (chunk) => {
|
||||
if (Buffer.isBuffer(chunk)) {
|
||||
return data.push(chunk);
|
||||
}
|
||||
return data.push(Buffer.from(chunk));
|
||||
});
|
||||
file.readStream.on('end', () => {
|
||||
resolve({
|
||||
buffer: Buffer.concat(data),
|
||||
length: file.length,
|
||||
});
|
||||
});
|
||||
});
|
||||
}
|
||||
|
||||
async deleteFile(fileName: string) {
|
||||
try {
|
||||
return await this.remove(fileName);
|
||||
} catch (error1) {
|
||||
console.error(error1);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
export const RocketChatFile = {
|
||||
bufferToStream(buffer: Buffer) {
|
||||
return Readable.from(buffer);
|
||||
},
|
||||
|
||||
dataURIParse(dataURI: string | Buffer) {
|
||||
const imageData = (Buffer.isBuffer(dataURI) ? dataURI : Buffer.from(dataURI)).toString().split(';base64,');
|
||||
return {
|
||||
image: imageData[1],
|
||||
contentType: imageData[0].replace('data:', ''),
|
||||
};
|
||||
},
|
||||
|
||||
GridFS,
|
||||
FileSystem,
|
||||
};
|
||||
@@ -0,0 +1,55 @@
|
||||
import { expect } from 'chai';
|
||||
import { describe, it } from 'mocha';
|
||||
|
||||
import { sanitizeFileName } from './sanitizeFileName';
|
||||
|
||||
describe('sanitizeFileName', () => {
|
||||
describe('valid filenames', () => {
|
||||
it('should allow simple filenames', () => {
|
||||
const result = sanitizeFileName('sound.mp3');
|
||||
expect(result).to.equal('sound.mp3');
|
||||
});
|
||||
|
||||
it('should allow filenames with dashes, underscores and dots', () => {
|
||||
const result = sanitizeFileName('alert_test-01.wav');
|
||||
expect(result).to.equal('alert_test-01.wav');
|
||||
});
|
||||
|
||||
it('should allow filenames without extension', () => {
|
||||
const result = sanitizeFileName('beep');
|
||||
expect(result).to.equal('beep');
|
||||
});
|
||||
});
|
||||
|
||||
describe('invalid paths', () => {
|
||||
it('should reject path traversal using ../', () => {
|
||||
expect(() => sanitizeFileName('../etc/passwd')).to.throw();
|
||||
});
|
||||
|
||||
it('should reject path traversal using ./', () => {
|
||||
expect(() => sanitizeFileName('./folder/sounds')).to.throw();
|
||||
});
|
||||
|
||||
it('should reject nested paths', () => {
|
||||
expect(() => sanitizeFileName('sounds/alert.mp3')).to.throw();
|
||||
});
|
||||
|
||||
it('should reject absolute paths', () => {
|
||||
expect(() => sanitizeFileName('/etc/passwd')).to.throw();
|
||||
});
|
||||
});
|
||||
|
||||
describe('invalid characters', () => {
|
||||
it('should reject filenames with spaces', () => {
|
||||
expect(() => sanitizeFileName('my sound.mp3')).to.throw();
|
||||
});
|
||||
|
||||
it('should reject filenames with special characters', () => {
|
||||
expect(() => sanitizeFileName('sound$.mp3')).to.throw();
|
||||
});
|
||||
|
||||
it('should reject filenames with backslashes', () => {
|
||||
expect(() => sanitizeFileName('..\\passwd')).to.throw();
|
||||
});
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,19 @@
|
||||
import path from 'node:path';
|
||||
|
||||
export function sanitizeFileName(fileName: string) {
|
||||
const base = path.basename(fileName);
|
||||
|
||||
if (base !== fileName) {
|
||||
throw new Error('error-invalid-file-name');
|
||||
}
|
||||
|
||||
if (base === '.' || base.startsWith('..')) {
|
||||
throw new Error('error-invalid-file-name');
|
||||
}
|
||||
|
||||
if (!/^[a-zA-Z0-9._-]+$/.test(base)) {
|
||||
throw new Error('error-invalid-characters-in-file-name');
|
||||
}
|
||||
|
||||
return base;
|
||||
}
|
||||
3
apps/meteor/server/lib/media/file/index.ts
Normal file
3
apps/meteor/server/lib/media/file/index.ts
Normal file
@@ -0,0 +1,3 @@
|
||||
import { RocketChatFile } from './file.server';
|
||||
|
||||
export { RocketChatFile };
|
||||
Reference in New Issue
Block a user