snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
@@ -0,0 +1,211 @@
|
||||
import type { IIntegration, INewIncomingIntegration, IUpdateIncomingIntegration } from '@rocket.chat/core-typings';
|
||||
import type { ServerMethods } from '@rocket.chat/ddp-client';
|
||||
import { Integrations, Subscriptions, Users, Rooms } from '@rocket.chat/models';
|
||||
import { wrapExceptions } from '@rocket.chat/tools';
|
||||
import { Meteor } from 'meteor/meteor';
|
||||
|
||||
import { hasAllPermissionAsync, hasPermissionAsync } from '../../../lib/authorization/hasPermission';
|
||||
import { methodDeprecationLogger } from '../../../lib/deprecationWarningLogger';
|
||||
import { compileIntegrationScript } from '../../../lib/integrations/lib/compileIntegrationScript';
|
||||
import { isScriptEngineFrozen, validateScriptEngine } from '../../../lib/integrations/lib/validateScriptEngine';
|
||||
import { notifyOnIntegrationChanged } from '../../../lib/notifyListener';
|
||||
|
||||
const validChannelChars = ['@', '#'];
|
||||
|
||||
declare module '@rocket.chat/ddp-client' {
|
||||
// eslint-disable-next-line @typescript-eslint/naming-convention
|
||||
interface ServerMethods {
|
||||
updateIncomingIntegration(
|
||||
integrationId: string,
|
||||
integration: INewIncomingIntegration | IUpdateIncomingIntegration,
|
||||
): IIntegration | null;
|
||||
}
|
||||
}
|
||||
|
||||
function validateChannels(channelString: string | undefined): string[] {
|
||||
if (!channelString || typeof channelString.valueOf() !== 'string' || channelString.trim() === '') {
|
||||
throw new Meteor.Error('error-invalid-channel', 'Invalid channel', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
const channels = channelString.split(',').map((channel) => channel.trim());
|
||||
|
||||
for (const channel of channels) {
|
||||
if (!validChannelChars.includes(channel[0])) {
|
||||
throw new Meteor.Error('error-invalid-channel-start-with-chars', 'Invalid channel. Start with @ or #', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
return channels;
|
||||
}
|
||||
|
||||
export const updateIncomingIntegration = async (
|
||||
userId: string,
|
||||
integrationId: string,
|
||||
integration: INewIncomingIntegration | IUpdateIncomingIntegration,
|
||||
): Promise<IIntegration | null> => {
|
||||
const channels = validateChannels(integration.channel);
|
||||
|
||||
let currentIntegration;
|
||||
|
||||
if (await hasPermissionAsync(userId, 'manage-incoming-integrations')) {
|
||||
currentIntegration = await Integrations.findOneById(integrationId);
|
||||
} else if (await hasPermissionAsync(userId, 'manage-own-incoming-integrations')) {
|
||||
currentIntegration = await Integrations.findOne({
|
||||
'_id': integrationId,
|
||||
'_createdBy._id': userId,
|
||||
});
|
||||
} else {
|
||||
throw new Meteor.Error('not_authorized', 'Unauthorized', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
if (!currentIntegration) {
|
||||
throw new Meteor.Error('error-invalid-integration', 'Invalid integration', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
const oldScriptEngine = currentIntegration.scriptEngine;
|
||||
const scriptEngine = integration.scriptEngine ?? oldScriptEngine ?? 'isolated-vm';
|
||||
if (
|
||||
integration.script?.trim() &&
|
||||
(scriptEngine !== oldScriptEngine || integration.script?.trim() !== currentIntegration.script?.trim())
|
||||
) {
|
||||
wrapExceptions(() => validateScriptEngine(scriptEngine)).catch((e) => {
|
||||
throw new Meteor.Error(e.message);
|
||||
});
|
||||
}
|
||||
|
||||
const isFrozen = isScriptEngineFrozen(scriptEngine);
|
||||
|
||||
// Default to transpiling with Babel for backwards compatibility; integrations
|
||||
// can opt-out per-record by setting `skipTranspile: true` (removed in 9.0.0).
|
||||
const skipTranspile = integration.skipTranspile === true;
|
||||
|
||||
if (!isFrozen && integration.scriptEnabled === true && integration.script && integration.script.trim() !== '') {
|
||||
const { script, error } = compileIntegrationScript(integration.script, { transpile: !skipTranspile });
|
||||
if (error) {
|
||||
await Integrations.updateOne(
|
||||
{ _id: integrationId },
|
||||
{
|
||||
$set: { scriptError: error, skipTranspile },
|
||||
$unset: { scriptCompiled: 1 as const },
|
||||
},
|
||||
);
|
||||
} else {
|
||||
await Integrations.updateOne(
|
||||
{ _id: integrationId },
|
||||
{
|
||||
$set: { scriptCompiled: script, skipTranspile },
|
||||
$unset: { scriptError: 1 as const },
|
||||
},
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
for (let channel of channels) {
|
||||
const channelType = channel[0];
|
||||
channel = channel.slice(1);
|
||||
let record;
|
||||
|
||||
switch (channelType) {
|
||||
case '#':
|
||||
record = await Rooms.findOne({
|
||||
$or: [{ _id: channel }, { name: channel }],
|
||||
});
|
||||
break;
|
||||
case '@':
|
||||
record = await Users.findOne({
|
||||
$or: [{ _id: channel }, { username: channel }],
|
||||
});
|
||||
break;
|
||||
}
|
||||
|
||||
if (!record) {
|
||||
throw new Meteor.Error('error-invalid-room', 'Invalid room', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
if (
|
||||
!(await hasAllPermissionAsync(userId, ['manage-incoming-integrations', 'manage-own-incoming-integrations'])) &&
|
||||
!(await Subscriptions.findOneByRoomIdAndUserId(record._id, userId, { projection: { _id: 1 } }))
|
||||
) {
|
||||
throw new Meteor.Error('error-invalid-channel', 'Invalid Channel', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
const username = 'username' in integration ? integration.username : currentIntegration.username;
|
||||
const user = await Users.findOneByUsername(username, { projection: { _id: 1, username: 1 } });
|
||||
|
||||
if (!user) {
|
||||
throw new Meteor.Error('error-invalid-post-as-user', 'Invalid Post As User', {
|
||||
method: 'updateIncomingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
if (!(await hasPermissionAsync(user._id, 'message-impersonate'))) {
|
||||
throw new Meteor.Error(
|
||||
'error-user-lacks-message-impersonate-permission',
|
||||
"User selected for the incoming integration lacks the 'message-impersonate' permission.",
|
||||
{
|
||||
method: 'updateIncomingIntegration',
|
||||
},
|
||||
);
|
||||
}
|
||||
|
||||
const updatedIntegration = await Integrations.findOneAndUpdate(
|
||||
{ _id: integrationId },
|
||||
{
|
||||
$set: {
|
||||
enabled: integration.enabled,
|
||||
name: integration.name,
|
||||
...(typeof integration.avatar !== 'undefined' && { avatar: integration.avatar }),
|
||||
...(typeof integration.emoji !== 'undefined' && { emoji: integration.emoji }),
|
||||
...(typeof integration.alias !== 'undefined' && { alias: integration.alias }),
|
||||
...(channels && { channel: channels }),
|
||||
...('username' in integration && { username: user.username, userId: user._id }),
|
||||
...(isFrozen
|
||||
? {}
|
||||
: {
|
||||
...(typeof integration.script !== 'undefined' && { script: integration.script }),
|
||||
scriptEnabled: integration.scriptEnabled,
|
||||
...(scriptEngine && { scriptEngine }),
|
||||
skipTranspile,
|
||||
}),
|
||||
...(typeof integration.overrideDestinationChannelEnabled !== 'undefined' && {
|
||||
overrideDestinationChannelEnabled: integration.overrideDestinationChannelEnabled,
|
||||
}),
|
||||
_updatedAt: new Date(),
|
||||
_updatedBy: await Users.findOne({ _id: userId }, { projection: { username: 1 } }),
|
||||
},
|
||||
},
|
||||
{ returnDocument: 'after' },
|
||||
);
|
||||
|
||||
if (updatedIntegration) {
|
||||
void notifyOnIntegrationChanged(updatedIntegration);
|
||||
}
|
||||
|
||||
return updatedIntegration;
|
||||
};
|
||||
|
||||
Meteor.methods<ServerMethods>({
|
||||
async updateIncomingIntegration(integrationId, integration) {
|
||||
methodDeprecationLogger.method('updateIncomingIntegration', '9.0.0', '/v1/integrations.update');
|
||||
if (!this.userId) {
|
||||
throw new Meteor.Error('error-invalid-user', 'Invalid user', {
|
||||
method: 'updateOutgoingIntegration',
|
||||
});
|
||||
}
|
||||
|
||||
return updateIncomingIntegration(this.userId, integrationId, integration);
|
||||
},
|
||||
});
|
||||
Reference in New Issue
Block a user