snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
70
apps/meteor/tests/unit/app/emoji/emojiNativeParser.spec.ts
Normal file
70
apps/meteor/tests/unit/app/emoji/emojiNativeParser.spec.ts
Normal file
@@ -0,0 +1,70 @@
|
||||
import { expect } from 'chai';
|
||||
import { describe, it } from 'mocha';
|
||||
|
||||
import { getEmojiData } from '../../../../app/emoji-native/lib/generateEmojiData';
|
||||
import { getEmojiConfig } from '../../../../app/emoji-native/lib/getEmojiConfig';
|
||||
import { shortnameToUnicode } from '../../../../app/emoji-native/lib/shortnameToUnicode';
|
||||
|
||||
describe('emoji-native shortcode resolution', () => {
|
||||
describe('shortnameToUnicode', () => {
|
||||
it('resolves skin-tone variants stored under emojione alternate names', () => {
|
||||
expect(shortnameToUnicode(':thumbsup_tone3:')).to.equal('👍🏽');
|
||||
expect(shortnameToUnicode(':thumbup_tone3:')).to.equal('👍🏽');
|
||||
expect(shortnameToUnicode(':clap_tone2:')).to.equal('👏🏼');
|
||||
expect(shortnameToUnicode(':pray_tone4:')).to.equal('🙏🏾');
|
||||
});
|
||||
|
||||
it('still resolves the emojibase primary skin-tone name', () => {
|
||||
expect(shortnameToUnicode(':+1_tone3:')).to.equal('👍🏽');
|
||||
});
|
||||
|
||||
it('resolves regional indicator letters', () => {
|
||||
expect(shortnameToUnicode(':regional_indicator_a:')).to.equal('🇦');
|
||||
expect(shortnameToUnicode(':regional_indicator_z:')).to.equal('🇿');
|
||||
});
|
||||
|
||||
it('resolves legacy emojione base aliases', () => {
|
||||
expect(shortnameToUnicode(':digit_zero:')).to.equal('0️⃣');
|
||||
expect(shortnameToUnicode(':digit_nine:')).to.equal('9️⃣');
|
||||
expect(shortnameToUnicode(':pound_symbol:')).to.equal('#️⃣');
|
||||
expect(shortnameToUnicode(':asterisk_symbol:')).to.equal('*️⃣');
|
||||
expect(shortnameToUnicode(':tone3:')).to.equal('🏽');
|
||||
});
|
||||
|
||||
it('leaves unknown shortcodes untouched', () => {
|
||||
expect(shortnameToUnicode(':not_a_real_emoji:')).to.equal(':not_a_real_emoji:');
|
||||
});
|
||||
|
||||
it('resolves multiple shortcodes within a single string', () => {
|
||||
expect(shortnameToUnicode('hi :thumbsup_tone3: and :regional_indicator_a:')).to.equal('hi 👍🏽 and 🇦');
|
||||
});
|
||||
});
|
||||
|
||||
describe('render', () => {
|
||||
const { render } = getEmojiConfig({ list: {}, packages: {} });
|
||||
|
||||
it('renders a known shortcode as an emoji span', () => {
|
||||
expect(render(':smile:')).to.contain('class="emoji"');
|
||||
});
|
||||
|
||||
it('leaves prototype property names untouched', () => {
|
||||
expect(render(':toString:')).to.equal(':toString:');
|
||||
expect(render('topic :toString: end')).to.equal('topic :toString: end');
|
||||
});
|
||||
});
|
||||
|
||||
describe('getEmojiData', () => {
|
||||
it('registers regional indicators in emojiList but keeps them out of the picker', () => {
|
||||
const { emojiList, emojisByCategory } = getEmojiData();
|
||||
expect(emojiList[':regional_indicator_a:']?.unicode).to.equal('🇦');
|
||||
expect(emojisByCategory.flags).to.not.include('regional_indicator_a');
|
||||
});
|
||||
|
||||
it('registers alternate skin-tone shortnames alongside the primary', () => {
|
||||
const { emojiList } = getEmojiData();
|
||||
expect(emojiList[':thumbsup_tone3:']?.unicode).to.equal('👍🏽');
|
||||
expect(emojiList[':thumbup_tone3:']?.unicode).to.equal('👍🏽');
|
||||
expect(emojiList[':+1_tone3:']?.unicode).to.equal('👍🏽');
|
||||
});
|
||||
});
|
||||
});
|
||||
136
apps/meteor/tests/unit/app/emoji/helpers.spec.ts
Normal file
136
apps/meteor/tests/unit/app/emoji/helpers.spec.ts
Normal file
@@ -0,0 +1,136 @@
|
||||
import { expect } from 'chai';
|
||||
import { describe, it, beforeEach, before } from 'mocha';
|
||||
|
||||
import { getEmojiConfig } from '../../../../app/emoji-native/lib/getEmojiConfig';
|
||||
import { getEmojisBySearchTerm, updateRecent, removeFromRecent, replaceEmojiInRecent } from '../../../../client/lib/emoji/helpers';
|
||||
import { emoji } from '../../../../client/lib/emoji/lib';
|
||||
|
||||
const registerNativeEmojis = () => {
|
||||
const config = getEmojiConfig(emoji);
|
||||
|
||||
emoji.packages.native = {
|
||||
emojiCategories: config.emojiCategories as any,
|
||||
emojisByCategory: config.emojisByCategory,
|
||||
toneList: config.toneList,
|
||||
render: config.render,
|
||||
renderPicker: config.renderPicker,
|
||||
sprites: config.sprites,
|
||||
};
|
||||
|
||||
for (const [key, currentEmoji] of Object.entries(config.emojiList)) {
|
||||
currentEmoji.emojiPackage = 'native';
|
||||
emoji.list[key] = currentEmoji as any;
|
||||
|
||||
if (currentEmoji.shortnames) {
|
||||
currentEmoji.shortnames.forEach((shortname: string) => {
|
||||
emoji.list[shortname] = currentEmoji as any;
|
||||
});
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
const registerCustomEmoji = (name: string) => {
|
||||
if (!emoji.packages.emojiCustom) {
|
||||
emoji.packages.emojiCustom = {
|
||||
emojiCategories: [{ key: 'rocket', i18n: 'Custom' as any }],
|
||||
emojisByCategory: { rocket: [] },
|
||||
toneList: {},
|
||||
render: (html: string) => html,
|
||||
renderPicker: () => '<span class="emoji-custom" />',
|
||||
} as any;
|
||||
}
|
||||
emoji.packages.emojiCustom.emojisByCategory.rocket.push(name);
|
||||
emoji.list[`:${name}:`] = { emojiPackage: 'emojiCustom', name } as any;
|
||||
};
|
||||
|
||||
describe('Emoji Client Helpers', () => {
|
||||
beforeEach(() => {
|
||||
emoji.packages.base.emojisByCategory.recent = [];
|
||||
});
|
||||
|
||||
describe('getEmojisBySearchTerm', () => {
|
||||
before(registerNativeEmojis);
|
||||
|
||||
const search = (term: string) => getEmojisBySearchTerm(term, 0, [], () => undefined);
|
||||
const names = (term: string) => search(term).map((result) => result.emoji);
|
||||
const rendersThumbsUp = (term: string) => search(term).some((result) => result.image?.includes('👍'));
|
||||
|
||||
it('finds an emoji by its primary shortcode', () => {
|
||||
expect(names('+1')).to.include('+1');
|
||||
});
|
||||
|
||||
it('finds an emoji by its first alias (thumbsup -> 👍)', () => {
|
||||
expect(rendersThumbsUp('thumbsup')).to.be.true;
|
||||
});
|
||||
|
||||
it('finds an emoji by a secondary alias (thumbup -> 👍)', () => {
|
||||
expect(rendersThumbsUp('thumbup')).to.be.true;
|
||||
});
|
||||
|
||||
it('matches aliases partially (thumb -> thumbsup)', () => {
|
||||
expect(names('thumb')).to.include('thumbsup');
|
||||
});
|
||||
|
||||
it('does not list the same emoji more than once', () => {
|
||||
const images = search('grinning').map((result) => result.image);
|
||||
expect(images.length).to.equal(new Set(images).size);
|
||||
});
|
||||
|
||||
it('excludes skin-tone variants from the results', () => {
|
||||
expect(names('+1').some((name) => /_tone[1-5]/.test(name))).to.be.false;
|
||||
});
|
||||
|
||||
it('applies the selected skin tone when searching by an alias', () => {
|
||||
const result = getEmojisBySearchTerm('thumbsup', 2, [], () => undefined).find(({ image }) => image?.includes('👍'));
|
||||
|
||||
expect(result).to.exist;
|
||||
expect(result?.image).to.include('👍🏼');
|
||||
expect(result?.emoji).to.equal('thumbsup_tone2');
|
||||
});
|
||||
|
||||
it('finds a custom emoji whose name ends in a mixed skin-tone suffix (CORE-2473)', () => {
|
||||
registerCustomEmoji('mycustom_tone1-2');
|
||||
expect(names('mycustom_tone1-2')).to.include('mycustom_tone1-2');
|
||||
});
|
||||
});
|
||||
|
||||
describe('updateRecent', () => {
|
||||
it('should update recent emojis with the provided emojis', () => {
|
||||
const recentEmojis = ['emoji1', 'emoji2'];
|
||||
updateRecent(recentEmojis);
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.contain('emoji1');
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.contain('emoji2');
|
||||
});
|
||||
});
|
||||
|
||||
describe('removeFromRecent', () => {
|
||||
it('should remove a specific emoji from recent emojis', () => {
|
||||
emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2', 'emoji3'];
|
||||
removeFromRecent('emoji2', emoji.packages.base.emojisByCategory.recent);
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.not.include('emoji2');
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji3']);
|
||||
});
|
||||
|
||||
it('should do nothing if the emoji is not in the recent list', () => {
|
||||
emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2'];
|
||||
removeFromRecent('emoji3', emoji.packages.base.emojisByCategory.recent);
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji2']);
|
||||
});
|
||||
});
|
||||
|
||||
describe('replaceEmojiInRecent', () => {
|
||||
it('should replace an existing emoji with a new one in recent emojis', () => {
|
||||
emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2', 'emoji3'];
|
||||
replaceEmojiInRecent({ oldEmoji: 'emoji2', newEmoji: 'emoji4' });
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.not.include('emoji2');
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.include('emoji4');
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji4', 'emoji3']);
|
||||
});
|
||||
|
||||
it('should do nothing if the emoji to replace is not in the recent list', () => {
|
||||
emoji.packages.base.emojisByCategory.recent = ['emoji1', 'emoji2'];
|
||||
replaceEmojiInRecent({ oldEmoji: 'emoji3', newEmoji: 'emoji4' });
|
||||
expect(emoji.packages.base.emojisByCategory.recent).to.deep.equal(['emoji1', 'emoji2']);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user