snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
@@ -0,0 +1,100 @@
|
||||
import { expect } from 'chai';
|
||||
import proxyquire from 'proxyquire';
|
||||
import sinon from 'sinon';
|
||||
|
||||
const mockUsers = {
|
||||
acquireAgentLock: sinon.stub(),
|
||||
releaseAgentLock: sinon.stub(),
|
||||
};
|
||||
|
||||
const mockSettings = {
|
||||
get: sinon.stub(),
|
||||
};
|
||||
|
||||
const mockHasRoleAsync = sinon.stub();
|
||||
|
||||
const { conditionalLockAgent } = proxyquire.noCallThru().load('../../../../../server/lib/omnichannel/conditionalLockAgent', {
|
||||
'@rocket.chat/models': { Users: mockUsers },
|
||||
'../authorization/hasRole': { hasRoleAsync: mockHasRoleAsync },
|
||||
'../../settings': { settings: mockSettings },
|
||||
});
|
||||
|
||||
describe('conditionalLockAgent', () => {
|
||||
beforeEach(() => {
|
||||
mockUsers.acquireAgentLock.reset();
|
||||
mockUsers.releaseAgentLock.reset();
|
||||
mockSettings.get.reset();
|
||||
mockHasRoleAsync.reset();
|
||||
});
|
||||
|
||||
describe('when waiting_queue is enabled', () => {
|
||||
beforeEach(() => {
|
||||
mockSettings.get.withArgs('Livechat_waiting_queue').returns(true);
|
||||
mockHasRoleAsync.resolves(false);
|
||||
});
|
||||
|
||||
it('should return acquired: true when lock is successfully acquired', async () => {
|
||||
mockUsers.acquireAgentLock.resolves(true);
|
||||
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
|
||||
expect(result.acquired).to.equal(true);
|
||||
expect(result.required).to.equal(true);
|
||||
expect(mockUsers.acquireAgentLock.calledOnce).to.equal(true);
|
||||
});
|
||||
|
||||
it('should return acquired: false when lock is already held by another process', async () => {
|
||||
mockUsers.acquireAgentLock.resolves(false);
|
||||
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
|
||||
expect(result.acquired).to.equal(false);
|
||||
expect(result.required).to.equal(true);
|
||||
expect(mockUsers.acquireAgentLock.calledOnce).to.equal(true);
|
||||
});
|
||||
|
||||
it('should call releaseAgentLock when unlock is called', async () => {
|
||||
mockUsers.acquireAgentLock.resolves(true);
|
||||
mockUsers.releaseAgentLock.resolves(true);
|
||||
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
await result.unlock();
|
||||
|
||||
expect(mockUsers.releaseAgentLock.calledOnce).to.equal(true);
|
||||
expect(mockUsers.releaseAgentLock.firstCall.args[0]).to.equal('agent1');
|
||||
expect(mockUsers.releaseAgentLock.firstCall.args[1]).to.be.instanceOf(Date);
|
||||
});
|
||||
|
||||
it('should skip lock acquisition for bot agents', async () => {
|
||||
mockHasRoleAsync.resolves(true);
|
||||
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
|
||||
expect(result.acquired).to.equal(false);
|
||||
expect(result.required).to.equal(false);
|
||||
expect(mockUsers.acquireAgentLock.called).to.equal(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('when waiting_queue is disabled', () => {
|
||||
beforeEach(() => {
|
||||
mockSettings.get.withArgs('Livechat_waiting_queue').returns(false);
|
||||
});
|
||||
|
||||
it('should return acquired: false and required: false without calling acquireAgentLock', async () => {
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
|
||||
expect(result.acquired).to.equal(false);
|
||||
expect(result.required).to.equal(false);
|
||||
expect(mockUsers.acquireAgentLock.called).to.equal(false);
|
||||
expect(mockHasRoleAsync.called).to.equal(false);
|
||||
});
|
||||
|
||||
it('should have a no-op unlock function', async () => {
|
||||
const result = await conditionalLockAgent('agent1');
|
||||
await result.unlock(); // should not throw an error
|
||||
|
||||
expect(mockUsers.releaseAgentLock.called).to.equal(false);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user