snapshot of https://github.com/RocketChat/Rocket.Chat.git (develop, 2026-09-16; blobs > 131072B omitted)
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
This commit is contained in:
@@ -0,0 +1,119 @@
|
||||
import type { IUser } from '@rocket.chat/core-typings';
|
||||
import { expect } from 'chai';
|
||||
import { beforeEach, describe, it } from 'mocha';
|
||||
import p from 'proxyquire';
|
||||
import sinon from 'sinon';
|
||||
|
||||
const sandbox = sinon.createSandbox();
|
||||
|
||||
const modelsMock = {
|
||||
Subscriptions: {
|
||||
findOneBannedSubscription: sandbox.stub(),
|
||||
countByRoomIdAndUserId: sandbox.stub(),
|
||||
},
|
||||
Rooms: {
|
||||
findOneById: sandbox.stub(),
|
||||
},
|
||||
TeamMember: {
|
||||
findOneByUserIdAndTeamId: sandbox.stub(),
|
||||
},
|
||||
Team: {
|
||||
findOneById: sandbox.stub(),
|
||||
},
|
||||
Users: {
|
||||
findOneById: sandbox.stub(),
|
||||
},
|
||||
};
|
||||
|
||||
const coreServicesMock = {
|
||||
Authorization: {
|
||||
hasPermission: sandbox.stub(),
|
||||
canAccessRoom: sandbox.stub(),
|
||||
},
|
||||
License: {
|
||||
hasModule: sandbox.stub(),
|
||||
},
|
||||
Abac: {
|
||||
canAccessObject: sandbox.stub(),
|
||||
},
|
||||
Settings: {
|
||||
get: sandbox.stub(),
|
||||
},
|
||||
};
|
||||
|
||||
const canAccessRoomLivechatMock = sandbox.stub();
|
||||
|
||||
const { canAccessRoom } = p.noCallThru().load('../../../../../server/services/authorization/canAccessRoom.ts', {
|
||||
'@rocket.chat/models': modelsMock,
|
||||
'@rocket.chat/core-services': coreServicesMock,
|
||||
'./canAccessRoomLivechat': { canAccessRoomLivechat: canAccessRoomLivechatMock },
|
||||
});
|
||||
|
||||
describe('canAccessRoom', () => {
|
||||
beforeEach(() => {
|
||||
sandbox.reset();
|
||||
|
||||
// sane defaults: everything denies access unless a test says otherwise
|
||||
modelsMock.Subscriptions.findOneBannedSubscription.resolves(null);
|
||||
modelsMock.Subscriptions.countByRoomIdAndUserId.resolves(0);
|
||||
modelsMock.Rooms.findOneById.resolves(null);
|
||||
modelsMock.TeamMember.findOneByUserIdAndTeamId.resolves(null);
|
||||
modelsMock.Team.findOneById.resolves(null);
|
||||
modelsMock.Users.findOneById.resolves(null);
|
||||
coreServicesMock.Authorization.hasPermission.resolves(false);
|
||||
coreServicesMock.Authorization.canAccessRoom.resolves(false);
|
||||
coreServicesMock.License.hasModule.resolves(false);
|
||||
coreServicesMock.Abac.canAccessObject.resolves(false);
|
||||
coreServicesMock.Settings.get.resolves(false);
|
||||
canAccessRoomLivechatMock.resolves(false);
|
||||
});
|
||||
|
||||
describe('user hydration', () => {
|
||||
it('should hydrate a partial user before running the validators', async () => {
|
||||
const fullUser = { _id: 'user-id', username: 'john.doe', roles: ['user'] };
|
||||
modelsMock.Users.findOneById.resolves(fullUser);
|
||||
coreServicesMock.Authorization.hasPermission.resolves(true);
|
||||
|
||||
const result = await canAccessRoom({ _id: 'room-id', t: 'c' }, { _id: 'user-id' });
|
||||
|
||||
expect(result).to.be.true;
|
||||
expect(modelsMock.Users.findOneById.calledOnceWith('user-id')).to.be.true;
|
||||
expect(coreServicesMock.Authorization.hasPermission.calledWith(fullUser, 'view-c-room')).to.be.true;
|
||||
});
|
||||
|
||||
it('should throw when the partial user cannot be found', async () => {
|
||||
await expect(canAccessRoom({ _id: 'room-id', t: 'c' }, { _id: 'user-id' })).to.be.rejectedWith('User not found');
|
||||
});
|
||||
|
||||
it('should not hydrate a full user', async () => {
|
||||
await canAccessRoom({ _id: 'room-id', t: 'c' }, { _id: 'user-id', username: 'john.doe' } as IUser);
|
||||
|
||||
expect(modelsMock.Users.findOneById.notCalled).to.be.true;
|
||||
});
|
||||
|
||||
it('should not hydrate an undefined user', async () => {
|
||||
await canAccessRoom({ _id: 'room-id', t: 'c' }, undefined);
|
||||
|
||||
expect(modelsMock.Users.findOneById.notCalled).to.be.true;
|
||||
});
|
||||
|
||||
it('should not hydrate a user whose _id is undefined, and treat it as anonymous instead of throwing when anonymous read is on', async () => {
|
||||
coreServicesMock.Settings.get.resolves(true);
|
||||
|
||||
const result = await canAccessRoom({ _id: 'room-id', t: 'c' }, { _id: undefined });
|
||||
|
||||
expect(modelsMock.Users.findOneById.notCalled).to.be.true;
|
||||
expect(coreServicesMock.Settings.get.calledWith('Accounts_AllowAnonymousRead')).to.be.true;
|
||||
expect(result).to.be.true;
|
||||
});
|
||||
|
||||
it('should deny access to a user whose _id is undefined when anonymous read is off', async () => {
|
||||
coreServicesMock.Settings.get.resolves(false);
|
||||
|
||||
const result = await canAccessRoom({ _id: 'room-id', t: 'c' }, { _id: undefined });
|
||||
|
||||
expect(modelsMock.Users.findOneById.notCalled).to.be.true;
|
||||
expect(result).to.be.false;
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user