Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Code scanning - action / CodeQL-Build (push) Failing after 2s
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
135 lines
4.2 KiB
TypeScript
135 lines
4.2 KiB
TypeScript
import { expect } from 'chai';
|
|
import { describe, it } from 'mocha';
|
|
import proxyquire from 'proxyquire';
|
|
import sinon from 'sinon';
|
|
|
|
const mocks = {
|
|
settingsGet: sinon.stub(),
|
|
findOneById: sinon.stub(),
|
|
utils: {
|
|
serveSvgAvatarInRequestedFormat: sinon.spy(),
|
|
wasFallbackModified: sinon.stub(),
|
|
setCacheAndDispositionHeaders: sinon.spy(),
|
|
serveAvatarFile: sinon.spy(),
|
|
},
|
|
avatarFindOneByRoomId: sinon.stub(),
|
|
getRoomName: sinon.stub(),
|
|
};
|
|
|
|
class CookiesMock {
|
|
public get = (_key: any, value: any) => value;
|
|
}
|
|
|
|
const { roomAvatar } = proxyquire.noCallThru().load('./room', {
|
|
'@rocket.chat/models': {
|
|
Rooms: {
|
|
findOneById: mocks.findOneById,
|
|
},
|
|
Avatars: {
|
|
findOneByRoomId: mocks.avatarFindOneByRoomId,
|
|
},
|
|
},
|
|
'./utils': mocks.utils,
|
|
'../../lib/rooms/roomCoordinator': {
|
|
roomCoordinator: {
|
|
getRoomName: mocks.getRoomName,
|
|
},
|
|
},
|
|
'meteor/ostrio:cookies': {
|
|
Cookies: CookiesMock,
|
|
},
|
|
});
|
|
|
|
describe('#roomAvatar()', () => {
|
|
const response = {
|
|
setHeader: sinon.spy(),
|
|
writeHead: sinon.spy(),
|
|
end: sinon.spy(),
|
|
};
|
|
const next = sinon.spy();
|
|
|
|
afterEach(() => {
|
|
mocks.settingsGet.reset();
|
|
mocks.avatarFindOneByRoomId.reset();
|
|
mocks.findOneById.reset();
|
|
|
|
response.setHeader.resetHistory();
|
|
response.writeHead.resetHistory();
|
|
response.end.resetHistory();
|
|
next.resetHistory();
|
|
|
|
Object.values(mocks.utils).forEach((mock) => ('reset' in mock ? mock.reset() : mock.resetHistory()));
|
|
});
|
|
|
|
it(`should do nothing if url is not in request object`, async () => {
|
|
await roomAvatar({}, response, next);
|
|
expect(next.called).to.be.false;
|
|
expect(response.setHeader.called).to.be.false;
|
|
expect(response.writeHead.called).to.be.false;
|
|
expect(response.end.called).to.be.false;
|
|
});
|
|
|
|
it(`should write 404 if room is not found`, async () => {
|
|
mocks.findOneById.returns(null);
|
|
await roomAvatar({ url: '/' }, response, next);
|
|
expect(next.called).to.be.false;
|
|
expect(response.setHeader.called).to.be.false;
|
|
expect(response.writeHead.calledWith(404)).to.be.true;
|
|
expect(response.end.calledOnce).to.be.true;
|
|
});
|
|
|
|
it(`should serve avatar file if found`, async () => {
|
|
const request = { url: '/roomId' };
|
|
|
|
const file = { uploadedAt: new Date(0), type: 'image/png', size: 100 };
|
|
|
|
mocks.findOneById.withArgs('roomId').returns({ _id: 'roomId' });
|
|
mocks.avatarFindOneByRoomId.withArgs('roomId').returns(file);
|
|
|
|
await roomAvatar(request, response, next);
|
|
|
|
expect(mocks.utils.setCacheAndDispositionHeaders.calledWith(request, response)).to.be.true;
|
|
expect(mocks.utils.serveAvatarFile.calledWith(file, request, response, next)).to.be.true;
|
|
});
|
|
|
|
it(`should serve parent room avatar file if current room avatar is not found`, async () => {
|
|
const request = { url: '/roomId' };
|
|
|
|
const file = { uploadedAt: new Date(0), type: 'image/png', size: 100 };
|
|
|
|
mocks.findOneById.withArgs('roomId').returns({ _id: 'roomId', prid: 'roomId2' });
|
|
mocks.findOneById.withArgs('roomId2').returns({ _id: 'roomId2' });
|
|
mocks.avatarFindOneByRoomId.withArgs('roomId2').returns(file);
|
|
|
|
await roomAvatar(request, response, next);
|
|
|
|
expect(mocks.utils.setCacheAndDispositionHeaders.calledWith(request, response)).to.be.true;
|
|
expect(mocks.utils.serveAvatarFile.calledWith(file, request, response, next)).to.be.true;
|
|
});
|
|
|
|
it(`should write 304 if fallback content is not modified`, async () => {
|
|
const request = { url: '/roomId', headers: {} };
|
|
|
|
mocks.findOneById.withArgs('roomId').returns({ _id: 'roomId' });
|
|
mocks.utils.wasFallbackModified.returns(false);
|
|
await roomAvatar(request, response, next);
|
|
|
|
expect(mocks.utils.setCacheAndDispositionHeaders.calledWith(request, response)).to.be.true;
|
|
expect(response.writeHead.calledWith(304)).to.be.true;
|
|
expect(response.end.calledOnce).to.be.true;
|
|
});
|
|
|
|
it(`should serve svg fallback if no file found`, async () => {
|
|
const request = { url: '/roomId', headers: { cookie: 'userId' } };
|
|
|
|
mocks.utils.wasFallbackModified.returns(true);
|
|
mocks.findOneById.withArgs('roomId').returns({ _id: 'roomId' });
|
|
mocks.getRoomName.returns('roomName');
|
|
|
|
await roomAvatar(request, response, next);
|
|
|
|
expect(mocks.utils.setCacheAndDispositionHeaders.calledWith(request, response)).to.be.true;
|
|
expect(mocks.utils.serveSvgAvatarInRequestedFormat.calledWith({ nameOrUsername: 'roomName', req: request, res: response })).to.be.true;
|
|
});
|
|
});
|