Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 2s
381 lines
10 KiB
TypeScript
381 lines
10 KiB
TypeScript
import type { Credentials } from '@rocket.chat/api-client';
|
|
import type { IRoom, IUser } from '@rocket.chat/core-typings';
|
|
import { expect } from 'chai';
|
|
import { after, before, it } from 'mocha';
|
|
import type { Response } from 'supertest';
|
|
|
|
import { api, request, credentials } from './api-data';
|
|
import { imgURL, soundURL } from './interactions';
|
|
import { updateSetting } from './permissions.helper';
|
|
import { addUserToRoom, createRoom, deleteRoom } from './rooms.helper';
|
|
import { password } from './user';
|
|
import { createUser, deleteUser, login } from './users.helper';
|
|
|
|
export async function testFileUploads(
|
|
filesEndpoint: 'channels.files' | 'groups.files' | 'im.files',
|
|
roomType: 'c' | 'd' | 'p',
|
|
invalidRoomError = 'error-room-not-found',
|
|
) {
|
|
let testRoom: IRoom;
|
|
const propertyMap = {
|
|
c: 'channel',
|
|
p: 'group',
|
|
d: 'room',
|
|
};
|
|
let user: any;
|
|
|
|
before(async () => {
|
|
await Promise.all([updateSetting('Message_KeepHistory', true)]);
|
|
user = await createUser();
|
|
|
|
testRoom = (
|
|
await createRoom({
|
|
type: roomType,
|
|
...(roomType === 'd' ? { username: user.username } : { name: `channel-files-${Date.now()}` }),
|
|
} as any)
|
|
).body[propertyMap[roomType]];
|
|
});
|
|
|
|
after(() =>
|
|
Promise.all([deleteRoom({ type: 'c' as const, roomId: testRoom._id }), updateSetting('Message_KeepHistory', false), deleteUser(user)]),
|
|
);
|
|
|
|
it('should fail if invalid channel', (done) => {
|
|
void request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: 'invalid',
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(400)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', false);
|
|
expect(res.body).to.have.property('errorType', invalidRoomError);
|
|
})
|
|
.end(done);
|
|
});
|
|
|
|
it('should succeed when searching by roomId', (done) => {
|
|
void request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array');
|
|
})
|
|
.end(done);
|
|
});
|
|
|
|
it('should succeed when searching by roomId even requested with count and offset params', (done) => {
|
|
void request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
count: 5,
|
|
offset: 0,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array');
|
|
})
|
|
.end(done);
|
|
});
|
|
|
|
it('should succeed when searching by roomName', function (done) {
|
|
if (!testRoom.name) {
|
|
this.skip();
|
|
}
|
|
void request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomName: testRoom.name,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array');
|
|
})
|
|
.end(done);
|
|
});
|
|
|
|
it('should succeed when searching by roomName even requested with count and offset params', function (done) {
|
|
if (!testRoom.name) {
|
|
this.skip();
|
|
}
|
|
void request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomName: testRoom.name,
|
|
count: 5,
|
|
offset: 0,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array');
|
|
})
|
|
.end(done);
|
|
});
|
|
|
|
let fileId: string;
|
|
it('should not return thumbnails', async () => {
|
|
await request
|
|
.post(api(`rooms.media/${testRoom._id}`))
|
|
.set(credentials)
|
|
.attach('file', imgURL)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
fileId = res.body.file._id;
|
|
});
|
|
|
|
await request
|
|
.post(api(`rooms.mediaConfirm/${testRoom._id}/${fileId}`))
|
|
.set(credentials)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200);
|
|
|
|
await request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array').with.lengthOf(1);
|
|
|
|
const { files } = res.body;
|
|
|
|
files.forEach((file: unknown) => {
|
|
expect(file).to.not.have.property('originalFileId');
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should not return hidden files', async () => {
|
|
let msgId;
|
|
|
|
await request
|
|
.post(api(`rooms.media/${testRoom._id}`))
|
|
.set(credentials)
|
|
.attach('file', imgURL)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
fileId = res.body.file._id;
|
|
});
|
|
await request
|
|
.post(api(`rooms.mediaConfirm/${testRoom._id}/${fileId}`))
|
|
.set(credentials)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
msgId = res.body.message._id;
|
|
});
|
|
|
|
await request
|
|
.post(api('chat.delete'))
|
|
.set(credentials)
|
|
.send({
|
|
roomId: testRoom._id,
|
|
msgId,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200);
|
|
|
|
await request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array').with.lengthOf(1);
|
|
|
|
const { files } = res.body;
|
|
files.forEach((file: unknown) => {
|
|
expect(file).to.have.property('_id').to.not.be.equal(fileId);
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should properly filter files by name or typeGroup', async () => {
|
|
const fileOneName = 'image-zyxwv.png';
|
|
const fileTwoName = 'sound-abcde.png';
|
|
const fileIdsToConfirm: string[] = [];
|
|
|
|
// Post 2 files, one image and one audio
|
|
await Promise.all([
|
|
request
|
|
.post(api(`rooms.media/${testRoom._id}`))
|
|
.set(credentials)
|
|
.attach('file', imgURL, { filename: fileOneName })
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(typeof res.body?.file?._id).to.equal('string');
|
|
fileIdsToConfirm.push(res.body.file._id);
|
|
}),
|
|
request
|
|
.post(api(`rooms.media/${testRoom._id}`))
|
|
.set(credentials)
|
|
.attach('file', soundURL, { filename: fileTwoName })
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(typeof res.body?.file?._id).to.equal('string');
|
|
fileIdsToConfirm.push(res.body.file._id);
|
|
}),
|
|
]);
|
|
|
|
// Confirm the files
|
|
await Promise.all(
|
|
fileIdsToConfirm.map((fileId) =>
|
|
request
|
|
.post(api(`rooms.mediaConfirm/${testRoom._id}/${fileId}`))
|
|
.set(credentials)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200),
|
|
),
|
|
);
|
|
|
|
// test filtering by name
|
|
const nameFilterTest = request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
name: fileOneName,
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array').with.lengthOf(1);
|
|
|
|
const { files } = res.body;
|
|
|
|
expect(files[0].name).to.equal(fileOneName);
|
|
});
|
|
|
|
// test filtering by typeGroup
|
|
const typeGroupFilterTest = request
|
|
.get(api(filesEndpoint))
|
|
.set(credentials)
|
|
.query({
|
|
roomId: testRoom._id,
|
|
typeGroup: 'audio',
|
|
})
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
expect(res.body).to.have.property('files').and.to.be.an('array').with.lengthOf(1);
|
|
|
|
const { files } = res.body;
|
|
|
|
expect(files[0].name).to.equal(fileTwoName);
|
|
});
|
|
|
|
await Promise.all([nameFilterTest, typeGroupFilterTest]);
|
|
});
|
|
|
|
describe('with another user', () => {
|
|
let anotherUserCreds: Credentials;
|
|
let anotherUser: IUser;
|
|
let extraRoom: IRoom;
|
|
|
|
before(async () => {
|
|
anotherUser = await createUser();
|
|
anotherUserCreds = await login(anotherUser.username, password);
|
|
|
|
extraRoom = (
|
|
await createRoom({
|
|
type: roomType,
|
|
...(roomType === 'd' ? { username: user.username } : { name: `channel-files-${Date.now()}` }),
|
|
credentials: anotherUserCreds,
|
|
} as any)
|
|
).body[propertyMap[roomType]];
|
|
|
|
if (roomType === 'p') {
|
|
await addUserToRoom({
|
|
rid: testRoom._id,
|
|
usernames: [anotherUser.username!],
|
|
type: 'p',
|
|
});
|
|
}
|
|
});
|
|
|
|
after(() => Promise.all([deleteUser(anotherUser), deleteRoom({ type: roomType, roomId: extraRoom._id })]));
|
|
|
|
it('should not allow to confirm a file from another user', async function () {
|
|
if (roomType === 'd') {
|
|
this.skip();
|
|
}
|
|
|
|
let fileId: string;
|
|
await request
|
|
.post(api(`rooms.media/${testRoom._id}`))
|
|
.set(anotherUserCreds)
|
|
.attach('file', imgURL)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
fileId = res.body.file._id;
|
|
});
|
|
|
|
await request
|
|
.post(api(`rooms.mediaConfirm/${testRoom._id}/${fileId!}`))
|
|
.set(credentials)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(400);
|
|
});
|
|
|
|
it('should not allow to confirm a file that was not uploaded to the same room', async () => {
|
|
let fileId: string;
|
|
|
|
await request
|
|
.post(api(`rooms.media/${extraRoom._id}`))
|
|
.set(anotherUserCreds)
|
|
.attach('file', imgURL)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(200)
|
|
.expect((res: Response) => {
|
|
expect(res.body).to.have.property('success', true);
|
|
fileId = res.body.file._id;
|
|
});
|
|
|
|
await request
|
|
.post(api(`rooms.mediaConfirm/${testRoom._id}/${fileId!}`))
|
|
.set(credentials)
|
|
.expect('Content-Type', 'application/json')
|
|
.expect(400);
|
|
});
|
|
});
|
|
}
|