Some checks failed
Create issues from TODOs / todos (push) Failing after 3s
Close inactive issues / close-issues (push) Has been cancelled
Deploy GitHub Pages / deploy-preview (push) Has been cancelled
CI / ⚙️ Variables Setup (push) Has been cancelled
CI / ⚙️ Test Guard (push) Has been cancelled
CI / 🚀 Notify external services - draft (push) Has been cancelled
CI / 📦 Build Packages (push) Has been cancelled
CI / 📦 Meteor Build (coverage) (push) Has been cancelled
CI / 📦 Meteor Build (production) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [account-service presence-service omnichannel-transcript-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [authorization-service queue-worker-service ddp-streamer-service], fips) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Build Docker (amd64, [rocketchat], fips) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [account-service presence-service omnichannel-transcript-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [authorization-service queue-worker-service ddp-streamer-service], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], ${{ (github.event_name != 'release' && github.ref != 'refs/heads/develop') && 'coverage' || 'production' }}) (push) Has been cancelled
CI / 🚢 Build Docker (arm64, [rocketchat], coverage) (push) Has been cancelled
CI / 🚢 Publish Docker Images (ghcr.io) (push) Has been cancelled
CI / 📦 Track Image Sizes (push) Has been cancelled
CI / 🔎 Code Check - Action Lint (push) Has been cancelled
CI / 🔎 Code Check (push) Has been cancelled
CI / 🔨 Test Storybook (push) Has been cancelled
CI / 🔨 Test Unit (push) Has been cancelled
CI / 🔨 Test API (CE) (push) Has been cancelled
CI / 🔨 Test API Livechat (CE) (push) Has been cancelled
CI / 🔨 Test UI (CE) (push) Has been cancelled
CI / 🔨 Test API (EE) (push) Has been cancelled
CI / 🔨 Test API Livechat (EE) (push) Has been cancelled
CI / 🔨 Test API Apps (deno-runtime - EE) (push) Has been cancelled
CI / 🔨 Test UI (EE) (push) Has been cancelled
CI / 🔨 Test API (FIPS) (push) Has been cancelled
CI / 🔨 Test API Livechat (FIPS) (push) Has been cancelled
CI / 🔨 Test UI (FIPS) (push) Has been cancelled
CI / 🔨 Test Federation Matrix (push) Has been cancelled
CI / 📊 Report Coverage (push) Has been cancelled
CI / ✅ Tests Done (push) Has been cancelled
CI / 🚀 Publish build assets (push) Has been cancelled
CI / 🚀 Publish Docker Images (DockerHub) (push) Has been cancelled
CI / 🚀 Notify external services (push) Has been cancelled
CI / Update Version Durability (push) Has been cancelled
Release / Release (push) Has been cancelled
Auto-close duplicate issues / auto-close-duplicates (push) Failing after 1s
Code scanning - action / CodeQL-Build (push) Failing after 1s
75 lines
2.5 KiB
TypeScript
75 lines
2.5 KiB
TypeScript
import { expect } from 'chai';
|
|
import { describe, it, beforeEach } from 'mocha';
|
|
import proxyquire from 'proxyquire';
|
|
import sinon from 'sinon';
|
|
|
|
const retrieveCredential = sinon.stub().resolves(null);
|
|
const removeById = sinon.stub().resolves();
|
|
const samlUtilsMock = {
|
|
serviceProviders: [{ provider: 'test-saml' }] as any[],
|
|
log: sinon.stub(),
|
|
mapProfileToUserObject: sinon.stub(),
|
|
events: { emit: sinon.stub() },
|
|
};
|
|
|
|
const handler = sinon.stub();
|
|
proxyquire.noCallThru().load('../../../../../server/lib/saml/loginHandler', {
|
|
'@rocket.chat/models': {
|
|
CredentialTokens: { removeById },
|
|
},
|
|
'meteor/accounts-base': {
|
|
Accounts: {
|
|
LoginCancelledError: { numericError: 403 },
|
|
registerLoginHandler: (_name: string, fn: any) => {
|
|
handler.callsFake(fn);
|
|
},
|
|
},
|
|
},
|
|
'meteor/meteor': {
|
|
Meteor: { Error },
|
|
},
|
|
'./lib/SAML': {
|
|
SAML: { retrieveCredential },
|
|
},
|
|
'./lib/Utils': {
|
|
SAMLUtils: samlUtilsMock,
|
|
},
|
|
'../i18n': { i18n: { t: sinon.stub().returns('') } },
|
|
'../logger/system': { SystemLogger: { error: sinon.stub() } },
|
|
});
|
|
|
|
describe('SAML loginHandler', () => {
|
|
beforeEach(() => {
|
|
retrieveCredential.reset();
|
|
retrieveCredential.resolves(null);
|
|
removeById.reset();
|
|
removeById.resolves();
|
|
samlUtilsMock.serviceProviders = [{ provider: 'test-saml' }];
|
|
});
|
|
|
|
it('should reject non-string credentialToken and never query the database (NoSQL injection prevention)', async () => {
|
|
expect(await handler({ saml: true, credentialToken: { $gt: '' } })).to.be.undefined;
|
|
expect(await handler({ saml: true, credentialToken: { $ne: null } })).to.be.undefined;
|
|
expect(await handler({ saml: true, credentialToken: { $not: { $eq: '__nonexistent__' } } })).to.be.undefined;
|
|
expect(await handler({ saml: true, credentialToken: 123 })).to.be.undefined;
|
|
expect(await handler({ saml: true, credentialToken: ['a'] })).to.be.undefined;
|
|
expect(await handler({ saml: true, credentialToken: null })).to.be.undefined;
|
|
|
|
expect(retrieveCredential.called).to.be.false;
|
|
});
|
|
|
|
it('should return undefined when no SAML providers are configured', async () => {
|
|
samlUtilsMock.serviceProviders = [];
|
|
|
|
expect(await handler({ saml: true, credentialToken: 'valid-token' })).to.be.undefined;
|
|
expect(retrieveCredential.called).to.be.false;
|
|
});
|
|
|
|
it('should delete the credential token after retrieval', async () => {
|
|
await handler({ saml: true, credentialToken: 'token-to-delete' });
|
|
|
|
expect(removeById.calledOnce).to.be.true;
|
|
expect(removeById.calledWith('token-to-delete')).to.be.true;
|
|
});
|
|
});
|