snapshot of https://github.com/seaweedfs/seaweedfs.git (master, 2026-09-16; blobs > 131072B omitted)
Some checks failed
go: build dev binaries / cleanup (push) Successful in 4s
Codespell / Check for spelling errors (push) Failing after 3s
docker: build dev containers / build-rust-binaries (amd64, x86_64-unknown-linux-musl) (push) Failing after 3s
docker: build dev containers / build-dev-containers (push) Has been skipped
docker: build dev containers / build-rust-binaries (arm64, true, aarch64-unknown-linux-musl) (push) Failing after 3s
End to End / FUSE Mount (push) Failing after 2s
EC Integration Tests / EC Integration Tests (push) Failing after 30s
FUSE DLM Integration Tests / FUSE DLM Integration Tests (push) Failing after 3s
FUSE Volume Server Failover Tests / FUSE Volume Server Failover (push) Failing after 3s
FUSE Integration Tests / FUSE Integration Testing (push) Failing after 2s
FUSE P2P Peer Chunk Sharing Integration Tests / FUSE P2P Peer Chunk Sharing (push) Failing after 3s
go: build binary / Go Vet (push) Failing after 2s
go: build binary / Go Vet 32-bit (push) Failing after 3s
go: build binary / Build (push) Failing after 4s
go: build binary / Build cross-platform (freebsd/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (darwin/arm64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/arm64) (push) Failing after 3s
go: build binary / Test (push) Failing after 2s
go: build binary / Test 32-bit (push) Failing after 3s
helm: lint and test charts / lint-test (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (11) (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (17) (push) Failing after 3s
go: build dev binaries / build_dev_linux_windows (amd64, linux) (push) Failing after 2s
go: build dev binaries / build_dev_linux_windows (amd64, windows) (push) Failing after 3s
go: build dev binaries / build_dev_darwin (amd64, darwin) (push) Has been skipped
go: build dev binaries / build_dev_darwin (arm64, darwin) (push) Has been skipped
Java Client Unit Tests / Java Unit Tests (11) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (17) (push) Failing after 2s
Java Client Unit Tests / Java Unit Tests (21) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (8) (push) Failing after 3s
Kafka Quick Test (Load Test with Schema Registry) / Kafka Client Load Test (Quick) (push) Failing after 3s
Kafka Gateway Tests / Kafka Unit Tests (unit-tests-1) (push) Failing after 11s
Kafka Gateway Tests / Kafka Integration Tests (Critical) (integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka End-to-End Tests (with SMQ) (e2e-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Consumer Group Tests (Highly Isolated) (consumer-group-1) (push) Failing after 2s
Kafka Gateway Tests / Kafka Client Compatibility (with SMQ) (client-compat-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka SMQ Integration Tests (Full Stack) (smq-integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Protocol Tests (Isolated) (protocol-1) (push) Failing after 3s
KMS Tests / KMS Provider Integration Tests (push) Failing after 2s
KMS Tests / S3 KMS End-to-End Tests (push) Failing after 3s
Master Cold Start Tests / Master Cold Start Tests (push) Failing after 4s
Metadata Subscribe Integration Tests / Metadata Subscribe Integration Tests (push) Failing after 3s
Multi-Master Tests / Multi-Master Failover Tests (push) Failing after 3s
Performance / CPU and Heap Profile (push) Failing after 2s
Performance / S3 Read/Write Benchmark (rust volume) (push) Failing after 3s
pjdfstest POSIX Compliance / pjdfstest (push) Failing after 2s
Plugin Worker Integration Tests / Plugin Worker: erasure_coding (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: vacuum (push) Failing after 3s
Rust Volume Server Tests / Rust Integration Tests (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 1) (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 1) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 3) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Distributed Tests (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Performance Tests (push) Failing after 3s
Performance / Throughput Benchmark (go volume) (push) Failing after 3s
Performance / Throughput Benchmark (rust volume) (push) Failing after 2s
Performance / S3 Read/Write Benchmark (go volume) (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: volume_balance (push) Failing after 3s
PostgreSQL Gateway Tests / PostgreSQL Basic Tests (push) Failing after 3s
Rust Volume Server Tests / Rust Unit Tests (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 3) (push) Failing after 3s
Rust Plugin Worker Tests / Rust Plugin Worker Build and Unit Tests (push) Failing after 3s
rust: build dev volume server binaries / cleanup (push) Successful in 3s
S3 ETag and ACL Tests / S3 ETag + ACL Integration Tests (push) Failing after 3s
S3 IAM Integration Tests / IAM Unit Tests (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (advanced) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (basic) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (group) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (policy-enforcement) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (sts) (push) Failing after 4s
S3 Keycloak Integration Tests / S3 Keycloak Integration Tests (push) Failing after 3s
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.11) (push) Failing after 3s
S3 PyArrow Parquet Tests / Go Unit Tests (Implicit Directory) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.12) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-amd64, x86_64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-arm64, aarch64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.9) (push) Has been cancelled
S3 Proxy Signature Tests / S3 Proxy Signature Verification Tests (push) Has been cancelled
S3 SDK V2 Route Disambiguation Tests / S3 SDK V2 Routing Tests (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (quick) (push) Has been cancelled
S3 SSE Tests / S3 SSE Compatibility Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Metadata Persistence Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Copy Operations Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Multipart Upload Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Performance Test (push) Has been cancelled
S3 SSE Tests / S3 Volume Encryption Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (comprehensive) (push) Has been cancelled
Spark Integration Tests / Spark Integration Tests (push) Failing after 2s
Telemetry Integration Tests / telemetry-integration-test (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 1) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 1) (push) Failing after 3s
Ceph S3 tests / Basic S3 tests (KV store) (push) Has been cancelled
Ceph S3 tests / S3 Versioning & Object Lock tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Unit Tests (push) Failing after 3s
Ceph S3 tests / S3 CORS tests (push) Has been cancelled
Ceph S3 tests / SeaweedFS Custom S3 Copy tests (push) Has been cancelled
Ceph S3 tests / Basic S3 tests (SQL store) (push) Has been cancelled
test s3 over https using aws-cli / awscli-tests (push) Has been cancelled
TLS Rotation Integration Tests / TLS Rotation Integration Tests (push) Has been cancelled
Vacuum Integration Tests / Vacuum Integration Tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Variables Integration Tests (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (advanced-policy) (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (basic-policy) (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (contextual-policy) (push) Failing after 4s
S3 Policy Integration Tests / Trusted Proxy Detection Tests (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Shell Integration Tests (push) Failing after 3s
Samba on FUSE Integration / samba-integration (push) Failing after 2s
SFTP Integration Tests / SFTP Integration Testing (push) Failing after 3s
terraform: validate and test modules / fmt, validate, plan-level tests (push) Failing after 3s
terraform: validate and test modules / local cluster smoke test (real weed) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 3) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 2) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 2) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 3) (push) Failing after 5s
mount: windows conformance / WinFsp conformance (push) Has been cancelled
mount: windows / Mount on Windows (push) Has been cancelled

This commit is contained in:
upstream-mirror
2026-09-16 03:23:42 +05:00
commit 89f5be005d
3997 changed files with 961970 additions and 0 deletions

90
weed/sftpd/auth/auth.go Normal file
View File

@@ -0,0 +1,90 @@
// Package auth provides authentication and authorization functionality for the SFTP server
package auth
import (
"fmt"
"github.com/seaweedfs/seaweedfs/weed/sftpd/user"
"golang.org/x/crypto/ssh"
)
// Provider defines the interface for authentication providers
type Provider interface {
// GetAuthMethods returns the SSH server auth methods
GetAuthMethods() []ssh.AuthMethod
}
// Manager handles authentication and authorization
type Manager struct {
userStore user.Store
passwordAuth *PasswordAuthenticator
publicKeyAuth *PublicKeyAuthenticator
certificateAuth *CertificateAuthenticator
enabledAuthMethods []string
}
// NewManager creates a new authentication manager.
//
// trustedUserCAKeysFile is the path to a file containing trusted CA public
// keys (OpenSSH authorized_keys format). It is required when "certificate"
// is listed in enabledAuthMethods and ignored otherwise.
func NewManager(userStore user.Store, enabledAuthMethods []string, trustedUserCAKeysFile string) (*Manager, error) {
manager := &Manager{
userStore: userStore,
enabledAuthMethods: enabledAuthMethods,
}
// Initialize authenticators based on enabled methods
passwordEnabled := false
publicKeyEnabled := false
certificateEnabled := false
for _, method := range enabledAuthMethods {
switch method {
case "password":
passwordEnabled = true
case "publickey":
publicKeyEnabled = true
case "certificate":
certificateEnabled = true
}
}
manager.passwordAuth = NewPasswordAuthenticator(userStore, passwordEnabled)
manager.publicKeyAuth = NewPublicKeyAuthenticator(userStore, publicKeyEnabled)
certAuth, err := NewCertificateAuthenticator(userStore, certificateEnabled, trustedUserCAKeysFile)
if err != nil {
return nil, fmt.Errorf("init certificate auth: %w", err)
}
manager.certificateAuth = certAuth
return manager, nil
}
// GetSSHServerConfig returns an SSH server config with the appropriate authentication methods
func (m *Manager) GetSSHServerConfig() *ssh.ServerConfig {
config := &ssh.ServerConfig{}
// Add password authentication if enabled
if m.passwordAuth.Enabled() {
config.PasswordCallback = m.passwordAuth.Authenticate
}
// Wire the public-key channel. Certificate auth, when enabled, takes
// over the channel entirely (MinIO/OpenSSH-style): plain public keys
// are rejected even if "publickey" is also listed in enabledAuthMethods.
switch {
case m.certificateAuth.Enabled():
config.PublicKeyCallback = m.certificateAuth.Authenticate
case m.publicKeyAuth.Enabled():
config.PublicKeyCallback = m.publicKeyAuth.Authenticate
}
return config
}
// GetUser retrieves a user from the user store
func (m *Manager) GetUser(username string) (*user.User, error) {
return m.userStore.GetUser(username)
}

View File

@@ -0,0 +1,79 @@
package auth
import (
"strings"
"testing"
"time"
"golang.org/x/crypto/ssh"
)
// When both "publickey" and "certificate" are enabled, certificate auth takes
// over the public-key channel: plain keys are rejected, certs are accepted, and
// password auth stays independently wired.
func TestManager_CertificateTakesOverPublicKeyChannel(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
mgr, err := NewManager(store, []string{"password", "publickey", "certificate"}, env.caKeyFile)
if err != nil {
t.Fatalf("NewManager: %v", err)
}
cfg := mgr.GetSSHServerConfig()
if cfg.PasswordCallback == nil {
t.Fatal("expected password callback to stay wired")
}
if cfg.PublicKeyCallback == nil {
t.Fatal("expected public-key callback")
}
// Plain public key is rejected by the certificate authenticator.
if _, err := cfg.PublicKeyCallback(&fakeConnMetadata{user: "alice"}, env.userSigner.PublicKey()); err == nil {
t.Fatal("expected plain public key to be rejected")
} else if !strings.Contains(err.Error(), "public key without certificate") {
t.Fatalf("expected certificate-channel rejection, got %v", err)
}
// A valid cert is accepted.
cert := env.signCert(t, ssh.UserCert, []string{"alice"},
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
perms, err := cfg.PublicKeyCallback(&fakeConnMetadata{user: "alice"}, cert)
if err != nil {
t.Fatalf("expected cert to be accepted: %v", err)
}
if perms.Extensions["username"] != "alice" {
t.Fatalf("expected username extension alice, got %q", perms.Extensions["username"])
}
}
// Without "certificate", the public-key channel keeps plain public-key auth.
func TestManager_PublicKeyOnlyChannel(t *testing.T) {
mgr, err := NewManager(newStubStore("alice"), []string{"publickey"}, "")
if err != nil {
t.Fatalf("NewManager: %v", err)
}
cfg := mgr.GetSSHServerConfig()
if cfg.PublicKeyCallback == nil {
t.Fatal("expected public-key callback")
}
env := newTestEnv(t)
// Routes to plain public-key auth (stub store has no registered key), which
// fails with a different error than the certificate channel would.
_, err = cfg.PublicKeyCallback(&fakeConnMetadata{user: "alice"}, env.userSigner.PublicKey())
if err == nil {
t.Fatal("expected authentication failure")
}
if strings.Contains(err.Error(), "without certificate") {
t.Fatalf("certificate auth should not be wired, got %v", err)
}
}
// Enabling certificate auth without a CA keys file is a hard configuration error.
func TestManager_CertificateRequiresCAFile(t *testing.T) {
if _, err := NewManager(newStubStore(), []string{"certificate"}, ""); err == nil {
t.Fatal("expected error when certificate auth enabled without CA keys file")
}
}

View File

@@ -0,0 +1,150 @@
package auth
import (
"bytes"
"crypto/subtle"
"errors"
"fmt"
"os"
"github.com/seaweedfs/seaweedfs/weed/sftpd/user"
"golang.org/x/crypto/ssh"
)
// CertificateAuthenticator authenticates clients that present an OpenSSH
// user certificate signed by one of the configured trusted CA public keys.
//
// Behaviour mirrors MinIO's --sftp=trusted-user-ca-key option and OpenSSH's
// TrustedUserCAKeys directive: when enabled, only key blobs of type
// *ssh.Certificate are accepted on the public-key channel. Plain public
// keys are rejected. The SSH login username must appear in the cert's
// ValidPrincipals list and must resolve to an existing user in the store.
type CertificateAuthenticator struct {
userStore user.Store
enabled bool
trustedCAs []ssh.PublicKey
checker *ssh.CertChecker
}
// NewCertificateAuthenticator constructs a CertificateAuthenticator.
// When enabled is true, caKeysFile must point to a file containing one or
// more CA public keys in OpenSSH authorized_keys format (one per line).
func NewCertificateAuthenticator(userStore user.Store, enabled bool, caKeysFile string) (*CertificateAuthenticator, error) {
a := &CertificateAuthenticator{
userStore: userStore,
enabled: enabled,
}
if !enabled {
return a, nil
}
if caKeysFile == "" {
return nil, fmt.Errorf("certificate auth enabled but no trustedUserCAKeysFile provided")
}
cas, err := loadAuthorizedKeysFile(caKeysFile)
if err != nil {
return nil, fmt.Errorf("load trusted user CA keys from %s: %w", caKeysFile, err)
}
if len(cas) == 0 {
return nil, fmt.Errorf("no trusted user CA keys found in %s", caKeysFile)
}
a.trustedCAs = cas
// Pre-marshal trusted CA keys once. IsUserAuthority runs on every
// authentication attempt, so caching the marshaled form avoids
// repeated allocations on the hot path.
trustedCAsMarshaled := make([][]byte, len(cas))
for i, ca := range cas {
trustedCAsMarshaled[i] = ca.Marshal()
}
a.checker = &ssh.CertChecker{
IsUserAuthority: func(auth ssh.PublicKey) bool {
marshaled := auth.Marshal()
for _, caBytes := range trustedCAsMarshaled {
if subtle.ConstantTimeCompare(marshaled, caBytes) == 1 {
return true
}
}
return false
},
}
return a, nil
}
// Enabled reports whether certificate authentication is active.
func (a *CertificateAuthenticator) Enabled() bool {
return a.enabled
}
// Authenticate implements ssh.ServerConfig.PublicKeyCallback.
func (a *CertificateAuthenticator) Authenticate(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) {
if !a.enabled {
return nil, fmt.Errorf("certificate authentication disabled")
}
cert, ok := key.(*ssh.Certificate)
if !ok {
return nil, fmt.Errorf("public key without certificate not allowed")
}
if cert.CertType != ssh.UserCert {
return nil, fmt.Errorf("certificate is not a user certificate")
}
if len(cert.ValidPrincipals) == 0 {
return nil, fmt.Errorf("certificate has no valid principals")
}
username := conn.User()
// CertChecker.Authenticate verifies the CA signature (via IsUserAuthority),
// the ValidAfter/ValidBefore window, and that username is in ValidPrincipals.
perms, err := a.checker.Authenticate(conn, key)
if err != nil {
return nil, fmt.Errorf("certificate validation failed: %w", err)
}
// The SSH login user must exist in the SeaweedFS user store.
if _, err := a.userStore.GetUser(username); err != nil {
var notFound *user.UserNotFoundError
if errors.As(err, &notFound) {
return nil, fmt.Errorf("user %q not found", username)
}
return nil, fmt.Errorf("lookup user %q: %w", username, err)
}
if perms == nil {
perms = &ssh.Permissions{}
}
if perms.Extensions == nil {
perms.Extensions = map[string]string{}
}
perms.Extensions["username"] = username
return perms, nil
}
// loadAuthorizedKeysFile parses an authorized_keys-style file and returns
// all public keys found in it. Blank lines and comment lines starting with
// '#' are skipped.
func loadAuthorizedKeysFile(path string) ([]ssh.PublicKey, error) {
data, err := os.ReadFile(path)
if err != nil {
return nil, err
}
var keys []ssh.PublicKey
for _, line := range bytes.Split(data, []byte("\n")) {
line = bytes.TrimSpace(line)
if len(line) == 0 || line[0] == '#' {
continue
}
pub, _, _, _, err := ssh.ParseAuthorizedKey(line)
if err != nil {
return nil, err
}
keys = append(keys, pub)
}
return keys, nil
}

View File

@@ -0,0 +1,312 @@
package auth
import (
"crypto/ed25519"
"crypto/rand"
"errors"
"net"
"os"
"path/filepath"
"strings"
"testing"
"time"
"github.com/seaweedfs/seaweedfs/weed/sftpd/user"
"golang.org/x/crypto/ssh"
)
// stubStore is a minimal user.Store for auth tests.
type stubStore struct {
users map[string]*user.User
}
func newStubStore(usernames ...string) *stubStore {
s := &stubStore{users: map[string]*user.User{}}
for _, name := range usernames {
s.users[name] = &user.User{Username: name}
}
return s
}
func (s *stubStore) GetUser(username string) (*user.User, error) {
if u, ok := s.users[username]; ok {
return u, nil
}
return nil, &user.UserNotFoundError{Username: username}
}
func (s *stubStore) ValidatePassword(string, []byte) bool { return false }
func (s *stubStore) ValidatePublicKey(string, string) bool { return false }
func (s *stubStore) GetUserPermissions(string, string) []string { return nil }
func (s *stubStore) SaveUser(*user.User) error { return nil }
func (s *stubStore) DeleteUser(string) error { return nil }
func (s *stubStore) ListUsers() ([]string, error) { return nil, nil }
// fakeConnMetadata satisfies ssh.ConnMetadata for the parts CertChecker uses.
type fakeConnMetadata struct {
user string
}
func (c *fakeConnMetadata) User() string { return c.user }
func (c *fakeConnMetadata) SessionID() []byte { return []byte("session") }
func (c *fakeConnMetadata) ClientVersion() []byte { return []byte("SSH-2.0-test") }
func (c *fakeConnMetadata) ServerVersion() []byte { return []byte("SSH-2.0-test") }
func (c *fakeConnMetadata) RemoteAddr() net.Addr { return &fakeAddr{} }
func (c *fakeConnMetadata) LocalAddr() net.Addr { return &fakeAddr{} }
type fakeAddr struct{}
func (fakeAddr) Network() string { return "tcp" }
func (fakeAddr) String() string { return "127.0.0.1:0" }
// testEnv bundles a CA, a user signer, and a temp dir for a single test.
type testEnv struct {
caSigner ssh.Signer
userSigner ssh.Signer
caKeyFile string
}
func newTestEnv(t *testing.T) *testEnv {
t.Helper()
_, caPriv, err := ed25519.GenerateKey(rand.Reader)
if err != nil {
t.Fatalf("ed25519 CA: %v", err)
}
caSigner, err := ssh.NewSignerFromKey(caPriv)
if err != nil {
t.Fatalf("ca signer: %v", err)
}
_, userPriv, err := ed25519.GenerateKey(rand.Reader)
if err != nil {
t.Fatalf("ed25519 user: %v", err)
}
userSigner, err := ssh.NewSignerFromKey(userPriv)
if err != nil {
t.Fatalf("user signer: %v", err)
}
dir := t.TempDir()
caFile := filepath.Join(dir, "ca_user.pub")
if err := os.WriteFile(caFile, ssh.MarshalAuthorizedKey(caSigner.PublicKey()), 0o600); err != nil {
t.Fatalf("write ca file: %v", err)
}
return &testEnv{caSigner: caSigner, userSigner: userSigner, caKeyFile: caFile}
}
// signCert produces a user cert signed by the test CA.
func (e *testEnv) signCert(t *testing.T, certType uint32, principals []string, validAfter, validBefore time.Time) *ssh.Certificate {
t.Helper()
cert := &ssh.Certificate{
Key: e.userSigner.PublicKey(),
CertType: certType,
ValidPrincipals: principals,
ValidAfter: uint64(validAfter.Unix()),
ValidBefore: uint64(validBefore.Unix()),
}
if err := cert.SignCert(rand.Reader, e.caSigner); err != nil {
t.Fatalf("sign cert: %v", err)
}
return cert
}
func TestCertificateAuthenticator_GoldenPath(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, err := NewCertificateAuthenticator(store, true, env.caKeyFile)
if err != nil {
t.Fatalf("new: %v", err)
}
cert := env.signCert(t, ssh.UserCert, []string{"alice"},
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
perms, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert)
if err != nil {
t.Fatalf("Authenticate: %v", err)
}
if perms.Extensions["username"] != "alice" {
t.Fatalf("expected username extension alice, got %q", perms.Extensions["username"])
}
}
func TestCertificateAuthenticator_RejectsPlainPublicKey(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, err := NewCertificateAuthenticator(store, true, env.caKeyFile)
if err != nil {
t.Fatalf("new: %v", err)
}
_, err = a.Authenticate(&fakeConnMetadata{user: "alice"}, env.userSigner.PublicKey())
if err == nil {
t.Fatal("expected rejection of plain public key, got nil")
}
if !strings.Contains(err.Error(), "public key without certificate") {
t.Fatalf("unexpected error: %v", err)
}
}
func TestCertificateAuthenticator_RejectsHostCert(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
cert := env.signCert(t, ssh.HostCert, []string{"alice"},
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
if _, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert); err == nil {
t.Fatal("expected rejection of host cert, got nil")
}
}
func TestCertificateAuthenticator_RejectsEmptyPrincipals(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
cert := env.signCert(t, ssh.UserCert, nil,
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
_, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert)
if err == nil || !strings.Contains(err.Error(), "no valid principals") {
t.Fatalf("expected empty-principals rejection, got %v", err)
}
}
func TestCertificateAuthenticator_RejectsWrongPrincipal(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice", "bob")
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
cert := env.signCert(t, ssh.UserCert, []string{"bob"},
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
if _, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert); err == nil {
t.Fatal("expected wrong-principal rejection, got nil")
}
}
func TestCertificateAuthenticator_RejectsExpiredCert(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
cert := env.signCert(t, ssh.UserCert, []string{"alice"},
time.Now().Add(-2*time.Hour), time.Now().Add(-time.Hour))
if _, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert); err == nil {
t.Fatal("expected expired-cert rejection, got nil")
}
}
func TestCertificateAuthenticator_RejectsUnknownCA(t *testing.T) {
env := newTestEnv(t)
store := newStubStore("alice")
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
// Sign with a different CA.
_, otherCAPriv, _ := ed25519.GenerateKey(rand.Reader)
otherCASigner, _ := ssh.NewSignerFromKey(otherCAPriv)
cert := &ssh.Certificate{
Key: env.userSigner.PublicKey(),
CertType: ssh.UserCert,
ValidPrincipals: []string{"alice"},
ValidAfter: uint64(time.Now().Add(-time.Minute).Unix()),
ValidBefore: uint64(time.Now().Add(time.Hour).Unix()),
}
if err := cert.SignCert(rand.Reader, otherCASigner); err != nil {
t.Fatalf("sign: %v", err)
}
if _, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert); err == nil {
t.Fatal("expected unknown-CA rejection, got nil")
}
}
func TestCertificateAuthenticator_RejectsUnknownUser(t *testing.T) {
env := newTestEnv(t)
store := newStubStore() // no users
a, _ := NewCertificateAuthenticator(store, true, env.caKeyFile)
cert := env.signCert(t, ssh.UserCert, []string{"alice"},
time.Now().Add(-time.Minute), time.Now().Add(time.Hour))
_, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert)
if err == nil || !strings.Contains(err.Error(), "not found") {
t.Fatalf("expected user-not-found, got %v", err)
}
}
func TestCertificateAuthenticator_LoadsMultipleCAKeys(t *testing.T) {
env := newTestEnv(t)
// Append a second CA pubkey to the file.
_, ca2Priv, _ := ed25519.GenerateKey(rand.Reader)
ca2Signer, _ := ssh.NewSignerFromKey(ca2Priv)
f, err := os.OpenFile(env.caKeyFile, os.O_APPEND|os.O_WRONLY, 0)
if err != nil {
t.Fatalf("open: %v", err)
}
if _, err := f.Write(ssh.MarshalAuthorizedKey(ca2Signer.PublicKey())); err != nil {
t.Fatalf("write: %v", err)
}
f.Close()
store := newStubStore("alice")
a, err := NewCertificateAuthenticator(store, true, env.caKeyFile)
if err != nil {
t.Fatalf("new: %v", err)
}
if len(a.trustedCAs) != 2 {
t.Fatalf("expected 2 CAs, got %d", len(a.trustedCAs))
}
// A cert signed by the second CA should be accepted.
cert := &ssh.Certificate{
Key: env.userSigner.PublicKey(),
CertType: ssh.UserCert,
ValidPrincipals: []string{"alice"},
ValidAfter: uint64(time.Now().Add(-time.Minute).Unix()),
ValidBefore: uint64(time.Now().Add(time.Hour).Unix()),
}
if err := cert.SignCert(rand.Reader, ca2Signer); err != nil {
t.Fatalf("sign: %v", err)
}
if _, err := a.Authenticate(&fakeConnMetadata{user: "alice"}, cert); err != nil {
t.Fatalf("Authenticate with second CA: %v", err)
}
}
func TestNewCertificateAuthenticator_DisabledIgnoresFile(t *testing.T) {
a, err := NewCertificateAuthenticator(newStubStore(), false, "")
if err != nil {
t.Fatalf("new: %v", err)
}
if a.Enabled() {
t.Fatal("expected disabled")
}
}
func TestNewCertificateAuthenticator_EnabledRequiresFile(t *testing.T) {
_, err := NewCertificateAuthenticator(newStubStore(), true, "")
if err == nil {
t.Fatal("expected error when enabled without file")
}
}
func TestNewCertificateAuthenticator_MissingFile(t *testing.T) {
_, err := NewCertificateAuthenticator(newStubStore(), true, filepath.Join(t.TempDir(), "nope.pub"))
if err == nil {
t.Fatal("expected error for missing file")
}
// Sanity: not a not-found-user-style error.
var notFound *user.UserNotFoundError
if errors.As(err, &notFound) {
t.Fatalf("unexpected error type: %v", err)
}
}

View File

@@ -0,0 +1,53 @@
package auth
import (
"fmt"
"math/rand/v2"
"time"
"github.com/seaweedfs/seaweedfs/weed/sftpd/user"
"golang.org/x/crypto/ssh"
)
// PasswordAuthenticator handles password-based authentication
type PasswordAuthenticator struct {
userStore user.Store
enabled bool
}
// NewPasswordAuthenticator creates a new password authenticator
func NewPasswordAuthenticator(userStore user.Store, enabled bool) *PasswordAuthenticator {
return &PasswordAuthenticator{
userStore: userStore,
enabled: enabled,
}
}
// Enabled returns whether password authentication is enabled
func (a *PasswordAuthenticator) Enabled() bool {
return a.enabled
}
// Authenticate validates a password for a user
func (a *PasswordAuthenticator) Authenticate(conn ssh.ConnMetadata, password []byte) (*ssh.Permissions, error) {
username := conn.User()
// Check if password auth is enabled
if !a.enabled {
return nil, fmt.Errorf("password authentication disabled")
}
// Validate password against user store
if a.userStore.ValidatePassword(username, password) {
return &ssh.Permissions{
Extensions: map[string]string{
"username": username,
},
}, nil
}
// Add delay to prevent brute force attacks
time.Sleep(time.Duration(100+rand.IntN(100)) * time.Millisecond)
return nil, fmt.Errorf("authentication failed")
}

View File

@@ -0,0 +1,51 @@
package auth
import (
"fmt"
"github.com/seaweedfs/seaweedfs/weed/sftpd/user"
"golang.org/x/crypto/ssh"
)
// PublicKeyAuthenticator handles public key-based authentication
type PublicKeyAuthenticator struct {
userStore user.Store
enabled bool
}
// NewPublicKeyAuthenticator creates a new public key authenticator
func NewPublicKeyAuthenticator(userStore user.Store, enabled bool) *PublicKeyAuthenticator {
return &PublicKeyAuthenticator{
userStore: userStore,
enabled: enabled,
}
}
// Enabled returns whether public key authentication is enabled
func (a *PublicKeyAuthenticator) Enabled() bool {
return a.enabled
}
// Authenticate validates a public key for a user
func (a *PublicKeyAuthenticator) Authenticate(conn ssh.ConnMetadata, key ssh.PublicKey) (*ssh.Permissions, error) {
username := conn.User()
// Check if public key auth is enabled
if !a.enabled {
return nil, fmt.Errorf("public key authentication disabled")
}
// Convert key to string format for comparison
keyData := string(key.Marshal())
// Validate public key
if a.userStore.ValidatePublicKey(username, keyData) {
return &ssh.Permissions{
Extensions: map[string]string{
"username": username,
},
}, nil
}
return nil, fmt.Errorf("authentication failed")
}