Some checks failed
go: build dev binaries / cleanup (push) Successful in 4s
Codespell / Check for spelling errors (push) Failing after 3s
docker: build dev containers / build-rust-binaries (amd64, x86_64-unknown-linux-musl) (push) Failing after 3s
docker: build dev containers / build-dev-containers (push) Has been skipped
docker: build dev containers / build-rust-binaries (arm64, true, aarch64-unknown-linux-musl) (push) Failing after 3s
End to End / FUSE Mount (push) Failing after 2s
EC Integration Tests / EC Integration Tests (push) Failing after 30s
FUSE DLM Integration Tests / FUSE DLM Integration Tests (push) Failing after 3s
FUSE Volume Server Failover Tests / FUSE Volume Server Failover (push) Failing after 3s
FUSE Integration Tests / FUSE Integration Testing (push) Failing after 2s
FUSE P2P Peer Chunk Sharing Integration Tests / FUSE P2P Peer Chunk Sharing (push) Failing after 3s
go: build binary / Go Vet (push) Failing after 2s
go: build binary / Go Vet 32-bit (push) Failing after 3s
go: build binary / Build (push) Failing after 4s
go: build binary / Build cross-platform (freebsd/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (darwin/arm64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/arm64) (push) Failing after 3s
go: build binary / Test (push) Failing after 2s
go: build binary / Test 32-bit (push) Failing after 3s
helm: lint and test charts / lint-test (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (11) (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (17) (push) Failing after 3s
go: build dev binaries / build_dev_linux_windows (amd64, linux) (push) Failing after 2s
go: build dev binaries / build_dev_linux_windows (amd64, windows) (push) Failing after 3s
go: build dev binaries / build_dev_darwin (amd64, darwin) (push) Has been skipped
go: build dev binaries / build_dev_darwin (arm64, darwin) (push) Has been skipped
Java Client Unit Tests / Java Unit Tests (11) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (17) (push) Failing after 2s
Java Client Unit Tests / Java Unit Tests (21) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (8) (push) Failing after 3s
Kafka Quick Test (Load Test with Schema Registry) / Kafka Client Load Test (Quick) (push) Failing after 3s
Kafka Gateway Tests / Kafka Unit Tests (unit-tests-1) (push) Failing after 11s
Kafka Gateway Tests / Kafka Integration Tests (Critical) (integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka End-to-End Tests (with SMQ) (e2e-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Consumer Group Tests (Highly Isolated) (consumer-group-1) (push) Failing after 2s
Kafka Gateway Tests / Kafka Client Compatibility (with SMQ) (client-compat-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka SMQ Integration Tests (Full Stack) (smq-integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Protocol Tests (Isolated) (protocol-1) (push) Failing after 3s
KMS Tests / KMS Provider Integration Tests (push) Failing after 2s
KMS Tests / S3 KMS End-to-End Tests (push) Failing after 3s
Master Cold Start Tests / Master Cold Start Tests (push) Failing after 4s
Metadata Subscribe Integration Tests / Metadata Subscribe Integration Tests (push) Failing after 3s
Multi-Master Tests / Multi-Master Failover Tests (push) Failing after 3s
Performance / CPU and Heap Profile (push) Failing after 2s
Performance / S3 Read/Write Benchmark (rust volume) (push) Failing after 3s
pjdfstest POSIX Compliance / pjdfstest (push) Failing after 2s
Plugin Worker Integration Tests / Plugin Worker: erasure_coding (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: vacuum (push) Failing after 3s
Rust Volume Server Tests / Rust Integration Tests (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 1) (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 1) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 3) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Distributed Tests (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Performance Tests (push) Failing after 3s
Performance / Throughput Benchmark (go volume) (push) Failing after 3s
Performance / Throughput Benchmark (rust volume) (push) Failing after 2s
Performance / S3 Read/Write Benchmark (go volume) (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: volume_balance (push) Failing after 3s
PostgreSQL Gateway Tests / PostgreSQL Basic Tests (push) Failing after 3s
Rust Volume Server Tests / Rust Unit Tests (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 3) (push) Failing after 3s
Rust Plugin Worker Tests / Rust Plugin Worker Build and Unit Tests (push) Failing after 3s
rust: build dev volume server binaries / cleanup (push) Successful in 3s
S3 ETag and ACL Tests / S3 ETag + ACL Integration Tests (push) Failing after 3s
S3 IAM Integration Tests / IAM Unit Tests (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (advanced) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (basic) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (group) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (policy-enforcement) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (sts) (push) Failing after 4s
S3 Keycloak Integration Tests / S3 Keycloak Integration Tests (push) Failing after 3s
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.11) (push) Failing after 3s
S3 PyArrow Parquet Tests / Go Unit Tests (Implicit Directory) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.12) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-amd64, x86_64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-arm64, aarch64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.9) (push) Has been cancelled
S3 Proxy Signature Tests / S3 Proxy Signature Verification Tests (push) Has been cancelled
S3 SDK V2 Route Disambiguation Tests / S3 SDK V2 Routing Tests (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (quick) (push) Has been cancelled
S3 SSE Tests / S3 SSE Compatibility Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Metadata Persistence Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Copy Operations Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Multipart Upload Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Performance Test (push) Has been cancelled
S3 SSE Tests / S3 Volume Encryption Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (comprehensive) (push) Has been cancelled
Spark Integration Tests / Spark Integration Tests (push) Failing after 2s
Telemetry Integration Tests / telemetry-integration-test (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 1) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 1) (push) Failing after 3s
Ceph S3 tests / Basic S3 tests (KV store) (push) Has been cancelled
Ceph S3 tests / S3 Versioning & Object Lock tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Unit Tests (push) Failing after 3s
Ceph S3 tests / S3 CORS tests (push) Has been cancelled
Ceph S3 tests / SeaweedFS Custom S3 Copy tests (push) Has been cancelled
Ceph S3 tests / Basic S3 tests (SQL store) (push) Has been cancelled
test s3 over https using aws-cli / awscli-tests (push) Has been cancelled
TLS Rotation Integration Tests / TLS Rotation Integration Tests (push) Has been cancelled
Vacuum Integration Tests / Vacuum Integration Tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Variables Integration Tests (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (advanced-policy) (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (basic-policy) (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (contextual-policy) (push) Failing after 4s
S3 Policy Integration Tests / Trusted Proxy Detection Tests (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Shell Integration Tests (push) Failing after 3s
Samba on FUSE Integration / samba-integration (push) Failing after 2s
SFTP Integration Tests / SFTP Integration Testing (push) Failing after 3s
terraform: validate and test modules / fmt, validate, plan-level tests (push) Failing after 3s
terraform: validate and test modules / local cluster smoke test (real weed) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 3) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 2) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 2) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 3) (push) Failing after 5s
mount: windows conformance / WinFsp conformance (push) Has been cancelled
mount: windows / Mount on Windows (push) Has been cancelled
285 lines
7.8 KiB
Go
285 lines
7.8 KiB
Go
package s3tables
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/http"
|
|
"reflect"
|
|
"strings"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/iam/integration"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
)
|
|
|
|
// IAMAuthorizer allows s3tables handlers to evaluate IAM policies without importing s3api.
|
|
type IAMAuthorizer interface {
|
|
IsActionAllowed(ctx context.Context, request *integration.ActionRequest) (bool, error)
|
|
}
|
|
|
|
// SetIAMAuthorizer injects the IAM authorizer for policy-based access checks.
|
|
func (h *S3TablesHandler) SetIAMAuthorizer(authorizer IAMAuthorizer) {
|
|
h.iamAuthorizer = authorizer
|
|
}
|
|
|
|
func (h *S3TablesHandler) shouldUseIAM(r *http.Request, identityActions, identityPolicyNames []string) bool {
|
|
if h.iamAuthorizer == nil || r == nil {
|
|
return false
|
|
}
|
|
if s3_constants.GetIdentityFromContext(r) == nil {
|
|
return false
|
|
}
|
|
// When default-allow is enabled, keep anonymous requests on the legacy path
|
|
// to preserve zero-config behavior (IAM policies are not available for anonymous).
|
|
if h.defaultAllow && isAnonymousIdentity(r) {
|
|
return false
|
|
}
|
|
// An empty inline `identityActions` slice doesn't mean the identity has no
|
|
// permissions—it just means authorization lives in IAM policies or session
|
|
// tokens instead of static action lists. We therefore prefer the IAM path
|
|
// whenever inline actions are absent and fall back to default policy names
|
|
// or session tokens.
|
|
if hasSessionToken(r) {
|
|
return true
|
|
}
|
|
if len(identityActions) == 0 {
|
|
return true
|
|
}
|
|
return len(identityPolicyNames) > 0
|
|
}
|
|
|
|
// defaultAllowFor reports whether the open-by-default fallback applies: only for
|
|
// trusted tooling or unauthenticated/anonymous access. An authenticated principal
|
|
// must pass an explicit check.
|
|
func (h *S3TablesHandler) defaultAllowFor(r *http.Request) bool {
|
|
if h.trusted {
|
|
return true
|
|
}
|
|
if !h.defaultAllow {
|
|
return false
|
|
}
|
|
// The Manager path forwards only the identity name, so a name alone (no
|
|
// identity object) still counts as an authenticated principal.
|
|
if s3_constants.GetIdentityFromContext(r) == nil && s3_constants.GetIdentityNameFromContext(r) == "" {
|
|
return true
|
|
}
|
|
return isAnonymousIdentity(r)
|
|
}
|
|
|
|
func isAnonymousIdentity(r *http.Request) bool {
|
|
val, ok := getIdentityStructValue(r)
|
|
if !ok {
|
|
return false
|
|
}
|
|
if nameField := val.FieldByName("Name"); nameField.IsValid() && nameField.Kind() == reflect.String {
|
|
if nameField.String() == s3_constants.AccountAnonymousId {
|
|
return true
|
|
}
|
|
}
|
|
accountField := val.FieldByName("Account")
|
|
if accountField.IsValid() && !accountField.IsNil() {
|
|
if accountField.Kind() == reflect.Ptr {
|
|
accountField = accountField.Elem()
|
|
}
|
|
if accountField.Kind() == reflect.Struct {
|
|
if idField := accountField.FieldByName("Id"); idField.IsValid() && idField.Kind() == reflect.String {
|
|
if idField.String() == s3_constants.AccountAnonymousId {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func hasSessionToken(r *http.Request) bool {
|
|
return extractSessionToken(r) != ""
|
|
}
|
|
|
|
func extractSessionToken(r *http.Request) string {
|
|
if token := r.Header.Get(s3_constants.SeaweedFSSessionTokenHeader); token != "" {
|
|
return token
|
|
}
|
|
if token := r.Header.Get("X-Amz-Security-Token"); token != "" {
|
|
return token
|
|
}
|
|
return r.URL.Query().Get("X-Amz-Security-Token")
|
|
}
|
|
|
|
func (h *S3TablesHandler) authorizeIAMAction(r *http.Request, identityPolicyNames []string, action string, resources ...string) (bool, error) {
|
|
if h.iamAuthorizer == nil {
|
|
err := fmt.Errorf("nil iamAuthorizer in authorizeIAMAction")
|
|
glog.V(2).Infof("S3Tables: %v", err)
|
|
return false, err
|
|
}
|
|
principal := r.Header.Get(s3_constants.SeaweedFSPrincipalHeader)
|
|
if principal == "" {
|
|
principal = getIdentityPrincipalArn(r)
|
|
}
|
|
if principal == "" {
|
|
return false, fmt.Errorf("missing principal for IAM authorization")
|
|
}
|
|
|
|
if !strings.Contains(action, ":") {
|
|
action = "s3tables:" + action
|
|
}
|
|
|
|
sessionToken := extractSessionToken(r)
|
|
|
|
requestContext := buildIAMRequestContext(r, getIdentityClaims(r))
|
|
policyNames := identityPolicyNames
|
|
if len(policyNames) == 0 {
|
|
policyNames = getIdentityPolicyNames(r)
|
|
}
|
|
|
|
if len(resources) == 0 {
|
|
return false, fmt.Errorf("no resources provided to authorizeIAMAction")
|
|
}
|
|
checkedResource := false
|
|
for _, resource := range resources {
|
|
if resource == "" {
|
|
continue
|
|
}
|
|
checkedResource = true
|
|
allowed, err := h.iamAuthorizer.IsActionAllowed(r.Context(), &integration.ActionRequest{
|
|
Principal: principal,
|
|
Action: action,
|
|
Resource: resource,
|
|
SessionToken: sessionToken,
|
|
RequestContext: requestContext,
|
|
PolicyNames: policyNames,
|
|
})
|
|
if err != nil {
|
|
glog.V(2).Infof("S3Tables: IAM authorization error action=%s resource=%s principal=%s: %v", action, resource, principal, err)
|
|
return false, err
|
|
}
|
|
if !allowed {
|
|
err := fmt.Errorf("access denied by IAM for resource %s", resource)
|
|
return false, err
|
|
}
|
|
}
|
|
if !checkedResource {
|
|
return false, fmt.Errorf("no non-empty resources provided to authorizeIAMAction")
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
func getIdentityPrincipalArn(r *http.Request) string {
|
|
val, ok := getIdentityStructValue(r)
|
|
if !ok {
|
|
return ""
|
|
}
|
|
field := val.FieldByName("PrincipalArn")
|
|
if field.IsValid() && field.Kind() == reflect.String {
|
|
return field.String()
|
|
}
|
|
return ""
|
|
}
|
|
|
|
func getIdentityPolicyNames(r *http.Request) []string {
|
|
val, ok := getIdentityStructValue(r)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
field := val.FieldByName("PolicyNames")
|
|
if !field.IsValid() || field.Kind() != reflect.Slice {
|
|
return nil
|
|
}
|
|
policies := make([]string, 0, field.Len())
|
|
for i := 0; i < field.Len(); i++ {
|
|
item := field.Index(i)
|
|
if item.Kind() == reflect.String {
|
|
policies = append(policies, item.String())
|
|
} else if item.CanInterface() {
|
|
policies = append(policies, fmt.Sprint(item.Interface()))
|
|
}
|
|
}
|
|
if len(policies) == 0 {
|
|
return nil
|
|
}
|
|
return policies
|
|
}
|
|
|
|
func getIdentityClaims(r *http.Request) map[string]interface{} {
|
|
val, ok := getIdentityStructValue(r)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
field := val.FieldByName("Claims")
|
|
if !field.IsValid() || field.Kind() != reflect.Map || field.IsNil() {
|
|
return nil
|
|
}
|
|
if field.Type().Key().Kind() != reflect.String {
|
|
return nil
|
|
}
|
|
claims := make(map[string]interface{}, field.Len())
|
|
for _, key := range field.MapKeys() {
|
|
if key.Kind() != reflect.String {
|
|
continue
|
|
}
|
|
val := field.MapIndex(key)
|
|
if !val.IsValid() {
|
|
continue
|
|
}
|
|
claims[key.String()] = val.Interface()
|
|
}
|
|
if len(claims) == 0 {
|
|
return nil
|
|
}
|
|
return claims
|
|
}
|
|
|
|
func buildIAMRequestContext(r *http.Request, claims map[string]interface{}) map[string]interface{} {
|
|
ctx := make(map[string]interface{})
|
|
if ua := r.Header.Get("User-Agent"); ua != "" {
|
|
ctx["userAgent"] = ua
|
|
}
|
|
if referer := r.Header.Get("Referer"); referer != "" {
|
|
ctx["referer"] = referer
|
|
}
|
|
for k, v := range claims {
|
|
if strings.HasPrefix(k, "jwt:") {
|
|
if _, exists := ctx[k]; !exists {
|
|
ctx[k] = v
|
|
}
|
|
}
|
|
}
|
|
for k, v := range claims {
|
|
if strings.HasPrefix(k, "jwt:") {
|
|
continue
|
|
}
|
|
if _, exists := ctx[k]; !exists {
|
|
ctx[k] = v
|
|
}
|
|
jwtKey := "jwt:" + k
|
|
if _, exists := ctx[jwtKey]; !exists {
|
|
ctx[jwtKey] = v
|
|
}
|
|
}
|
|
if len(ctx) == 0 {
|
|
return nil
|
|
}
|
|
return ctx
|
|
}
|
|
|
|
// getIdentityStructValue fetches the identity struct held in the request context.
|
|
// The identity is expected to be a pointer to a struct with the fields used by
|
|
// the reflection helpers (PrincipalArn string, PolicyNames []string,
|
|
// Claims map[string]interface{}).
|
|
// This helper centralizes the nil-check and ptr-deref logic so callers focus on
|
|
// reading the specific fields they need.
|
|
func getIdentityStructValue(r *http.Request) (reflect.Value, bool) {
|
|
identityRaw := s3_constants.GetIdentityFromContext(r)
|
|
if identityRaw == nil {
|
|
return reflect.Value{}, false
|
|
}
|
|
val := reflect.ValueOf(identityRaw)
|
|
if val.Kind() == reflect.Ptr {
|
|
val = val.Elem()
|
|
}
|
|
if val.Kind() != reflect.Struct {
|
|
return reflect.Value{}, false
|
|
}
|
|
return val, true
|
|
}
|