Some checks failed
go: build dev binaries / cleanup (push) Successful in 4s
Codespell / Check for spelling errors (push) Failing after 3s
docker: build dev containers / build-rust-binaries (amd64, x86_64-unknown-linux-musl) (push) Failing after 3s
docker: build dev containers / build-dev-containers (push) Has been skipped
docker: build dev containers / build-rust-binaries (arm64, true, aarch64-unknown-linux-musl) (push) Failing after 3s
End to End / FUSE Mount (push) Failing after 2s
EC Integration Tests / EC Integration Tests (push) Failing after 30s
FUSE DLM Integration Tests / FUSE DLM Integration Tests (push) Failing after 3s
FUSE Volume Server Failover Tests / FUSE Volume Server Failover (push) Failing after 3s
FUSE Integration Tests / FUSE Integration Testing (push) Failing after 2s
FUSE P2P Peer Chunk Sharing Integration Tests / FUSE P2P Peer Chunk Sharing (push) Failing after 3s
go: build binary / Go Vet (push) Failing after 2s
go: build binary / Go Vet 32-bit (push) Failing after 3s
go: build binary / Build (push) Failing after 4s
go: build binary / Build cross-platform (freebsd/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (darwin/arm64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/arm64) (push) Failing after 3s
go: build binary / Test (push) Failing after 2s
go: build binary / Test 32-bit (push) Failing after 3s
helm: lint and test charts / lint-test (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (11) (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (17) (push) Failing after 3s
go: build dev binaries / build_dev_linux_windows (amd64, linux) (push) Failing after 2s
go: build dev binaries / build_dev_linux_windows (amd64, windows) (push) Failing after 3s
go: build dev binaries / build_dev_darwin (amd64, darwin) (push) Has been skipped
go: build dev binaries / build_dev_darwin (arm64, darwin) (push) Has been skipped
Java Client Unit Tests / Java Unit Tests (11) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (17) (push) Failing after 2s
Java Client Unit Tests / Java Unit Tests (21) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (8) (push) Failing after 3s
Kafka Quick Test (Load Test with Schema Registry) / Kafka Client Load Test (Quick) (push) Failing after 3s
Kafka Gateway Tests / Kafka Unit Tests (unit-tests-1) (push) Failing after 11s
Kafka Gateway Tests / Kafka Integration Tests (Critical) (integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka End-to-End Tests (with SMQ) (e2e-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Consumer Group Tests (Highly Isolated) (consumer-group-1) (push) Failing after 2s
Kafka Gateway Tests / Kafka Client Compatibility (with SMQ) (client-compat-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka SMQ Integration Tests (Full Stack) (smq-integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Protocol Tests (Isolated) (protocol-1) (push) Failing after 3s
KMS Tests / KMS Provider Integration Tests (push) Failing after 2s
KMS Tests / S3 KMS End-to-End Tests (push) Failing after 3s
Master Cold Start Tests / Master Cold Start Tests (push) Failing after 4s
Metadata Subscribe Integration Tests / Metadata Subscribe Integration Tests (push) Failing after 3s
Multi-Master Tests / Multi-Master Failover Tests (push) Failing after 3s
Performance / CPU and Heap Profile (push) Failing after 2s
Performance / S3 Read/Write Benchmark (rust volume) (push) Failing after 3s
pjdfstest POSIX Compliance / pjdfstest (push) Failing after 2s
Plugin Worker Integration Tests / Plugin Worker: erasure_coding (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: vacuum (push) Failing after 3s
Rust Volume Server Tests / Rust Integration Tests (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 1) (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 1) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 3) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Distributed Tests (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Performance Tests (push) Failing after 3s
Performance / Throughput Benchmark (go volume) (push) Failing after 3s
Performance / Throughput Benchmark (rust volume) (push) Failing after 2s
Performance / S3 Read/Write Benchmark (go volume) (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: volume_balance (push) Failing after 3s
PostgreSQL Gateway Tests / PostgreSQL Basic Tests (push) Failing after 3s
Rust Volume Server Tests / Rust Unit Tests (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 3) (push) Failing after 3s
Rust Plugin Worker Tests / Rust Plugin Worker Build and Unit Tests (push) Failing after 3s
rust: build dev volume server binaries / cleanup (push) Successful in 3s
S3 ETag and ACL Tests / S3 ETag + ACL Integration Tests (push) Failing after 3s
S3 IAM Integration Tests / IAM Unit Tests (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (advanced) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (basic) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (group) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (policy-enforcement) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (sts) (push) Failing after 4s
S3 Keycloak Integration Tests / S3 Keycloak Integration Tests (push) Failing after 3s
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.11) (push) Failing after 3s
S3 PyArrow Parquet Tests / Go Unit Tests (Implicit Directory) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.12) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-amd64, x86_64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-arm64, aarch64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.9) (push) Has been cancelled
S3 Proxy Signature Tests / S3 Proxy Signature Verification Tests (push) Has been cancelled
S3 SDK V2 Route Disambiguation Tests / S3 SDK V2 Routing Tests (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (quick) (push) Has been cancelled
S3 SSE Tests / S3 SSE Compatibility Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Metadata Persistence Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Copy Operations Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Multipart Upload Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Performance Test (push) Has been cancelled
S3 SSE Tests / S3 Volume Encryption Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (comprehensive) (push) Has been cancelled
Spark Integration Tests / Spark Integration Tests (push) Failing after 2s
Telemetry Integration Tests / telemetry-integration-test (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 1) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 1) (push) Failing after 3s
Ceph S3 tests / Basic S3 tests (KV store) (push) Has been cancelled
Ceph S3 tests / S3 Versioning & Object Lock tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Unit Tests (push) Failing after 3s
Ceph S3 tests / S3 CORS tests (push) Has been cancelled
Ceph S3 tests / SeaweedFS Custom S3 Copy tests (push) Has been cancelled
Ceph S3 tests / Basic S3 tests (SQL store) (push) Has been cancelled
test s3 over https using aws-cli / awscli-tests (push) Has been cancelled
TLS Rotation Integration Tests / TLS Rotation Integration Tests (push) Has been cancelled
Vacuum Integration Tests / Vacuum Integration Tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Variables Integration Tests (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (advanced-policy) (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (basic-policy) (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (contextual-policy) (push) Failing after 4s
S3 Policy Integration Tests / Trusted Proxy Detection Tests (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Shell Integration Tests (push) Failing after 3s
Samba on FUSE Integration / samba-integration (push) Failing after 2s
SFTP Integration Tests / SFTP Integration Testing (push) Failing after 3s
terraform: validate and test modules / fmt, validate, plan-level tests (push) Failing after 3s
terraform: validate and test modules / local cluster smoke test (real weed) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 3) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 2) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 2) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 3) (push) Failing after 5s
mount: windows conformance / WinFsp conformance (push) Has been cancelled
mount: windows / Mount on Windows (push) Has been cancelled
177 lines
5.3 KiB
Go
177 lines
5.3 KiB
Go
package balancer
|
|
|
|
import (
|
|
"slices"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/storage/super_block"
|
|
)
|
|
|
|
// Location identifies where a volume replica lives, at the granularity replica
|
|
// placement reasons about: data center, rack, data node, and physical host
|
|
// (machine). Servers sharing a host are one fault domain. It is the shared shape
|
|
// the shell (from master_pb) and the worker (from ActiveTopology) both adapt to.
|
|
type Location struct {
|
|
DataCenter string
|
|
Rack string
|
|
NodeID string
|
|
Host string
|
|
}
|
|
|
|
// HostFromAddress returns the physical machine (host/IP) of a server address,
|
|
// falling back to the node id (== ip:port in the common case) when no address is
|
|
// known.
|
|
func HostFromAddress(address, nodeID string) string {
|
|
if address == "" {
|
|
address = nodeID
|
|
}
|
|
return pb.ServerAddress(address).ToHost()
|
|
}
|
|
|
|
type rackKey struct {
|
|
DataCenter string
|
|
Rack string
|
|
}
|
|
|
|
type nodeKey struct {
|
|
DataCenter string
|
|
Rack string
|
|
NodeID string
|
|
}
|
|
|
|
// IsGoodMove reports whether moving a volume from sourceNodeID onto target keeps
|
|
// the volume's replica placement policy satisfied, given the current replica
|
|
// locations. It refuses moving onto the source itself, onto a node that already
|
|
// holds a replica, and onto a host that already holds another replica (best-effort
|
|
// machine anti-affinity), then defers to SatisfyReplicaPlacement.
|
|
func IsGoodMove(rp *super_block.ReplicaPlacement, existingReplicas []Location, sourceNodeID string, target Location) bool {
|
|
if rp == nil || !rp.HasReplication() {
|
|
return true // no replication constraint
|
|
}
|
|
|
|
// Never move onto the source node itself.
|
|
if target.NodeID == sourceNodeID {
|
|
return false
|
|
}
|
|
|
|
// Build the replica set after the move: remove the one replica being moved off
|
|
// the source, keeping any others (an over-replicated node may hold more than
|
|
// one replica of this volume, and only one is moving).
|
|
afterMove := make([]Location, 0, len(existingReplicas))
|
|
sourceFound := false
|
|
for _, r := range existingReplicas {
|
|
if r.NodeID == sourceNodeID && !sourceFound {
|
|
sourceFound = true
|
|
} else {
|
|
afterMove = append(afterMove, r)
|
|
}
|
|
}
|
|
if !sourceFound {
|
|
// Source not in the replica list — cluster state may be inconsistent.
|
|
// Treat as unsafe to avoid an incorrect placement decision.
|
|
return false
|
|
}
|
|
|
|
// Best-effort machine anti-affinity: don't move a replica onto a host that
|
|
// already holds another replica of this volume, so a single machine failure
|
|
// can't take out two replicas.
|
|
if target.Host != "" {
|
|
for _, r := range afterMove {
|
|
if r.Host == target.Host {
|
|
return false
|
|
}
|
|
}
|
|
}
|
|
|
|
return SatisfyReplicaPlacement(rp, afterMove, target)
|
|
}
|
|
|
|
// SatisfyReplicaPlacement reports whether placing a replica at target is
|
|
// consistent with the replication policy given the existing replicas. It is the
|
|
// shared implementation for the shell (volume.balance / fix.replication /
|
|
// tier.move) and the maintenance balance worker.
|
|
func SatisfyReplicaPlacement(rp *super_block.ReplicaPlacement, replicas []Location, target Location) bool {
|
|
existingDCs, _, existingNodes := countReplicas(replicas)
|
|
|
|
targetNK := nodeKey{DataCenter: target.DataCenter, Rack: target.Rack, NodeID: target.NodeID}
|
|
if _, found := existingNodes[targetNK]; found {
|
|
// avoid a duplicated volume on the same data node
|
|
return false
|
|
}
|
|
|
|
primaryDCs, _ := findTopDCKeys(existingDCs)
|
|
|
|
// ensure the data center count is within limit
|
|
if _, found := existingDCs[target.DataCenter]; !found {
|
|
// different from existing dcs
|
|
return len(existingDCs) < rp.DiffDataCenterCount+1
|
|
}
|
|
// same as one of the existing data centers
|
|
if !slices.Contains(primaryDCs, target.DataCenter) {
|
|
return false
|
|
}
|
|
|
|
// on a primary dc — check racks within this DC
|
|
primaryDcRacks := make(map[rackKey]int)
|
|
for _, r := range replicas {
|
|
if r.DataCenter != target.DataCenter {
|
|
continue
|
|
}
|
|
primaryDcRacks[rackKey{DataCenter: r.DataCenter, Rack: r.Rack}]++
|
|
}
|
|
|
|
targetRK := rackKey{DataCenter: target.DataCenter, Rack: target.Rack}
|
|
primaryRacks, _ := findTopRackKeys(primaryDcRacks)
|
|
sameRackCount := primaryDcRacks[targetRK]
|
|
|
|
if _, found := primaryDcRacks[targetRK]; !found {
|
|
// different from existing racks
|
|
return len(primaryDcRacks) < rp.DiffRackCount+1
|
|
}
|
|
// same as one of the existing racks
|
|
if !slices.Contains(primaryRacks, targetRK) {
|
|
return false
|
|
}
|
|
|
|
// on the primary rack — check the same-rack count
|
|
return sameRackCount < rp.SameRackCount+1
|
|
}
|
|
|
|
func countReplicas(replicas []Location) (dcCounts map[string]int, rackCounts map[rackKey]int, nodeCounts map[nodeKey]int) {
|
|
dcCounts = make(map[string]int)
|
|
rackCounts = make(map[rackKey]int)
|
|
nodeCounts = make(map[nodeKey]int)
|
|
for _, r := range replicas {
|
|
dcCounts[r.DataCenter]++
|
|
rackCounts[rackKey{DataCenter: r.DataCenter, Rack: r.Rack}]++
|
|
nodeCounts[nodeKey{DataCenter: r.DataCenter, Rack: r.Rack, NodeID: r.NodeID}]++
|
|
}
|
|
return
|
|
}
|
|
|
|
func findTopDCKeys(m map[string]int) (topKeys []string, max int) {
|
|
for k, c := range m {
|
|
if max < c {
|
|
topKeys = topKeys[:0]
|
|
topKeys = append(topKeys, k)
|
|
max = c
|
|
} else if max == c {
|
|
topKeys = append(topKeys, k)
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
func findTopRackKeys(m map[rackKey]int) (topKeys []rackKey, max int) {
|
|
for k, c := range m {
|
|
if max < c {
|
|
topKeys = topKeys[:0]
|
|
topKeys = append(topKeys, k)
|
|
max = c
|
|
} else if max == c {
|
|
topKeys = append(topKeys, k)
|
|
}
|
|
}
|
|
return
|
|
}
|