Some checks failed
go: build dev binaries / cleanup (push) Successful in 4s
Codespell / Check for spelling errors (push) Failing after 3s
docker: build dev containers / build-rust-binaries (amd64, x86_64-unknown-linux-musl) (push) Failing after 3s
docker: build dev containers / build-dev-containers (push) Has been skipped
docker: build dev containers / build-rust-binaries (arm64, true, aarch64-unknown-linux-musl) (push) Failing after 3s
End to End / FUSE Mount (push) Failing after 2s
EC Integration Tests / EC Integration Tests (push) Failing after 30s
FUSE DLM Integration Tests / FUSE DLM Integration Tests (push) Failing after 3s
FUSE Volume Server Failover Tests / FUSE Volume Server Failover (push) Failing after 3s
FUSE Integration Tests / FUSE Integration Testing (push) Failing after 2s
FUSE P2P Peer Chunk Sharing Integration Tests / FUSE P2P Peer Chunk Sharing (push) Failing after 3s
go: build binary / Go Vet (push) Failing after 2s
go: build binary / Go Vet 32-bit (push) Failing after 3s
go: build binary / Build (push) Failing after 4s
go: build binary / Build cross-platform (freebsd/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (darwin/arm64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/arm64) (push) Failing after 3s
go: build binary / Test (push) Failing after 2s
go: build binary / Test 32-bit (push) Failing after 3s
helm: lint and test charts / lint-test (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (11) (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (17) (push) Failing after 3s
go: build dev binaries / build_dev_linux_windows (amd64, linux) (push) Failing after 2s
go: build dev binaries / build_dev_linux_windows (amd64, windows) (push) Failing after 3s
go: build dev binaries / build_dev_darwin (amd64, darwin) (push) Has been skipped
go: build dev binaries / build_dev_darwin (arm64, darwin) (push) Has been skipped
Java Client Unit Tests / Java Unit Tests (11) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (17) (push) Failing after 2s
Java Client Unit Tests / Java Unit Tests (21) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (8) (push) Failing after 3s
Kafka Quick Test (Load Test with Schema Registry) / Kafka Client Load Test (Quick) (push) Failing after 3s
Kafka Gateway Tests / Kafka Unit Tests (unit-tests-1) (push) Failing after 11s
Kafka Gateway Tests / Kafka Integration Tests (Critical) (integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka End-to-End Tests (with SMQ) (e2e-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Consumer Group Tests (Highly Isolated) (consumer-group-1) (push) Failing after 2s
Kafka Gateway Tests / Kafka Client Compatibility (with SMQ) (client-compat-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka SMQ Integration Tests (Full Stack) (smq-integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Protocol Tests (Isolated) (protocol-1) (push) Failing after 3s
KMS Tests / KMS Provider Integration Tests (push) Failing after 2s
KMS Tests / S3 KMS End-to-End Tests (push) Failing after 3s
Master Cold Start Tests / Master Cold Start Tests (push) Failing after 4s
Metadata Subscribe Integration Tests / Metadata Subscribe Integration Tests (push) Failing after 3s
Multi-Master Tests / Multi-Master Failover Tests (push) Failing after 3s
Performance / CPU and Heap Profile (push) Failing after 2s
Performance / S3 Read/Write Benchmark (rust volume) (push) Failing after 3s
pjdfstest POSIX Compliance / pjdfstest (push) Failing after 2s
Plugin Worker Integration Tests / Plugin Worker: erasure_coding (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: vacuum (push) Failing after 3s
Rust Volume Server Tests / Rust Integration Tests (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 1) (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 1) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 3) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Distributed Tests (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Performance Tests (push) Failing after 3s
Performance / Throughput Benchmark (go volume) (push) Failing after 3s
Performance / Throughput Benchmark (rust volume) (push) Failing after 2s
Performance / S3 Read/Write Benchmark (go volume) (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: volume_balance (push) Failing after 3s
PostgreSQL Gateway Tests / PostgreSQL Basic Tests (push) Failing after 3s
Rust Volume Server Tests / Rust Unit Tests (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 3) (push) Failing after 3s
Rust Plugin Worker Tests / Rust Plugin Worker Build and Unit Tests (push) Failing after 3s
rust: build dev volume server binaries / cleanup (push) Successful in 3s
S3 ETag and ACL Tests / S3 ETag + ACL Integration Tests (push) Failing after 3s
S3 IAM Integration Tests / IAM Unit Tests (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (advanced) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (basic) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (group) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (policy-enforcement) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (sts) (push) Failing after 4s
S3 Keycloak Integration Tests / S3 Keycloak Integration Tests (push) Failing after 3s
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.11) (push) Failing after 3s
S3 PyArrow Parquet Tests / Go Unit Tests (Implicit Directory) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.12) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-amd64, x86_64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-arm64, aarch64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.9) (push) Has been cancelled
S3 Proxy Signature Tests / S3 Proxy Signature Verification Tests (push) Has been cancelled
S3 SDK V2 Route Disambiguation Tests / S3 SDK V2 Routing Tests (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (quick) (push) Has been cancelled
S3 SSE Tests / S3 SSE Compatibility Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Metadata Persistence Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Copy Operations Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Multipart Upload Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Performance Test (push) Has been cancelled
S3 SSE Tests / S3 Volume Encryption Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (comprehensive) (push) Has been cancelled
Spark Integration Tests / Spark Integration Tests (push) Failing after 2s
Telemetry Integration Tests / telemetry-integration-test (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 1) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 1) (push) Failing after 3s
Ceph S3 tests / Basic S3 tests (KV store) (push) Has been cancelled
Ceph S3 tests / S3 Versioning & Object Lock tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Unit Tests (push) Failing after 3s
Ceph S3 tests / S3 CORS tests (push) Has been cancelled
Ceph S3 tests / SeaweedFS Custom S3 Copy tests (push) Has been cancelled
Ceph S3 tests / Basic S3 tests (SQL store) (push) Has been cancelled
test s3 over https using aws-cli / awscli-tests (push) Has been cancelled
TLS Rotation Integration Tests / TLS Rotation Integration Tests (push) Has been cancelled
Vacuum Integration Tests / Vacuum Integration Tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Variables Integration Tests (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (advanced-policy) (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (basic-policy) (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (contextual-policy) (push) Failing after 4s
S3 Policy Integration Tests / Trusted Proxy Detection Tests (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Shell Integration Tests (push) Failing after 3s
Samba on FUSE Integration / samba-integration (push) Failing after 2s
SFTP Integration Tests / SFTP Integration Testing (push) Failing after 3s
terraform: validate and test modules / fmt, validate, plan-level tests (push) Failing after 3s
terraform: validate and test modules / local cluster smoke test (real weed) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 3) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 2) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 2) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 3) (push) Failing after 5s
mount: windows conformance / WinFsp conformance (push) Has been cancelled
mount: windows / Mount on Windows (push) Has been cancelled
242 lines
8.0 KiB
Go
242 lines
8.0 KiB
Go
package s3_objectlock
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/glog"
|
|
"github.com/seaweedfs/seaweedfs/weed/pb/filer_pb"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
)
|
|
|
|
// ====================================================================
|
|
// SHARED OBJECT LOCK CHECKING FUNCTIONS
|
|
// ====================================================================
|
|
// These functions are used by S3 API, Admin UI, and shell commands for
|
|
// checking Object Lock status before bucket deletion.
|
|
|
|
// EntryHasActiveLock checks if an entry has an active retention or legal hold
|
|
// This is a standalone function that can be used by any component
|
|
func EntryHasActiveLock(entry *filer_pb.Entry, currentTime time.Time) bool {
|
|
if entry == nil || entry.Extended == nil {
|
|
return false
|
|
}
|
|
|
|
// Check for active legal hold (case-insensitive, trimmed for defensive parsing)
|
|
if legalHoldBytes, exists := entry.Extended[s3_constants.ExtLegalHoldKey]; exists {
|
|
legalHold := strings.TrimSpace(strings.ToUpper(string(legalHoldBytes)))
|
|
if legalHold == s3_constants.LegalHoldOn {
|
|
return true
|
|
}
|
|
}
|
|
|
|
// Check for active retention (case-insensitive, trimmed for defensive parsing)
|
|
if modeBytes, exists := entry.Extended[s3_constants.ExtObjectLockModeKey]; exists {
|
|
mode := strings.TrimSpace(strings.ToUpper(string(modeBytes)))
|
|
if mode == s3_constants.RetentionModeCompliance || mode == s3_constants.RetentionModeGovernance {
|
|
// Check if retention is still active
|
|
if dateBytes, dateExists := entry.Extended[s3_constants.ExtRetentionUntilDateKey]; dateExists {
|
|
dateStr := strings.TrimSpace(string(dateBytes))
|
|
timestamp, err := strconv.ParseInt(dateStr, 10, 64)
|
|
if err != nil {
|
|
// Fail-safe: if we can't parse the retention date, assume the object is locked
|
|
// to prevent accidental data loss
|
|
glog.Warningf("Failed to parse retention date '%s' for entry, assuming locked: %v", dateStr, err)
|
|
return true
|
|
}
|
|
retainUntil := time.Unix(timestamp, 0)
|
|
if retainUntil.After(currentTime) {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// HasObjectsWithActiveLocks checks if any objects in the bucket have active retention or legal hold
|
|
// This function uses the filer gRPC client to scan the bucket directory
|
|
func HasObjectsWithActiveLocks(ctx context.Context, client filer_pb.SeaweedFilerClient, bucketPath string) (bool, error) {
|
|
hasLocks := false
|
|
currentTime := time.Now()
|
|
|
|
err := recursivelyCheckLocksWithClient(ctx, client, bucketPath, &hasLocks, currentTime)
|
|
if err != nil {
|
|
return false, fmt.Errorf("error checking for locked objects: %w", err)
|
|
}
|
|
|
|
return hasLocks, nil
|
|
}
|
|
|
|
// paginateEntries is a generic helper that handles pagination logic for listing directory entries.
|
|
// The processEntry callback is called for each entry; returning stop=true stops iteration early.
|
|
func paginateEntries(ctx context.Context, client filer_pb.SeaweedFilerClient, dir string,
|
|
processEntry func(entry *filer_pb.Entry) (stop bool, err error)) error {
|
|
lastFileName := ""
|
|
for {
|
|
resp, err := client.ListEntries(ctx, &filer_pb.ListEntriesRequest{
|
|
Directory: dir,
|
|
StartFromFileName: lastFileName,
|
|
InclusiveStartFrom: false,
|
|
Limit: 10000,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("failed to list directory %s: %w", dir, err)
|
|
}
|
|
|
|
entriesReceived := false
|
|
for {
|
|
entryResp, recvErr := resp.Recv()
|
|
if recvErr != nil {
|
|
if errors.Is(recvErr, io.EOF) {
|
|
break // Normal end of stream
|
|
}
|
|
return fmt.Errorf("failed to receive entry from %s: %w", dir, recvErr)
|
|
}
|
|
entry := entryResp.Entry
|
|
if entry == nil {
|
|
continue
|
|
}
|
|
entriesReceived = true
|
|
lastFileName = entry.Name
|
|
|
|
// Skip invalid entry names to prevent path traversal
|
|
if entry.Name == "" || entry.Name == "." || entry.Name == ".." ||
|
|
strings.ContainsAny(entry.Name, "/\\") {
|
|
glog.V(2).Infof("Skipping invalid entry name: %q in %s", entry.Name, dir)
|
|
continue
|
|
}
|
|
|
|
stop, err := processEntry(entry)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if stop {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
if !entriesReceived {
|
|
break
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// recursivelyCheckLocksWithClient recursively checks all objects and versions for active locks
|
|
func recursivelyCheckLocksWithClient(ctx context.Context, client filer_pb.SeaweedFilerClient, dir string, hasLocks *bool, currentTime time.Time) error {
|
|
if *hasLocks {
|
|
return nil // Early exit if already found a locked object
|
|
}
|
|
|
|
return paginateEntries(ctx, client, dir, func(entry *filer_pb.Entry) (bool, error) {
|
|
if *hasLocks {
|
|
return true, nil // Stop iteration
|
|
}
|
|
|
|
// Skip special directories
|
|
if entry.Name == s3_constants.MultipartUploadsFolder {
|
|
return false, nil // Continue
|
|
}
|
|
|
|
if entry.IsDirectory {
|
|
subDir := dir + "/" + entry.Name
|
|
if entry.Name == s3_constants.VersionsFolder {
|
|
// Check all version files (exact match for .versions folder)
|
|
if err := checkVersionsForLocksWithClient(ctx, client, subDir, hasLocks, currentTime); err != nil {
|
|
return false, err
|
|
}
|
|
} else {
|
|
// A directory-marker object (key ending in "/") is stored as a
|
|
// directory entry and can carry a lock, so check it before recursing.
|
|
if EntryHasActiveLock(entry, currentTime) {
|
|
*hasLocks = true
|
|
glog.V(2).Infof("Found directory marker with active lock: %s/%s", dir, entry.Name)
|
|
return true, nil
|
|
}
|
|
// Recursively check subdirectories
|
|
if err := recursivelyCheckLocksWithClient(ctx, client, subDir, hasLocks, currentTime); err != nil {
|
|
return false, err
|
|
}
|
|
}
|
|
} else {
|
|
// Check if this object has an active lock
|
|
if EntryHasActiveLock(entry, currentTime) {
|
|
*hasLocks = true
|
|
glog.V(2).Infof("Found object with active lock: %s/%s", dir, entry.Name)
|
|
return true, nil // Stop iteration
|
|
}
|
|
}
|
|
return false, nil // Continue
|
|
})
|
|
}
|
|
|
|
// checkVersionsForLocksWithClient checks all versions in a .versions directory for active locks
|
|
func checkVersionsForLocksWithClient(ctx context.Context, client filer_pb.SeaweedFilerClient, versionsDir string, hasLocks *bool, currentTime time.Time) error {
|
|
return paginateEntries(ctx, client, versionsDir, func(entry *filer_pb.Entry) (bool, error) {
|
|
if *hasLocks {
|
|
return true, nil // Stop iteration
|
|
}
|
|
|
|
if EntryHasActiveLock(entry, currentTime) {
|
|
*hasLocks = true
|
|
glog.V(2).Infof("Found version with active lock: %s/%s", versionsDir, entry.Name)
|
|
return true, nil // Stop iteration
|
|
}
|
|
return false, nil // Continue
|
|
})
|
|
}
|
|
|
|
// IsObjectLockEnabled checks if Object Lock is enabled on a bucket entry
|
|
func IsObjectLockEnabled(entry *filer_pb.Entry) bool {
|
|
if entry == nil || entry.Extended == nil {
|
|
return false
|
|
}
|
|
|
|
enabledBytes, exists := entry.Extended[s3_constants.ExtObjectLockEnabledKey]
|
|
if !exists {
|
|
return false
|
|
}
|
|
|
|
enabled := string(enabledBytes)
|
|
return enabled == s3_constants.ObjectLockEnabled || enabled == "true"
|
|
}
|
|
|
|
// CheckBucketForLockedObjects is a unified function that checks if a bucket has Object Lock enabled
|
|
// and if so, scans for objects with active locks. This combines the bucket lookup and lock check
|
|
// into a single operation used by S3 API, Admin UI, and shell commands.
|
|
// Returns an error if the bucket has locked objects or if the check fails.
|
|
func CheckBucketForLockedObjects(ctx context.Context, client filer_pb.SeaweedFilerClient, bucketsPath, bucketName string) error {
|
|
// Look up the bucket entry
|
|
lookupResp, err := client.LookupDirectoryEntry(ctx, &filer_pb.LookupDirectoryEntryRequest{
|
|
Directory: bucketsPath,
|
|
Name: bucketName,
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("bucket not found: %w", err)
|
|
}
|
|
|
|
// Check if Object Lock is enabled
|
|
if !IsObjectLockEnabled(lookupResp.Entry) {
|
|
return nil // No Object Lock, nothing to check
|
|
}
|
|
|
|
// Check for objects with active locks
|
|
bucketPath := bucketsPath + "/" + bucketName
|
|
hasLockedObjects, checkErr := HasObjectsWithActiveLocks(ctx, client, bucketPath)
|
|
if checkErr != nil {
|
|
return fmt.Errorf("failed to check for locked objects: %w", checkErr)
|
|
}
|
|
if hasLockedObjects {
|
|
return fmt.Errorf("bucket has objects with active Object Lock retention or legal hold")
|
|
}
|
|
|
|
return nil
|
|
}
|