Some checks failed
go: build dev binaries / cleanup (push) Successful in 4s
Codespell / Check for spelling errors (push) Failing after 3s
docker: build dev containers / build-rust-binaries (amd64, x86_64-unknown-linux-musl) (push) Failing after 3s
docker: build dev containers / build-dev-containers (push) Has been skipped
docker: build dev containers / build-rust-binaries (arm64, true, aarch64-unknown-linux-musl) (push) Failing after 3s
End to End / FUSE Mount (push) Failing after 2s
EC Integration Tests / EC Integration Tests (push) Failing after 30s
FUSE DLM Integration Tests / FUSE DLM Integration Tests (push) Failing after 3s
FUSE Volume Server Failover Tests / FUSE Volume Server Failover (push) Failing after 3s
FUSE Integration Tests / FUSE Integration Testing (push) Failing after 2s
FUSE P2P Peer Chunk Sharing Integration Tests / FUSE P2P Peer Chunk Sharing (push) Failing after 3s
go: build binary / Go Vet (push) Failing after 2s
go: build binary / Go Vet 32-bit (push) Failing after 3s
go: build binary / Build (push) Failing after 4s
go: build binary / Build cross-platform (freebsd/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/amd64) (push) Failing after 3s
go: build binary / Build cross-platform (darwin/arm64) (push) Failing after 3s
go: build binary / Build cross-platform (windows/arm64) (push) Failing after 3s
go: build binary / Test (push) Failing after 2s
go: build binary / Test 32-bit (push) Failing after 3s
helm: lint and test charts / lint-test (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (11) (push) Failing after 3s
Java Client Integration Tests / Java Integration Tests (17) (push) Failing after 3s
go: build dev binaries / build_dev_linux_windows (amd64, linux) (push) Failing after 2s
go: build dev binaries / build_dev_linux_windows (amd64, windows) (push) Failing after 3s
go: build dev binaries / build_dev_darwin (amd64, darwin) (push) Has been skipped
go: build dev binaries / build_dev_darwin (arm64, darwin) (push) Has been skipped
Java Client Unit Tests / Java Unit Tests (11) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (17) (push) Failing after 2s
Java Client Unit Tests / Java Unit Tests (21) (push) Failing after 3s
Java Client Unit Tests / Java Unit Tests (8) (push) Failing after 3s
Kafka Quick Test (Load Test with Schema Registry) / Kafka Client Load Test (Quick) (push) Failing after 3s
Kafka Gateway Tests / Kafka Unit Tests (unit-tests-1) (push) Failing after 11s
Kafka Gateway Tests / Kafka Integration Tests (Critical) (integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka End-to-End Tests (with SMQ) (e2e-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Consumer Group Tests (Highly Isolated) (consumer-group-1) (push) Failing after 2s
Kafka Gateway Tests / Kafka Client Compatibility (with SMQ) (client-compat-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka SMQ Integration Tests (Full Stack) (smq-integration-1) (push) Failing after 3s
Kafka Gateway Tests / Kafka Protocol Tests (Isolated) (protocol-1) (push) Failing after 3s
KMS Tests / KMS Provider Integration Tests (push) Failing after 2s
KMS Tests / S3 KMS End-to-End Tests (push) Failing after 3s
Master Cold Start Tests / Master Cold Start Tests (push) Failing after 4s
Metadata Subscribe Integration Tests / Metadata Subscribe Integration Tests (push) Failing after 3s
Multi-Master Tests / Multi-Master Failover Tests (push) Failing after 3s
Performance / CPU and Heap Profile (push) Failing after 2s
Performance / S3 Read/Write Benchmark (rust volume) (push) Failing after 3s
pjdfstest POSIX Compliance / pjdfstest (push) Failing after 2s
Plugin Worker Integration Tests / Plugin Worker: erasure_coding (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: vacuum (push) Failing after 3s
Rust Volume Server Tests / Rust Integration Tests (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 1) (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 1) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 2) (push) Failing after 3s
Rust Volume Server Tests / Go Tests with Rust Volume (grpc - Shard 3) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Distributed Tests (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Performance Tests (push) Failing after 3s
Performance / Throughput Benchmark (go volume) (push) Failing after 3s
Performance / Throughput Benchmark (rust volume) (push) Failing after 2s
Performance / S3 Read/Write Benchmark (go volume) (push) Failing after 3s
Plugin Worker Integration Tests / Plugin Worker: volume_balance (push) Failing after 3s
PostgreSQL Gateway Tests / PostgreSQL Basic Tests (push) Failing after 3s
Rust Volume Server Tests / Rust Unit Tests (push) Failing after 2s
Rust Volume Server Tests / Go Tests with Rust Volume (http - Shard 3) (push) Failing after 3s
Rust Plugin Worker Tests / Rust Plugin Worker Build and Unit Tests (push) Failing after 3s
rust: build dev volume server binaries / cleanup (push) Successful in 3s
S3 ETag and ACL Tests / S3 ETag + ACL Integration Tests (push) Failing after 3s
S3 IAM Integration Tests / IAM Unit Tests (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (advanced) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (basic) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (group) (push) Failing after 3s
S3 IAM Integration Tests / S3 IAM Integration Tests (policy-enforcement) (push) Failing after 2s
S3 IAM Integration Tests / S3 IAM Integration Tests (sts) (push) Failing after 4s
S3 Keycloak Integration Tests / S3 Keycloak Integration Tests (push) Failing after 3s
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.11) (push) Failing after 3s
S3 PyArrow Parquet Tests / Go Unit Tests (Implicit Directory) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.12) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-amd64, x86_64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-darwin (darwin-arm64, aarch64-apple-darwin) (push) Has been cancelled
rust: build dev volume server binaries / build-rust-volume-dev-linux (linux-amd64, x86_64-unknown-linux-gnu) (push) Has been cancelled
S3 PyArrow Parquet Tests / PyArrow Parquet Tests (Python 3.9) (push) Has been cancelled
S3 Proxy Signature Tests / S3 Proxy Signature Verification Tests (push) Has been cancelled
S3 SDK V2 Route Disambiguation Tests / S3 SDK V2 Routing Tests (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (quick) (push) Has been cancelled
S3 SSE Tests / S3 SSE Compatibility Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Metadata Persistence Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Copy Operations Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Multipart Upload Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Performance Test (push) Has been cancelled
S3 SSE Tests / S3 Volume Encryption Test (push) Has been cancelled
S3 SSE Tests / S3 SSE Integration Tests (comprehensive) (push) Has been cancelled
Spark Integration Tests / Spark Integration Tests (push) Failing after 2s
Telemetry Integration Tests / telemetry-integration-test (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 1) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 1) (push) Failing after 3s
Ceph S3 tests / Basic S3 tests (KV store) (push) Has been cancelled
Ceph S3 tests / S3 Versioning & Object Lock tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Unit Tests (push) Failing after 3s
Ceph S3 tests / S3 CORS tests (push) Has been cancelled
Ceph S3 tests / SeaweedFS Custom S3 Copy tests (push) Has been cancelled
Ceph S3 tests / Basic S3 tests (SQL store) (push) Has been cancelled
test s3 over https using aws-cli / awscli-tests (push) Has been cancelled
TLS Rotation Integration Tests / TLS Rotation Integration Tests (push) Has been cancelled
Vacuum Integration Tests / Vacuum Integration Tests (push) Has been cancelled
S3 Policy Integration Tests / S3 Policy Variables Integration Tests (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (advanced-policy) (push) Failing after 3s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (basic-policy) (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Enforcement Integration Tests (contextual-policy) (push) Failing after 4s
S3 Policy Integration Tests / Trusted Proxy Detection Tests (push) Failing after 2s
S3 Policy Integration Tests / S3 Policy Shell Integration Tests (push) Failing after 3s
Samba on FUSE Integration / samba-integration (push) Failing after 2s
SFTP Integration Tests / SFTP Integration Testing (push) Failing after 3s
terraform: validate and test modules / fmt, validate, plan-level tests (push) Failing after 3s
terraform: validate and test modules / local cluster smoke test (real weed) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 3) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (grpc - Shard 2) (push) Failing after 3s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 2) (push) Failing after 2s
Volume Server Integration Tests / Volume Server Integration Tests (http - Shard 3) (push) Failing after 5s
mount: windows conformance / WinFsp conformance (push) Has been cancelled
mount: windows / Mount on Windows (push) Has been cancelled
326 lines
9.4 KiB
Go
326 lines
9.4 KiB
Go
package s3api
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3_constants"
|
|
"github.com/seaweedfs/seaweedfs/weed/s3api/s3err"
|
|
)
|
|
|
|
// CopyValidationError represents validation errors during copy operations
|
|
type CopyValidationError struct {
|
|
Code s3err.ErrorCode
|
|
Message string
|
|
}
|
|
|
|
func (e *CopyValidationError) Error() string {
|
|
return e.Message
|
|
}
|
|
|
|
// ValidateCopyEncryption performs comprehensive validation of copy encryption parameters
|
|
func ValidateCopyEncryption(srcMetadata map[string][]byte, headers http.Header) error {
|
|
// Validate SSE-C copy requirements
|
|
if err := validateSSECCopyRequirements(srcMetadata, headers); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Validate SSE-KMS copy requirements
|
|
if err := validateSSEKMSCopyRequirements(srcMetadata, headers); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Validate incompatible encryption combinations
|
|
if err := validateEncryptionCompatibility(headers); err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateSSECCopyRequirements validates SSE-C copy header requirements
|
|
func validateSSECCopyRequirements(srcMetadata map[string][]byte, headers http.Header) error {
|
|
srcIsSSEC := IsSSECEncrypted(srcMetadata)
|
|
hasCopyHeaders := hasSSECCopyHeaders(headers)
|
|
hasSSECHeaders := hasSSECHeaders(headers)
|
|
|
|
// If source is SSE-C encrypted, copy headers are required
|
|
if srcIsSSEC && !hasCopyHeaders {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C encrypted source requires copy source encryption headers",
|
|
}
|
|
}
|
|
|
|
// If copy headers are provided, source must be SSE-C encrypted
|
|
if hasCopyHeaders && !srcIsSSEC {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C copy headers provided but source is not SSE-C encrypted",
|
|
}
|
|
}
|
|
|
|
// Validate copy header completeness
|
|
if hasCopyHeaders {
|
|
if err := validateSSECCopyHeaderCompleteness(headers); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
// Validate destination SSE-C headers if present
|
|
if hasSSECHeaders {
|
|
if err := validateSSECHeaderCompleteness(headers); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateSSEKMSCopyRequirements validates SSE-KMS copy requirements
|
|
func validateSSEKMSCopyRequirements(srcMetadata map[string][]byte, headers http.Header) error {
|
|
dstIsSSEKMS := IsSSEKMSRequest(&http.Request{Header: headers})
|
|
|
|
// Validate KMS key ID format if provided
|
|
if dstIsSSEKMS {
|
|
keyID := headers.Get(s3_constants.AmzServerSideEncryptionAwsKmsKeyId)
|
|
if keyID != "" && !isValidKMSKeyID(keyID) {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrKMSKeyNotFound,
|
|
Message: fmt.Sprintf("Invalid KMS key ID format: %s", keyID),
|
|
}
|
|
}
|
|
}
|
|
|
|
// Validate encryption context format if provided
|
|
if contextHeader := headers.Get(s3_constants.AmzServerSideEncryptionContext); contextHeader != "" {
|
|
if !dstIsSSEKMS {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "Encryption context can only be used with SSE-KMS",
|
|
}
|
|
}
|
|
|
|
// Validate base64 encoding and JSON format
|
|
if err := validateEncryptionContext(contextHeader); err != nil {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: fmt.Sprintf("Invalid encryption context: %v", err),
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateEncryptionCompatibility validates that encryption methods are not conflicting
|
|
func validateEncryptionCompatibility(headers http.Header) error {
|
|
sseAlgorithm := headers.Get(s3_constants.AmzServerSideEncryption)
|
|
hasSSEC := hasSSECHeaders(headers)
|
|
hasSSEKMS := sseAlgorithm == s3_constants.SSEAlgorithmKMS
|
|
hasSSES3 := sseAlgorithm == s3_constants.SSEAlgorithmAES256
|
|
|
|
// Reject unsupported algorithms so they are never persisted as a bogus
|
|
// destination header advertising encryption that was never applied.
|
|
if sseAlgorithm != "" && !hasSSEKMS && !hasSSES3 {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidEncryptionAlgorithm,
|
|
Message: fmt.Sprintf("Unsupported server-side encryption algorithm: %s", sseAlgorithm),
|
|
}
|
|
}
|
|
|
|
// Count how many encryption methods are specified
|
|
encryptionCount := 0
|
|
if hasSSEC {
|
|
encryptionCount++
|
|
}
|
|
if hasSSEKMS {
|
|
encryptionCount++
|
|
}
|
|
if hasSSES3 {
|
|
encryptionCount++
|
|
}
|
|
|
|
// Only one encryption method should be specified
|
|
if encryptionCount > 1 {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "Multiple encryption methods specified - only one is allowed",
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateSSECCopyHeaderCompleteness validates that all required SSE-C copy headers are present
|
|
func validateSSECCopyHeaderCompleteness(headers http.Header) error {
|
|
algorithm := headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerAlgorithm)
|
|
key := headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerKey)
|
|
keyMD5 := headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerKeyMD5)
|
|
|
|
if algorithm == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C copy customer algorithm header is required",
|
|
}
|
|
}
|
|
|
|
if key == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C copy customer key header is required",
|
|
}
|
|
}
|
|
|
|
if keyMD5 == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C copy customer key MD5 header is required",
|
|
}
|
|
}
|
|
|
|
// Validate algorithm
|
|
if algorithm != "AES256" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: fmt.Sprintf("Unsupported SSE-C algorithm: %s", algorithm),
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// validateSSECHeaderCompleteness validates that all required SSE-C headers are present
|
|
func validateSSECHeaderCompleteness(headers http.Header) error {
|
|
algorithm := headers.Get(s3_constants.AmzServerSideEncryptionCustomerAlgorithm)
|
|
key := headers.Get(s3_constants.AmzServerSideEncryptionCustomerKey)
|
|
keyMD5 := headers.Get(s3_constants.AmzServerSideEncryptionCustomerKeyMD5)
|
|
|
|
if algorithm == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C customer algorithm header is required",
|
|
}
|
|
}
|
|
|
|
if key == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C customer key header is required",
|
|
}
|
|
}
|
|
|
|
if keyMD5 == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "SSE-C customer key MD5 header is required",
|
|
}
|
|
}
|
|
|
|
// Validate algorithm
|
|
if algorithm != "AES256" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: fmt.Sprintf("Unsupported SSE-C algorithm: %s", algorithm),
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Helper functions for header detection
|
|
func hasSSECCopyHeaders(headers http.Header) bool {
|
|
return headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerAlgorithm) != "" ||
|
|
headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerKey) != "" ||
|
|
headers.Get(s3_constants.AmzCopySourceServerSideEncryptionCustomerKeyMD5) != ""
|
|
}
|
|
|
|
func hasSSECHeaders(headers http.Header) bool {
|
|
return headers.Get(s3_constants.AmzServerSideEncryptionCustomerAlgorithm) != "" ||
|
|
headers.Get(s3_constants.AmzServerSideEncryptionCustomerKey) != "" ||
|
|
headers.Get(s3_constants.AmzServerSideEncryptionCustomerKeyMD5) != ""
|
|
}
|
|
|
|
// validateEncryptionContext validates the encryption context header format
|
|
func validateEncryptionContext(contextHeader string) error {
|
|
// This would validate base64 encoding and JSON format
|
|
// Implementation would decode base64 and parse JSON
|
|
// For now, just check it's not empty
|
|
if contextHeader == "" {
|
|
return fmt.Errorf("encryption context cannot be empty")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// ValidateCopySource validates the copy source path.
|
|
func ValidateCopySource(copySource string, srcBucket, srcObject string) error {
|
|
return validateCopySource(copySource, srcBucket, srcObject, "")
|
|
}
|
|
|
|
func validateCopySource(copySource string, srcBucket, srcObject, srcVersionId string) error {
|
|
if copySource == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidCopySource,
|
|
Message: "Copy source header is required",
|
|
}
|
|
}
|
|
|
|
if srcBucket == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidCopySource,
|
|
Message: "Source bucket cannot be empty",
|
|
}
|
|
}
|
|
|
|
if srcObject == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidCopySource,
|
|
Message: "Source object cannot be empty",
|
|
}
|
|
}
|
|
|
|
// `.`/`..` segments are collapsed by the filer's path join; reject them as
|
|
// IsValidObjectKey does for the request URL so the source stays in-bucket.
|
|
if !s3_constants.IsValidBucketName(srcBucket) || !s3_constants.IsValidObjectKey(srcObject) {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidCopySource,
|
|
Message: "Copy source contains invalid path segments",
|
|
}
|
|
}
|
|
if !isValidVersionID(srcVersionId) {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidCopySource,
|
|
Message: "Copy source contains an invalid version ID",
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ValidateCopyDestination validates the copy destination
|
|
func ValidateCopyDestination(dstBucket, dstObject string) error {
|
|
if dstBucket == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "Destination bucket cannot be empty",
|
|
}
|
|
}
|
|
|
|
if dstObject == "" {
|
|
return &CopyValidationError{
|
|
Code: s3err.ErrInvalidRequest,
|
|
Message: "Destination object cannot be empty",
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// MapCopyValidationError maps validation errors to appropriate S3 error codes
|
|
func MapCopyValidationError(err error) s3err.ErrorCode {
|
|
if validationErr, ok := err.(*CopyValidationError); ok {
|
|
return validationErr.Code
|
|
}
|
|
return s3err.ErrInvalidRequest
|
|
}
|