snapshot of https://github.com/tldraw/tldraw.git (main, 2026-09-23; blobs > 131072B omitted)
Some checks failed
Deploy analytics worker / Deploy analytics worker to ${{ (github.ref == 'refs/heads/production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Failing after 1s
i18n upload strings / Upload latest strings (push) Failing after 1s
Deploy bemo / Deploy bemo to ${{ (github.ref == 'refs/heads/bemo-production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Failing after 1s
Deploy grafana resources / ${{ github.event_name == 'push' && 'Deploy grafana resources' || 'Validate grafana resources (dry run)' }} (push) Failing after 0s
End to end tests (dotcom) / Check for relevant changes (push) Failing after 0s
End to end tests (examples) / Check for relevant changes (push) Failing after 0s
End to end tests (mermaid readability) / Check for relevant changes (push) Failing after 1s
End to end tests (perf) / Check for relevant changes (push) Failing after 0s
Publish editor extensions / Publish editor extensions (push) Failing after 1s
Publish SDK packages / Remove the publish-packages label (push) Has been skipped
Checks / Tests & checks (push) Has been cancelled
Checks / Build all projects (push) Has been cancelled
Deploy templates / Deploy templates (push) Has been cancelled
End to end tests (dotcom) / End to end tests (dotcom) (push) Has been cancelled
End to end tests (mermaid readability) / End to end tests (mermaid readability) (push) Has been cancelled
End to end tests (perf) / End to end tests (perf) (push) Has been cancelled
Deploy .com / Deploy dotcom to ${{ (github.ref == 'refs/heads/production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Has been cancelled
End to end tests (examples) / End to end tests (examples) (push) Has been cancelled
Publish SDK packages / Publish SDK packages (push) Has been cancelled
Publish SDK packages / Tell user released version (push) Has been cancelled
Publish SDK packages / Publishes code templates to separate repositories (push) Has been cancelled
Publish SDK packages / Deploys the template demos with the new SDK version (push) Has been cancelled
Some checks failed
Deploy analytics worker / Deploy analytics worker to ${{ (github.ref == 'refs/heads/production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Failing after 1s
i18n upload strings / Upload latest strings (push) Failing after 1s
Deploy bemo / Deploy bemo to ${{ (github.ref == 'refs/heads/bemo-production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Failing after 1s
Deploy grafana resources / ${{ github.event_name == 'push' && 'Deploy grafana resources' || 'Validate grafana resources (dry run)' }} (push) Failing after 0s
End to end tests (dotcom) / Check for relevant changes (push) Failing after 0s
End to end tests (examples) / Check for relevant changes (push) Failing after 0s
End to end tests (mermaid readability) / Check for relevant changes (push) Failing after 1s
End to end tests (perf) / Check for relevant changes (push) Failing after 0s
Publish editor extensions / Publish editor extensions (push) Failing after 1s
Publish SDK packages / Remove the publish-packages label (push) Has been skipped
Checks / Tests & checks (push) Has been cancelled
Checks / Build all projects (push) Has been cancelled
Deploy templates / Deploy templates (push) Has been cancelled
End to end tests (dotcom) / End to end tests (dotcom) (push) Has been cancelled
End to end tests (mermaid readability) / End to end tests (mermaid readability) (push) Has been cancelled
End to end tests (perf) / End to end tests (perf) (push) Has been cancelled
Deploy .com / Deploy dotcom to ${{ (github.ref == 'refs/heads/production' && 'production') || (github.ref == 'refs/heads/main' && 'staging') || 'preview' }} (push) Has been cancelled
End to end tests (examples) / End to end tests (examples) (push) Has been cancelled
Publish SDK packages / Publish SDK packages (push) Has been cancelled
Publish SDK packages / Tell user released version (push) Has been cancelled
Publish SDK packages / Publishes code templates to separate repositories (push) Has been cancelled
Publish SDK packages / Deploys the template demos with the new SDK version (push) Has been cancelled
This commit is contained in:
163
apps/examples/e2e/tests/test-pointer-cancel.spec.ts
Normal file
163
apps/examples/e2e/tests/test-pointer-cancel.spec.ts
Normal file
@@ -0,0 +1,163 @@
|
||||
import { CDPSession, expect, Page } from '@playwright/test'
|
||||
import { Editor } from 'tldraw'
|
||||
import test from '../fixtures/fixtures'
|
||||
import { setupOrReset } from '../shared-e2e'
|
||||
|
||||
declare const editor: Editor
|
||||
|
||||
/*
|
||||
* Playwright's input APIs can't produce a `pointercancel`, so these tests drive
|
||||
* Chrome directly: a `touchCancel` through CDP makes the browser generate the
|
||||
* pointercancel itself, which is the path a system-interrupted touch takes (an
|
||||
* edge swipe, an incoming call). Checked against iPadOS Safari, which emits
|
||||
* `pointercancel` with `pointerType: 'touch'` and `button: -1` for those
|
||||
* gestures, and none at all for a rejected palm.
|
||||
*/
|
||||
|
||||
type TouchEventType = 'touchStart' | 'touchEnd' | 'touchMove' | 'touchCancel'
|
||||
type MouseEventType = 'mousePressed' | 'mouseReleased' | 'mouseMoved'
|
||||
|
||||
async function startTouchSession(page: Page): Promise<CDPSession> {
|
||||
const cdp = await page.context().newCDPSession(page)
|
||||
// The desktop project has no touch points of its own.
|
||||
await cdp.send('Emulation.setTouchEmulationEnabled', { enabled: true, maxTouchPoints: 5 })
|
||||
return cdp
|
||||
}
|
||||
|
||||
function touch(cdp: CDPSession, type: TouchEventType, points: [number, number][] = []) {
|
||||
return cdp.send('Input.dispatchTouchEvent', {
|
||||
type,
|
||||
touchPoints: points.map(([x, y], i) => ({ x, y, id: i })),
|
||||
})
|
||||
}
|
||||
|
||||
function pen(cdp: CDPSession, type: MouseEventType, x: number, y: number) {
|
||||
return cdp.send('Input.dispatchMouseEvent', {
|
||||
type,
|
||||
x,
|
||||
y,
|
||||
button: 'left',
|
||||
buttons: type === 'mouseReleased' ? 0 : 1,
|
||||
clickCount: 1,
|
||||
pointerType: 'pen',
|
||||
force: 0.5,
|
||||
})
|
||||
}
|
||||
|
||||
const getState = (page: Page) =>
|
||||
page.evaluate(() => ({
|
||||
path: editor.getPath(),
|
||||
isPointing: editor.inputs.getIsPointing(),
|
||||
buttons: [...editor.inputs.buttons],
|
||||
}))
|
||||
|
||||
test.describe('Cancelled pointers', () => {
|
||||
test.beforeEach(setupOrReset)
|
||||
|
||||
test('ends a select drag', async ({ page }) => {
|
||||
const cdp = await startTouchSession(page)
|
||||
await page.evaluate(() => {
|
||||
editor.setCurrentTool('select')
|
||||
})
|
||||
|
||||
await touch(cdp, 'touchStart', [[200, 300]])
|
||||
await touch(cdp, 'touchMove', [[340, 420]])
|
||||
// Pointer moves are queued until the next tick, so the transition into brushing
|
||||
// lands a frame after the CDP call resolves.
|
||||
await expect
|
||||
.poll(() => getState(page))
|
||||
.toMatchObject({ path: 'select.brushing', isPointing: true })
|
||||
|
||||
await touch(cdp, 'touchCancel')
|
||||
|
||||
// The button comes from the pointerdown: pointercancel reports -1, which would
|
||||
// otherwise stay stuck in inputs.buttons.
|
||||
expect(await getState(page)).toEqual({
|
||||
path: 'select.idle',
|
||||
isPointing: false,
|
||||
buttons: [],
|
||||
})
|
||||
})
|
||||
|
||||
test('ends a draw stroke', async ({ page }) => {
|
||||
const cdp = await startTouchSession(page)
|
||||
await page.evaluate(() => {
|
||||
editor.setCurrentTool('draw')
|
||||
})
|
||||
|
||||
await touch(cdp, 'touchStart', [[300, 300]])
|
||||
await touch(cdp, 'touchMove', [[380, 400]])
|
||||
expect(await getState(page)).toMatchObject({ path: 'draw.drawing', isPointing: true })
|
||||
|
||||
await touch(cdp, 'touchCancel')
|
||||
|
||||
expect(await getState(page)).toMatchObject({ path: 'draw.idle', isPointing: false })
|
||||
})
|
||||
|
||||
test('lets the next touch start a fresh stroke rather than continuing the old one', async ({
|
||||
page,
|
||||
}) => {
|
||||
const cdp = await startTouchSession(page)
|
||||
await page.evaluate(() => {
|
||||
editor.setCurrentTool('draw')
|
||||
})
|
||||
|
||||
await touch(cdp, 'touchStart', [[200, 300]])
|
||||
await touch(cdp, 'touchMove', [[260, 360]])
|
||||
await touch(cdp, 'touchCancel')
|
||||
|
||||
await touch(cdp, 'touchStart', [[160, 480]])
|
||||
await touch(cdp, 'touchMove', [[220, 540]])
|
||||
await touch(cdp, 'touchEnd')
|
||||
|
||||
// A draw tool left in its drawing state extends the cancelled shape instead of
|
||||
// starting a new one, so the two gestures come back as a single stroke.
|
||||
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(2)
|
||||
})
|
||||
|
||||
/**
|
||||
* iPadOS rejects a resting palm before it reaches the page, so these two never
|
||||
* fire in practice on a real device. They pin the guards that keep a cancelled
|
||||
* touch from ending the pen's own interaction if one ever does arrive.
|
||||
*/
|
||||
test.describe('in pen mode', () => {
|
||||
test('a cancelled palm landing after the pen leaves the stroke alone', async ({ page }) => {
|
||||
const cdp = await startTouchSession(page)
|
||||
await page.evaluate(() => {
|
||||
editor.updateInstanceState({ isPenMode: true })
|
||||
editor.setCurrentTool('draw')
|
||||
})
|
||||
|
||||
await pen(cdp, 'mousePressed', 300, 300)
|
||||
await pen(cdp, 'mouseMoved', 380, 400)
|
||||
|
||||
await touch(cdp, 'touchStart', [[160, 500]])
|
||||
await touch(cdp, 'touchCancel')
|
||||
|
||||
expect(await getState(page)).toMatchObject({ path: 'draw.drawing', isPointing: true })
|
||||
})
|
||||
|
||||
test('a cancelled palm landing before the pen leaves the stroke alone', async ({ page }) => {
|
||||
const cdp = await startTouchSession(page)
|
||||
await page.evaluate(() => {
|
||||
editor.updateInstanceState({ isPenMode: false })
|
||||
editor.setCurrentTool('draw')
|
||||
})
|
||||
|
||||
// The palm is accepted while pen mode is still off, so its button is recorded;
|
||||
// the pen then turns pen mode on before the palm is cancelled. The pen press
|
||||
// only auto-enables pen mode on a touch device (isDirectDisplayPen reads
|
||||
// tlenv.isTouchDevice, fixed at load), and the desktop project enables touch
|
||||
// through CDP after the page has loaded, so set it here instead.
|
||||
await touch(cdp, 'touchStart', [[160, 500]])
|
||||
await pen(cdp, 'mousePressed', 300, 300)
|
||||
await pen(cdp, 'mouseMoved', 380, 400)
|
||||
await page.evaluate(() => {
|
||||
editor.updateInstanceState({ isPenMode: true })
|
||||
})
|
||||
await touch(cdp, 'touchCancel')
|
||||
|
||||
expect(await getState(page)).toMatchObject({ path: 'draw.drawing', isPointing: true })
|
||||
})
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user