Files
upstream-twenty/packages/twenty-oxlint-rules/rules/no-icu-escaping-apostrophe.ts
upstream-mirror e7da97194a
Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
snapshot of https://github.com/twentyhq/twenty.git (main, 2026-09-17; blobs > 131072B omitted)
2026-09-17 23:28:13 +05:00

74 lines
2.2 KiB
TypeScript

import { defineRule } from '@oxlint/plugins';
export const RULE_NAME = 'no-icu-escaping-apostrophe';
const MESSAGE_TAG_NAMES = ['t', 'msg', 'defineMessage'];
const getTagName = (tag: any): string | undefined => {
if (tag.type === 'Identifier') {
return tag.name;
}
// useLingui() hands the macro back on an object, so `i18n.t` and `_.t` reach
// the extractor exactly as a bare tag does.
if (tag.type === 'MemberExpression' && tag.property.type === 'Identifier') {
return tag.property.name;
}
return undefined;
};
const countTrailingApostrophes = (text: string): number => {
const trailing = /'*$/.exec(text);
return trailing === null ? 0 : trailing[0].length;
};
// ICU reads an apostrophe placed directly before `{` as the start of a quoted
// literal, so `'{name}'` prints the placeholder instead of substituting it.
// Apostrophes pair up first: an even run is that many escaped literal
// apostrophes, and only an odd run leaves one to swallow the placeholder.
const escapesFollowingPlaceholder = (text: string): boolean =>
countTrailingApostrophes(text) % 2 === 1;
export const rule = defineRule({
meta: {
type: 'problem',
docs: {
description:
'Disallow an apostrophe directly before a Lingui placeholder, which ICU reads as an escape.',
},
messages: {
escapingApostrophe:
"An apostrophe directly before a placeholder escapes it: ICU renders the placeholder as literal text instead of substituting the value. Quote the value with double quotes, or double the apostrophe ('') to print one.",
},
schema: [],
},
create: (context) => ({
TaggedTemplateExpression: (node: any) => {
const tagName = getTagName(node.tag);
if (tagName === undefined || !MESSAGE_TAG_NAMES.includes(tagName)) {
return;
}
node.quasi.quasis.forEach((quasi: any, index: number) => {
const isFollowedByPlaceholder =
node.quasi.expressions[index] !== undefined;
if (!isFollowedByPlaceholder) {
return;
}
const text = quasi.value.cooked ?? quasi.value.raw;
if (!escapesFollowingPlaceholder(text)) {
return;
}
context.report({ node: quasi, messageId: 'escapingApostrophe' });
});
},
}),
});