Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
167 lines
5.4 KiB
TypeScript
167 lines
5.4 KiB
TypeScript
import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
|
|
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
|
|
import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
|
|
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
|
|
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
|
|
import { type NavigationMenuItemManifest } from 'twenty-shared/application';
|
|
import {
|
|
eachTestingContextFilter,
|
|
type EachTestingContext,
|
|
} from 'twenty-shared/testing';
|
|
import { NavigationMenuItemType } from 'twenty-shared/types';
|
|
|
|
const TEST_APP_ID = 'c1b2c3d4-0001-4000-a000-000000000001';
|
|
const TEST_ROLE_ID = 'c1b2c3d4-0002-4000-a000-000000000002';
|
|
const TEST_NAVIGATION_MENU_ITEM_ID = 'c1b2c3d4-0003-4000-a000-000000000003';
|
|
|
|
type TestContext = {
|
|
navigationMenuItem: NavigationMenuItemManifest;
|
|
};
|
|
|
|
const failingNavigationMenuItemSyncTestCases: EachTestingContext<TestContext>[] =
|
|
[
|
|
{
|
|
title: 'when syncing a FOLDER item without name',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.FOLDER,
|
|
position: 0,
|
|
icon: 'IconFolder',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when syncing a FOLDER item with a blank name',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.FOLDER,
|
|
position: 0,
|
|
name: ' ',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when syncing a LINK item without link',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.LINK,
|
|
position: 0,
|
|
name: 'Link without url',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when syncing a LINK item with a link that is not a valid url',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.LINK,
|
|
position: 0,
|
|
name: 'Link with invalid url',
|
|
link: 'not a link',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title:
|
|
'when syncing an OBJECT item without targetObjectUniversalIdentifier',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.OBJECT,
|
|
position: 0,
|
|
name: 'Object without target',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title:
|
|
'when syncing an OBJECT item with a targetObjectUniversalIdentifier that is not a uuid',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.OBJECT,
|
|
position: 0,
|
|
name: 'Object with malformed target',
|
|
targetObjectUniversalIdentifier: 'not-a-uuid',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title:
|
|
'when syncing a VIEW item with a viewUniversalIdentifier that is not a uuid',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.VIEW,
|
|
position: 0,
|
|
name: 'View with malformed identifier',
|
|
viewUniversalIdentifier: 'not-a-uuid',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title:
|
|
'when syncing a PAGE_LAYOUT item with a pageLayoutUniversalIdentifier that is not a uuid',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: NavigationMenuItemType.PAGE_LAYOUT,
|
|
position: 0,
|
|
name: 'Page layout with malformed identifier',
|
|
pageLayoutUniversalIdentifier: 'not-a-uuid',
|
|
},
|
|
},
|
|
},
|
|
{
|
|
title: 'when syncing an item with an unknown type',
|
|
context: {
|
|
navigationMenuItem: {
|
|
universalIdentifier: TEST_NAVIGATION_MENU_ITEM_ID,
|
|
type: 'UNKNOWN_NAVIGATION_MENU_ITEM_TYPE' as NavigationMenuItemType,
|
|
position: 0,
|
|
name: 'Item with unknown type',
|
|
},
|
|
},
|
|
},
|
|
];
|
|
|
|
describe('Sync application should fail on invalid navigation menu items', () => {
|
|
beforeAll(async () => {
|
|
await setupApplicationForSync({
|
|
applicationUniversalIdentifier: TEST_APP_ID,
|
|
name: 'Test Invalid Navigation Menu Item App',
|
|
description: 'App for testing navigation menu item manifest validation',
|
|
sourcePath: 'test-invalid-navigation-menu-item',
|
|
});
|
|
}, 60000);
|
|
|
|
afterAll(async () => {
|
|
await cleanupApplicationAndAppRegistration({
|
|
applicationUniversalIdentifier: TEST_APP_ID,
|
|
});
|
|
});
|
|
|
|
it.each(eachTestingContextFilter(failingNavigationMenuItemSyncTestCases))(
|
|
'$title',
|
|
async ({ context }) => {
|
|
const { errors } = await syncApplication({
|
|
manifest: buildBaseManifest({
|
|
appId: TEST_APP_ID,
|
|
roleId: TEST_ROLE_ID,
|
|
overrides: {
|
|
navigationMenuItems: [context.navigationMenuItem],
|
|
},
|
|
}),
|
|
expectToFail: true,
|
|
});
|
|
|
|
expectOneNotInternalServerErrorSnapshot({ errors });
|
|
},
|
|
60000,
|
|
);
|
|
});
|