Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
233 lines
7.9 KiB
TypeScript
233 lines
7.9 KiB
TypeScript
import request from 'supertest';
|
|
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
|
|
import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
|
|
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
|
|
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
|
|
import { findConnectionProvidersByApplication } from 'test/integration/metadata/suites/connection-provider/utils/find-connection-providers-by-application.util';
|
|
import { makeMetadataAPIRequestWithMemberRole } from 'test/integration/metadata/suites/utils/make-metadata-api-request-with-member-role.util';
|
|
import { generateTransientToken } from 'test/integration/utils/generate-transient-token.util';
|
|
import { getDataOrThrow } from 'test/integration/utils/query-messaging.util';
|
|
import gql from 'graphql-tag';
|
|
import { ConnectedAccountProvider } from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
import { v4 as uuidv4 } from 'uuid';
|
|
|
|
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
|
|
import { USER_WORKSPACE_DATA_SEED_IDS } from 'src/engine/workspace-manager/dev-seeder/core/utils/seed-user-workspaces.util';
|
|
|
|
const APP_ID = uuidv4();
|
|
const APP_ROLE_ID = uuidv4();
|
|
const APP_PROVIDER_ID = uuidv4();
|
|
|
|
const SHARED_BY_TIM_ID = uuidv4();
|
|
const PRIVATE_OF_TIM_ID = uuidv4();
|
|
const PRIVATE_OF_JONY_ID = uuidv4();
|
|
|
|
describe('app connection management guards (e2e)', () => {
|
|
let applicationDbId: string;
|
|
let providerDbId: string;
|
|
|
|
const insertAppConnection = async ({
|
|
id,
|
|
visibility,
|
|
userWorkspaceId,
|
|
}: {
|
|
id: string;
|
|
visibility: 'user' | 'workspace';
|
|
userWorkspaceId: string;
|
|
}): Promise<void> => {
|
|
await globalThis.testDataSource.query(
|
|
`INSERT INTO core."connectedAccount"
|
|
(id, handle, provider, visibility, "workspaceId", "userWorkspaceId",
|
|
"applicationId", "connectionProviderId")
|
|
VALUES ($1, $2, $3, $4, $5, $6, $7, $8)`,
|
|
[
|
|
id,
|
|
'slack-bot@apple.dev',
|
|
ConnectedAccountProvider.APP,
|
|
visibility,
|
|
SEED_APPLE_WORKSPACE_ID,
|
|
userWorkspaceId,
|
|
applicationDbId,
|
|
providerDbId,
|
|
],
|
|
);
|
|
};
|
|
|
|
const generateMemberTransientToken = async (): Promise<string> => {
|
|
const response = await makeMetadataAPIRequestWithMemberRole({
|
|
query: gql`
|
|
mutation GenerateTransientToken {
|
|
generateTransientToken {
|
|
transientToken {
|
|
token
|
|
}
|
|
}
|
|
}
|
|
`,
|
|
});
|
|
|
|
const data = getDataOrThrow(response) as {
|
|
generateTransientToken: { transientToken: { token: string } };
|
|
};
|
|
|
|
return data.generateTransientToken.transientToken.token;
|
|
};
|
|
|
|
const startAuthorizeAndGetErrorMessage = async ({
|
|
reconnectingConnectedAccountId,
|
|
visibility,
|
|
asMember = false,
|
|
}: {
|
|
reconnectingConnectedAccountId?: string;
|
|
visibility?: 'user' | 'workspace';
|
|
asMember?: boolean;
|
|
}): Promise<string> => {
|
|
const response = await request(`http://localhost:${APP_PORT}`)
|
|
.get('/auth/apps/authorize')
|
|
.query({
|
|
applicationId: applicationDbId,
|
|
providerName: 'slack',
|
|
transientToken: asMember
|
|
? await generateMemberTransientToken()
|
|
: await generateTransientToken(),
|
|
...(isDefined(reconnectingConnectedAccountId)
|
|
? { reconnectingConnectedAccountId }
|
|
: {}),
|
|
...(isDefined(visibility) ? { visibility } : {}),
|
|
});
|
|
|
|
expect(response.status).toBe(302);
|
|
|
|
return (
|
|
new URL(response.headers.location).searchParams.get('errorMessage') ?? ''
|
|
);
|
|
};
|
|
|
|
beforeAll(async () => {
|
|
await setupApplicationForSync({
|
|
applicationUniversalIdentifier: APP_ID,
|
|
name: 'test-app-connection-management-guards',
|
|
description: 'App for testing app connection management guards',
|
|
sourcePath: 'test-app-connection-management-guards',
|
|
});
|
|
|
|
await syncApplication({
|
|
manifest: buildBaseManifest({
|
|
appId: APP_ID,
|
|
roleId: APP_ROLE_ID,
|
|
overrides: {
|
|
connectionProviders: [
|
|
{
|
|
universalIdentifier: APP_PROVIDER_ID,
|
|
name: 'slack',
|
|
displayName: 'Slack',
|
|
type: 'oauth',
|
|
oauth: {
|
|
authorizationEndpoint: 'https://slack.com/oauth/v2/authorize',
|
|
tokenEndpoint: 'https://slack.com/api/oauth.v2.access',
|
|
scopes: ['chat:write'],
|
|
clientIdVariable: 'SLACK_CLIENT_ID',
|
|
clientSecretVariable: 'SLACK_CLIENT_SECRET',
|
|
},
|
|
},
|
|
],
|
|
},
|
|
}),
|
|
expectToFail: false,
|
|
});
|
|
|
|
jest.useRealTimers();
|
|
|
|
const [provider] = await findConnectionProvidersByApplication(APP_ID);
|
|
|
|
applicationDbId = provider.applicationId;
|
|
providerDbId = provider.id;
|
|
|
|
await insertAppConnection({
|
|
id: SHARED_BY_TIM_ID,
|
|
visibility: 'workspace',
|
|
userWorkspaceId: USER_WORKSPACE_DATA_SEED_IDS.TIM,
|
|
});
|
|
await insertAppConnection({
|
|
id: PRIVATE_OF_TIM_ID,
|
|
visibility: 'user',
|
|
userWorkspaceId: USER_WORKSPACE_DATA_SEED_IDS.TIM,
|
|
});
|
|
await insertAppConnection({
|
|
id: PRIVATE_OF_JONY_ID,
|
|
visibility: 'user',
|
|
userWorkspaceId: USER_WORKSPACE_DATA_SEED_IDS.JONY,
|
|
});
|
|
}, 180000);
|
|
|
|
afterAll(async () => {
|
|
await globalThis.testDataSource.query(
|
|
`DELETE FROM core."connectedAccount"
|
|
WHERE "workspaceId" = $1 AND "applicationId" = $2`,
|
|
[SEED_APPLE_WORKSPACE_ID, applicationDbId],
|
|
);
|
|
|
|
await cleanupApplicationAndAppRegistration({
|
|
applicationUniversalIdentifier: APP_ID,
|
|
});
|
|
}, 120000);
|
|
|
|
it('refuses to reconnect a private connection owned by another member', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
reconnectingConnectedAccountId: PRIVATE_OF_TIM_ID,
|
|
});
|
|
|
|
expect(errorMessage).toContain(
|
|
`Cannot reconnect connectedAccount ${PRIVATE_OF_TIM_ID}`,
|
|
);
|
|
});
|
|
|
|
it('lets a member with the Applications permission reconnect a workspace-shared connection', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
reconnectingConnectedAccountId: SHARED_BY_TIM_ID,
|
|
});
|
|
|
|
expect(errorMessage).not.toContain('Cannot reconnect connectedAccount');
|
|
expect(errorMessage).not.toContain('does not have permission');
|
|
});
|
|
|
|
it('refuses a member without the Applications permission to reconnect a workspace-shared connection', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
reconnectingConnectedAccountId: SHARED_BY_TIM_ID,
|
|
asMember: true,
|
|
});
|
|
|
|
expect(errorMessage).toContain('does not have permission');
|
|
});
|
|
|
|
it('refuses a member without the Applications permission to create a workspace-shared connection', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
visibility: 'workspace',
|
|
asMember: true,
|
|
});
|
|
|
|
expect(errorMessage).toContain('does not have permission');
|
|
});
|
|
|
|
it('refuses a member without the Applications permission to share their own private connection', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
reconnectingConnectedAccountId: PRIVATE_OF_JONY_ID,
|
|
visibility: 'workspace',
|
|
asMember: true,
|
|
});
|
|
|
|
expect(errorMessage).toContain('does not have permission');
|
|
});
|
|
|
|
it('lets a member without the Applications permission reconnect their own private connection', async () => {
|
|
const errorMessage = await startAuthorizeAndGetErrorMessage({
|
|
reconnectingConnectedAccountId: PRIVATE_OF_JONY_ID,
|
|
asMember: true,
|
|
});
|
|
|
|
expect(errorMessage).not.toContain('Cannot reconnect connectedAccount');
|
|
expect(errorMessage).not.toContain('does not have permission');
|
|
});
|
|
});
|