Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 3s
217 lines
5.7 KiB
TypeScript
217 lines
5.7 KiB
TypeScript
import { faker } from '@faker-js/faker';
|
|
import { type CountryCode } from 'libphonenumber-js';
|
|
import { createOneOperation } from 'test/integration/graphql/utils/create-one-operation.util';
|
|
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
|
|
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
|
|
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
|
import { updateOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata.util';
|
|
import { type EachTestingContext } from 'twenty-shared/testing';
|
|
import {
|
|
FieldMetadataType,
|
|
type AdditionalPhoneMetadata,
|
|
type PhonesMetadata,
|
|
} from 'twenty-shared/types';
|
|
|
|
const FIELD_NAME = 'phonenumber';
|
|
|
|
type TestCaseInputAndExpected = Partial<
|
|
Omit<PhonesMetadata, 'additionalPhones'>
|
|
> & {
|
|
additionalPhones?: Array<Partial<AdditionalPhoneMetadata>> | null;
|
|
};
|
|
|
|
type CreatePhoneFieldMetadataTestCase = {
|
|
input: TestCaseInputAndExpected;
|
|
expected?: TestCaseInputAndExpected;
|
|
};
|
|
|
|
const FAILING_TEST_INPUTS: { input: Partial<PhonesMetadata>; label: string }[] =
|
|
[
|
|
{
|
|
label: 'phone field without country or calling code at all',
|
|
input: {
|
|
primaryPhoneNumber: '123456789',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with invalid country code',
|
|
input: {
|
|
primaryPhoneNumber: '123456789',
|
|
primaryPhoneCallingCode: '+33',
|
|
primaryPhoneCountryCode: 'XX' as CountryCode,
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with invalid calling code',
|
|
input: {
|
|
primaryPhoneNumber: '123456789',
|
|
primaryPhoneCallingCode: '+999',
|
|
primaryPhoneCountryCode: 'FR',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with conflicting country code and calling code',
|
|
input: {
|
|
primaryPhoneNumber: '123456789',
|
|
primaryPhoneCallingCode: '+33',
|
|
primaryPhoneCountryCode: 'US',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with invalid phone number format',
|
|
input: {
|
|
primaryPhoneNumber: 'not-a-number',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with conflicting phone number country code',
|
|
input: {
|
|
primaryPhoneNumber: '+33123456789',
|
|
primaryPhoneCountryCode: 'US',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
{
|
|
label: 'phone field with conflicting phone number calling code',
|
|
input: {
|
|
primaryPhoneNumber: '+33123456789',
|
|
primaryPhoneCallingCode: '+1',
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
];
|
|
|
|
const primaryFailingTests = FAILING_TEST_INPUTS.map<
|
|
EachTestingContext<CreatePhoneFieldMetadataTestCase>
|
|
>(({ input, label }) => ({
|
|
title: `create primary ${label}`,
|
|
context: {
|
|
input: {
|
|
...input,
|
|
additionalPhones: [],
|
|
},
|
|
},
|
|
}));
|
|
|
|
const additionalPhonesNumberFailingTests = FAILING_TEST_INPUTS.map<
|
|
EachTestingContext<CreatePhoneFieldMetadataTestCase>
|
|
>(
|
|
({
|
|
input: {
|
|
primaryPhoneCallingCode,
|
|
primaryPhoneCountryCode,
|
|
primaryPhoneNumber,
|
|
},
|
|
label,
|
|
}) => ({
|
|
title: `create primary ${label}`,
|
|
context: {
|
|
input: {
|
|
additionalPhones: [
|
|
{
|
|
callingCode: primaryPhoneCallingCode,
|
|
countryCode: primaryPhoneCountryCode,
|
|
number: primaryPhoneNumber,
|
|
},
|
|
],
|
|
},
|
|
},
|
|
}),
|
|
);
|
|
|
|
const FAILING_TEST_CASES: EachTestingContext<CreatePhoneFieldMetadataTestCase>[] =
|
|
[...primaryFailingTests, ...additionalPhonesNumberFailingTests];
|
|
|
|
describe('failing create phone field metadata test suite', () => {
|
|
let createdObjectMetadataId: string;
|
|
|
|
beforeAll(async () => {
|
|
const { data } = await createOneObjectMetadata({
|
|
input: {
|
|
nameSingular: 'myTestObject',
|
|
namePlural: 'myTestObjects',
|
|
labelSingular: 'My Test Object',
|
|
labelPlural: 'My Test Objects',
|
|
icon: 'Icon123',
|
|
isLabelSyncedWithName: false,
|
|
},
|
|
});
|
|
|
|
createdObjectMetadataId = data.createOneObject.id;
|
|
|
|
await createOneFieldMetadata({
|
|
input: {
|
|
name: FIELD_NAME,
|
|
label: 'Phone number',
|
|
type: FieldMetadataType.PHONES,
|
|
objectMetadataId: createdObjectMetadataId,
|
|
isLabelSyncedWithName: false,
|
|
},
|
|
gqlFields: `
|
|
id
|
|
name
|
|
label
|
|
isLabelSyncedWithName
|
|
`,
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await updateOneObjectMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToUpdate: createdObjectMetadataId,
|
|
updatePayload: {
|
|
isActive: false,
|
|
},
|
|
},
|
|
});
|
|
await deleteOneObjectMetadata({
|
|
input: { idToDelete: createdObjectMetadataId },
|
|
});
|
|
});
|
|
|
|
test.each(FAILING_TEST_CASES)(
|
|
'it should fail to $title',
|
|
|
|
async ({ context: { input } }) => {
|
|
const {
|
|
data: { createOneResponse },
|
|
errors,
|
|
} = await createOneOperation<{
|
|
id: string;
|
|
[FIELD_NAME]: any;
|
|
}>({
|
|
objectMetadataSingularName: 'myTestObject',
|
|
input: {
|
|
id: faker.string.uuid(),
|
|
[FIELD_NAME]: input,
|
|
},
|
|
gqlFields: `
|
|
id
|
|
${FIELD_NAME} {
|
|
primaryPhoneNumber
|
|
primaryPhoneCountryCode
|
|
primaryPhoneCallingCode
|
|
additionalPhones {
|
|
number
|
|
callingCode
|
|
countryCode
|
|
}
|
|
__typename
|
|
}
|
|
`,
|
|
});
|
|
|
|
expect(createOneResponse).toBeNull();
|
|
expect(errors).toBeDefined();
|
|
expect(errors).toMatchSnapshot();
|
|
},
|
|
);
|
|
});
|