Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 3s
270 lines
8.8 KiB
TypeScript
270 lines
8.8 KiB
TypeScript
import { expectOneNotInternalServerErrorSnapshot } from 'test/integration/graphql/utils/expect-one-not-internal-server-error-snapshot.util';
|
|
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
|
|
import { deleteOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata.util';
|
|
import { updateOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/update-one-field-metadata.util';
|
|
import { createOnePageLayoutTab } from 'test/integration/metadata/suites/page-layout-tab/utils/create-one-page-layout-tab.util';
|
|
import { destroyOnePageLayoutTab } from 'test/integration/metadata/suites/page-layout-tab/utils/destroy-one-page-layout-tab.util';
|
|
import {
|
|
fetchTestFieldMetadataIds,
|
|
type TestFieldMetadataIds,
|
|
} from 'test/integration/metadata/suites/page-layout-widget/utils/fetch-test-field-metadata-ids.util';
|
|
import { createOnePageLayout } from 'test/integration/metadata/suites/page-layout/utils/create-one-page-layout.util';
|
|
import { destroyOnePageLayout } from 'test/integration/metadata/suites/page-layout/utils/destroy-one-page-layout.util';
|
|
import { updateOnePageLayoutWithTabsAndWidgets } from 'test/integration/metadata/suites/page-layout/utils/update-one-page-layout-with-tabs-and-widgets.util';
|
|
import {
|
|
AggregateOperations,
|
|
FieldMetadataType,
|
|
PageLayoutTabLayoutMode,
|
|
PageLayoutType,
|
|
ViewFilterOperand,
|
|
WidgetType,
|
|
} from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
import { v4 } from 'uuid';
|
|
|
|
import { WidgetConfigurationType } from 'src/engine/metadata-modules/page-layout-widget/enums/widget-configuration-type.type';
|
|
import { type AllPageLayoutWidgetConfiguration } from 'src/engine/metadata-modules/page-layout-widget/types/all-page-layout-widget-configuration.type';
|
|
|
|
describe('Page layout with tabs update should fail', () => {
|
|
it('when updating a non-existent page layout', async () => {
|
|
const tabId = 'bb4bd7f2-2f89-429c-9d85-8c20a6f776ea';
|
|
const widgetId = 'cf89849b-2106-4b51-8945-359ffeb88141';
|
|
|
|
const { errors } = await updateOnePageLayoutWithTabsAndWidgets({
|
|
expectToFail: true,
|
|
input: {
|
|
id: '5b66ba47-198c-4b0d-8583-cd4745f8f9f3',
|
|
name: 'Updated Name',
|
|
type: PageLayoutType.RECORD_PAGE,
|
|
objectMetadataId: null,
|
|
tabs: [
|
|
{
|
|
id: tabId,
|
|
title: 'Tab 1',
|
|
position: 0,
|
|
widgets: [
|
|
{
|
|
id: widgetId,
|
|
pageLayoutTabId: tabId,
|
|
title: 'Widget 1',
|
|
type: WidgetType.FIELDS,
|
|
objectMetadataId: null,
|
|
position: {
|
|
layoutMode: PageLayoutTabLayoutMode.GRID as const,
|
|
row: 0,
|
|
column: 0,
|
|
rowSpan: 1,
|
|
columnSpan: 1,
|
|
},
|
|
configuration: {
|
|
configurationType: WidgetConfigurationType.IFRAME,
|
|
},
|
|
},
|
|
],
|
|
},
|
|
],
|
|
},
|
|
});
|
|
|
|
expectOneNotInternalServerErrorSnapshot({ errors });
|
|
});
|
|
|
|
describe('chart filter validation failures', () => {
|
|
let testFieldMetadataIds: TestFieldMetadataIds;
|
|
let testPageLayoutId: string | undefined;
|
|
let testPageLayoutTabId: string | undefined;
|
|
let testFilterFieldMetadataId: string | undefined;
|
|
let testFilterFieldDeleted = false;
|
|
|
|
beforeAll(async () => {
|
|
testFieldMetadataIds = await fetchTestFieldMetadataIds();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
const filterFieldName = `deletedFilterField${Date.now()}`;
|
|
|
|
const { data: createdFieldData } = await createOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
objectMetadataId: testFieldMetadataIds.objectMetadataId,
|
|
type: FieldMetadataType.TEXT,
|
|
label: 'Deleted Filter Field',
|
|
name: filterFieldName,
|
|
isLabelSyncedWithName: false,
|
|
},
|
|
});
|
|
|
|
testFilterFieldMetadataId = createdFieldData.createOneField.id;
|
|
|
|
const { data: layoutData } = await createOnePageLayout({
|
|
expectToFail: false,
|
|
input: {
|
|
name: 'Deleted Filter Field Layout',
|
|
type: PageLayoutType.RECORD_PAGE,
|
|
},
|
|
});
|
|
|
|
testPageLayoutId = layoutData.createPageLayout.id;
|
|
|
|
const { data: tabData } = await createOnePageLayoutTab({
|
|
expectToFail: false,
|
|
input: {
|
|
title: 'Deleted Filter Field Tab',
|
|
pageLayoutId: testPageLayoutId,
|
|
},
|
|
});
|
|
|
|
testPageLayoutTabId = tabData.createPageLayoutTab.id;
|
|
testFilterFieldDeleted = false;
|
|
});
|
|
|
|
afterEach(async () => {
|
|
if (isDefined(testFilterFieldMetadataId) && !testFilterFieldDeleted) {
|
|
await updateOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToUpdate: testFilterFieldMetadataId,
|
|
updatePayload: {
|
|
isActive: false,
|
|
},
|
|
},
|
|
});
|
|
await deleteOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToDelete: testFilterFieldMetadataId,
|
|
},
|
|
});
|
|
}
|
|
|
|
if (isDefined(testPageLayoutTabId)) {
|
|
await destroyOnePageLayoutTab({
|
|
expectToFail: false,
|
|
input: { id: testPageLayoutTabId },
|
|
});
|
|
}
|
|
|
|
if (isDefined(testPageLayoutId)) {
|
|
await destroyOnePageLayout({
|
|
expectToFail: false,
|
|
input: { id: testPageLayoutId },
|
|
});
|
|
}
|
|
|
|
testFilterFieldMetadataId = undefined;
|
|
testPageLayoutTabId = undefined;
|
|
testPageLayoutId = undefined;
|
|
testFilterFieldDeleted = false;
|
|
});
|
|
|
|
it('when saving layout tabs and widgets with a deleted chart filter field', async () => {
|
|
if (
|
|
!isDefined(testPageLayoutId) ||
|
|
!isDefined(testPageLayoutTabId) ||
|
|
!isDefined(testFilterFieldMetadataId)
|
|
) {
|
|
throw new Error('Test setup incomplete');
|
|
}
|
|
|
|
const chartWidgetId = v4();
|
|
const chartTitle = 'Opportunities by Name';
|
|
const chartConfiguration = {
|
|
configurationType: WidgetConfigurationType.PIE_CHART,
|
|
aggregateFieldMetadataId: testFieldMetadataIds.fieldMetadataId1,
|
|
aggregateOperation: AggregateOperations.COUNT,
|
|
groupByFieldMetadataId: testFieldMetadataIds.fieldMetadataId2,
|
|
filter: {
|
|
recordFilters: [
|
|
{
|
|
fieldMetadataId: testFilterFieldMetadataId,
|
|
operand: ViewFilterOperand.CONTAINS,
|
|
value: 'acme',
|
|
},
|
|
],
|
|
recordFilterGroups: [],
|
|
},
|
|
} satisfies AllPageLayoutWidgetConfiguration;
|
|
|
|
const tabs = [
|
|
{
|
|
id: testPageLayoutTabId,
|
|
title: 'Deleted Filter Field Tab',
|
|
position: 0,
|
|
widgets: [
|
|
{
|
|
id: chartWidgetId,
|
|
pageLayoutTabId: testPageLayoutTabId,
|
|
title: chartTitle,
|
|
type: WidgetType.GRAPH,
|
|
objectMetadataId: testFieldMetadataIds.objectMetadataId,
|
|
position: {
|
|
layoutMode: PageLayoutTabLayoutMode.GRID as const,
|
|
row: 0,
|
|
column: 0,
|
|
rowSpan: 1,
|
|
columnSpan: 1,
|
|
},
|
|
configuration: chartConfiguration,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
|
|
await updateOnePageLayoutWithTabsAndWidgets({
|
|
expectToFail: false,
|
|
input: {
|
|
id: testPageLayoutId,
|
|
name: 'Deleted Filter Field Layout',
|
|
type: PageLayoutType.RECORD_PAGE,
|
|
objectMetadataId: null,
|
|
tabs,
|
|
},
|
|
});
|
|
|
|
await updateOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToUpdate: testFilterFieldMetadataId,
|
|
updatePayload: {
|
|
isActive: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
await deleteOneFieldMetadata({
|
|
expectToFail: false,
|
|
input: {
|
|
idToDelete: testFilterFieldMetadataId,
|
|
},
|
|
});
|
|
|
|
testFilterFieldDeleted = true;
|
|
|
|
const { errors } = await updateOnePageLayoutWithTabsAndWidgets({
|
|
expectToFail: true,
|
|
input: {
|
|
id: testPageLayoutId,
|
|
name: 'Deleted Filter Field Layout',
|
|
type: PageLayoutType.RECORD_PAGE,
|
|
objectMetadataId: null,
|
|
tabs,
|
|
},
|
|
});
|
|
|
|
expect(errors).toBeDefined();
|
|
expect(errors).toHaveLength(1);
|
|
|
|
const [firstError] = errors!;
|
|
|
|
expect(firstError.extensions.code).toBe('BAD_USER_INPUT');
|
|
expect(firstError.message).toContain(`Chart "${chartTitle}":`);
|
|
expect(firstError.message).toContain(
|
|
'Please remove or replace this filter rule.',
|
|
);
|
|
expect(String(firstError.extensions.userFriendlyMessage)).toContain(
|
|
`Chart "${chartTitle}":`,
|
|
);
|
|
});
|
|
});
|
|
});
|