Some checks failed
App Prod-Parity E2E Dispatch / dispatch (push) Failing after 10s
CD Storybook UI / build (push) Failing after 3m25s
CD Storybook UI / dispatch (push) Has been skipped
CD deploy main / website-changed-files (push) Successful in 18m8s
CI Agent Skills / changed-files-check (push) Successful in 18m9s
CI Create App E2E minimal / changed-files-check (push) Successful in 24s
CI Create App / changed-files-check (push) Successful in 26s
CI Docs / changed-files-check (push) Successful in 26s
CI Emails / changed-files-check (push) Successful in 28s
CI Example App Hello World / changed-files-check (push) Successful in 23s
CI Front / changed-files-check (push) Has been skipped
CI Example App Postcard / changed-files-check (push) Successful in 27s
CI UI / changed-files-check (push) Has been skipped
CI Utils Test / changed-files-check (push) Successful in 45s
CI Twenty Apps / discover (push) Successful in 1m3s
CD deploy main / deploy-main (push) Failing after 3s
CI Agent Skills / agent-skills-validate (push) Has been skipped
CI Create App / create-app-test (lint) (push) Has been skipped
CI Emails / emails-test (push) Has been skipped
CI Front / front-task (lingui:compile) (push) Has been skipped
CI Front / front-task (lint) (push) Has been skipped
CI Example App Postcard / example-app-postcard (push) Has been skipped
CI UI / ui-task (lint) (push) Has been skipped
CI UI / ui-task (pack-size) (push) Has been skipped
CI UI / ui-task (size) (push) Has been skipped
CI UI / ui-task (test) (push) Has been skipped
CI UI / ui-task (typecheck) (push) Has been skipped
CI Utils Test / utils-test (push) Has been skipped
CI Twenty Apps / ${{ matrix.app.name }} (push) Has been skipped
CI Emails / ci-emails-status-check (push) Successful in 2s
CI Example App Hello World / ci-example-app-hello-world-status-check (push) Successful in 2s
CI Example App Postcard / ci-example-app-postcard-status-check (push) Successful in 3s
CI UI / ui-sb-test (push) Has been skipped
CI Utils Test / ci-utils-test-status-check (push) Successful in 2s
CI Twenty Apps / ci-twenty-apps-status-check (push) Successful in 2s
CI UI / ci-ui-status-check (push) Successful in 2s
CI Desktop / desktop (push) Failing after 1m8s
Push docs to Crowdin / Push documentation to Crowdin (push) Failing after 55s
Push translations to Crowdin / Extract and upload translations (push) Failing after 5s
Push website translations to Crowdin / Extract and upload website translations (push) Failing after 5s
CI Create App / create-app-test (test) (push) Has been skipped
CI Create App / create-app-test (typecheck) (push) Has been skipped
CI Docs / docs-lint (push) Has been skipped
CI Example App Hello World / example-app-hello-world (push) Has been skipped
CI Front / front-task (lingui:extract) (push) Has been skipped
CI Front / front-task (test) (push) Has been skipped
CI Front / front-task (typecheck) (push) Has been skipped
CI UI / ui-sb-build (push) Failing after 1m32s
CI Twenty Apps / ${{ matrix.app.name }} (${{ matrix.server-source }}) (push) Has been skipped
CI Agent Skills / agent-skills-publish (push) Has been skipped
CI Create App / ci-create-app-status-check (push) Successful in 2s
CI Agent Skills / agent-skills-remote-source (push) Has been skipped
CI Create App E2E minimal / create-app-e2e-minimal (push) Has been cancelled
CI E2E Main / e2e-test (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-build (push) Has been cancelled
CI Create App E2E minimal / ci-create-app-e2e-minimal-status-check (push) Has been cancelled
CI E2E Main / ci-e2e-main-status-check (push) Has been cancelled
CI E2E Main / notify-main-ci-failure (push) Has been cancelled
CI E2E Main / qa-scout-comment (push) Has been cancelled
CI Front / front-sb-test (push) Has been cancelled
CI Front / front-sb-screenshots (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
DPA Sub-Processor Sync / sync-subprocessors (push) Failing after 3s
AI Catalog Sync / sync-catalog (push) Failing after 2s
326 lines
12 KiB
TypeScript
326 lines
12 KiB
TypeScript
import request from 'supertest';
|
|
import { buildBaseManifest } from 'test/integration/metadata/suites/application/utils/build-base-manifest.util';
|
|
import { cleanupApplicationAndAppRegistration } from 'test/integration/metadata/suites/application/utils/cleanup-application-and-app-registration.util';
|
|
import { setupApplicationForSync } from 'test/integration/metadata/suites/application/utils/setup-application-for-sync.util';
|
|
import { syncApplication } from 'test/integration/metadata/suites/application/utils/sync-application.util';
|
|
import { uploadApplicationFile } from 'test/integration/metadata/suites/application/utils/upload-application-file.util';
|
|
import { expectOneNotInternalServerErrorHttpResponseSnapshot } from 'test/integration/utils/expect-one-not-internal-server-error-http-response-snapshot.util';
|
|
import {
|
|
type LogicFunctionManifest,
|
|
type ServerRouteTriggerSettings,
|
|
} from 'twenty-shared/application';
|
|
import { LOGIC_FUNCTION_HTTP_RESPONSE_MARKER } from 'twenty-shared/types';
|
|
import { isDefined } from 'twenty-shared/utils';
|
|
|
|
import { SEED_APPLE_WORKSPACE_ID } from 'src/engine/workspace-manager/dev-seeder/core/constants/seeder-workspaces.constant';
|
|
|
|
const OWNER_WORKSPACE_ID = SEED_APPLE_WORKSPACE_ID;
|
|
|
|
const APP_UNIVERSAL_IDENTIFIER = 'd41340eb-6cc9-4383-8b04-9be7dc794bb1';
|
|
const ROLE_UNIVERSAL_IDENTIFIER = 'e5b19f77-3e1c-4a10-9c2e-56d6b0f8a3d2';
|
|
|
|
const NON_EXPOSED_FUNCTION_UNIVERSAL_IDENTIFIER =
|
|
'1a1f983f-5c1a-4c60-a3c8-7d0e2a4a11a1';
|
|
const EXPOSED_RESOLVER_UNIVERSAL_IDENTIFIER =
|
|
'2b2f983f-5c1a-4c60-a3c8-7d0e2a4a22b2';
|
|
const AUTH_REQUIRED_RESOLVER_UNIVERSAL_IDENTIFIER =
|
|
'3c3f983f-5c1a-4c60-a3c8-7d0e2a4a33c3';
|
|
const TARGET_FUNCTION_UNIVERSAL_IDENTIFIER =
|
|
'4d4f983f-5c1a-4c60-a3c8-7d0e2a4a44d4';
|
|
const HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER =
|
|
'5e5f983f-5c1a-4c60-a3c8-7d0e2a4a55e5';
|
|
const GET_HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER =
|
|
'6f6f983f-5c1a-4c60-a3c8-7d0e2a4a66f6';
|
|
|
|
const TARGET_FUNCTION_RESPONSE = { greeting: 'hello from target function' };
|
|
|
|
// Built (ESM) handler code executed by the logic function driver. The resolver
|
|
// routes the public request to the target function in the owner workspace.
|
|
const RESOLVER_BUILT_HANDLER_CODE = `export const main = async () => ({
|
|
workspaceId: '${OWNER_WORKSPACE_ID}',
|
|
targetLogicFunctionUniversalIdentifier: '${TARGET_FUNCTION_UNIVERSAL_IDENTIFIER}',
|
|
});
|
|
`;
|
|
|
|
const HANDSHAKE_RESOLVER_BUILT_HANDLER_CODE = `export const main = async (event) => ({
|
|
${LOGIC_FUNCTION_HTTP_RESPONSE_MARKER}: true,
|
|
status: 200,
|
|
body: { challenge: event.body.challenge },
|
|
});
|
|
`;
|
|
|
|
// Mirrors how a provider verifies a webhook: the challenge arrives in the query
|
|
// string of a GET, and the answer must be the bare value, not JSON.
|
|
const GET_HANDSHAKE_RESOLVER_BUILT_HANDLER_CODE = `export const main = async (event) => ({
|
|
${LOGIC_FUNCTION_HTTP_RESPONSE_MARKER}: true,
|
|
status: 200,
|
|
headers: { 'content-type': 'text/plain' },
|
|
body: event.queryStringParameters['hub.challenge'],
|
|
});
|
|
`;
|
|
|
|
const TARGET_BUILT_HANDLER_CODE = `export const main = async () => (${JSON.stringify(
|
|
TARGET_FUNCTION_RESPONSE,
|
|
)});
|
|
`;
|
|
|
|
const buildLogicFunctionManifest = ({
|
|
universalIdentifier,
|
|
name,
|
|
serverRouteExposed,
|
|
authRequired,
|
|
httpMethods,
|
|
}: {
|
|
universalIdentifier: string;
|
|
name: string;
|
|
serverRouteExposed: boolean;
|
|
authRequired: boolean;
|
|
httpMethods?: ServerRouteTriggerSettings['httpMethods'];
|
|
}): LogicFunctionManifest => ({
|
|
universalIdentifier,
|
|
name,
|
|
handlerName: 'main',
|
|
sourceHandlerPath: `src/${name}.ts`,
|
|
builtHandlerPath: `dist/${name}.mjs`,
|
|
builtHandlerChecksum: `checksum-${name}`,
|
|
...(authRequired
|
|
? {
|
|
httpRouteTriggerSettings: {
|
|
path: `/${name}`,
|
|
httpMethod: 'POST',
|
|
isAuthRequired: true,
|
|
},
|
|
}
|
|
: {}),
|
|
...(serverRouteExposed
|
|
? {
|
|
serverRouteTriggerSettings: {
|
|
forwardedRequestHeaders: [],
|
|
...(isDefined(httpMethods) ? { httpMethods } : {}),
|
|
},
|
|
}
|
|
: {}),
|
|
});
|
|
|
|
const uploadBuiltHandlerFile = async ({
|
|
builtHandlerPath,
|
|
builtHandlerCode,
|
|
}: {
|
|
builtHandlerPath: string;
|
|
builtHandlerCode: string;
|
|
}) => {
|
|
jest.useRealTimers();
|
|
|
|
await uploadApplicationFile({
|
|
applicationUniversalIdentifier: APP_UNIVERSAL_IDENTIFIER,
|
|
fileFolder: 'BuiltLogicFunction',
|
|
filePath: builtHandlerPath,
|
|
fileBuffer: Buffer.from(builtHandlerCode),
|
|
filename: builtHandlerPath.split('/').pop() as string,
|
|
contentType: 'application/javascript',
|
|
expectToFail: false,
|
|
});
|
|
|
|
jest.useFakeTimers();
|
|
};
|
|
|
|
describe('ServerRouteTrigger authorization (integration)', () => {
|
|
const baseUrl = `http://localhost:${APP_PORT}`;
|
|
|
|
beforeAll(async () => {
|
|
await setupApplicationForSync({
|
|
applicationUniversalIdentifier: APP_UNIVERSAL_IDENTIFIER,
|
|
name: 'Server Route Auth Test App',
|
|
description: 'App for testing server route trigger authorization',
|
|
sourcePath: 'server-route-auth-test-app',
|
|
});
|
|
|
|
await uploadBuiltHandlerFile({
|
|
builtHandlerPath: 'dist/exposed-resolver.mjs',
|
|
builtHandlerCode: RESOLVER_BUILT_HANDLER_CODE,
|
|
});
|
|
|
|
await uploadBuiltHandlerFile({
|
|
builtHandlerPath: 'dist/handshake-resolver.mjs',
|
|
builtHandlerCode: HANDSHAKE_RESOLVER_BUILT_HANDLER_CODE,
|
|
});
|
|
|
|
await uploadBuiltHandlerFile({
|
|
builtHandlerPath: 'dist/get-handshake-resolver.mjs',
|
|
builtHandlerCode: GET_HANDSHAKE_RESOLVER_BUILT_HANDLER_CODE,
|
|
});
|
|
|
|
await uploadBuiltHandlerFile({
|
|
builtHandlerPath: 'dist/target-function.mjs',
|
|
builtHandlerCode: TARGET_BUILT_HANDLER_CODE,
|
|
});
|
|
|
|
await syncApplication({
|
|
manifest: buildBaseManifest({
|
|
appId: APP_UNIVERSAL_IDENTIFIER,
|
|
roleId: ROLE_UNIVERSAL_IDENTIFIER,
|
|
overrides: {
|
|
logicFunctions: [
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: NON_EXPOSED_FUNCTION_UNIVERSAL_IDENTIFIER,
|
|
name: 'non-exposed-function',
|
|
serverRouteExposed: false,
|
|
authRequired: true,
|
|
}),
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: EXPOSED_RESOLVER_UNIVERSAL_IDENTIFIER,
|
|
name: 'exposed-resolver',
|
|
serverRouteExposed: true,
|
|
authRequired: false,
|
|
}),
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: AUTH_REQUIRED_RESOLVER_UNIVERSAL_IDENTIFIER,
|
|
name: 'auth-required-resolver',
|
|
serverRouteExposed: true,
|
|
authRequired: true,
|
|
}),
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER,
|
|
name: 'handshake-resolver',
|
|
serverRouteExposed: true,
|
|
authRequired: false,
|
|
}),
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: GET_HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER,
|
|
name: 'get-handshake-resolver',
|
|
serverRouteExposed: true,
|
|
authRequired: false,
|
|
httpMethods: ['GET', 'POST'],
|
|
}),
|
|
buildLogicFunctionManifest({
|
|
universalIdentifier: TARGET_FUNCTION_UNIVERSAL_IDENTIFIER,
|
|
name: 'target-function',
|
|
serverRouteExposed: false,
|
|
authRequired: false,
|
|
}),
|
|
],
|
|
},
|
|
}),
|
|
expectToFail: false,
|
|
});
|
|
}, 60000);
|
|
|
|
afterAll(async () => {
|
|
await cleanupApplicationAndAppRegistration({
|
|
applicationUniversalIdentifier: APP_UNIVERSAL_IDENTIFIER,
|
|
});
|
|
}, 60000);
|
|
|
|
describe('POST /webhooks/server/:universalIdentifier (public, unauthenticated)', () => {
|
|
it('rejects an owner-workspace function without serverRouteTriggerSettings before executing it', async () => {
|
|
const response = await request(baseUrl)
|
|
.post(`/webhooks/server/${NON_EXPOSED_FUNCTION_UNIVERSAL_IDENTIFIER}`)
|
|
.send({ any: 'payload' });
|
|
|
|
expect(response.status).toBe(404);
|
|
expectOneNotInternalServerErrorHttpResponseSnapshot({
|
|
status: response.status,
|
|
body: response.body,
|
|
});
|
|
});
|
|
|
|
it('dispatches a server-route-exposed resolver, queues the target, and acks with 200', async () => {
|
|
const response = await request(baseUrl)
|
|
.post(`/webhooks/server/${EXPOSED_RESOLVER_UNIVERSAL_IDENTIFIER}`)
|
|
.send({ any: 'payload' });
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(response.body).toEqual({ queued: true });
|
|
}, 60000);
|
|
|
|
it('answers the caller with the response returned by the resolver', async () => {
|
|
const response = await request(baseUrl)
|
|
.post(`/webhooks/server/${HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER}`)
|
|
.send({ type: 'url_verification', challenge: 'abc123' });
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(response.body).toEqual({ challenge: 'abc123' });
|
|
}, 60000);
|
|
|
|
it('rejects a server-route-exposed resolver that requires authentication before executing it', async () => {
|
|
const response = await request(baseUrl)
|
|
.post(`/webhooks/server/${AUTH_REQUIRED_RESOLVER_UNIVERSAL_IDENTIFIER}`)
|
|
.send({ any: 'payload' });
|
|
|
|
expect(response.status).toBe(403);
|
|
expectOneNotInternalServerErrorHttpResponseSnapshot({
|
|
status: response.status,
|
|
body: response.body,
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('GET /webhooks/server/:universalIdentifier (public, unauthenticated)', () => {
|
|
it('rejects a GET on a resolver that did not declare it', async () => {
|
|
const response = await request(baseUrl).get(
|
|
`/webhooks/server/${EXPOSED_RESOLVER_UNIVERSAL_IDENTIFIER}`,
|
|
);
|
|
|
|
expect(response.status).toBe(405);
|
|
expectOneNotInternalServerErrorHttpResponseSnapshot({
|
|
status: response.status,
|
|
body: response.body,
|
|
});
|
|
});
|
|
|
|
// Express dispatches HEAD to the GET handler, so it reaches the same gate.
|
|
it('rejects a HEAD on a resolver that did not declare it', async () => {
|
|
const response = await request(baseUrl).head(
|
|
`/webhooks/server/${EXPOSED_RESOLVER_UNIVERSAL_IDENTIFIER}`,
|
|
);
|
|
|
|
expect(response.status).toBe(405);
|
|
});
|
|
|
|
it('answers the verification challenge of a resolver that declared GET', async () => {
|
|
const response = await request(baseUrl)
|
|
.get(`/webhooks/server/${GET_HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER}`)
|
|
.query({
|
|
'hub.mode': 'subscribe',
|
|
'hub.challenge': 'challenge-abc123',
|
|
'hub.verify_token': 'a-token',
|
|
});
|
|
|
|
expect(response.status).toBe(200);
|
|
expect(response.headers['content-type']).toContain('text/plain');
|
|
expect(response.text).toBe('challenge-abc123');
|
|
}, 60000);
|
|
|
|
// HEAD is not an HTTPMethod a resolver can declare, so it stays rejected even
|
|
// on a route that answers GET, rather than executing the function for a
|
|
// request that cannot carry the challenge back.
|
|
it('rejects a HEAD on a resolver that declared GET', async () => {
|
|
const response = await request(baseUrl).head(
|
|
`/webhooks/server/${GET_HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER}`,
|
|
);
|
|
|
|
expect(response.status).toBe(405);
|
|
});
|
|
|
|
it('still dispatches a POST on a resolver that declared both methods', async () => {
|
|
const response = await request(baseUrl)
|
|
.post(`/webhooks/server/${GET_HANDSHAKE_RESOLVER_UNIVERSAL_IDENTIFIER}`)
|
|
.send({ any: 'payload' });
|
|
|
|
expect(response.status).toBe(200);
|
|
}, 60000);
|
|
|
|
it('answers 404, not 405, for an identifier that resolves to nothing', async () => {
|
|
const response = await request(baseUrl).get(
|
|
`/webhooks/server/${NON_EXPOSED_FUNCTION_UNIVERSAL_IDENTIFIER}`,
|
|
);
|
|
|
|
expect(response.status).toBe(404);
|
|
expectOneNotInternalServerErrorHttpResponseSnapshot({
|
|
status: response.status,
|
|
body: response.body,
|
|
});
|
|
});
|
|
});
|
|
});
|