snapshot of https://github.com/zulip/zulip.git @ 48c69911c7dd4e03b20552eb3bd77ad8151c1357 (2026-09-15)
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
This commit is contained in:
81
tools/check-capitalization
Executable file
81
tools/check-capitalization
Executable file
@@ -0,0 +1,81 @@
|
||||
#!/usr/bin/env python3
|
||||
|
||||
import argparse
|
||||
import json
|
||||
import os
|
||||
import re
|
||||
import subprocess
|
||||
import sys
|
||||
|
||||
sys.path.append(os.path.join(os.path.dirname(__file__), ".."))
|
||||
|
||||
# check for the venv
|
||||
from tools.lib import sanity_check
|
||||
|
||||
sanity_check.check_venv(__file__)
|
||||
|
||||
from scripts.lib.zulip_tools import ENDC, FAIL, WARNING
|
||||
from tools.lib.capitalization import check_capitalization
|
||||
|
||||
DJANGO_PO_REGEX = re.compile(r'msgid "(.*?)"')
|
||||
|
||||
if __name__ == "__main__":
|
||||
parser = argparse.ArgumentParser()
|
||||
parser.add_argument(
|
||||
"--show-ignored",
|
||||
action="store_true",
|
||||
help="Show strings that passed the check because they contained ignored phrases.",
|
||||
)
|
||||
parser.add_argument(
|
||||
"--no-generate", action="store_true", help="Don't run makemessages command."
|
||||
)
|
||||
args = parser.parse_args()
|
||||
|
||||
if not args.no_generate:
|
||||
subprocess.check_call(
|
||||
["./manage.py", "makemessages", "--locale", "en"], stderr=subprocess.STDOUT
|
||||
)
|
||||
|
||||
with open("locale/en/translations.json") as f:
|
||||
data = json.load(f)
|
||||
frontend = check_capitalization(list(data.keys()))
|
||||
frontend_errors, frontend_ignored, banned_errors_front = frontend
|
||||
|
||||
with open("locale/en/LC_MESSAGES/django.po") as f:
|
||||
rows = [r for r in DJANGO_PO_REGEX.findall(f.read()) if r]
|
||||
backend = check_capitalization(rows)
|
||||
backend_errors, backend_ignored, banned_errors_back = backend
|
||||
|
||||
if frontend_errors:
|
||||
print(WARNING + "Strings not properly capitalized in frontend:" + ENDC)
|
||||
print("\n".join(frontend_errors))
|
||||
|
||||
if backend_errors:
|
||||
print(WARNING + "Strings not properly capitalized in backend:" + ENDC)
|
||||
print("\n".join(backend_errors))
|
||||
|
||||
if banned_errors_front:
|
||||
print(WARNING + "Found banned words in frontend strings" + ENDC)
|
||||
print("\n".join(banned_errors_front))
|
||||
|
||||
if banned_errors_back:
|
||||
print(WARNING + "Found banned words in backend strings" + ENDC)
|
||||
print("\n".join(banned_errors_back))
|
||||
|
||||
if args.show_ignored:
|
||||
print(WARNING + "Strings which were ignored: " + ENDC)
|
||||
print("\n".join(frontend_ignored + backend_ignored))
|
||||
|
||||
if frontend_errors or backend_errors or banned_errors_back or banned_errors_front:
|
||||
# Point the user to the documentation on what the policy is.
|
||||
docs_url = (
|
||||
"https://zulip.readthedocs.io/en/latest/translating/translating.html#capitalization"
|
||||
)
|
||||
print()
|
||||
print(WARNING + "You can usually find strings using `git grep 'String to find'`" + ENDC)
|
||||
print(WARNING + "See also " + docs_url + ENDC)
|
||||
print()
|
||||
print(FAIL + "Failed!" + ENDC)
|
||||
sys.exit(1)
|
||||
else:
|
||||
sys.exit(0)
|
||||
Reference in New Issue
Block a user