snapshot of https://github.com/zulip/zulip.git @ 48c69911c7dd4e03b20552eb3bd77ad8151c1357 (2026-09-15)
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
Some checks failed
Code scanning / CodeQL (push) Failing after 15s
Zulip production suite / Ubuntu 22.04 production build (push) Failing after 26s
Zulip production suite / Debian 12 production install with custom db name and user (push) Has been skipped
Zulip production suite / Ubuntu 22.04 production install and PostgreSQL upgrade with pgroonga (push) Has been skipped
Zulip production suite / Ubuntu 24.04 production install (push) Has been skipped
Zulip production suite / Ubuntu 26.04 production install (push) Has been skipped
Zulip production suite / Debian 13 production install (push) Has been skipped
Zulip production suite / 7.0 Version Upgrade (push) Has been skipped
Zulip production suite / 8.0 Version Upgrade (push) Has been skipped
Zulip production suite / 6.0 Version Upgrade (push) Has been skipped
Zulip production suite / 10.0 Version Upgrade (push) Has been skipped
Zulip production suite / 9.0 Version Upgrade (push) Has been skipped
Zulip production suite / 12.0 Version Upgrade (push) Has been skipped
Zulip production suite / 11.0 Version Upgrade (push) Has been skipped
GitHub Actions Security Analysis with zizmor / zizmor (push) Failing after 3s
Zulip CI / Debian 12 (Python 3.11, backend + documentation) (push) Failing after 26s
Zulip CI / Ubuntu 22.04 (Python 3.10, backend + frontend) (push) Failing after 3s
Zulip CI / Ubuntu 24.04 (Python 3.12, backend) (push) Failing after 25s
Zulip CI / Ubuntu 26.04 (Python 3.14, backend) (push) Failing after 25s
Zulip CI / Debian 13 (Python 3.13, backend) (push) Failing after 28s
Zulip production suite / Required jobs (push) Has been cancelled
Zulip CI / Required jobs (push) Has been cancelled
API Documentation Update Check / check-feature-level-updated (push) Has been cancelled
API Documentation Update Check / notify-if-api-docs-changed (push) Has been cancelled
This commit is contained in:
84
web/tests/message_util.test.cjs
Normal file
84
web/tests/message_util.test.cjs
Normal file
@@ -0,0 +1,84 @@
|
||||
"use strict";
|
||||
|
||||
const assert = require("node:assert/strict");
|
||||
|
||||
const {mock_esm, zrequire} = require("./lib/namespace.cjs");
|
||||
const {run_test, noop} = require("./lib/test.cjs");
|
||||
|
||||
const channel = mock_esm("../src/channel");
|
||||
|
||||
const message_util = zrequire("message_util");
|
||||
|
||||
let reported_ids = [];
|
||||
function record_last_message_id(id) {
|
||||
reported_ids.push(id);
|
||||
}
|
||||
|
||||
function test(label, f) {
|
||||
run_test(label, (helpers) => {
|
||||
reported_ids = [];
|
||||
f(helpers);
|
||||
});
|
||||
}
|
||||
|
||||
test("get_last_message_id_in_narrow builds the request from the narrow", () => {
|
||||
let requested_opts;
|
||||
channel.get = (opts) => {
|
||||
requested_opts = opts;
|
||||
};
|
||||
|
||||
const narrow = [
|
||||
{operator: "channel", operand: 5},
|
||||
{operator: "topic", operand: "topic"},
|
||||
];
|
||||
message_util.get_last_message_id_in_narrow(narrow, noop, {allow_empty_topic_name: true});
|
||||
|
||||
assert.equal(requested_opts.url, "/json/messages");
|
||||
assert.deepEqual(requested_opts.data, {
|
||||
narrow: JSON.stringify(narrow),
|
||||
anchor: "newest",
|
||||
num_before: 1,
|
||||
num_after: 0,
|
||||
allow_empty_topic_name: true,
|
||||
});
|
||||
});
|
||||
|
||||
test("get_last_message_id_in_narrow reports the last message id on success", () => {
|
||||
channel.get = (opts) => {
|
||||
opts.success({messages: [{id: 987}]});
|
||||
};
|
||||
|
||||
message_util.get_last_message_id_in_narrow(
|
||||
[{operator: "dm", operand: [4]}],
|
||||
record_last_message_id,
|
||||
);
|
||||
|
||||
assert.deepEqual(reported_ids, [987]);
|
||||
});
|
||||
|
||||
test("get_last_message_id_in_narrow ignores an empty result", () => {
|
||||
channel.get = (opts) => {
|
||||
opts.success({messages: []});
|
||||
};
|
||||
|
||||
message_util.get_last_message_id_in_narrow(
|
||||
[{operator: "dm", operand: [4]}],
|
||||
record_last_message_id,
|
||||
);
|
||||
|
||||
assert.deepEqual(reported_ids, []);
|
||||
});
|
||||
|
||||
test("get_last_message_id_in_narrow ignores errors", () => {
|
||||
channel.get = (opts) => {
|
||||
opts.error();
|
||||
};
|
||||
|
||||
// Should not throw or report a message id.
|
||||
message_util.get_last_message_id_in_narrow(
|
||||
[{operator: "dm", operand: [4]}],
|
||||
record_last_message_id,
|
||||
);
|
||||
|
||||
assert.deepEqual(reported_ids, []);
|
||||
});
|
||||
Reference in New Issue
Block a user